Subject: Re: [bug#53474] [PATCH] gnu: Add emacs-all-the-icons-completion.

From: Nicolas Goaziou <[email-masked]>
Date: Sun, 23 Jan 2022 18:29:52 +0100

Hello,

Brandon Lucas <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-all-the-icons-completion): New
>   variable.

Thank you.

> +  ;; No tags. Version comes from latest melpa build.
> +  (let ((commit "9e7d456b0934ecb568b6f05a8445e3f4ce32261f")
> +        (revision "0"))
> +    (package
> +      (name "emacs-all-the-icons-completion")
> +      (version (git-version "20220106.1310" revision commit))

We don't use fancy MELPA versioning. In this situation, base version is
extracted from "Version" keyword in the header of the main file.

> +      (description "Add icons to completion candidates using the built in
> +completion metadata functions.  For example, with this package, @code{find-file}
> +can display a file icon for each candidate based on the file type.")

I reworded the first sentence so it would be complete.

Applied!

Regards,
-- 
Nicolas Goaziou