GNU bug report logs - #53474
[PATCH] gnu: Add emacs-all-the-icons-completion.

Previous Next

Package: guix-patches;

Reported by: Brandon Lucas <br <at> ndon.dk>

Date: Sun, 23 Jan 2022 14:05:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53474 in the body.
You can then email your comments to 53474 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#53474; Package guix-patches. (Sun, 23 Jan 2022 14:05:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Brandon Lucas <br <at> ndon.dk>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 23 Jan 2022 14:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brandon Lucas <br <at> ndon.dk>
To: guix-patches <at> gnu.org
Cc: Brandon Lucas <br <at> ndon.dk>
Subject: [PATCH] gnu: Add emacs-all-the-icons-completion.
Date: Sun, 23 Jan 2022 14:03:54 +0000
* gnu/packages/emacs-xyz.scm (emacs-all-the-icons-completion): New
  variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8edbfc5a3d..db514e1145 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22311,6 +22311,31 @@ (define-public emacs-all-the-icons
     (license
      (list license:expat license:gpl3+ license:silofl1.1 license:asl2.0))))

+(define-public emacs-all-the-icons-completion
+  ;; No tags. Version comes from latest melpa build.
+  (let ((commit "9e7d456b0934ecb568b6f05a8445e3f4ce32261f")
+        (revision "0"))
+    (package
+      (name "emacs-all-the-icons-completion")
+      (version (git-version "20220106.1310" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/iyefrat/all-the-icons-completion")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "04bnmmd6lyx0p39sgymqvmcy7bk8mr7sikbpy49adxi7d2891ldg"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-all-the-icons))
+      (home-page "https://github.com/iyefrat/all-the-icons-completion")
+      (synopsis "Add icons to completion candidates")
+      (description "Add icons to completion candidates using the built in
+completion metadata functions.  For example, with this package, @code{find-file}
+can display a file icon for each candidate based on the file type.")
+      (license license:gpl3+))))
+
 (define-public emacs-wttrin
   (let ((commit "df5427ce2a5ad4dab652dbb1c4a1834d7ddc2abc")
         (revision "1"))
--
2.34.0






Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sun, 23 Jan 2022 17:31:01 GMT) Full text and rfc822 format available.

Notification sent to Brandon Lucas <br <at> ndon.dk>:
bug acknowledged by developer. (Sun, 23 Jan 2022 17:31:02 GMT) Full text and rfc822 format available.

Message #10 received at 53474-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brandon Lucas <br <at> ndon.dk>
Cc: 53474-done <at> debbugs.gnu.org
Subject: Re: [bug#53474] [PATCH] gnu: Add emacs-all-the-icons-completion.
Date: Sun, 23 Jan 2022 18:29:52 +0100
Hello,

Brandon Lucas <br <at> ndon.dk> writes:

> * gnu/packages/emacs-xyz.scm (emacs-all-the-icons-completion): New
>   variable.

Thank you.

> +  ;; No tags. Version comes from latest melpa build.
> +  (let ((commit "9e7d456b0934ecb568b6f05a8445e3f4ce32261f")
> +        (revision "0"))
> +    (package
> +      (name "emacs-all-the-icons-completion")
> +      (version (git-version "20220106.1310" revision commit))

We don't use fancy MELPA versioning. In this situation, base version is
extracted from "Version" keyword in the header of the main file.

> +      (description "Add icons to completion candidates using the built in
> +completion metadata functions.  For example, with this package, @code{find-file}
> +can display a file icon for each candidate based on the file type.")

I reworded the first sentence so it would be complete.

Applied!

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 21 Feb 2022 12:24:13 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 211 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.