GNU bug report logs - #5342
23.1; mairix-widget-search always shows whole threads

Previous Next

Full log

Message #8 received at 5342 <at> debbugs.gnu.org (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: David Abrahams <dave <at> boostpro.com>
Cc: 5342 <at> debbugs.gnu.org
Subject: Re: bug#5342: 23.1; mairix-widget-search always shows whole threads
Date: Sun, 10 Jan 2010 14:51:04 +0100

[Message part 1 (text/plain, inline)]

David Abrahams <dave <at> boostpro.com> writes:
> Please write in English if possible, because the Emacs maintainers
> `M-x mairix-widget-search'
> search on body containing "foobar"
> do NOT check "Show full threads"
> finds all messages in threads that mention foobar in the body of any message.
>
> Tracked it down to 
>
>   (defun mairix-widget-send-query (widgets)
>     "Send query from WIDGETS to mairix binary."
>     (mairix-search
>      (mairix-widget-make-query-from-widgets widgets)
>      (if (widget-value (cadr (assoc "Threads" widgets)))
>          t
>        -1))
>   ;    ^^---------this should be nil
>     (kill-buffer mairix-customize-query-buffer))

I can confirm this change fixes the bug.  Thank you for tracking it
down.

I attached a bzr bundle containing the above patch.  Could please
someone commit this as a tiny change by Dave Abrahams and close this
bug?

Thanks,
David

[mairix-el-bug-5342.txt (text/plain, inline)]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: void <at> void-20100110134124-hfbk3j5r5xns33kr
# target_branch: http://bzr.savannah.gnu.org/srv/bzr/emacs/trunk
# testament_sha1: 474d00d991bef2c435a2bd6a1eb45039f742af62
# timestamp: 2010-01-10 14:47:44 +0100
# base_revision_id: monnier <at> iro.umontreal.ca-20100110052254-\
#   6c004mpy2oj0fkey
# 
# Begin patch
=== modified file 'lisp/net/mairix.el'
--- lisp/net/mairix.el	2009-10-31 02:38:34 +0000
+++ lisp/net/mairix.el	2010-01-10 13:41:24 +0000
@@ -597,7 +597,7 @@
    (mairix-widget-make-query-from-widgets widgets)
    (if (widget-value (cadr (assoc "Threads" widgets)))
        t
-     -1))
+     nil))
   (kill-buffer mairix-customize-query-buffer))
 
 (defun mairix-widget-save-search (widgets)

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWbh+TvsAAXtfgCAQWOP/91MA
AAD////wUANF5cS7bHHr1hKIiYaKemk8m0RpNPICGnomjQEokwQxSeNUbJNNNDQAAAGRT0CGqDya
mYnpR6g0AAAG1TSmjTQAGhpoABoGg00ElDUNJqaep4U9JtNTT00QyAxA0ZQ8k6V9SmpUqzRuAYyy
yCyBjZ0ZVxbLTueoq/Psn1BmF8lBeWzTH47+5l+x0XKnopLR2ovY9sdvAYolnVSq+Xg6n79dTRiZ
CUBwomb56I/RtzLIY3g1KhhlK3NoRVXbNT9g9BrTlaEwz0EyBkqh3EcMmFUcqIBWpQeXEw+G7A5q
+oWuZBMu9wuqurSY15ToJFFM/itxEv4W1bN9yOEvqnofU9vlOFkguFt1ksXOtQRqTGPMcS0N18Eq
BTAFZsJDJsxJ3IwEZu0Sh4nPjvs5WLtiS14A3vBs2YVZSvGgNgM60DqqyoLRLA1OO3Rn1wFxWOKB
hQ5NIQNqqa/GRmwoBEQukHfZ1BzNBNkCm6mWjdVKApXOO5LjbOrFiPIuzG3qmivGJIhPNb7ZTOSF
6ykPjQcjCAS12TxydcUWRdHsaSkOct0UdNQWUoHowgA+CQf4C3hvZLh2Jr6LmAhLpIVO2TXK6VgX
7oCHYDyANVnKv+rdztuKLlh0g3whAHdhWrIb3yQjkpv2D1MtRhhlhrg3qEttr+ptC9OcmL4gWjzw
3YzQTTagLLq0+N7hCkTcKROjRJEBcUC5jO1vGZJt5Mdehq4Y7ZLzFksgYXIPxh5kSelzk20rJdtS
aTQsvZhFCYIqaMa7gzX4tytM9rgcmSQzX1J5swTWI82JQd9WE7kpabyrFDP6jleFUXQSJs6Ka7Ce
bciR+EYB0hIEaTzhcmK7Q6/a6uFgWI/Qz5Br/rkUx4dq4CvMRSp+kGFLqwcdgODMDPBlPIVYS9Lv
fk6pR0UFtkAoCR58LbM0oYPqYGofj4B0kDJbxRRAKzDiTZlwJeLI2kB5ohSmjSVVV0oiZi1Bhjc4
ZPk7mZWqmHiaHKxcBODMGMl/WE0ERxpJ8rUUJwT2YOcKpw4hKQjpjHFVoqkngsEunAehqGSVjNhJ
YzGTiWnRmGiE4DOWfBZ/zm6/iE96nVYZ96W42jn88mYuF4LCIi+lIMY4E38XckU4UJC4fk77

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.