From unknown Sun Jun 15 01:05:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53417: reftex-change-label behavior Resent-From: Joseph Helfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53417 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 53417@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164278856321913 (code B ref -1); Fri, 21 Jan 2022 18:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jan 2022 18:09:23 +0000 Received: from localhost ([127.0.0.1]:35027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAyLi-0005hN-HN for submit@debbugs.gnu.org; Fri, 21 Jan 2022 13:09:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:52748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAyGv-0005Yi-GZ for submit@debbugs.gnu.org; Fri, 21 Jan 2022 13:04:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAyGu-0006DD-Ly for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 13:04:25 -0500 Received: from [2a00:1450:4864:20::52b] (port=36713 helo=mail-ed1-x52b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAyGs-0006BS-Pp for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 13:04:24 -0500 Received: by mail-ed1-x52b.google.com with SMTP id l5so27108127edv.3 for ; Fri, 21 Jan 2022 10:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=mnatRdsoqSY4Eps6fnDw1DgC34XDbYEJmnAYlRiF3QI=; b=YU3M9SYt8JZf2pDXSJLtVr3Jve2OKM23oaoKE7fBsZ94mwB/VIDRjeA5MAdzWIjXkv YFOTc2l94vhWkWl6VndwqN40OO2cyhiKDletUQ5ZufDV01C4mOtM68ajX4gyZyt0PjYs pNUBX8Cl3TbuLFjY83wQpE2F9ERYtQXNfDj78JkkuIW/29pHSg2u3DocnKM1/UOPeGen 9fsNmCNckL9UBbmmzsP2ko4wU3g6hU2+sZWaVRJKvEGdPDcnR8qZsYDPVwG1CbuGJ6kY 96at0sngZVq92rE7+1lofEzzW/y6XIRP6/YSmlQbze8/xQkL/jMQYx3h0406IXrw3w3v KUZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=mnatRdsoqSY4Eps6fnDw1DgC34XDbYEJmnAYlRiF3QI=; b=58+pJaHMNNSRdlJbCB2PCDCFr9w2qm9PkDQelplY7CyZ4/ZYh3KTPh7SnBbT6akRJf RMuuE01lY1BIq1jdpphLWPyEUKdhSUMadBDYQpSDv+yK3n0pyxzvNVYGe9WZ7ipw2Hoh C3KBFgY+pkkrFK9qebB3bNZEkoy4GZI5FdF9hVWFeqm81V+LmS9ndzF7UXlHEqA9QkkN 7NOl66OKxSvep6r9soZhxX1PbnIPOGWf75WqIP1Y4uUZ/41TeKQAYfIf3oyTFfLkoT9v 7XffZB08g70DXfKV7ggnDyS/GFhKobrsRe0sBA46KzIIeIVtVcbEktjOobOMGBnAF9P3 H15Q== X-Gm-Message-State: AOAM533OL2z5//mIYIfHo/4+Ifos1OFgeofJEMx8jsLcSnkP7CcLLxLA AlwCD19kf3YC3a0wF7BUWHHx/GgeSzkd3nYzRKYVDpCk+VFEwg== X-Google-Smtp-Source: ABdhPJzw26JCm7rqgsPs6/hE04h3Z2BBzNaoItoP6vLvXPIaEB4RKmbUW7RSBdQOxUgTbs8ZCKqL7qoT/My6a8HWGvw= X-Received: by 2002:aa7:cc10:: with SMTP id q16mr5351561edt.60.1642788257333; Fri, 21 Jan 2022 10:04:17 -0800 (PST) MIME-Version: 1.0 From: Joseph Helfer Date: Fri, 21 Jan 2022 10:03:41 -0800 Message-ID: Content-Type: multipart/mixed; boundary="0000000000008516fc05d61b7278" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::52b (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=joseph.helfer@gmail.com; helo=mail-ed1-x52b.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Mailman-Approved-At: Fri, 21 Jan 2022 13:09:21 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000008516fc05d61b7278 Content-Type: text/plain; charset="UTF-8" Hello, I apologize if I am not following the usual protocols for bug reports. This is somewhere between a bug report and a feature request. The function `reftex-change-label' defined in `lisp/textmodes/reftex-global.el' asks for the label you want to change (`from') and what you want to change it to (`to'). The default value for `from' is the label under point, which is good. I think the initial input for `to' should be this as well (or rather, whatever was entered for `from'), since usually, one just wants to make a small change. This is a trivial edit. I have attached an appropriate patch for the file https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/textmodes/reftex-global.el?h=emacs-28.0.91 It could be better to add a customizable variable to control this behavior, but I am not familiar enough with the reftex code to provide a patch for that now. However, I think the new proposed behavior is better, and I doubt that any existing code depends on the old behavior. Best, Joj --0000000000008516fc05d61b7278 Content-Type: text/x-patch; charset="US-ASCII"; name="reftex-global.el.patch" Content-Disposition: attachment; filename="reftex-global.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kyopiwhz0 LS0tIHJlZnRleC1nbG9iYWwuZWwJMjAyMi0wMS0yMSAwOTo0OToyMi4wODkwOTE5NjggLTA4MDAK KysrIHJlZnRleC1nbG9iYWwtcGF0Y2hlZC5lbAkyMDIyLTAxLTIxIDA5OjUxOjIwLjU5NDE3OTE2 MyAtMDgwMApAQCAtMTgzLDcgKzE4Myw3IEBACiAgICAgKGlmIChzdHJpbmc9IGZyb20gIiIpIChz ZXRxIGZyb20gZGVmYXVsdCkpCiAgICAgKHVubGVzcyB0bwogICAgICAgKHNldHEgdG8gKHJlYWQt c3RyaW5nIChmb3JtYXQgIlJlcGxhY2UgbGFiZWwgJXMgd2l0aDogIgotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZnJvbSkpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGZyb20pIGZyb20pKSkKICAgICAocmVmdGV4LXF1ZXJ5LXJlcGxhY2UtZG9jdW1l bnQKICAgICAgKGNvbmNhdCAieyIgKHJlZ2V4cC1xdW90ZSBmcm9tKSAifSIpCiAgICAgIChmb3Jt YXQgInslc30iIHRvKSkpKQo= --0000000000008516fc05d61b7278-- From unknown Sun Jun 15 01:05:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53417: reftex-change-label behavior Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jan 2022 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53417 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Joseph Helfer Cc: 53417@debbugs.gnu.org Received: via spool by 53417-submit@debbugs.gnu.org id=B53417.164285293513480 (code B ref 53417); Sat, 22 Jan 2022 12:03:02 +0000 Received: (at 53417) by debbugs.gnu.org; 22 Jan 2022 12:02:15 +0000 Received: from localhost ([127.0.0.1]:35929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBF5z-0003V5-9y for submit@debbugs.gnu.org; Sat, 22 Jan 2022 07:02:15 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBF5x-0003Q2-Do for 53417@debbugs.gnu.org; Sat, 22 Jan 2022 07:02:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=15x5tYMq5Tu714i5P7aEy1gBwapTpTslg67I3LO2eBs=; b=pnl0fPNRlYJpr6gDpInLO6At5c dM+ML3sh6DhEhEp7jofpFuaUa203DJRHckH4pjexpJGFPhT6ZGaPmJl956qNZSCY6E5tkV1RabzwZ 62F53OL0KI9cOkZelx2SEke2jITDcjo7Nsa+54UtAG0sON/4DhIO8RgN0Re4OePTCzqI=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBF5o-0004xw-Me; Sat, 22 Jan 2022 13:02:07 +0100 From: Lars Ingebrigtsen References: X-Now-Playing: Supertramp's _Crime of the Century_: "Asylum" Date: Sat, 22 Jan 2022 13:02:02 +0100 In-Reply-To: (Joseph Helfer's message of "Fri, 21 Jan 2022 10:03:41 -0800") Message-ID: <87h79wj7wl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Joseph Helfer writes: > The function `reftex-change-label' defined in > `lisp/textmodes/reftex-global.el' asks for the label you want to > change (`from') and what you want to change it to (`to'). The default > value for ` [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Helfer writes: > The function `reftex-change-label' defined in > `lisp/textmodes/reftex-global.el' asks for the label you want to > change (`from') and what you want to change it to (`to'). The default > value for `from' is the label under point, which is good. I think the > initial input for `to' should be this as well (or rather, whatever was > entered for `from'), since usually, one just wants to make a small > change. Makes sense to me. However, we're moving away from using INITIAL-INPUT for these functions, and instead putting things like this into DEFAULT-VALUE, which means that the user can hit `M-n' to edit it. So I've now done that in Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 22 07:02:20 2022 Received: (at control) by debbugs.gnu.org; 22 Jan 2022 12:02:20 +0000 Received: from localhost ([127.0.0.1]:35932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBF64-0003Zg-Kq for submit@debbugs.gnu.org; Sat, 22 Jan 2022 07:02:20 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBF63-0003UM-CJ for control@debbugs.gnu.org; Sat, 22 Jan 2022 07:02:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+opgtu2ZiuLORp8XUYY/aqOoCaDdj5OVGU4mELejweE=; b=TC7aUDjAn5SLyS9x77+sFIrn5B kpZiL/nKnCAWrQ194h/SSXUYocFI0rH8syq/EHQrG6aLVrKXR9oGWFSg8pMAagG8HokBLTRPCz9gs ejS4+dejZmRwhPSGODOiP7heHHpBZ0I4kAFyvBLODHbbIvi4fjWElkAz2ti54diiaQkY=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBF5v-0004y4-Hp for control@debbugs.gnu.org; Sat, 22 Jan 2022 13:02:13 +0100 Date: Sat, 22 Jan 2022 13:02:11 +0100 Message-Id: <87fspgj7wc.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53417 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 53417 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 53417 29.1 quit