GNU bug report logs - #53414
[PATCH] update Node LTS to 16.13.2

Previous Next

Package: guix-patches;

Reported by: zamfofex <zamfofex <at> twdb.moe>

Date: Fri, 21 Jan 2022 16:03:02 UTC

Severity: normal

Tags: patch

Done: Steve George <steve <at> futurile.net>

Bug is archived. No further changes may be made.

Full log

Message #59 received at 53414 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ryan Sundberg <ryan <at> arctype.co>, Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 53414 <at> debbugs.gnu.org
Subject: Re: [bug#53414] [PATCH] update Node LTS to 16.13.2
Date: Thu, 09 Jun 2022 22:53:43 +0200

[Message part 1 (text/plain, inline)]
Ryan Sundberg via Guix-patches via schreef op wo 08-06-2022 om 23:39 [-
0700]:
> +              (modules '((guix build utils)))
> +              (snippet
> +               `(begin
> +                  ;; Remove bundled software, where possible
> +                  (for-each delete-file-recursively
> +                            '("deps/cares"
> +                              "deps/icu-small"
> +                              "deps/nghttp2"
> +                              "deps/openssl"
> +                              "deps/zlib"))
> +                  (substitute* "Makefile"
> +                    ;; Remove references to bundled software.
> +                    (("deps/uv/uv.gyp") "")
> +                    (("deps/zlib/zlib.gyp") ""))
> +                  #t))))

This is identical to what node-14 has, so you can use inheritance to
simplify things:

  (origin
    (inherit (package-source node-14))
    (uri ...)
    (sha256 ...))

Also, could you verify that no new things have been bundled?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 84 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.