GNU bug report logs - #53395
Fix pypi import for flake8-array-spacing

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53395: closed (Fix pypi import for flake8-array-spacing)
Date: Wed, 26 Jan 2022 15:22:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 26 Jan 2022 16:20:52 +0100
with message-id <87ee4uh6az.fsf <at> gnu.org>
and subject line Re: bug#53395: Fix pypi import for flake8-array-spacing
has caused the debbugs.gnu.org bug report #53395,
regarding Fix pypi import for flake8-array-spacing
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53395: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53395
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Subject: Fix pypi import for flake8-array-spacing
Date: Thu, 20 Jan 2022 20:45:19 +0100

[Message part 3 (text/plain, inline)]

Dear guix,

flake8-array-spacing is a funny package because its download URI uses a
base name of flake8_array_spacing. Apparently some other packages have
similar features, appearing as the downcase version.

What do you think?

Best regards,

Vivien

[0001-pypi-importer-Convert-to-_-in-pypi-urls-if-needed.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 53395-done <at> debbugs.gnu.org
Subject: Re: bug#53395: Fix pypi import for flake8-array-spacing
Date: Wed, 26 Jan 2022 16:20:52 +0100

Hi,

Vivien Kraus <vivien <at> planete-kraus.eu> skribis:

> From 8792367617d288e584a703db38c82c749a067c26 Mon Sep 17 00:00:00 2001
> From: Vivien Kraus <vivien <at> planete-kraus.eu>
> Date: Thu, 20 Jan 2022 20:11:56 +0100
> Subject: [PATCH] pypi importer: Convert - to _ in pypi urls if needed.
>
> * guix/import/pypi.scm (find-project-url): New function.
> (make-pypi-sexp): Use find-project-url.
> * tests/pypi.scm ("Package Foo has a correct pypi-uri of foo"): New test.
> ("If the package goo is released as foo, the importer warns"): New test.

\o/

I took the liberty to remove the integration tests you had added, I
think it’s preferable (especially since there’s a patch refactoring
these bits that Maxime submitted recently…).  I mentioned the other
changes to the commit log and added a copyright line for you.

Let me know if I got anything wrong.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.