Subject: [bug#53388] New package: gallery-dl

From: Bird <[email-masked]>
Date: Fri, 21 Jan 2022 04:46:59 +0000

[Added Maxime because this patch should fix his worries too]

Leo Famulari <[email-masked]> writes:

> On Thu, Jan 20, 2022 at 11:48:25AM +0000, Bird wrote:

> I applied it to a Git checkout of the Guix source code, and tried
> rebuilding Guix, as described here in the Contributing chapter of the
> manual:
>
> https://guix.gnu.org/manual/devel/en/html_node/Building-from-Git.html
>
> However, it crashes like this:
[...]
> The reason for this error is that licenses in the gnu/packages/video.scm
> module are "prefixed" to avoid a namespace collision between packages
> and licenses with the same name, such as zlib and expat:
>
> https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/video.scm?id=f223535e1c2f052f671e44a6c546d0ebde3591b1#n80
>
> You can check other packages in that module for examples of how to
> prefix the license.
>
>> +    (license gpl2+)

Thanks, fixed.

>
> I checked several of the .py files in the source code, and setup.py,
>and
> they all seem to specify that the program is made available under the
> terms of version 2 of the GPL, but no later versions. So, this package
> should use "gpl2", not "gpl2+".

I was confused due to the example on LICENSE containing phrase 'or (at
your option) any later version' but turns out that was an example.

>
>> +    (arguments
>> +     '(#:tests? #f))))
>
> We always run upstream test suites in Guix packages, because it helps
> validate our packaging and finds bugs to assist upstream development.
> If we do not run the tests, we add a code comment explaining why. In
> Scheme, comments begin with the ; (semicolon) character.
>
> So, can you send a revised patch that adjusts the license and either
> runs the test suite or explains why not?

It is attached in this mail.

> Thanks in advance!

Thanks!

>From 8a3ab5dba4f85dd1fb2ddaf683f9da7e5ec9854e Mon Sep 17 00:00:00 2001
From: Bird <[email-masked]>
Date: Fri, 21 Jan 2022 04:32:39 +0000
Subject: [PATCH] gnu: gallery-dl: Add a new package. *
 gnu/packages/video.scm(gallery-dl): Add package.

---
 gnu/packages/video.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 461ccbb950..47f33ed3ac 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2245,6 +2245,31 @@ (define-public smplayer
 the last played position, etc.")
     (license license:gpl2+)))
 
+(define-public gallery-dl
+  (package
+    (name "gallery-dl")
+    (version "1.20.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/mikf/gallery-dl"
+                                  "/releases/download/v"
+                                  version
+                                  "/gallery_dl-"
+                                  version
+                                  ".tar.gz"))
+              (sha256
+               (base32
+                "0qkz8aznvybdqrjxsl6ir319ras05mi8l0sal4mgi18l70jndh51"))))
+    (build-system python-build-system)
+    (inputs (list python-requests ffmpeg))
+    (home-page "https://github.com/mikf/gallery-dl")
+    (synopsis "Command-line program to download images from several sites")
+    (description "Command-line program to download image galleries
+and collections from several image hosting sites
+While this package can use youtube-dl or yt-dlp packages to download videos,
+the focus is more on images and image hosting sites.")
+    (license license:gpl2)))
+
 (define-public gnome-mpv
   (deprecated-package "gnome-mpv" celluloid))

base-commit: 2b6af630d61dd5b16424be55088de2b079e9fbaf
-- 
2.34.0