From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 06:56:55 2022 Received: (at submit) by debbugs.gnu.org; 20 Jan 2022 11:56:55 +0000 Received: from localhost ([127.0.0.1]:56580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAW3j-0004e5-Dz for submit@debbugs.gnu.org; Thu, 20 Jan 2022 06:56:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:33822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAW3h-0004dy-T6 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 06:56:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAW3h-0004XV-0r for guix-patches@gnu.org; Thu, 20 Jan 2022 06:56:53 -0500 Received: from [37.120.193.123] (port=45832 helo=mail.cock.li) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAW3c-0002Y7-S4 for guix-patches@gnu.org; Thu, 20 Jan 2022 06:56:51 -0500 From: Bird DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=airmail.cc; s=mail; t=1642679220; bh=e7iqcU6d/RP9zD/aha8z7To/0QXE7U7axxHKH8Agho8=; h=From:To:Subject:Date:From; b=dCoCv2WCUmT2uxCw54jHIrp/tB1LOeQIIie3opS3MMY4L2MbSLX1T2JQntdDUkPH6 dRDozBxszvYIgSy/GF33Lg8lNzr6iWmHxAjM73/zGt0sGP1vxjtzyhKTUCt2GNJ1MR lfBz0Dn5G0SHMdyILtKnpkm/ij1+wmEPEjfNLdHcozp/9B0WGh1aQPCjfO86tiY0q2 qV2iLbGXfcDRNiy8qooKMx/h7RMMRXWnsKF6zzLV100wqUebunNmNxlbmOA1yD3QA8 b3ct/YNOo84CQOQ2anJM3gWLydzk2kgMzUiSMj4tx0i6Dk3aJNknZa7CfT9/P2Vjyy vFFVv83ns2pOg== To: guix-patches@gnu.org Subject: New package: gallery-dl Date: Thu, 20 Jan 2022 11:48:25 +0000 Message-ID: <85ee52fx12.fsf@airmail.cc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 37.120.193.123 (failed) Received-SPF: pass client-ip=37.120.193.123; envelope-from=birdsite@airmail.cc; helo=mail.cock.li X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hello, The attached patch adds a new package: gallery-dl in gnu/packages/video.scm Thanks! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-gallery-dl-Add-a-new-package.patch >From 799d589e6b5d76b4cac6272d22f87603729fb9e1 Mon Sep 17 00:00:00 2001 From: Bird Date: Thu, 20 Jan 2022 11:42:24 +0000 Subject: [PATCH] gnu: gallery-dl: Add a new package. * gnu/packages/video.scm(gallery-dl): Add package. --- gnu/packages/video.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 461ccbb950..237cb931d0 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -2245,6 +2245,31 @@ (define-public smplayer the last played position, etc.") (license license:gpl2+))) +(define-public gallery-dl + (package + (name "gallery-dl") + (version "1.20.1") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/mikf/gallery-dl" + "/releases/download/v" + version + "/gallery_dl-" + version + ".tar.gz")) + (sha256 + (base32 + "0qkz8aznvybdqrjxsl6ir319ras05mi8l0sal4mgi18l70jndh51")))) + (build-system python-build-system) + (propagated-inputs (list python-requests)) + (home-page "https://github.com/mikf/gallery-dl") + (synopsis "Command-line program to download images from several sites") + (description "Command-line program to download image galleries + and collections from several image hosting sites") + (license gpl2+) + (arguments + '(#:tests? #f)))) + (define-public gnome-mpv (deprecated-package "gnome-mpv" celluloid)) base-commit: 2b6af630d61dd5b16424be55088de2b079e9fbaf -- 2.34.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 12:10:14 2022 Received: (at 53388) by debbugs.gnu.org; 20 Jan 2022 17:10:14 +0000 Received: from localhost ([127.0.0.1]:59075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAawv-0000IQ-VR for submit@debbugs.gnu.org; Thu, 20 Jan 2022 12:10:14 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:44580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAawt-0000IG-QM for 53388@debbugs.gnu.org; Thu, 20 Jan 2022 12:10:12 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id l5A62600H4UW6Th015A6vc; Thu, 20 Jan 2022 18:10:10 +0100 Message-ID: <978432cd205f87fd00e623be35f0598d53a22155.camel@telenet.be> Subject: Re: [bug#53388] New package: gallery-dl From: Maxime Devos To: Bird , 53388@debbugs.gnu.org Date: Thu, 20 Jan 2022 17:10:02 +0000 In-Reply-To: <85ee52fx12.fsf@airmail.cc> References: <85ee52fx12.fsf@airmail.cc> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-H1B0yz6gSUspo2N7c+09" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642698610; bh=T7btdvYZsBftvy+/kkOwQdDBTjY1GBfAff8KGjEKFNw=; h=Subject:From:To:Date:In-Reply-To:References; b=MJJNqJw3ljFHFV6Vv34XIpOUVSSUYHalsFNOVPYKI1aUUg/1Ilp684x+KFDvkiAvy ob4wgMiwm2FS0y8ToA/lfqcrnQoSYHfhHsWnvDd6fAkjd+6YY5gYWYp9dH/9y7kcR3 X3W0QB/MOeDISW+H98khbgGusCnkSPCQF5bUpFPm+1TB4GiSE1BE2IGH571sLXDvm6 Lesyru9fgWi4trJUaakc8KJjV0PAfMHENs7uEZRm3dhKXLo7qBRG0rPhlrtAzfGOVy GhY/wlxmyJEzYsh2ZEocIc/v1FGnBfbKHu0fNkELqfI4HKa+6c7IQHS19fYNKMgBwl ULfA1blIuq7IQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53388 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-H1B0yz6gSUspo2N7c+09 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Bird schreef op do 20-01-2022 om 11:48 [+0000]: > +=C2=A0=C2=A0=C2=A0 (propagated-inputs (list python-requests)) The README says it can use =E2=80=98youtube-dl=E2=80=99 or =E2=80=98yt-dlp= =E2=80=99 for vide downloads and =E2=80=98ffmpeg=E2=80=98 for some conversion, so maybe these could be a= dded? Also, propagation can lead to profile collisions which can be complicated to resolve, so can this be made a regular input instead of a propagated input? Some wrap-program might be necessary. > +=C2=A0=C2=A0=C2=A0 (home-page "https://github.com/mikf/gallery-dl") > +=C2=A0=C2=A0=C2=A0 (synopsis "Command-line program to download images fr= om several > sites") > +=C2=A0=C2=A0=C2=A0 (description "Command-line program to download image = galleries > + and collections from several image hosting sites") Does it only support images, or also videos? From the =E2=80=98ffmpeg=E2= =80=99 and =E2=80=98youtube-dl=E2=80=99 dependency, I would assume the latter. Also, = when I'm reading this description, it reminds me a lot of youtube-dl -- perhaps the description could explain it supports more video sites, or less video sites, or not only video but also images, or something along these lines. > +=C2=A0=C2=A0=C2=A0 (license gpl2+) > +=C2=A0=C2=A0=C2=A0 (arguments > +=C2=A0=C2=A0=C2=A0=C2=A0 '(#:tests? #f)))) Why are tests disabled here? Also, 'gallery-dl' (indirectly) uses openssl for the S in HTTPS, so you may need to add SSL_CERT_DIR (or SSL_CERT_FILE, not sure) to native-search-paths to make "guix shell --pure yt-dlp nss-certs" work. Although there appears to be some disagreement in that area, see e.g. some discussion in #53324, so maybe not. Greetings, Maxime. --=-H1B0yz6gSUspo2N7c+09 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYemXahccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lUaAPwKFxTIDj46NvmiA3xew1jdQEjn SDZRLhe/neXVssLumwD9Ge6+B+Mu4MYkYvH99ar0rsvQmBYQpDApP/ECn5ZeRww= =PRcw -----END PGP SIGNATURE----- --=-H1B0yz6gSUspo2N7c+09-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 12:41:08 2022 Received: (at 53388) by debbugs.gnu.org; 20 Jan 2022 17:41:08 +0000 Received: from localhost ([127.0.0.1]:59105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAbQq-00016U-Gt for submit@debbugs.gnu.org; Thu, 20 Jan 2022 12:41:08 -0500 Received: from [37.120.193.123] (port=43798 helo=mail.cock.li) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAbQk-00015f-CY for 53388@debbugs.gnu.org; Thu, 20 Jan 2022 12:41:06 -0500 From: Bird DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=airmail.cc; s=mail; t=1642700454; bh=jm1KwrZTbfUhPACKlD3PrLnGGhl5XxxQqoywvl3xvGo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DcOT/qT0uc8jRqq38ZYI8bec/9WyoNUj4CGrUqc7PWRTfoGYhRCaWZrgWURq3NP3l BSffSufMabTmJbxLgk1imxsNQO1dcg7bAdDs2WCq/SksXLqZRsJXyzJIRCeT/kuW/H /ck8TJxQj5mJNYwOiJyil/X7fjds1pIqDX8DP3E7+RJHIaTd1GgbIP2rVF/3LzH0Y+ ty1+yHadJnXK0q3t1ZA87+cdfkRw7g5Q+pfNLbmYRsvQpXf+vCr2vV+y3uRF3kDeo1 5kZ1b+pXg+X/J/dWgDozAmg2zm3oiuFxbgmvsTFmS2tggkH4JB2MflevXUMPVRwTJS 6/A3wt1HGMRcA== To: Maxime Devos Subject: Re: [bug#53388] New package: gallery-dl References: <85ee52fx12.fsf@airmail.cc> <978432cd205f87fd00e623be35f0598d53a22155.camel@telenet.be> Date: Thu, 20 Jan 2022 17:42:17 +0000 In-Reply-To: <978432cd205f87fd00e623be35f0598d53a22155.camel@telenet.be> (Maxime Devos's message of "Thu, 20 Jan 2022 17:10:02 +0000") Message-ID: <851r12pame.fsf@airmail.cc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Maxime Devos writes: > Hi, > > Bird schreef op do 20-01-2022 om 11:48 [+0000]: >> +    (propagated-inputs (list python-requests)) > > The README says it can use ‘youtube-dl’ or ‘yt-dlp’ for vide downloads > and [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 53388 Cc: 53388@debbugs.gnu.org, Bird X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Maxime Devos writes: > Hi, > > Bird schreef op do 20-01-2022 om 11:48 [+0000]: >> +=C2=A0=C2=A0=C2=A0 (propagated-inputs (list python-requests)) > > The README says it can use =E2=80=98youtube-dl=E2=80=99 or =E2=80=98yt-dl= p=E2=80=99 for vide downloads > and =E2=80=98ffmpeg=E2=80=98 for some conversion, so maybe these could be= added? > > Also, propagation can lead to profile collisions which can be > complicated to resolve, so can this be made a regular input instead of > a propagated input? Some wrap-program might be necessary. Can programs call to regular inputs that are not propagated? Since gallery-dl will need ffmpeg and python-requests (and possibly yt-dlp), would it need to be in user's profile? > >> +=C2=A0=C2=A0=C2=A0 (home-page "https://github.com/mikf/gallery-dl") >> +=C2=A0=C2=A0=C2=A0 (synopsis "Command-line program to download images f= rom several >> sites") >> +=C2=A0=C2=A0=C2=A0 (description "Command-line program to download image= galleries >> + and collections from several image hosting sites") > > Does it only support images, or also videos? From the =E2=80=98ffmpeg=E2= =80=99 and > =E2=80=98youtube-dl=E2=80=99 dependency, I would assume the latter. Also= , when I'm > reading this description, it reminds me a lot of youtube-dl -- perhaps > the description could explain it supports more video sites, or less > video sites, or not only video but also images, or something along > these lines. > It's really similar to youtube-dl but targets images primarily, i'll make that clearer in the next patch > >> +=C2=A0=C2=A0=C2=A0 (license gpl2+) >> +=C2=A0=C2=A0=C2=A0 (arguments >> +=C2=A0=C2=A0=C2=A0=C2=A0 '(#:tests? #f)))) > > Why are tests disabled here? > Sorry, I just assumed it will fail the tests due to network-lessness of build environment, it actually passes the tests. > > Also, 'gallery-dl' (indirectly) uses openssl for the S in HTTPS, > so you may need to add SSL_CERT_DIR (or SSL_CERT_FILE, not sure) to > native-search-paths to make "guix shell --pure yt-dlp nss-certs" work. > > Although there appears to be some disagreement in that area, see e.g. > some discussion in #53324, so maybe not. > I did a quick grep of SSL_CERT_FILE and SSL_CERT_DIR in gnu/packages/ but didn't find anything, could you please explain what i should do here?=20 > > Greetings, > Maxime. > Thanks, Bird From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 13:24:30 2022 Received: (at 53388) by debbugs.gnu.org; 20 Jan 2022 18:24:30 +0000 Received: from localhost ([127.0.0.1]:59154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAc6o-0002IT-1L for submit@debbugs.gnu.org; Thu, 20 Jan 2022 13:24:30 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:43357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAc6k-0002I0-RA for 53388@debbugs.gnu.org; Thu, 20 Jan 2022 13:24:29 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EF96A3202010; Thu, 20 Jan 2022 13:24:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 20 Jan 2022 13:24:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; bh=070LW34WOjXmL1IeEW2M5iizC7x VK6Qf3YsGC2LXhf4=; b=CEyyhwb5VHYmQRt1Vw/8wLaxKGLYUSnL7q+75+rJCni yttGaILnPFo43cggdTe9u3lJMvPcdGyxwI8h6dFngZZQfaZRMJdhVp0Cuv3vQspv zIKPZfeJgXu0Tfc6VN6Z/8WN22BJ8BIH1jFx/5/DJZDSTyuWjp4vWhy9cv1/7UOQ = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=070LW34WOjXmL1IeE W2M5iizC7xVK6Qf3YsGC2LXhf4=; b=bW9MV3LtOVOArFiDwFEHDwXFlC2dJX1T3 ZC33O7W0ZEX83Yx2YXcN2ptSZwFCuhoAgc2qeq4bwO20FbvzdbUjAFliEDLhPInO eHCxWTWVt9YD+lOnYBXjXzQPGgJ7jeLEXJ1riKqhlNMOpBEpe2EMxHHw8ATDkEO3 SJnMX7WaOF/0Y6sxaBi7+FGVXfRNM0v9AJFpixb6MR6RdVW4mlfdUJ4sOU4pyzBA DNfJIGI/ho/MKAj+LLwXh6CzRdkq3C1y58NV0PjpJQxbneeEraLWbhm4YHLu6odw 03LNKD1wdEkj9tKYvZKVgl28vK7n0vWHgTAncb/e/puMD/FzdKqZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedmnecujfgurhepfffhvf fukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcu oehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpedvvdduge fffeeitddthfefvdeuhffgkeeikeegkeevteeghfeftefggeeuudffieenucffohhmrghi nhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jan 2022 13:24:19 -0500 (EST) Date: Thu, 20 Jan 2022 13:24:17 -0500 From: Leo Famulari To: Bird Subject: Re: [bug#53388] New package: gallery-dl Message-ID: References: <85ee52fx12.fsf@airmail.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85ee52fx12.fsf@airmail.cc> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53388 Cc: 53388@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Jan 20, 2022 at 11:48:25AM +0000, Bird wrote: > The attached patch adds a new package: gallery-dl in > gnu/packages/video.scm > From 799d589e6b5d76b4cac6272d22f87603729fb9e1 Mon Sep 17 00:00:00 2001 > From: Bird > Date: Thu, 20 Jan 2022 11:42:24 +0000 > Subject: [PATCH] gnu: gallery-dl: Add a new package. * > gnu/packages/video.scm(gallery-dl): Add package. Hello, and thanks for the patch! I applied it to a Git checkout of the Guix source code, and tried rebuilding Guix, as described here in the Contributing chapter of the manual: https://guix.gnu.org/manual/devel/en/html_node/Building-from-Git.html However, it crashes like this: ------ ice-9/eval.scm:293:34: error: gpl2+: unbound variable hint: Did you forget `(use-modules (guix licenses))'? make[2]: *** [Makefile:7380: make-packages-go] Error 1 make[2]: Leaving directory '/home/leo/work/guix' make[1]: *** [Makefile:6453: all-recursive] Error 1 make[1]: Leaving directory '/home/leo/work/guix' make: *** [Makefile:3982: all] Error 2 ------ The reason for this error is that licenses in the gnu/packages/video.scm module are "prefixed" to avoid a namespace collision between packages and licenses with the same name, such as zlib and expat: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/video.scm?id=f223535e1c2f052f671e44a6c546d0ebde3591b1#n80 You can check other packages in that module for examples of how to prefix the license. > + (license gpl2+) I checked several of the .py files in the source code, and setup.py, and they all seem to specify that the program is made available under the terms of version 2 of the GPL, but no later versions. So, this package should use "gpl2", not "gpl2+". > + (arguments > + '(#:tests? #f)))) We always run upstream test suites in Guix packages, because it helps validate our packaging and finds bugs to assist upstream development. If we do not run the tests, we add a code comment explaining why. In Scheme, comments begin with the ; (semicolon) character. So, can you send a revised patch that adjusts the license and either runs the test suite or explains why not? Thanks in advance! From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 23:45:46 2022 Received: (at 53388) by debbugs.gnu.org; 21 Jan 2022 04:45:46 +0000 Received: from localhost ([127.0.0.1]:59838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAlo1-00068N-Fo for submit@debbugs.gnu.org; Thu, 20 Jan 2022 23:45:45 -0500 Received: from [37.120.193.123] (port=40230 helo=mail.cock.li) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAlny-000684-OO for 53388@debbugs.gnu.org; Thu, 20 Jan 2022 23:45:44 -0500 From: Bird DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=airmail.cc; s=mail; t=1642740334; bh=Vj7x2CWZahdwFZ6NaC4Y7YfZsGRf5eJK6LpNO09E+kE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DwW6ZSkXotoiOt0Achd1GQDaD/l2xz/cpAbpmQPc148sO+2RK8+wTuTaRWOrYYkul mfojqvg0xfj7OJCcMq46JZ8FrTniUNRO0aZdSr+pKsmWxBaeCohd85cYNSSR84WqtU TbgT3bjuvfpoLctwcwUWj7QEyQnaV8l7d0o4ShFM1fBmnbGm9P7WYLAowIW8JZDsGI kQNqU4bu0gTe/OX926fZ1HN3yY3RZq1ZlkPA9UE2hMomDzgG5cjFdjYIeYkmxeDw06 OPKzh00mN/+aojdOf1MOHQPJxxbJ7INzdM0I96CWzPxLlVB8J5x4XP1YUuLOICR2UL IL8SBWdMDBCBQ== To: Leo Famulari Subject: Re: [bug#53388] New package: gallery-dl References: <85ee52fx12.fsf@airmail.cc> Date: Fri, 21 Jan 2022 04:46:59 +0000 In-Reply-To: (Leo Famulari's message of "Thu, 20 Jan 2022 13:24:17 -0500") Message-ID: <85sfth8zlo.fsf@airmail.cc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: [Added Maxime because this patch should fix his worries too] Leo Famulari writes: > On Thu, Jan 20, 2022 at 11:48:25AM +0000, Bird wrote: Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 53388 Cc: 53388@debbugs.gnu.org, Maxime Devos , Bird X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --=-=-= Content-Type: text/plain [Added Maxime because this patch should fix his worries too] Leo Famulari writes: > On Thu, Jan 20, 2022 at 11:48:25AM +0000, Bird wrote: > I applied it to a Git checkout of the Guix source code, and tried > rebuilding Guix, as described here in the Contributing chapter of the > manual: > > https://guix.gnu.org/manual/devel/en/html_node/Building-from-Git.html > > However, it crashes like this: [...] > The reason for this error is that licenses in the gnu/packages/video.scm > module are "prefixed" to avoid a namespace collision between packages > and licenses with the same name, such as zlib and expat: > > https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/video.scm?id=f223535e1c2f052f671e44a6c546d0ebde3591b1#n80 > > You can check other packages in that module for examples of how to > prefix the license. > >> + (license gpl2+) Thanks, fixed. > > I checked several of the .py files in the source code, and setup.py, >and > they all seem to specify that the program is made available under the > terms of version 2 of the GPL, but no later versions. So, this package > should use "gpl2", not "gpl2+". I was confused due to the example on LICENSE containing phrase 'or (at your option) any later version' but turns out that was an example. > >> + (arguments >> + '(#:tests? #f)))) > > We always run upstream test suites in Guix packages, because it helps > validate our packaging and finds bugs to assist upstream development. > If we do not run the tests, we add a code comment explaining why. In > Scheme, comments begin with the ; (semicolon) character. > > So, can you send a revised patch that adjusts the license and either > runs the test suite or explains why not? It is attached in this mail. > > Thanks in advance! > Thanks! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-gallery-dl-Add-a-new-package.patch >From 8a3ab5dba4f85dd1fb2ddaf683f9da7e5ec9854e Mon Sep 17 00:00:00 2001 From: Bird Date: Fri, 21 Jan 2022 04:32:39 +0000 Subject: [PATCH] gnu: gallery-dl: Add a new package. * gnu/packages/video.scm(gallery-dl): Add package. --- gnu/packages/video.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 461ccbb950..47f33ed3ac 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -2245,6 +2245,31 @@ (define-public smplayer the last played position, etc.") (license license:gpl2+))) +(define-public gallery-dl + (package + (name "gallery-dl") + (version "1.20.1") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/mikf/gallery-dl" + "/releases/download/v" + version + "/gallery_dl-" + version + ".tar.gz")) + (sha256 + (base32 + "0qkz8aznvybdqrjxsl6ir319ras05mi8l0sal4mgi18l70jndh51")))) + (build-system python-build-system) + (inputs (list python-requests ffmpeg)) + (home-page "https://github.com/mikf/gallery-dl") + (synopsis "Command-line program to download images from several sites") + (description "Command-line program to download image galleries +and collections from several image hosting sites +While this package can use youtube-dl or yt-dlp packages to download videos, +the focus is more on images and image hosting sites.") + (license license:gpl2))) + (define-public gnome-mpv (deprecated-package "gnome-mpv" celluloid)) base-commit: 2b6af630d61dd5b16424be55088de2b079e9fbaf -- 2.34.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 13:31:50 2022 Received: (at 53388-done) by debbugs.gnu.org; 25 Jan 2022 18:31:50 +0000 Received: from localhost ([127.0.0.1]:50064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCQbe-0007h5-1B for submit@debbugs.gnu.org; Tue, 25 Jan 2022 13:31:50 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCQbY-0007Z2-Ta for 53388-done@debbugs.gnu.org; Tue, 25 Jan 2022 13:31:48 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 68CBC5C0150; Tue, 25 Jan 2022 13:31:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 25 Jan 2022 13:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; bh=d8sUTM8vXBrRsw1uHzXW2R70fRl 3XY2jutWZcbtIVM8=; b=R+i+sU4Rp09l4KjmdmbDL8h7xKjY20fcl5YF1Fl7Bw/ bQLWFjesQQLGB8+iE3ZLy+g+oWoHZ8ye3Yfkne6abLQkt8ykBdTFWvzoBW+jZ1u6 /T3u0f3QzeiUTF93c34H7AGZ5QFEYsauN7xHYyKhZi7O/eHIiOVop8VErXWWQvUQ = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=d8sUTM8vXBrRsw1uH zXW2R70fRl3XY2jutWZcbtIVM8=; b=F8ds3t/nqer3Q5R9Yye5xIS28d9PTDAiK U2OsuD9syp21POFH0ty8SoA+sEyBqrlsU6R/QO3R1fXUYYkcwKQDH/M97v/v3YF7 yMgQl7iNT5S98UtUCWYEcuLliuW7IzgQYkV40b2tN/NevFf+nVuP4FXPwW+COfA0 2TygR8heEUarBzNH4m9OxnsXAv+0CTMD/xPPuWvGMXiAfxksOxpLFSYoYyfFEngy 2hx9lcpI/pUql7h9+kcX74kkAqaEBFUV/CphhJanWaRM9hFG13rFKHfy9k79oL1w EL1DwJt7BZPwOger19EBiMU17Fprty3MhvmiAZ4/XZ0vTYXLQHzXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvdelgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedmnecujfgurhepfffhvffukfhfgggtuggjsehttdortddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeetgffgueeuudejleelvdejudejledtvdfgleff gfefueetieevtdekleehueduueenucffohhmrghinhepghhnuhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhl rghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jan 2022 13:31:38 -0500 (EST) Date: Tue, 25 Jan 2022 13:31:36 -0500 From: Leo Famulari To: Bird Subject: Re: [bug#53388] New package: gallery-dl Message-ID: References: <85ee52fx12.fsf@airmail.cc> <85sfth8zlo.fsf@airmail.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85sfth8zlo.fsf@airmail.cc> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53388-done Cc: 53388-done@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Jan 21, 2022 at 04:46:59AM +0000, Bird wrote: > From 8a3ab5dba4f85dd1fb2ddaf683f9da7e5ec9854e Mon Sep 17 00:00:00 2001 > From: Bird > Date: Fri, 21 Jan 2022 04:32:39 +0000 > Subject: [PATCH] gnu: gallery-dl: Add a new package. * > gnu/packages/video.scm(gallery-dl): Add package. Thanks! I made some minor cosmetic changes to indentation and standardized the commit message and pushed as commit cc74d19d663b78a9ec8207d7e3a41cabfbe1a100. https://git.savannah.gnu.org/cgit/guix.git/commit/?id=cc74d19d663b78a9ec8207d7e3a41cabfbe1a100 I forgot to make sure your authorship was recorded in the copyright header, so I did that in a followup commit. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 13:37:27 2022 Received: (at 53388-done) by debbugs.gnu.org; 25 Jan 2022 18:37:27 +0000 Received: from localhost ([127.0.0.1]:50085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCQh5-0008R0-4r for submit@debbugs.gnu.org; Tue, 25 Jan 2022 13:37:27 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCQh2-0008Qi-DL for 53388-done@debbugs.gnu.org; Tue, 25 Jan 2022 13:37:25 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 48F495C014E; Tue, 25 Jan 2022 13:37:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 25 Jan 2022 13:37:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; bh=lz0EuBZ2qKe pCQBWSOAYpt4l1MvuO9QqfLNkzjibgQo=; b=Y58h2eFqY1qRepVMwVtABEZ3nKh l0qxUlAiIPaJHNYAZrqITxC2SwZiSsF5HVvmIHjhQGWIWO7R9TX2+WIiDgRlMvK+ ALF02RmP6umQpziDAIBPvdazUb87UUddmctQoyrDgGDl/MoX1El8X7z3knvkcliI ohcGxoUYJVnSaT0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lz0EuBZ2qKepCQBWSOAYpt4l1MvuO9QqfLNkzjibg Qo=; b=jsA+GonOHlYXKPVhuMlq/QrSibQxsjjO9UiA1tQ4IAETt9UbELtoq95X4 rGT0gSnh9d2g5CLVSWlJI/OOFiNmgjTUZs9Abv9+Id/CgdYW0x1F8b/Beoc9pGqb HhXg3ypoDIT3gmnVUEpmg+2q3iVBV4pYf90OC+ZkAPdxwoAkBUa/aBwHSuzxFbQF ZM9LWDSPrLdNwuobz6uupxHxIO2JH8zS6YcDHIfD+JTYCv5jSp+BudUYJ8sMx18K z3q+Lws7wbxYbvU40J8760V2BBloQuBP6Cq6paUuZeDWydCLEWVbYpiQQpbB4nsn xmu1759ewOksX5pTFbGmQqUoUzaWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvdelgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepuefhteduudevtdetfeeghfeiudelvefgfeeitddviedugeduueegleffffej heevnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jan 2022 13:37:18 -0500 (EST) Date: Tue, 25 Jan 2022 13:37:17 -0500 From: Leo Famulari To: Bird Subject: Re: [bug#53388] New package: gallery-dl Message-ID: References: <85ee52fx12.fsf@airmail.cc> <978432cd205f87fd00e623be35f0598d53a22155.camel@telenet.be> <851r12pame.fsf@airmail.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <851r12pame.fsf@airmail.cc> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53388-done Cc: 53388-done@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Jan 20, 2022 at 05:42:17PM +0000, Bird wrote: > > The README says it can use ‘youtube-dl’ or ‘yt-dlp’ for vide downloads > > and ‘ffmpeg‘ for some conversion, so maybe these could be added? > > > > Also, propagation can lead to profile collisions which can be > > complicated to resolve, so can this be made a regular input instead of > > a propagated input? Some wrap-program might be necessary. > > Can programs call to regular inputs that are not propagated? Since > gallery-dl will need ffmpeg and python-requests (and possibly yt-dlp), > would it need to be in user's profile? They can, but they need to learn how to find them. Usually that happens by making the package record the "store path" of the input at build-time. On the other hand, propagated-inputs appear on $PATH, so if the calling program does the normal thing it will find them. But, the drawback of propagating, for example, FFmpeg, is that it makes it impossible for users to `guix install` a custom FFmpeg package alongside the propagated FFmpeg. > >> +    (home-page "https://github.com/mikf/gallery-dl") I looked at the source code, and this program respects some configuration options to find the location of youtube-dl and ffmpeg: https://github.com/mikf/gallery-dl/blob/master/docs/configuration.rst#ugoiraffmpeg-location It's a matter of opinion but, to me, both of those programs are things that users may customize or choose particular versions of, so it's okay to expect users to install them and configure gallery-dl properly. If we want to improve this package in that regard... that's for a followup patch! From unknown Sun Jun 15 09:03:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 23 Feb 2022 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator