From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 06:52:40 2022 Received: (at submit) by debbugs.gnu.org; 20 Jan 2022 11:52:40 +0000 Received: from localhost ([127.0.0.1]:56573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAVzb-0004XE-EF for submit@debbugs.gnu.org; Thu, 20 Jan 2022 06:52:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:32868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAVzZ-0004X6-15 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 06:52:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAVzR-0003L5-JS for guix-patches@gnu.org; Thu, 20 Jan 2022 06:52:31 -0500 Received: from [2a00:1450:4864:20::12a] (port=44864 helo=mail-lf1-x12a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAVzO-000225-Nm for guix-patches@gnu.org; Thu, 20 Jan 2022 06:52:29 -0500 Received: by mail-lf1-x12a.google.com with SMTP id h26so5901738lfv.11 for ; Thu, 20 Jan 2022 03:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=qfHkVV6ZonY47+yQL5KWBfmtiZ1XcmWzdvyHRrTAOlg=; b=J31RUKmbNxrSWwTMw0NsjA7uTsbOG1POXI6OjhzkrT1KdfbO5Iio9h+q32hFCW+C8m W/gpJyA1cFySnP6cLzmIUGiOQ4mTp6dIINoAIwmfkohBmnEMDeGrTeMJk7k/eD7sFOG6 Pe+qgVHVmn0e7t1IxAF9dhHJSMcBo596CN8rl1VRZ+pa9fWVqXfD/gnk7LSr54XjvdV8 Xg0DW8MDN0vVN507FTBhXd4EGxHLJsnAGTwIYFlaAiF0ElSDso2nyu95cZvLzSU/e7dT 8Iz80tmg6D8A8/AocApWD6aOheb7tYp5EQYX1+YzT7tXcgt9iwUE+BLTxA4lZjP3lb7v HAJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=qfHkVV6ZonY47+yQL5KWBfmtiZ1XcmWzdvyHRrTAOlg=; b=XIAwJg+cj166E9K0nakkxs+EPZtIn0BBv5QGwKvXDu3Z+owu43WF8aHf114YsWh6kk X7Oh1cUothz6k0uhHdcmhp0GWiYZpUYBhLMnrI8iTIjlLVpaE/R1qKzXGmBpLjSeFvwV W2m0KG/1qpqyEMZqSQC7GLhyfspXoPf00cKIeNy1/PuUVVqomyuYv+rT8MTKtRSFyHip 6eK+2HT4r9P3KAp8HBjWWYMVvBdLCEwRuMiyX/0YU/7z8r3sV0HpnIf7HbazBeIKOmJV HAyQVJWVI1OE63qVs5L7FsDIpHT96C/lDxuxmUpQ/4Iv8mmDCraW+axkVPsGWSzTX4SR qOLw== X-Gm-Message-State: AOAM532HaBJ9qLScAzT/UeOHPyiR4FSVwxNBEwHv73Zin+Rb0uaa/Led gmT3X+eBswDVm98XBiyE3CyLCafdHCKbkw== X-Google-Smtp-Source: ABdhPJwKONENVf5FpqbcpvvOuCVdApRkDQ1u9/Hnk6z/pY1AIIFUTy8y6cStOoR8DCMuAnuYWkqa0Q== X-Received: by 2002:a05:651c:1a24:: with SMTP id by36mr23028875ljb.321.1642679543782; Thu, 20 Jan 2022 03:52:23 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id l6sm252734ljh.63.2022.01.20.03.52.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jan 2022 03:52:22 -0800 (PST) From: Andrew Tropin To: guix-patches@gnu.org Subject: [PATCH 0/4] Update tdlib and telega packages Date: Thu, 20 Jan 2022 14:45:08 +0300 Message-ID: <87tudyipzg.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::12a (failed) Received-SPF: none client-ip=2a00:1450:4864:20::12a; envelope-from=andrew@trop.in; helo=mail-lf1-x12a.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain tdlib and telega are inteded to be used from specific commits not tags, I keep revision and commit parameters for those packages to make it easier to update them to untagged commits in the future. https://github.com/tdlib/td/issues/1790 Also, updated the style for arguments. Andrew Tropin (4): gnu: tdlib: Update to 1.8.0. gnu: telega: Update to 0.8.01. gnu: tdlib: Use new package style. gnu: telega: Use new package style. gnu/packages/emacs-xyz.scm | 88 +++++++++++++++++++------------------- gnu/packages/messaging.scm | 38 ++++++++-------- 2 files changed, 65 insertions(+), 61 deletions(-) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-tdlib-Update-to-1.8.0.patch Content-Transfer-Encoding: quoted-printable From=20c64a936ba458676cee41a11a42202fda13dda8cb Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Thu, 20 Jan 2022 11:56:11 +0300 Subject: [PATCH 1/4] gnu: tdlib: Update to 1.8.0. * gnu/packages/messaging.scm (tdlib): Update to 1.8.0. =2D-- gnu/packages/messaging.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 2fe0d35a10..843dba2c61 100644 =2D-- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -2593,10 +2593,11 @@ (define-public telegram-purple (license license:gpl2+))) =20 (define-public tdlib =2D (let ((commit "34ba9b21f365b8d3bdc36808c2d665ca5cd128f6")) + (let ((commit "b3ab664a18f8611f4dfcd3054717504271eeaa7a") + (revision "1")) (package (name "tdlib") =2D (version "1.7.10") + (version (git-version "1.8.0" revision commit)) (source (origin (method git-fetch) @@ -2604,7 +2605,7 @@ (define-public tdlib (url "https://github.com/tdlib/td") (commit commit))) (sha256 =2D (base32 "06fbdh1jypz0p1rf6xbpias4kx7xplq9xjd9vz177vwj9icq3wki"= )) + (base32 "19psqpyh9a2kzfdhgqkirpif4x8pzy89phvi59dq155y30a3661q")) (file-name (git-file-name name version)))) (build-system cmake-build-system) (arguments =2D-=20 2.34.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-telega-Update-to-0.8.01.patch Content-Transfer-Encoding: quoted-printable From=2084d1bce32f1a18f1e733499f5dc9dd4bb8374aba Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Thu, 20 Jan 2022 11:56:22 +0300 Subject: [PATCH 2/4] gnu: telega: Update to 0.8.01. * gnu/packages/emacs-xyz.scm (emacs-telega-server): Update to 0.8.01. =2D-- gnu/packages/emacs-xyz.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b317d4dc58..ed58989f56 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -26807,11 +26807,11 @@ (define-public emacs-helm-switch-to-repl (license license:gpl3+))) =20 (define-public emacs-telega-server =2D (let ((commit "b4a5e206bd259f3d7f7633a725b2990704d6a1e8") + (let ((commit "5739794d2d0c8a4e7b77c2e37a097e19f80ac9f0") (revision "1")) (package (name "emacs-telega-server") =2D (version (git-version "0.7.15" revision commit)) + (version (git-version "0.8.01" revision commit)) (source (origin (method git-fetch) @@ -26819,7 +26819,7 @@ (define-public emacs-telega-server (url "https://github.com/zevlg/telega.el") (commit commit))) (sha256 =2D (base32 "0gr4nmpk175hxmj357bpzaqywbjc6dmmvfxnyzkh884vyzbwdxlc"= )) + (base32 "1am0b2bjjkw7zd0yq39v015a08dcbk43j4d4h8y2q8hj53ryfk5a")) (file-name (git-file-name "emacs-telega" version)) (patches (search-patches "emacs-telega-path-placeholder.patch" =2D-=20 2.34.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0003-gnu-tdlib-Use-new-package-style.patch Content-Transfer-Encoding: quoted-printable From=204234d27ed60796b6c4927fdd378e75f6cdafa057 Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Thu, 20 Jan 2022 13:27:15 +0300 Subject: [PATCH 3/4] gnu: tdlib: Use new package style. * gnu/packages/messaging.scm (tdlib): Use gexps, remove trailing #t. =2D-- gnu/packages/messaging.scm | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 843dba2c61..f2d518fdf5 100644 =2D-- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -2609,21 +2609,22 @@ (define-public tdlib (file-name (git-file-name name version)))) (build-system cmake-build-system) (arguments =2D `(#:tests? #t =2D #:configure-flags =2D (list "-DCMAKE_BUILD_TYPE=3DRelease" =2D "-DTD_ENABLE_LTO=3DOFF") ; FIXME: Get LTO to work. =2D #:phases =2D (modify-phases %standard-phases =2D (add-after 'unpack 'remove-failing-tests =2D (lambda _ =2D (substitute* "test/CMakeLists.txt" =2D ;; The test cases are compiled into a distinct binary =2D ;; which uses mtproto.cpp to attempt to connect to =2D ;; a remote server. Removing this file from the sources =2D ;; list disables those specific test cases. =2D (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")) =2D #t))))) + (list + #:tests? #t + #:configure-flags + #~(list "-DCMAKE_BUILD_TYPE=3DRelease" + "-DTD_ENABLE_LTO=3DOFF") ; FIXME: Get LTO to work. + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'remove-failing-tests + (lambda _ + (substitute* "test/CMakeLists.txt" + ;; The test cases are compiled into a distinct binary + ;; which uses mtproto.cpp to attempt to connect to + ;; a remote server. Removing this file from the sources + ;; list disables those specific test cases. + (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")) + ))))) (native-inputs (list gperf openssl zlib php doxygen)) (synopsis "Cross-platform library for building Telegram clients") =2D-=20 2.34.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0004-gnu-telega-Use-new-package-style.patch Content-Transfer-Encoding: quoted-printable From=206a57549e00616dae5ae8e35e7375e60e2dfe68aa Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Thu, 20 Jan 2022 14:09:14 +0300 Subject: [PATCH 4/4] gnu: telega: Use new package style. * gnu/packages/emacs-xyz.scm (emacs-telega, emacs-telega-contrib): Use gexp= s, remove trailing #t. =2D-- gnu/packages/emacs-xyz.scm | 82 +++++++++++++++++++------------------- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index ed58989f56..c94f8443d9 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -26863,39 +26863,40 @@ (define-public emacs-telega (name "emacs-telega") (build-system emacs-build-system) (arguments =2D `(#:emacs ,(if (target-64bit?) =2D emacs-minimal =2D ;; Require wide-int support for 32-bit platform. =2D emacs-wide-int) =2D #:include (cons "^etc\\/" %default-include) =2D #:phases =2D (modify-phases %standard-phases =2D (add-after 'unpack 'patch-sources =2D (lambda* (#:key inputs #:allow-other-keys) =2D ;; Hard-code paths to `ffplay` and `ffmpeg`. =2D (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay")) =2D (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg")= )) =2D (substitute* '("telega-ffplay.el" "telega-vvnote.el") =2D (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe= )" =2D all func cmd) =2D (string-append func " \"" =2D (search-input-file =2D inputs (string-append "/bin/" cmd)))) =2D (("\\(executable-find \"ffplay\"\\)") =2D (string-append "(and (file-executable-p \"" ffplay-bin= "\")" =2D "\"" ffplay-bin "\")")) =2D (("\\(executable-find \"ffmpeg\"\\)") =2D (string-append "(and (file-executable-p \"" ffmpeg-bin= "\")" =2D "\"" ffmpeg-bin "\")")))))) =2D (add-after 'unpack 'configure =2D (lambda* (#:key inputs outputs #:allow-other-keys) =2D (substitute* "telega-customize.el" =2D (("@TELEGA_SERVER_BIN@") =2D (search-input-file inputs "/bin/telega-server"))) =2D (substitute* "telega-util.el" =2D (("@TELEGA_SHARE@") =2D (string-append (elpa-directory (assoc-ref outputs "out")) =2D "/etc")))))))) + (list + #:emacs (if (target-64bit?) + emacs-minimal + ;; Require wide-int support for 32-bit platform. + emacs-wide-int) + #:include #~(cons "^etc\\/" %default-include) + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-sources + (lambda* (#:key inputs #:allow-other-keys) + ;; Hard-code paths to `ffplay` and `ffmpeg`. + (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay")) + (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg"))) + (substitute* '("telega-ffplay.el" "telega-vvnote.el") + (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe)" + all func cmd) + (string-append func " \"" + (search-input-file + inputs (string-append "/bin/" cmd)))) + (("\\(executable-find \"ffplay\"\\)") + (string-append "(and (file-executable-p \"" ffplay-bin = "\")" + "\"" ffplay-bin "\")")) + (("\\(executable-find \"ffmpeg\"\\)") + (string-append "(and (file-executable-p \"" ffmpeg-bin = "\")" + "\"" ffmpeg-bin "\")")))))) + (add-after 'unpack 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + (substitute* "telega-customize.el" + (("@TELEGA_SERVER_BIN@") + (search-input-file inputs "/bin/telega-server"))) + (substitute* "telega-util.el" + (("@TELEGA_SHARE@") + (string-append (elpa-directory (assoc-ref outputs "out")) + "/etc")))))))) (inputs (list emacs-telega-server ffmpeg)) (native-inputs '()) @@ -26911,13 +26912,14 @@ (define-public emacs-telega-contrib (inherit emacs-telega) (name "emacs-telega-contrib") (arguments =2D `(#:exclude '("telega-live-location.el") =2D #:phases =2D (modify-phases %standard-phases =2D (add-after 'unpack 'enter-subdirectory =2D (lambda _ (chdir "contrib") #t)) =2D (add-before 'install-license-files 'leave-subdirectory =2D (lambda _ (chdir "..") #t))))) + (list + #:exclude '("telega-live-location.el") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'enter-subdirectory + (lambda _ (chdir "contrib"))) + (add-before 'install-license-files 'leave-subdirectory + (lambda _ (chdir "..")))))) (inputs '()) (native-inputs '()) (propagated-inputs =2D-=20 2.34.0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 2.34.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmHpTPMPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6w8TcP/3CaJrlmx9puLy+ectm9TN+lIG79k1In9zPi W09+xLg4PpU7abSJ/a73ovTjqDjQnmI9eZ3ZPj0vaS9Q9gsp1f004ZpTV1oxk0V4 l4xzuRdUZEk0wQU9Y+xrYZeZXzcIaw2rU/w9rQ77HD0cSL6At5YDsf4ZEVGuEfQb YIlZmszmYu7I0FzcMeNnQBXILu63oRPklC7nSUuXnIjXJwYpagCUp2AXn2mgfnhY JBk5XaIkVPgUO3rySVFgEr3O9yZwSYtCwl8Q0IgiuugOuKKHs6aZ8K68gyB3gJrG R4o+IMStILQINRcmeN7tzmPWmo1CuSss3fTxd1jTvuquaN0Gqpee+yrWrQsv+c7w 86yxLecYqbrSnld8W5+ZcjcV79IFaJ148NsW3TWi5i1fVH/DGwUME4xNjrkea8pS 8DTFg3cWSlYck0Vhf+cOwjxB7YLZWq0OVXAlcrnvwaMQpF7kIF92P6ZhlEEDtp+C RYPVUW/ynNxjXjCWoDNV+DuDZiBJN7yaqMxl+PmDrkUwr9Bc2crgR8KXOFZIk9wi SPG5j2t2sFI3wqt6Ghu+PI1qKji1LIbqR9eIhdy+mRAqEWP/9ZvlSRjf4ko1dnqA 3h9WXjp1YOu6bRgMxEch9KfeIOUChU/6BRFLvnjWvfUw8lfGkXVcsO3rUhwOuGFm jJhHgFyt =DiBi -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 22 10:15:03 2022 Received: (at 53387) by debbugs.gnu.org; 22 Jan 2022 15:15:03 +0000 Received: from localhost ([127.0.0.1]:37632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBI6Z-0001R9-5s for submit@debbugs.gnu.org; Sat, 22 Jan 2022 10:15:03 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBI6X-0001QN-K6 for 53387@debbugs.gnu.org; Sat, 22 Jan 2022 10:15:02 -0500 Received: by mail-wr1-f65.google.com with SMTP id u15so5263846wrt.3 for <53387@debbugs.gnu.org>; Sat, 22 Jan 2022 07:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=DaIbOyfelpHSRHcM8Sd6UKgN55B9AD6LNec+WzanAC0=; b=JSfWzA402Fk02Oqo1HNoGixBEEKkaOjvVObi8PBHRRMDIEvFPEkbvbeEq9TJpHH4Yx C44C1lgPFmsDwBlPgjHE45eumn5EdLBZBNRm6xyNEKYjHgpprlCAb3ThJ0FTPGuJtTuY 34FtqsqTd95rwAdUvfA89TFKPBRWLMQ/AWq/plnl6JD+ihmjoBhMmmE5nvr0W9jPVwp9 emHHCdNQ9FJv+w7WBHzf/H+hZ7/KrrsylBv2zUn0h+T3SESQp4xJv4G1jCGczINjWJy9 mvvhHhmezC5I70+yHEC3O65XqrW550AKKzeRBR8UxVUDcdCd3EiWuKJ5SuiTyetDB7Ib /ZtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=DaIbOyfelpHSRHcM8Sd6UKgN55B9AD6LNec+WzanAC0=; b=slv5/uac4nweOpziHzXHTHiJsAAQXfG8wLIADLnXoQnlK3/oahA1JJGAB203elfRSL BEyMovwFDOBX2jQ6vDQs0RfhDrvMBTJ3dx4q/UuqBdWrHOp88c3fWIde9k7/hJeddYye VRjlB/TAV0SRbb2sCNsce7DWtguWG4/WMLAKMzYCfmTc17bT12jGV+ZFear7EbwwYhs5 pDIFdFmt2tmWLcSD4Tis30H7ZwGfe/uoFbs/oBHmL0NX2Ksvj8c/n+BT1Dc8lQk3MVkC ZwdpjAT8m66Rl7jQki9Thp2eRpSitE8ZeCDIP+dY3wvsgS6i/+++GO5fCFQTNnOFLo2B alvQ== X-Gm-Message-State: AOAM532dAQk4wxmI7XE4+cjEd7h8FF7M6+SyxtpjE9ilyg6Pe6BBUoOz MZF8UBKCxy0qiruUfUZ4Aac= X-Google-Smtp-Source: ABdhPJyCHxPCV7DDr9ZS5pWtHwY440bFV+91WxZWZNxtyXBLBsdrvPoone66TyTr4WoxIqPW7z00HQ== X-Received: by 2002:a5d:68d0:: with SMTP id p16mr7455264wrw.151.1642864495651; Sat, 22 Jan 2022 07:14:55 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id c13sm9272909wrv.24.2022.01.22.07.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jan 2022 07:14:54 -0800 (PST) Message-ID: Subject: Re: [PATCH 0/4] Update tdlib and telega packages From: Liliana Marie Prikler To: Andrew Tropin , 53387@debbugs.gnu.org Date: Sat, 22 Jan 2022 16:14:53 +0100 In-Reply-To: <87tudyipzg.fsf@trop.in> References: <87tudyipzg.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53387 Cc: Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Andrew, Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin: > tdlib and telega are inteded to be used from specific commits not > tags, I keep revision and commit parameters for those packages to > make it easier to update them to untagged commits in the future. > > https://github.com/tdlib/td/issues/1790 > > Also, updated the style for arguments. It appears Telega was already updated through a different patch. The style adjustments are still relevant, but fail to apply currently. As for commit vs. tag, I've CC'd Nicolas to make a more informed decision. I do understand your reasoning, but OTOH I disagree with Telegram's "every commit is as good as a release" stance, particularly if there's a widely used client whose releases fail in CI :) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 27 02:54:37 2022 Received: (at 53387) by debbugs.gnu.org; 27 Jan 2022 07:54:37 +0000 Received: from localhost ([127.0.0.1]:54179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCzc4-0006Nd-Mc for submit@debbugs.gnu.org; Thu, 27 Jan 2022 02:54:37 -0500 Received: from mail-lj1-f174.google.com ([209.85.208.174]:46817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCzc0-0006NN-Ko for 53387@debbugs.gnu.org; Thu, 27 Jan 2022 02:54:35 -0500 Received: by mail-lj1-f174.google.com with SMTP id c7so2527745ljr.13 for <53387@debbugs.gnu.org>; Wed, 26 Jan 2022 23:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=K0W9YNdBfYGwhYmlCuvhw8UXlGBXqLfXO9xutKGTWKA=; b=IONvJrTM7kQKCavmDQvIs6MXCSlFg7Ei0HdrkVb7ohPIDQMjJKPcOvayrxweWkB6Mg u3qWcmcvjJchMG7yFzc1ae7DLxSo0vJimR8cLw11Fq1DG3r4vIdUERPM0Chl/hWuukSh xxYHd9XKEI/BDB9aK2xHch9WqiPKuq8rVyG9u6TmFUEElUH8NwB/PeAzYs0WiAaLl/rx B6lc0KF1CXvTo1Dd8h7Jv0NHKO6qJh8Goi9YDVSupF79fRxwRtV3qfLpipCUpA2FiSqx 1jw/mkkNTCy6+geFdzjbHpGTKD+DkZiacJft3XFncau6PEeK5Hzz/OBkEpD6OteKMPf4 4emw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=K0W9YNdBfYGwhYmlCuvhw8UXlGBXqLfXO9xutKGTWKA=; b=yw14qZxRSt0pq26/7LjT92Eiw53r1JbUCQGZVxk4Q7oIzdesiGhIAUhgNBhozHFJi3 Kt6pYNAiHLHYhlVQTAun6WlzwgYkLEfZJvcMnptXLNqfLgGQmUXdhNDwJR1UYWLPsEyA qsXVL7QuNPZbqohMtroC5FMfADVd2Nn/yQ73ygXxovrnOlYHFwShus69MZSWKxY9/zCy SEcy7D67umYha0d4wCUZxJuJlHYvQlq+4bxm1h5+184YiSd/RDZ4A1Tf5CATgo4IGmoX n/PqkYxS3ccJrpT7+ZEWV0gOtErxadsGTDjP+0dNZpjB5wKX9didD6gImLNHy3FY7F0+ ZYkA== X-Gm-Message-State: AOAM531FxXJ6XYJAC5wVqYSTuqPEGjcSgeADChOTjSXwOLSzU76MiCZj 9I4aLpyPa2WFMe/t6mU1CesQnA== X-Google-Smtp-Source: ABdhPJxxDFwqTnwsZikwgMkQ52U1NvmMq55+1vvGLVTHrTzmg9tgrokmTX19ycxU4geAmkcNZXNQ+Q== X-Received: by 2002:a2e:a812:: with SMTP id l18mr2078349ljq.110.1643270066468; Wed, 26 Jan 2022 23:54:26 -0800 (PST) Received: from localhost (109-252-135-33.dynamic.spd-mgts.ru. [109.252.135.33]) by smtp.gmail.com with ESMTPSA id d26sm2078250lfb.177.2022.01.26.23.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 23:54:22 -0800 (PST) From: Andrew Tropin To: Liliana Marie Prikler , 53387@debbugs.gnu.org Subject: Re: [PATCH 0/4] Update tdlib and telega packages In-Reply-To: References: <87tudyipzg.fsf@trop.in> Date: Thu, 27 Jan 2022 10:54:14 +0300 Message-ID: <87ee4tsjfd.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53387 Cc: zevlg@yandex.ru, Nicolas Goaziou , avityazev@posteo.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable CCed: avityazev, zevlg On 2022-01-22 16:14, Liliana Marie Prikler wrote: > Hi Andrew,=20 > > Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin: >> tdlib and telega are inteded to be used from specific commits not >> tags, I keep revision and commit parameters for those packages to >> make it easier to update them to untagged commits in the future. >>=20 >> https://github.com/tdlib/td/issues/1790 >>=20 >> Also, updated the style for arguments. > It appears Telega was already updated through a different patch. The > style adjustments are still relevant, but fail to apply currently. > Updated patches. >=20 > As for commit vs. tag, I've CC'd Nicolas to make a more informed > decision. I do understand your reasoning, but OTOH I disagree with > Telegram's "every commit is as good as a release" stance, particularly > if there's a widely used client whose releases fail in CI :) I agree, tdlib rolling release seems a little strange to me and I personally not in a favor of it. I still propose to keep commit and revision variables for both tdlib and telega to be able to update them from time to time to a fresh version, which surely won't have a release tag. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-telega-Use-new-package-style.patch Content-Transfer-Encoding: quoted-printable From=2078e24c360cbd9c9cd791f56aeb290fffbc29ebae Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Thu, 20 Jan 2022 14:09:14 +0300 Subject: [PATCH 1/2] gnu: telega: Use new package style. * gnu/packages/emacs-xyz.scm (emacs-telega, emacs-telega-contrib): Use gexp= s, remove trailing #t. =2D-- gnu/packages/emacs-xyz.scm | 82 +++++++++++++++++++------------------- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 387f1b93fd..d456a6cd52 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -27030,39 +27030,40 @@ (define-public emacs-telega (name "emacs-telega") (build-system emacs-build-system) (arguments =2D `(#:emacs ,(if (target-64bit?) =2D emacs-minimal =2D ;; Require wide-int support for 32-bit platform. =2D emacs-wide-int) =2D #:include (cons "^etc\\/" %default-include) =2D #:phases =2D (modify-phases %standard-phases =2D (add-after 'unpack 'patch-sources =2D (lambda* (#:key inputs #:allow-other-keys) =2D ;; Hard-code paths to `ffplay` and `ffmpeg`. =2D (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay")) =2D (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg")= )) =2D (substitute* '("telega-ffplay.el" "telega-vvnote.el") =2D (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe= )" =2D all func cmd) =2D (string-append func " \"" =2D (search-input-file =2D inputs (string-append "/bin/" cmd)))) =2D (("\\(executable-find \"ffplay\"\\)") =2D (string-append "(and (file-executable-p \"" ffplay-bin= "\")" =2D "\"" ffplay-bin "\")")) =2D (("\\(executable-find \"ffmpeg\"\\)") =2D (string-append "(and (file-executable-p \"" ffmpeg-bin= "\")" =2D "\"" ffmpeg-bin "\")")))))) =2D (add-after 'unpack 'configure =2D (lambda* (#:key inputs outputs #:allow-other-keys) =2D (substitute* "telega-customize.el" =2D (("@TELEGA_SERVER_BIN@") =2D (search-input-file inputs "/bin/telega-server"))) =2D (substitute* "telega-util.el" =2D (("@TELEGA_SHARE@") =2D (string-append (elpa-directory (assoc-ref outputs "out")) =2D "/etc")))))))) + (list + #:emacs (if (target-64bit?) + emacs-minimal + ;; Require wide-int support for 32-bit platform. + emacs-wide-int) + #:include #~(cons "^etc\\/" %default-include) + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-sources + (lambda* (#:key inputs #:allow-other-keys) + ;; Hard-code paths to `ffplay` and `ffmpeg`. + (let* ((ffplay-bin (search-input-file inputs "/bin/ffplay")) + (ffmpeg-bin (search-input-file inputs "/bin/ffmpeg"))) + (substitute* '("telega-ffplay.el" "telega-vvnote.el") + (("(shell-command-to-string\|concat) \"(ffmpeg\|ffprobe)" + all func cmd) + (string-append func " \"" + (search-input-file + inputs (string-append "/bin/" cmd)))) + (("\\(executable-find \"ffplay\"\\)") + (string-append "(and (file-executable-p \"" ffplay-bin = "\")" + "\"" ffplay-bin "\")")) + (("\\(executable-find \"ffmpeg\"\\)") + (string-append "(and (file-executable-p \"" ffmpeg-bin = "\")" + "\"" ffmpeg-bin "\")")))))) + (add-after 'unpack 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + (substitute* "telega-customize.el" + (("@TELEGA_SERVER_BIN@") + (search-input-file inputs "/bin/telega-server"))) + (substitute* "telega-util.el" + (("@TELEGA_SHARE@") + (string-append (elpa-directory (assoc-ref outputs "out")) + "/etc")))))))) (inputs (list emacs-telega-server ffmpeg)) (native-inputs '()) @@ -27078,13 +27079,14 @@ (define-public emacs-telega-contrib (inherit emacs-telega) (name "emacs-telega-contrib") (arguments =2D `(#:exclude '("telega-live-location.el") =2D #:phases =2D (modify-phases %standard-phases =2D (add-after 'unpack 'enter-subdirectory =2D (lambda _ (chdir "contrib") #t)) =2D (add-before 'install-license-files 'leave-subdirectory =2D (lambda _ (chdir "..") #t))))) + (list + #:exclude '("telega-live-location.el") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'enter-subdirectory + (lambda _ (chdir "contrib"))) + (add-before 'install-license-files 'leave-subdirectory + (lambda _ (chdir "..")))))) (inputs '()) (native-inputs '()) (propagated-inputs =2D-=20 2.34.0 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-tdlib-Use-new-package-style.patch Content-Transfer-Encoding: quoted-printable From=2090a77ee77aa4f339c9cee978e96ee72e1316bcd9 Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Thu, 20 Jan 2022 13:27:15 +0300 Subject: [PATCH 2/2] gnu: tdlib: Use new package style. * gnu/packages/messaging.scm (tdlib): Use gexps, remove trailing #t. =2D-- gnu/packages/messaging.scm | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 768642f119..01316f8bd2 100644 =2D-- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -2612,20 +2612,21 @@ (define-public tdlib (file-name (git-file-name name version)))) (build-system cmake-build-system) (arguments =2D `(#:tests? #t =2D #:configure-flags =2D (list "-DCMAKE_BUILD_TYPE=3DRelease" =2D "-DTD_ENABLE_LTO=3DOFF") ; FIXME: Get LTO to work. =2D #:phases =2D (modify-phases %standard-phases =2D (add-after 'unpack 'remove-failing-tests =2D (lambda _ =2D (substitute* "test/CMakeLists.txt" =2D ;; The test cases are compiled into a distinct binary =2D ;; which uses mtproto.cpp to attempt to connect to =2D ;; a remote server. Removing this file from the sources =2D ;; list disables those specific test cases. =2D (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") ""))))= ))) + (list + #:tests? #t + #:configure-flags + #~(list "-DCMAKE_BUILD_TYPE=3DRelease" + "-DTD_ENABLE_LTO=3DOFF") ; FIXME: Get LTO to work. + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'remove-failing-tests + (lambda _ + (substitute* "test/CMakeLists.txt" + ;; The test cases are compiled into a distinct binary + ;; which uses mtproto.cpp to attempt to connect to + ;; a remote server. Removing this file from the sources + ;; list disables those specific test cases. + (("\\$\\{CMAKE_CURRENT_SOURCE_DIR\\}/mtproto.cpp") "")))))= )) (native-inputs (list gperf openssl zlib php doxygen)) (synopsis "Cross-platform library for building Telegram clients") =2D-=20 2.34.0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 Best regards, Andrew Tropin --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmHyT6YPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wovYP/1sM9pTpRvgOn/tkIZJK88lfJadDDcMUlda+ KXIOHEUsH5yOr2GU+QW3ii4T57RiVRMIBuXOtk92OX1PmhMrKjFl9PElNOpw8gwb Xhvq0LPc6gXg2FU//mkXWeN/fG0EF9zDpUO0chfbLbZNZDzAPejSMvbzcRVSO67c 0ZJkDRNG0uUYGOb4eLCMwWA/pZTR8M0/VgznfreaXhUqoGhXc5HOCmFVjIBrhN5N tcaGZ1JZD8B9Z5qXLNVSwA119HFSkw24MAK74Fld6AD5OR4OTUEqMIIipWILf9RF ulsYTIrRXPp18B1kaqNOQ9O603aEJffM7vKjjvS+cLq9Ajs1iHuz/5ZNiF9bkkJp d12i/sUCWvUidQ8WMis4FpkkdrqKtq0uxWX8PQW8Ywnco4dZt6pYaC+QWLvcZEr2 /WfVt87Oi+T0Yd6Tb+m2evKaWwQN2FAtcFMXKs1eL5VI+IeFawToxP/GQlhceKei 3E1/oMMSki2XXum1VFX1xbQ8l22RCihEpWXOp1Xf1Lmttt8dFx977s9CDnLsEF5i u1XPY8i1ovFsGnFp9YKGonkvnam6KFjDKeAyi7Jv7EVrtD5y8NuKQM60IuWnPCyz XqMknX4iPthIY3B6Y4YPnR/rx1O2vFDI7s58QGiKdcV+R6lZTyX9xji5du9kTced OVojp/5C =YGRn -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 07:58:12 2022 Received: (at 53387) by debbugs.gnu.org; 26 Nov 2022 12:58:12 +0000 Received: from localhost ([127.0.0.1]:38130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyul2-0004YC-CG for submit@debbugs.gnu.org; Sat, 26 Nov 2022 07:58:12 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyul0-0004Xl-AO for 53387@debbugs.gnu.org; Sat, 26 Nov 2022 07:58:11 -0500 Received: by mail-wm1-f68.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so8106651wmb.2 for <53387@debbugs.gnu.org>; Sat, 26 Nov 2022 04:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=0zH85g3Ht0Rp7rrDSbM+lOPk/VzfyEdSWoCn+/R0OHM=; b=onGJwS3+3pnCgde0ndW6Xwf37GHovIK+LD98ySB5Q/R/d+T9J4udrNRFhJ3smY/xL7 mQMVb6iOfRKGHrIq3ct888dTEhZToSjcjppay2VD4I/cesHUuRMHDmXyMzm0kRs+N0jb oJN2qTcZb8yzrGzLCGK1RvlEPcubN6iOxYjtyPDjPPiFC/Kusl8Hc6YsleUfUI4zetb0 bAJ82F84yJLmkzfB9pT/cKzTGteHihIeHpc71Mb+UcYH4IcUroRaqpjNvlwqxn8Ejgiu wxIWJUO3PDGTiDvt/3DJxEHHn1O2xISAnLSXz13RL4UwOX7dag+AQEw4MRlfTfsa9VOy zsVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0zH85g3Ht0Rp7rrDSbM+lOPk/VzfyEdSWoCn+/R0OHM=; b=ZQwvssFBl9x/eLuMIG6oN/Avlkel5LhBScBT2sjGbUbv/X/HI50/0D0hlVQMQIohU4 3Pfk+1tZy/lovk6HXo3P4Ad+QeqqcIoq5hc40gKTPj+hlMU24l6hxyfe6m2B2pRsC6Ky sMPqwmQePsp+hhTjgrFoKhta8P8ph45xa1AD49zFTRm2TEGV0H+X65ZQ8HeXe2tjeQAw Jz7HggslruFK4mEb03I6gna+UWWhtHljQrfyQjniz7J6lXHK0prnZBuH+yTFPwPM0Dje Zh7K4kA8Dyl/lF52v45p/z51qm5d+7u4naTukCxSrifCK5s/+AiUpDLvAQ1mzMV3hjI4 Fo1g== X-Gm-Message-State: ANoB5pn2aQV4qd1k8/mDSC8TNvtJT8UNu/CODg+sUWz/XhXECJzmcjbk meo1Lr7wV8YVKklK3niKG9E= X-Google-Smtp-Source: AA0mqf7Ps8OzkwRcCkr6FkwRsD/CdfWLnMPhXIgOpKFkK16R2ap9pIyN8d2jcck/XLBd97x2kxnFjA== X-Received: by 2002:a7b:cd85:0:b0:3d0:4af1:a342 with SMTP id y5-20020a7bcd85000000b003d04af1a342mr4736411wmj.114.1669467484627; Sat, 26 Nov 2022 04:58:04 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id z12-20020a05600c220c00b003cf7055c014sm8436169wml.1.2022.11.26.04.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Nov 2022 04:58:04 -0800 (PST) Message-ID: <79a67632531acfefcf781bdc942b2f60c3f3619e.camel@gmail.com> Subject: Re: [PATCH 0/4] Update tdlib and telega packages From: Liliana Marie Prikler To: Andrew Tropin , 53387@debbugs.gnu.org Date: Sat, 26 Nov 2022 13:58:03 +0100 In-Reply-To: <87ee4tsjfd.fsf@trop.in> References: <87tudyipzg.fsf@trop.in> <87ee4tsjfd.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53387 Cc: zevlg@yandex.ru, Nicolas Goaziou , avityazev@posteo.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Andrew, sorry for not reacting earlier. Is this patch still "fresh and relevant"? Should we aim for newer versions? Am Donnerstag, dem 27.01.2022 um 10:54 +0300 schrieb Andrew Tropin: > CCed: avityazev, zevlg >=20 > On 2022-01-22 16:14, Liliana Marie Prikler wrote: >=20 > > Hi Andrew,=20 > >=20 > > Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin: > > > tdlib and telega are inteded to be used from specific commits not > > > tags, I keep revision and commit parameters for those packages to > > > make it easier to update them to untagged commits in the future. > > >=20 > > > https://github.com/tdlib/td/issues/1790 > > >=20 > > > Also, updated the style for arguments. > > It appears Telega was already updated through a different patch.=C2=A0 > > The style adjustments are still relevant, but fail to apply > > currently. > >=20 >=20 > Updated patches. >=20 > >=20 > > As for commit vs. tag, I've CC'd Nicolas to make a more informed > > decision.=C2=A0 I do understand your reasoning, but OTOH I disagree wit= h > > Telegram's "every commit is as good as a release" stance, > > particularly if there's a widely used client whose releases fail in > > CI :) >=20 > I agree, tdlib rolling release seems a little strange to me and I > personally not in a favor of it.=C2=A0 I still propose to keep commit and > revision variables for both tdlib and telega to be able to update > them from time to time to a fresh version, which surely won't have a > release tag. >=20 >=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 00:43:25 2022 Received: (at 53387) by debbugs.gnu.org; 28 Nov 2022 05:43:25 +0000 Received: from localhost ([127.0.0.1]:46349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozWvM-0007Te-VH for submit@debbugs.gnu.org; Mon, 28 Nov 2022 00:43:25 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozWvK-0007TY-Ei for 53387@debbugs.gnu.org; Mon, 28 Nov 2022 00:43:23 -0500 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id C4DBDE0008; Mon, 28 Nov 2022 05:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1669614195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ewm876YeGtKzitpk67gTSRcq3fLP1J4qdnv9UtuD3so=; b=k+vAuMZkYnheWjDvKSbl1G8O33SHiEZn+DiQ0dRLcQcB2dlO0zVBj9qui5znvlz2hE0pSd NkicYeWQL8pAFlCRwsUYaeZcMsqrMzC1z28MpH4nWiLEZDqWE86seNAfN8n0eCTnaiWhnC lmLKUMfTfSwoRHerwpN7mT1IlS02aiWNUM5HBkLfckqeknk7MxjhU6EfESK/HvWEMykeI4 BUS8CTdR6glRrBGAhrbUdyJ2jOWF1hPAFV3ma9P1nGWvMu36jvYAdb0lcu9QfI4Sp6upQy W/50xpSwkzN/8GCqWNc8t/2P/N0e3peoS9w6Bg/ewqL2P48qqir+GObKFovUiQ== From: Andrew Tropin To: Liliana Marie Prikler , 53387@debbugs.gnu.org Subject: Re: [PATCH 0/4] Update tdlib and telega packages In-Reply-To: <79a67632531acfefcf781bdc942b2f60c3f3619e.camel@gmail.com> References: <87tudyipzg.fsf@trop.in> <87ee4tsjfd.fsf@trop.in> <79a67632531acfefcf781bdc942b2f60c3f3619e.camel@gmail.com> Date: Mon, 28 Nov 2022 09:43:09 +0400 Message-ID: <87pmd7d47m.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53387 Cc: zevlg@yandex.ru, Nicolas Goaziou , avityazev@posteo.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-11-26 13:58, Liliana Marie Prikler wrote: > Hi Andrew, > > sorry for not reacting earlier. Is this patch still "fresh and > relevant"? Should we aim for newer versions? > > Am Donnerstag, dem 27.01.2022 um 10:54 +0300 schrieb Andrew Tropin: >> CCed: avityazev, zevlg >>=20 >> On 2022-01-22 16:14, Liliana Marie Prikler wrote: >>=20 >> > Hi Andrew,=20 >> >=20 >> > Am Donnerstag, dem 20.01.2022 um 14:45 +0300 schrieb Andrew Tropin: >> > > tdlib and telega are inteded to be used from specific commits not >> > > tags, I keep revision and commit parameters for those packages to >> > > make it easier to update them to untagged commits in the future. >> > >=20 >> > > https://github.com/tdlib/td/issues/1790 >> > >=20 >> > > Also, updated the style for arguments. >> > It appears Telega was already updated through a different patch.=C2=A0 >> > The style adjustments are still relevant, but fail to apply >> > currently. >> >=20 >>=20 >> Updated patches. >>=20 >> >=20 >> > As for commit vs. tag, I've CC'd Nicolas to make a more informed >> > decision.=C2=A0 I do understand your reasoning, but OTOH I disagree wi= th >> > Telegram's "every commit is as good as a release" stance, >> > particularly if there's a widely used client whose releases fail in >> > CI :) >>=20 >> I agree, tdlib rolling release seems a little strange to me and I >> personally not in a favor of it.=C2=A0 I still propose to keep commit and >> revision variables for both tdlib and telega to be able to update >> them from time to time to a fresh version, which surely won't have a >> release tag. >>=20 >>=20 > Hi Liliana, version update seems outdated, emacs-telega-server and tdlib styles updates outdated as well. But emacs-telega and emacs-telega-contrib style updates looks relevant and still applies. Slightly updated the patch, applied, pushed. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmOESm0ACgkQIgjSCVjB 3rCGxQ/9GNEDij8pZZebemSyZfSH8s4JAcxf+h31x8bfc0c1CQKcRM2uvMVJXgWU gx2vkfZfG7OgYqU8w8hJ637sa3rT61odQ6CyICGgSlccts0mju334WlSy7+/QaN+ nlwMpPJXc88AgSOnJKKqMpjDjQ4IPs/BjMYybmPwMg0O6js5Gc5YIb+/shswH60g Eg044eZV0veIWZJYGuubGDgfBFvHkM/Z1XEHk3rGn33xl8kDcfdr8tHr+ER9M/eI zNX43RcSezWxaPw5AvSgAaCQQd40iJYOysR/IwYpMwqQRHcEYJ9WxIu0hxCbX0Kf /Umlzp2EEa1ykgnjBL0O4XUxBtnJHQ3cFC/0+lgftVzDBs9B/qdrH0+rx1pEsnAv bxfzm3PHAxKRYv58TmpgPHT5AYJBmPeM81EArx72gYtBeCIkk9zGg26LyJFXIgeR FUD+TXT7o4lrSpie0RB+xjnhnQULgVSwoz2AhTxgV1VPL/aWRi83ohNn/olarFN1 dd8GiIhPDfa5RGcNLMJxxGCSMs2CeDthYpOGo0cflpS144j0QlDY65a6ytSbo4xM ePkSoTp2RDp4NqxGvOTU9sWFUYMl4/x8WGOvQNCT5VQj2ug0j9sGpmUjdPsLlNAU Xao25HnpThS1HWGloQHkcE3RSK1uDFs218/eDvP3lgMEjg9t3Uw= =PLl/ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 01:38:22 2022 Received: (at control) by debbugs.gnu.org; 28 Nov 2022 06:38:22 +0000 Received: from localhost ([127.0.0.1]:46630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozXmY-0008D6-BQ for submit@debbugs.gnu.org; Mon, 28 Nov 2022 01:38:22 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozXmW-0008D0-Ch for control@debbugs.gnu.org; Mon, 28 Nov 2022 01:38:21 -0500 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id C6F54FF808 for ; Mon, 28 Nov 2022 06:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1669617494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=8CmZQ7XkZViH9Fijzdt3HQ553nOR1v1Mlwk0XOSIOaI=; b=JSAHCldJwj2NOIZb9XBnzveveco1cinZLtwGKX/EkZICRJQM29kEgz05FcFHo8MXLUueTZ jF+/C+VfxjfIapjuZvv6lRAlrnmYH9Wy9hYdc15qpGg0QuhBqbRy1iiNJmEgyAS76mJ7q6 o6sXiK4xW8Vj6sxziDxF2DrjDsLVgMtNrawd8F+qXFz1fpICvflLIvosB5c/Ffu+1QiEwZ Mc4oJl9CTuxPP7E7he0tWJgiJg7bxTrTRzq7fhRabeoPyAi1UGedE33oOuffyS8PXhEqj/ j2f4kjC3Y3UTtcvSIBR3tH2PixVUF3KI3Wc6Xd4+/lwxbl3QncEt5Rc36S6fOg== From: Andrew Tropin To: control@debbugs.gnu.org Subject: Applied Date: Mon, 28 Nov 2022 10:38:08 +0400 Message-ID: <8735a3k2i7.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain close 53387 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmOEV1AACgkQIgjSCVjB 3rD64RAAirHmz6RUioOdyv7+D/0xWjQIxj4jJKFYQ5x9W49R+k0Ca7BfqmQXBmcB HnuK4lV0XOmilappIHixpw9gCPvNcMwAbFFeK+c0icoli2vM55yVYDkqLoyVJI8P ck+4i9z/qkdPmqbi9p7ic3vvZ5G1KCqkzUOgql6E2zj3g7mWoRccP8i9zqR2c8kg OwbMpGMGqYgnl9Dp86metLfvsA3WsZ93Q/JOjgPXZ7JWz0X084y/qCWsfP/R3kZC jLIY/hlNsildTD0bg8Rb6N82LTk2f9NSpXyC0aL9ATnX+RdvUNeqtX+0saac6YV8 +6lwmUBjbspVdMUDlS727jLKf4OGecNC3VCECwvIvEY9W2JNjUbSUfG6tbAqoU9B Ui775f/qYf6uXvab/0YeZZ2vCzAvaC04pz1wUb4vkPEDDe1A0zv3bKWZtbSZHvUC hGVTRNz3KNjroVHGaKZ5hpRtYH14Nfb+a5dtQez2p3Mgf4yfV4EYfmcRuxkEL8T+ 4js6MptUNrkOwVsM1UA8AiDY7cOOkYI/c98vyP41t/GLK8TghF+z7BCb/olQ93p3 o8Vty/kVsX2XZcCAtFMC1HnX1JvDzjl3EOhbil7rmstp1j3koFpQUOZv+gRO8kOh 01sQwVHemtx2qC90/wRpCGs6yraKKVEyn/Tp0EWzQNwwMDnm2Qo= =RnFf -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 17 22:27:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 26 Dec 2022 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator