GNU bug report logs - #53385
29.0.50; bug-fix for image-dired-delete-marked

Previous Next

Package: emacs;

Reported by: Peter Münster <pm <at> a16n.net>

Date: Thu, 20 Jan 2022 10:08:02 UTC

Severity: normal

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53385 in the body.
You can then email your comments to 53385 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#53385; Package emacs. (Thu, 20 Jan 2022 10:08:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Peter Münster <pm <at> a16n.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 20 Jan 2022 10:08:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Münster <pm <at> a16n.net>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; bug-fix for image-dired-delete-marked
Date: Thu, 20 Jan 2022 11:07:36 +0100

[Message part 1 (text/plain, inline)]
Hi,

Please avoid, that backward-char signals an error:

diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index b81df8567b..d5ed5d4ce8 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -2353,7 +2351,8 @@ image-dired-delete-marked
   (interactive)
   (image-dired--with-marked
    (image-dired-delete-char)
-   (backward-char))
+   (unless (bobp)
+     (backward-char)))
   (image-dired--line-up-with-method)
   (with-current-buffer (image-dired-associated-dired-buffer)
     (dired-do-delete)))

TIA,
-- 
           Peter

[signature.asc (application/pgp-signature, inline)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#53385; Package emacs. (Thu, 20 Jan 2022 14:18:02 GMT) Full text and rfc822 format available.

Message #8 received at 53385 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Peter Münster <pm <at> a16n.net>
Cc: 53385 <at> debbugs.gnu.org
Subject: Re: bug#53385: 29.0.50; bug-fix for image-dired-delete-marked
Date: Thu, 20 Jan 2022 15:16:57 +0100

Peter Münster <pm <at> a16n.net> writes:

> Please avoid, that backward-char signals an error:

Thanks; applied to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 29.1, send any further explanations to 53385 <at> debbugs.gnu.org and Peter Münster <pm <at> a16n.net> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 20 Jan 2022 14:18:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 18 Feb 2022 12:24:14 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 121 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.