From unknown Fri Jun 20 07:18:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53319 <53319@debbugs.gnu.org> To: bug#53319 <53319@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add n2n. Reply-To: bug#53319 <53319@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:28 +0000 retitle 53319 [PATCH] gnu: Add n2n. reassign 53319 guix-patches submitter 53319 =E8=B7=AF=E8=BE=89 severity 53319 normal tag 53319 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 17 09:47:58 2022 Received: (at submit) by debbugs.gnu.org; 17 Jan 2022 14:47:58 +0000 Received: from localhost ([127.0.0.1]:45612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9TIa-0007UV-EM for submit@debbugs.gnu.org; Mon, 17 Jan 2022 09:47:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:46024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9TIW-0007U9-HP for submit@debbugs.gnu.org; Mon, 17 Jan 2022 09:47:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9TIV-0004ya-QK for guix-patches@gnu.org; Mon, 17 Jan 2022 09:47:51 -0500 Received: from [2607:f8b0:4864:20::444] (port=33618 helo=mail-pf1-x444.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9TIT-0008Mv-HK for guix-patches@gnu.org; Mon, 17 Jan 2022 09:47:51 -0500 Received: by mail-pf1-x444.google.com with SMTP id x83so10383416pfc.0 for ; Mon, 17 Jan 2022 06:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=RsRS6+MNx3bSfB4OOU99pIRMENYZJxCVYv5WOqmkUTw=; b=b9ApvkcU+/5YY6qPAS8BaQr3joCCfxd/8xoge3QMfSNYyPjrRhp30jKvaL5fcI+hJR 6grAJpoFhxGH88xFTgr2VJNxJIdPZRtNc83tg4Ibo+gwlpO01eSYWbHcdANi+Arlt7hi bIno9kcF58n46IKeiO2CIcYlhhzn3YvlOVMi2tTs3Xh0W8Gj+vXJMvs95N8WfGd8H9Cp 3ac1xU9C4mYB4gaO5WYsHBTaTUWkoitPOLN5h7XJOKw6AOywDPnrTH7HmGgq4cCpZs1e IcpEB0i4d/8SjWT1fBRxmWj4mWWxuw/faXWwaGzcaFNRc8cvaQ30P+pP8VW5ZfkWnsHQ /qaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=RsRS6+MNx3bSfB4OOU99pIRMENYZJxCVYv5WOqmkUTw=; b=NLkknKaom1Mji9XfpyR8xfgSALpScq0IO7Is+r8Jqqc1lYiiNUvCcAF4JxV6mR/8+O JIlvKNqyPp6bi0/uYahxyJus4h6RVZ1NBKZVZGzNOo6agJvmhu8iH+TR6HrWv0tQJEij hjApBH0HnM08Zf4i6yXpknzk2p4lGf1lzhegByPR2VogQRhHj/YEK9qFJHV5Um1y4BZA pSNhp4Au/SCd9EcaZDgD++5Xmrc/885bndd8/ObtAXPVjxPUyyh1hYwUQTYMV8fUu4Bh 2p/3k3x1Mq2/kUae8ySPumcB8woFdKjV+44k3NPNlL2J6lkHDRB8LyPPH+TXeR9ZYIWZ JrVA== X-Gm-Message-State: AOAM531pnT739myfG2Z+Pu85ab9iWuPE3kY0rJ9kvNNWT4tHnC4iN0hM vm82cer+pJuiwYPoRUfhg/sOuX2A/Bm9USqstfB6R1i240CXjYT+tpY= X-Google-Smtp-Source: ABdhPJyEJAus3G7d54zfpxkImlMHUo+7asgRykJ8NhLfqvrROzjrC3NWbyJaFtI+TcFuy3N6DRnmI3lkqONTT+6GLz0= X-Received: by 2002:aa7:92c5:0:b0:4bd:9f44:9562 with SMTP id k5-20020aa792c5000000b004bd9f449562mr21199638pfa.80.1642430867935; Mon, 17 Jan 2022 06:47:47 -0800 (PST) MIME-Version: 1.0 From: =?UTF-8?B?6Lev6L6J?= Date: Mon, 17 Jan 2022 14:47:36 +0000 Message-ID: Subject: [PATCH] gnu: Add n2n. To: guix-patches@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::444 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=luhux76@gmail.com; helo=mail-pf1-x444.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) >From c9d69917251e377c3291443dda0090cfa5e46956 Mon Sep 17 00:00:00 2001 From: Lu Hui Date: Mon, 17 Jan 2022 10:48:44 +0800 Subject: [PATCH] gnu: Add n2n. * gnu/packages/vpn.scm (n2n-2): New variable --- gnu/packages/vpn.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 4ad555ef1b..542d6518fd 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -18,6 +18,7 @@ ;;; Copyright =C2=A9 2021 Domagoj Stolfa ;;; Copyright =C2=A9 2021 Raghav Gururajan ;;; Copyright =C2=A9 2021 jgart +;;; Copyright =C2=A9 2022 Lu hui ;;; ;;; This file is part of GNU Guix. ;;; @@ -1093,3 +1094,39 @@ (define-public xl2tpd "xl2tpd is an implementation of the Layer 2 Tunnelling Protocol (RFC 2661). L2TP allows you to tunnel PPP over UDP.") (license license:gpl2))) + +(define-public n2n-2 + (package + (name "n2n") + (version "2.8") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ntop/n2n") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1ph2npvnqh1xnmkp96pdzpxm033jkb8zznd3nc59l9arhn0pq4nv")))) + (build-system gnu-build-system) + (native-inputs (list autoconf automake)) + (arguments + `(#:make-flags (list (string-append "PREFIX=3D" %output) "CC=3Dgcc") + #:phases + (modify-phases %standard-phases + (add-before 'bootstrap 'move-configure + ;; don't execute configure script in bootstrap + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "autogen.sh" + (("./configure") "")))) + (add-before 'configure 'fix-configure + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configure" + (("/bin/sh") (which "sh")))))) + #:tests? #f)) ;there is no check target + (home-page "https://github.com/ntop/n2n") + (synopsis "Peer-to-peer VPN client and server") + (description + "A light VPN software which makes it +easy to create virtual networks bypassing intermediate firewalls.") + (license license:gpl3+))) --=20 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 28 05:10:25 2022 Received: (at 53319) by debbugs.gnu.org; 28 Jan 2022 10:10:25 +0000 Received: from localhost ([127.0.0.1]:57491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDOD3-00036g-1C for submit@debbugs.gnu.org; Fri, 28 Jan 2022 05:10:25 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDOD0-00036O-SI for 53319@debbugs.gnu.org; Fri, 28 Jan 2022 05:10:23 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id F12FBC0002; Fri, 28 Jan 2022 10:10:15 +0000 (UTC) From: Nicolas Goaziou To: =?utf-8?B?6Lev6L6J?= Subject: Re: [bug#53319] [PATCH] gnu: Add n2n. References: Date: Fri, 28 Jan 2022 11:10:14 +0100 In-Reply-To: (=?utf-8?B?Iui3r+i+iSIncw==?= message of "Mon, 17 Jan 2022 14:47:36 +0000") Message-ID: <87r18stbll.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53319 Cc: 53319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, =E8=B7=AF=E8=BE=89 writes: > Subject: [PATCH] gnu: Add n2n. Thank you. Some comments follow. > +(define-public n2n-2 I think the variable should be "n2n" only. > + (native-inputs (list autoconf automake)) > + (arguments > + `(#:make-flags (list (string-append "PREFIX=3D" %output) "CC=3Dgcc") CC=3Dgcc is not cross-compilation friendly. Also, %output is being phased out. I suggest using G-expressions: (arguments (list #:make-flags #~(list (string-append "PREFIX=3D" #$output) #$(string-append "CC=3D" (cc-for-target))) ...)) > + #:phases > + (modify-phases %standard-phases If you use G-expressions, you'll need to start with: #~(modify-phases %standard-phases ...) > + (add-before 'configure 'fix-configure > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "configure" > + (("/bin/sh") (which "sh")))))) Instead of using `which', you can use `search-input-file': (("/bin/sh") (search-input-file inputs "/bin/sh"))=20=20 > + #:tests? #f)) ;there is no check target > + (home-page "https://github.com/ntop/n2n") > + (synopsis "Peer-to-peer VPN client and server") > + (description > + "A light VPN software which makes it > +easy to create virtual networks bypassing intermediate firewalls.") Description should consist of full sentences. I suggest: n2n is a light VPN software which makes it easy to create virtual networks bypassing intermediate firewalls. Also, the package brings third-party software: libnatpmp and libupnp. Would it be possible to unbundle them, since Guix already ships both? Could you send an updated patch? Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 06:20:29 2022 Received: (at 53319-done) by debbugs.gnu.org; 22 Feb 2022 11:20:29 +0000 Received: from localhost ([127.0.0.1]:40165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMTDY-0005UC-U0 for submit@debbugs.gnu.org; Tue, 22 Feb 2022 06:20:29 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMTDX-0005Tx-1W for 53319-done@debbugs.gnu.org; Tue, 22 Feb 2022 06:20:27 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 40075FF806; Tue, 22 Feb 2022 11:20:20 +0000 (UTC) From: Nicolas Goaziou To: =?utf-8?B?6Lev6L6J?= Subject: Re: [bug#53319] [PATCH] gnu: Add n2n. References: Date: Tue, 22 Feb 2022 12:20:19 +0100 In-Reply-To: (=?utf-8?B?Iui3r+i+iSIncw==?= message of "Mon, 17 Jan 2022 14:47:36 +0000") Message-ID: <87sfsb2ln0.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53319-done Cc: 53319-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, =E8=B7=AF=E8=BE=89 writes: > Subject: [PATCH] gnu: Add n2n. Thank you. I applied your patch with the changes below. > > +(define-public n2n-2 I renamed it to n2n. > + (native-inputs (list autoconf automake)) I added pkg-config and bash-minimal. > + (arguments > + `(#:make-flags (list (string-append "PREFIX=3D" %output) "CC=3Dgcc") Using G-expressions I wrote #:make-flags #~(list (string-append "PREFIX=3D" #$output) (string-append "CC=3D" #$(cc-for-target))) ... > + (substitute* "configure" > + (("/bin/sh") (which "sh")))))) Here I wrote (("/bin/sh") (search-inputs-file input "/bin/sh")) > + #:tests? #f)) ;there is no check target > + (home-page "https://github.com/ntop/n2n") > + (synopsis "Peer-to-peer VPN client and server") > + (description > + "A light VPN software which makes it I turned the description into complete sentences. Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 06:36:32 2022 Received: (at 53319) by debbugs.gnu.org; 22 Feb 2022 11:36:32 +0000 Received: from localhost ([127.0.0.1]:40196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMTT6-00062v-IG for submit@debbugs.gnu.org; Tue, 22 Feb 2022 06:36:32 -0500 Received: from albert.telenet-ops.be ([195.130.137.90]:34814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMTT4-00062m-Jp for 53319@debbugs.gnu.org; Tue, 22 Feb 2022 06:36:31 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id yBcU2600Q4UW6Th06BcUME; Tue, 22 Feb 2022 12:36:28 +0100 Message-ID: Subject: Re: [bug#53319] [PATCH] gnu: Add n2n. From: Maxime Devos To: Nicolas Goaziou , =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= Date: Tue, 22 Feb 2022 12:36:24 +0100 In-Reply-To: <87r18stbll.fsf@nicolasgoaziou.fr> References: <87r18stbll.fsf@nicolasgoaziou.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wrcp7TDMnqBcFygVmig1" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1645529789; bh=zdIGDwl6CdXTTPge4XMBXHZLilo47DfBBFpDv7kdD5Q=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=hfnEy0rzGoCgmZKETpT7BKd6j1IIimMt8BsNN+Y0Ch36GaLwF6MJ6iCIUUMHfBGbV mfXastsb0qsHz+lN8ITcoeSDQ9PrD1LpqH9PBPqbMl59V2LHzVk61KgxRu6vW9LwRN M8Jez+Dux7BI7S2czWBxFSlnig15bRzHtaXAnuTlIOeVC+5usBdSB6XstArCtpIlMp HUMs+DkhZNt4y7zHrOI6lYEB5UENxQ1hSB/f+5R4PrlG9m+Pkz3gT3R2R0iYJXsdzT SfEb7fB1bA+rRy4yThzVAQvhQQYe/H66ubmKTUog7FRREe7h1KT4jsJLOtQ6yunhXH CPdeYfvG2ZkXA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53319 Cc: 53319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-wrcp7TDMnqBcFygVmig1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicolas Goaziou schreef op vr 28-01-2022 om 11:10 [+0100]: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-before 'configur= e 'fix-configure > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda* = (#:key inputs #:allow-other-keys) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (substitute* "configure" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 (("/bin/sh") (which "sh")))))) >=20 > Instead of using `which', you can use `search-input-file': >=20 > =C2=A0 (("/bin/sh") (search-input-file inputs "/bin/sh"))=C2=A0=20 'configure' is run during build, so for cross-compilation, a sh from 'native-inputs' shoud be used instead of 'inputs': (("/bin/sh") (search-input-file (or native-inputs inputs) "/bin/sh")) or simpler: (("/bin/sh") (which "sh"))=20 Also, this package definition packages version 2.8. Why not package the latest version instead? In the latest version, 'autogen.sh' does not run "./configure" and hence 'move-configure' and 'fix-configure' should not be necessary. Also, looking at , it seems that n2n might not be bit-for-bit reproducible. Greetings, Maxime --=-wrcp7TDMnqBcFygVmig1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYhTKuBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gDaAPwLFUpDQgDwi0vnvd/jebJC9xZk jKNygGJJe7tRhRXTfAEAuRPfq1qjnghlX9bvGcex/B8YvkhVeNRWpIpmsb/Gngg= =UGQC -----END PGP SIGNATURE----- --=-wrcp7TDMnqBcFygVmig1-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 22 13:49:48 2022 Received: (at 53319) by debbugs.gnu.org; 22 Feb 2022 18:49:48 +0000 Received: from localhost ([127.0.0.1]:42665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMaEO-0002Ay-34 for submit@debbugs.gnu.org; Tue, 22 Feb 2022 13:49:48 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:62991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMaEL-0002Ag-Aj for 53319@debbugs.gnu.org; Tue, 22 Feb 2022 13:49:46 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id EAC804000D; Tue, 22 Feb 2022 18:49:37 +0000 (UTC) From: Nicolas Goaziou To: Maxime Devos Subject: Re: [bug#53319] [PATCH] gnu: Add n2n. References: <87r18stbll.fsf@nicolasgoaziou.fr> Date: Tue, 22 Feb 2022 19:49:34 +0100 In-Reply-To: (Maxime Devos's message of "Tue, 22 Feb 2022 12:36:24 +0100") Message-ID: <87ilt63fep.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53319 Cc: =?utf-8?B?6Lev6L6J?= , 53319@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Maxime Devos writes: > 'configure' is run during build, so for cross-compilation, a sh from > 'native-inputs' shoud be used instead of 'inputs': > > (("/bin/sh") (search-input-file (or native-inputs inputs) "/bin/sh")) True, I keep forgetting about this. It would be more natural to use (search-input-file native-inputs "/bin/sh"), but, IIRC, native-inputs may be empty if we are not cross-compiling. I will fix it. > or simpler: > > (("/bin/sh") (which "sh")) IIUC, search-input-file is a replacement for `which', so that seems to be going backwards. Of course, if `which' is the preferred solution for package style, I'd love to hear a confirmation about it. > Also, this package definition packages version 2.8. Why not package > the latest version instead? The OP waited one month without any feedback. I consider this is more respectful to apply the patch in its current version rather than requesting more changes now. YMMV. Of course, the update can happen in a later, very welcome, patch. > Also, looking at > , > it seems that n2n might not be bit-for-bit reproducible. I agree this package has room for improvement. Hopefully, =E8=B7=AF=E8=BE= =89 can have a look at it. Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 08:21:21 2022 Received: (at 53319) by debbugs.gnu.org; 20 Mar 2022 12:21:21 +0000 Received: from localhost ([127.0.0.1]:33054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuYi-0005zR-3Q for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:21:21 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:53244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuYe-0005zE-P8 for 53319@debbugs.gnu.org; Sun, 20 Mar 2022 08:21:18 -0400 Received: by mail-pj1-f68.google.com with SMTP id v4so10953344pjh.2 for <53319@debbugs.gnu.org>; Sun, 20 Mar 2022 05:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QSKlkHmf2OMuRascxsoc3qR9DZvP2UsYH4fgCL+vrKU=; b=hcpVWMQHDYtT9ZbJ5mnoZD8BeV/CIpkl3a7cDaZfnWeLy/WHtSBLVfAc7Jw8NTiML6 XjKP0zWi+9xDLnAYIOqc89XqWb5iv9v9x+Hl3okAg9pgz5sRn8d4WaB+0Sg7fD4wgn/k Hh0o4GeWTW/FjbsHzYdaPUTi/ZpqzCOBruCn8nX8HJdATgwc3kdunEltz1rHKSv/HS7y 2vOSaJ3SE1AuehO3m8jlejcVCa5Fn8/GdBjFjFZ9Upg03m/QTuxujsN9nJG61PD2ps05 PV4rEBuSP7nrpTfIOuAPDxmo0rhoqen5US2O2wIo6C4TxPCxkyYmJuF+mFqwj0WfqWyS BzMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QSKlkHmf2OMuRascxsoc3qR9DZvP2UsYH4fgCL+vrKU=; b=ikfQVSMVHF3XIsFQHLWS3W2j9rF4oBb+DxkvhX5SnqFnCIDVeOmoWEYpHxz2i8rZ65 0ZAnvOQwK4z+dcJKdHu3WlWEEziFcqQ7kt8WIE/sVbIDhMcx/CcvMt7cBFRu9pg6YpSy IEWRa8+BVN5MO2iWpbbTnERvlm2iKGC0/hCauY0QHwD4NOL4v8BS1J1qiYH/hqI6pXb3 oWkJYCYhy7xTnOKAu3K6NZjAd2UVSwFfBqQdcZSV2SpOfC2pgEScoHA9zrukoVakkDc3 qHQQnNNcBVqYcvRg0Iqk5fUiNYOmXwOHpSacJr6dJLNLSDIDcaNFrXBiHgbJhK9auRrJ cFvg== X-Gm-Message-State: AOAM530eGg1U4orvtwH/YI9k6yL0Gu8hHQ3kXjYkWx7+gJX2Aqfu4yiM vZUFYLozPjcad0VaT8AruFU60ha+0Cc4EkhYSF8= X-Google-Smtp-Source: ABdhPJzriVgLsF3uj50zyJdrIVBkugVA7wJAxApV3Jtxr/DwEBci6rmUb062bX3R3sNXfrx5K5I2mkMyYE4KKiauBE8= X-Received: by 2002:a17:90b:4ac7:b0:1bf:2ef7:334a with SMTP id mh7-20020a17090b4ac700b001bf2ef7334amr31422579pjb.239.1647778870860; Sun, 20 Mar 2022 05:21:10 -0700 (PDT) MIME-Version: 1.0 References: <87r18stbll.fsf@nicolasgoaziou.fr> <87ilt63fep.fsf@nicolasgoaziou.fr> In-Reply-To: <87ilt63fep.fsf@nicolasgoaziou.fr> From: =?UTF-8?B?6Lev6L6J?= Date: Sun, 20 Mar 2022 12:20:58 +0000 Message-ID: Subject: Re: [bug#53319] [PATCH] gnu: Add n2n. To: Nicolas Goaziou Content-Type: multipart/mixed; boundary="000000000000448c6905daa56af9" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 53319 Cc: 53319@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000448c6905daa56af9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicolas Goaziou =E4=BA=8E2022=E5=B9=B42=E6=9C=8822= =E6=97=A5=E5=91=A8=E4=BA=8C 18:49=E5=86=99=E9=81=93=EF=BC=9A > > Hello, > > Maxime Devos writes: > > > 'configure' is run during build, so for cross-compilation, a sh from > > 'native-inputs' shoud be used instead of 'inputs': > > > > (("/bin/sh") (search-input-file (or native-inputs inputs) "/bin/sh")) > > True, I keep forgetting about this. It would be more natural to use > (search-input-file native-inputs "/bin/sh"), but, IIRC, native-inputs > may be empty if we are not cross-compiling. > > I will fix it. > > > or simpler: > > > > (("/bin/sh") (which "sh")) > > IIUC, search-input-file is a replacement for `which', so that seems to > be going backwards. > > Of course, if `which' is the preferred solution for package style, I'd > love to hear a confirmation about it. > > > Also, this package definition packages version 2.8. Why not package > > the latest version instead? > > The OP waited one month without any feedback. I consider this is more > respectful to apply the patch in its current version rather than > requesting more changes now. YMMV. > > Of course, the update can happen in a later, very welcome, patch. > > > Also, looking at > > , > > it seems that n2n might not be bit-for-bit reproducible. > > I agree this package has room for improvement. Hopefully, =E8=B7=AF=E8=BE= =89 can have > a look at it. > > Regards, > -- > Nicolas Goaziou --000000000000448c6905daa56af9 Content-Type: text/x-patch; charset="US-ASCII"; name="0004-gnu-n2n-Update-to-3.0.patch" Content-Disposition: attachment; filename="0004-gnu-n2n-Update-to-3.0.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0z8yaes3 RnJvbSBkZTZiZDhkOGRkM2Q0YjE0OTk5MzYxZjY2ZDE1ZjA4MjdhZGEwYjFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdSBIdWkgPGx1aHV4NzZAZ21haWwuY29tPgpEYXRlOiBTdW4s IDIwIE1hciAyMDIyIDIwOjEzOjEzICswODAwClN1YmplY3Q6IFtQQVRDSCA0LzRdIGdudTogbjJu OiBVcGRhdGUgdG8gMy4wCgoqIGdudS9wYWNrYWdlcy92cG4uc2NtIChuMm4pOiBbdmVyc2lvbl06 IFVwZGF0ZSB0byAzLjAuCi0tLQogZ251L3BhY2thZ2VzL3Zwbi5zY20gfCA0ICsrLS0KIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv Z251L3BhY2thZ2VzL3Zwbi5zY20gYi9nbnUvcGFja2FnZXMvdnBuLnNjbQppbmRleCBmMDY2YmZh Njg5Li42YzYzYzNkNjcxIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvdnBuLnNjbQorKysgYi9n bnUvcGFja2FnZXMvdnBuLnNjbQpAQCAtMjk5LDcgKzI5OSw3IEBAIChkZWZpbmUtcHVibGljIGd2 cGUKIChkZWZpbmUtcHVibGljIG4ybgogICAocGFja2FnZQogICAgIChuYW1lICJuMm4iKQotICAg ICh2ZXJzaW9uICIyLjgiKQorICAgICh2ZXJzaW9uICIzLjAiKQogICAgIChzb3VyY2UgKG9yaWdp bgogICAgICAgICAgICAgICAobWV0aG9kIGdpdC1mZXRjaCkKICAgICAgICAgICAgICAgKHVyaSAo Z2l0LXJlZmVyZW5jZQpAQCAtMzA4LDcgKzMwOCw3IEBAIChkZWZpbmUtcHVibGljIG4ybgogICAg ICAgICAgICAgICAoZmlsZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCiAgICAg ICAgICAgICAgIChzaGEyNTYKICAgICAgICAgICAgICAgIChiYXNlMzIKLSAgICAgICAgICAgICAg ICAiMXBoMm5wdm5xaDF4bm1rcDk2cGR6cHhtMDMzamtiOHp6bmQzbmM1OWw5YXJobjBwcTRudiIp KSkpCisgICAgICAgICAgICAgICAgIjBrZ3FtcWNuNnMyeTJyeGEwaTZteXEzc2drMmFsaXYxZ2tm aHp2bjMyemd5bTlycnF5OXIiKSkpKQogICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3Rl bSkKICAgICAoYXJndW1lbnRzCiAgICAgIChsaXN0Ci0tIAoyLjM0LjAKCg== --000000000000448c6905daa56af9 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-gnu-n2n-remove-hardcodepath.patch" Content-Disposition: attachment; filename="0002-gnu-n2n-remove-hardcodepath.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0z8yaes1 RnJvbSBmOWYxMmNhOWM4YTg5MDMyMjM4NWQwYWQ2OTVmMzcwZTIxZjQ0NjViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdSBIdWkgPGx1aHV4NzZAZ21haWwuY29tPgpEYXRlOiBTdW4s IDIwIE1hciAyMDIyIDE5OjQ1OjMzICswODAwClN1YmplY3Q6IFtQQVRDSCAyLzRdIGdudTogbjJu OiByZW1vdmUgaGFyZGNvZGVwYXRoCgoqIGdudS9wYWNrYWdlcy92cG4uc2NtIChuMm4pOiBbcGhh c2VzXTogTmV3IHBoYXNlCi0tLQogZ251L3BhY2thZ2VzL3Zwbi5zY20gfCA3ICsrKysrKysKIDEg ZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMv dnBuLnNjbSBiL2dudS9wYWNrYWdlcy92cG4uc2NtCmluZGV4IDRiMGU3ZDc1MWEuLmRiOWU4Y2Iw NTkgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy92cG4uc2NtCisrKyBiL2dudS9wYWNrYWdlcy92 cG4uc2NtCkBAIC0zMjcsNiArMzI3LDEzIEBAIChkZWZpbmUtcHVibGljIG4ybgogICAgICAgICAg ICAgICAoc3Vic3RpdHV0ZSogImNvbmZpZ3VyZS5zZWVkIgogICAgICAgICAgICAgICAgICgoIkRB VEU9YGRhdGUgK1wiJVktJW0tJWRcImAiKQogICAgICAgICAgICAgICAgICAiREFURT1gVFo9dXRj IGRhdGUgLWQgQDAgK1wiJVktJW0tJWRcImAiKSkpKQorICAgICAgICAgIChhZGQtYmVmb3JlICdi b290c3RyYXAgJ3JlbW92ZS1oYXJkY29kZXBhdGgKKyAgICAgICAgICAgIChsYW1iZGEgXworICAg ICAgICAgICAgICAoc3Vic3RpdHV0ZSogImNvbmZpZ3VyZS5zZWVkIgorICAgICAgICAgICAgICAg ICgoIi1JL3Vzci9sb2NhbC9vcHQvb3BlbnNzbEAxLjEvaW5jbHVkZSIpCisgICAgICAgICAgICAg ICAgICIiKQorICAgICAgICAgICAgICAgICgoIi1JL3Vzci9sb2NhbC9vcHQvb3BlbnNzbEAxLjEv bGliIikKKyAgICAgICAgICAgICAgICAgIiIpKSkpCiAgICAgICAgICAgKGFkZC1iZWZvcmUgJ2Nv bmZpZ3VyZSAnZml4LWNvbmZpZ3VyZQogICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IGlucHV0 cyBuYXRpdmUtaW5wdXRzICM6YWxsb3ctb3RoZXIta2V5cykKICAgICAgICAgICAgICAgKHN1YnN0 aXR1dGUqICJjb25maWd1cmUiCi0tIAoyLjM0LjAKCg== --000000000000448c6905daa56af9 Content-Type: text/x-patch; charset="US-ASCII"; name="0003-gnu-n2n-add-compression-AES-crypto-method-support.patch" Content-Disposition: attachment; filename="0003-gnu-n2n-add-compression-AES-crypto-method-support.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0z8yaes2 RnJvbSA4NWM0MGE4OWVhMTQ1OGY1YWJjOWFjOGMyMmY0YTY5NjhiNDhkZWNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdSBIdWkgPGx1aHV4NzZAZ21haWwuY29tPgpEYXRlOiBTdW4s IDIwIE1hciAyMDIyIDIwOjA3OjIzICswODAwClN1YmplY3Q6IFtQQVRDSCAzLzRdIGdudTogbjJu OiBhZGQgY29tcHJlc3Npb24sQUVTIGNyeXB0byBtZXRob2Qgc3VwcG9ydC4KCiogZ251L3BhY2th Z2VzL3Zwbi5zY20gKG4ybik6IFtpbnB1dHNdOiBBZGQgenN0ZC1saWIgbGlicGNhcCBvcGVuc3Ns IGxpYmNhcC4KLS0tCiBnbnUvcGFja2FnZXMvdnBuLnNjbSB8IDIgKysKIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvdnBuLnNjbSBiL2du dS9wYWNrYWdlcy92cG4uc2NtCmluZGV4IGRiOWU4Y2IwNTkuLmYwNjZiZmE2ODkgMTAwNjQ0Ci0t LSBhL2dudS9wYWNrYWdlcy92cG4uc2NtCisrKyBiL2dudS9wYWNrYWdlcy92cG4uc2NtCkBAIC0z NDAsNiArMzQwLDggQEAgKGRlZmluZS1wdWJsaWMgbjJuCiAgICAgICAgICAgICAgICAgKCgiL2Jp bi9zaCIpCiAgICAgICAgICAgICAgICAgIChzZWFyY2gtaW5wdXQtZmlsZSAob3IgbmF0aXZlLWlu cHV0cyBpbnB1dHMpICIvYmluL3NoIikpKSkpKQogICAgICAgIzp0ZXN0cz8gI2YpKSAgICAgICAg ICAgICAgICAgICAgIDt0aGVyZSBpcyBubyBjaGVjayB0YXJnZXQKKyAgICAoaW5wdXRzCisgICAg IChsaXN0IGAoLHpzdGQgImxpYiIpIGxpYnBjYXAgb3BlbnNzbCBsaWJjYXApKQogICAgIChuYXRp dmUtaW5wdXRzCiAgICAgIChsaXN0IGF1dG9jb25mIGF1dG9tYWtlIGJhc2gtbWluaW1hbCBwa2ct Y29uZmlnKSkKICAgICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1Yi5jb20vbnRvcC9uMm4iKQot LSAKMi4zNC4wCgo= --000000000000448c6905daa56af9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-n2n-more-reproducible.patch" Content-Disposition: attachment; filename="0001-gnu-n2n-more-reproducible.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0z8yac00 RnJvbSBhNmM5OGRmYWVkZWJiYTE3MmQ0NTFkNjJiYTJkNGM5YjE4YWVhM2I4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdSBIdWkgPGx1aHV4NzZAZ21haWwuY29tPgpEYXRlOiBTdW4s IDIwIE1hciAyMDIyIDE5OjE2OjUyICswODAwClN1YmplY3Q6IFtQQVRDSCAxLzRdIGdudTogbjJu OiBtb3JlIHJlcHJvZHVjaWJsZS4KCiogZ251L3BhY2thZ2VzL3Zwbi5zY20gKG4ybik6IFtwaGFz ZXNdOiBOZXcgVmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL3Zwbi5zY20gfCA1ICsrKysrCiAx IGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2Vz L3Zwbi5zY20gYi9nbnUvcGFja2FnZXMvdnBuLnNjbQppbmRleCA1YmY1YTYyNDgxLi40YjBlN2Q3 NTFhIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvdnBuLnNjbQorKysgYi9nbnUvcGFja2FnZXMv dnBuLnNjbQpAQCAtMzIyLDYgKzMyMiwxMSBAQCAoZGVmaW5lLXB1YmxpYyBuMm4KICAgICAgICAg ICAgIChsYW1iZGEgXwogICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSogImF1dG9nZW4uc2giCiAg ICAgICAgICAgICAgICAgKCgiLi9jb25maWd1cmUiKSAiIikpKSkKKyAgICAgICAgICAoYWRkLWJl Zm9yZSAnYm9vdHN0cmFwICdtb3JlLXJlcHJvZHVjaWJsZQorICAgICAgICAgICAgKGxhbWJkYSBf CisgICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAiY29uZmlndXJlLnNlZWQiCisgICAgICAgICAg ICAgICAgKCgiREFURT1gZGF0ZSArXCIlWS0lbS0lZFwiYCIpCisgICAgICAgICAgICAgICAgICJE QVRFPWBUWj11dGMgZGF0ZSAtZCBAMCArXCIlWS0lbS0lZFwiYCIpKSkpCiAgICAgICAgICAgKGFk ZC1iZWZvcmUgJ2NvbmZpZ3VyZSAnZml4LWNvbmZpZ3VyZQogICAgICAgICAgICAgKGxhbWJkYSog KCM6a2V5IGlucHV0cyBuYXRpdmUtaW5wdXRzICM6YWxsb3ctb3RoZXIta2V5cykKICAgICAgICAg ICAgICAgKHN1YnN0aXR1dGUqICJjb25maWd1cmUiCi0tIAoyLjM0LjAKCg== --000000000000448c6905daa56af9-- From unknown Fri Jun 20 07:18:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 18 Apr 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator