GNU bug report logs - #53318
[PATCH] gnu: Add go-github-com-go-chi-chi-v5.

Previous Next

Full log

Message #14 received at 53318 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 路辉 <luhux76 <at> gmail.com>
Cc: 53318 <at> debbugs.gnu.org
Subject: Re: [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
Date: Tue, 18 Jan 2022 18:51:29 +0100

[Message part 1 (text/plain, inline)]

Hi,

Please keep debbugs in CC: or To: so other people know how the patch is
progressing.

路辉 schreef op di 18-01-2022 om 15:26 [+0000]:
> OK, new patch: [...]

I did the following checks:

  1. [x] it builds
  2. [x] "guix lint" shows no problems
  3. [x] there doesn't appear to be any malware in the source code

While doing (3), I noticed that the test code has a certificate
‘certs.pem’ and ‘key.pem’, which will expire eventually, which isn't
good for long-term reproducibility
(cf. https://issues.guix.gnu.org/44559).

So in the adjusted package definition, I deleted the affected test
‘middleware/middleware_test.go’, 'testdata/cert.pem' and
'testdata/key.pem', see attachement.

I also capitalised 'http' to 'HTTP' in the description.
The description is a bit short but I don't have much of an idea
how to improve it.

Aside from that, it LGTM.

Greetings,
Maxime.

[chi.scm (text/x-scheme, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.