From unknown Fri Aug 15 21:22:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53313 <53313@debbugs.gnu.org> To: bug#53313 <53313@debbugs.gnu.org> Subject: Status: [ERT] EMACS_TEST_VERBOSE can not be explicitly disabled Reply-To: bug#53313 <53313@debbugs.gnu.org> Date: Sat, 16 Aug 2025 04:22:42 +0000 retitle 53313 [ERT] EMACS_TEST_VERBOSE can not be explicitly disabled reassign 53313 emacs submitter 53313 Max Nikulin severity 53313 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 17 05:59:53 2022 Received: (at submit) by debbugs.gnu.org; 17 Jan 2022 10:59:53 +0000 Received: from localhost ([127.0.0.1]:44866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Pjr-0006zz-Vg for submit@debbugs.gnu.org; Mon, 17 Jan 2022 05:59:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:52766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Pjh-0006zW-4Y for submit@debbugs.gnu.org; Mon, 17 Jan 2022 05:59:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9Pjg-0000hB-Qf for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 05:59:40 -0500 Received: from [2a00:1450:4864:20::132] (port=40651 helo=mail-lf1-x132.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9Pjf-00020V-3n for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 05:59:40 -0500 Received: by mail-lf1-x132.google.com with SMTP id s30so56097166lfo.7 for ; Mon, 17 Jan 2022 02:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=diGPAjoAR9nNkjLmlF7ZIXBDtjcQkoEqmOmbryfKyaw=; b=PvCmYobXxsjTM5jV1/pSfFEl6CciBUKW8mR225Rjd9njNQLoOQkK88L4z/hIY3IW4E TdELMu/R/6iogZbXLr1/5zSZybHq25avyceM90mpMdh1mcPzrSM7CDu9/Uovq9nUXFd5 KAjDlYcITHf2naJ9hhshRW0OvGBHCDoN0pn6Nfikax/ctzKfd2M1a1LigPMhQlnQOrTn l4YtaO0/XxMqJ3PeDs+2azYvQ+y+3g9ln5xzMwe1/HdLRB5cqijZf2Nl89otes3CXr3z lg3tkYdl3wI+RZKOYV3HCo7Bgxcs55DJtrvkwCbVZp5w46SFw1f0Ynhe9hwBBNPd3yHd gKaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=diGPAjoAR9nNkjLmlF7ZIXBDtjcQkoEqmOmbryfKyaw=; b=kHM68GLwqOreyHoG+h9po+g95EVYnk0R+ZMFsI8EpcFpVWopD+dSCbEEWzmQqcQivd +WR4+rG0r8Mw5HkX5maSf1VzTVgf7/M2pRwXRbvfa2aiCRO5ZN/JcybIqI+1ncQrywgX pEHevhp1jlsUq6SUxRKty3Y8TP/rgIf90nsWXZbvD+jOWJSl64w69pRpWVa5D+2BsUHa QcbH4hFkwTzHpvwEBfW2ITLhE61ceeJ/nFRd2YReQfD40eJn2Gu3Rdo0uoEdKZYIpL9V PaiSIpUWCKt9nvNdFFpqoUjKrWoLEixC1cLZ+/0+GhNwFwZpYup3kwx16aupIOeAQWvI Oxlg== X-Gm-Message-State: AOAM530LCaiIu7H6lsAPv7BIGmLXiPwHBnuw/T7rYdsExuATZiDxTywD jA5pfPKAGm+fx42rPC7GNBKTNh4B8TU= X-Google-Smtp-Source: ABdhPJxzq14Yjg51+yEOI0hLfmUbubMVMU/jgGORYpc/7hVrVjtegvn6jPq1j+wb1+zvS2rlu4Kuew== X-Received: by 2002:a05:651c:1a29:: with SMTP id by41mr1671780ljb.18.1642417175695; Mon, 17 Jan 2022 02:59:35 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id n6sm467213ljj.58.2022.01.17.02.59.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 02:59:35 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.io:119 To: bug-gnu-emacs@gnu.org From: Max Nikulin Subject: [ERT] EMACS_TEST_VERBOSE can not be explicitly disabled Message-ID: <7b4db8e7-2457-c291-7c38-2844bc921858@gmail.com> Date: Mon, 17 Jan 2022 17:59:33 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::132 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::132; envelope-from=manikulin@gmail.com; helo=mail-lf1-x132.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) At least empty value of EMACS_TEST_VERBOSE environment variable should be considered as false value that disables verbose ERT summary. Currently ERT implementation does not distinguish non-empty and empty values of the variable and generates verbose summary when such variable is just present in the process environment. To improve user experience some strings widely used in configuration files as false values should be recognized by ERT as well. Examples (case insensitive): "0", "false", "N", "no", "off", "none", "nil". Recently Ihor Radchenko proposed to enable verbose summary mode by default for Org Mode tests when it is built as a standalone project outside of Emacs source tree: https://lists.gnu.org/archive/html/emacs-orgmode/2022-01/msg00022.html I like the idea, but I can not say the same concerning implementation. Ihor introduced new make variable while I believe that it is not necessary and Org makefiles should be transparent in relation to EMACS_TEST_VERBOSE. I expect that it should be enough to add EMACS_TEST_VERBOSE ?= yes export EMACS_TEST_VERBOSE to the default.mk file https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/mk/default.mk Actually with current implementation developer has no chance to disable verbose summary mode from command line since empty string is considered as true value by ERT implementation. The following does not work: EMACS_TEST_VERBOSE= make test make test EMACS_TEST_VERBOSE= A workaround is "unexport EMACS_TEST_VERBOSE" either in the local.mk file or wrapped with ifeq-else-endif in default.mk. Another case is that a developer may have "export EMACS_TEST_VERBOSE=yes" in their shell init file but sometimes wants to disable verbose summary for a couple of commands without changing of environment by "unset EMACS_TEST_VERBOSE" that will affect following commands. The following commands should cause different states of verbose summary setting independently of current environment: make test EMACS_TEST_VERBOSE= make test EMACS_TEST_VERBOSE=yes Standalone example: ert-sample.el ---- >8 ---- (require 'ert) (ert-deftest ert-sample () (should (equal 5 (* 2 2)))) (ert-run-tests-batch-and-exit) ---- 8< ---- export EMACS_TEST_VERBOSE=yes # in ~/.profile, ~/.bashrc, etc. EMACS_TEST_VERBOSE= emacs --batch -Q ert-sample.el I have not found any discussion of design choices related to this variable. To wrap up, I suppose that at least empty value of EMACS_TEST_VERBOSE should be considered as a request to generate brief summary. It would be great to have opportunity to explicitly say "no": EMACS_TEST_VERBOSE=off (or "false", "0", etc.). It will make it easier for various build tools to respect developer's choice. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 06:32:30 2022 Received: (at 53313) by debbugs.gnu.org; 21 Jan 2022 11:32:30 +0000 Received: from localhost ([127.0.0.1]:60371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAs9e-0001OF-9n for submit@debbugs.gnu.org; Fri, 21 Jan 2022 06:32:30 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAs9d-0001Jw-9v for 53313@debbugs.gnu.org; Fri, 21 Jan 2022 06:32:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ju4viyuJ3jNyMQwgbay6es16pPgtvVIegFZUNgC35Cs=; b=d/5LeXrqAnKyDHEDiLCdIIbUPJ 4FZMww9IITEaCJG2arPRjzfcG4V0qc0UQjJeXb6m7E0of3MDG1XNiJdntsS7CLevRkmAotnnI58v9 159M7UcRDUvbmdkcnu8DvwYtdjQPdBgYS7hFxx7T/1UxR7uxj6SYGXujVUnKC/YNJEjc=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAs9U-00037m-Rc; Fri, 21 Jan 2022 12:32:23 +0100 From: Lars Ingebrigtsen To: Max Nikulin Subject: Re: bug#53313: [ERT] EMACS_TEST_VERBOSE can not be explicitly disabled References: <7b4db8e7-2457-c291-7c38-2844bc921858@gmail.com> X-Now-Playing: Osees's _Levitation Sessions_: "Dreary Nonsense" Date: Fri, 21 Jan 2022 12:32:20 +0100 In-Reply-To: <7b4db8e7-2457-c291-7c38-2844bc921858@gmail.com> (Max Nikulin's message of "Mon, 17 Jan 2022 17:59:33 +0700") Message-ID: <87k0ets4sb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Max Nikulin writes: > At least empty value of EMACS_TEST_VERBOSE environment variable > should be considered as false value that disables verbose ERT summary. I've now fixed this in Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53313 Cc: 53313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Max Nikulin writes: > At least empty value of EMACS_TEST_VERBOSE environment variable > should be considered as false value that disables verbose ERT summary. I've now fixed this in Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 06:32:36 2022 Received: (at control) by debbugs.gnu.org; 21 Jan 2022 11:32:36 +0000 Received: from localhost ([127.0.0.1]:60374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAs9k-0001S9-GF for submit@debbugs.gnu.org; Fri, 21 Jan 2022 06:32:36 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAs9j-0001Nq-2T for control@debbugs.gnu.org; Fri, 21 Jan 2022 06:32:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pMGjxwGcmoSqoJz/BsuLV/mhiyqe0KeOArmDXKz43wU=; b=PljSeRd3u3o7YyCEwPo7YOBExk px0EJSMgzJEA3LtS8EGBWuGUjWmOZWXg0LrvNpaaMAD3tKes62nG0u5VQ6THs3r21aESAP8Ic1WJs cb1C3sOzIi66n5IvV+4kaW6OrbSYy4meEGOYKpaJIN0LcyArVKW0oApd40iZCghENhw4=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAs9b-000389-5L for control@debbugs.gnu.org; Fri, 21 Jan 2022 12:32:29 +0100 Date: Fri, 21 Jan 2022 12:32:26 +0100 Message-Id: <87iluds4s5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53313 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 53313 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 53313 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 09:53:56 2022 Received: (at 53313) by debbugs.gnu.org; 21 Jan 2022 14:53:56 +0000 Received: from localhost ([127.0.0.1]:60831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAvIa-0005uM-C4 for submit@debbugs.gnu.org; Fri, 21 Jan 2022 09:53:56 -0500 Received: from mail-lf1-f53.google.com ([209.85.167.53]:46882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAvIX-0005u8-KI for 53313@debbugs.gnu.org; Fri, 21 Jan 2022 09:53:55 -0500 Received: by mail-lf1-f53.google.com with SMTP id d3so34306925lfv.13 for <53313@debbugs.gnu.org>; Fri, 21 Jan 2022 06:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8mcWCk+F/IBWwXvhKbnxTqcaoOyfb1WMgSJrKKWGvds=; b=Vlnl1wIig0qxYefAqtuyNf8rqtqTyGcPBcSUrsABUEDYGAiEARfA88ShyH5J0NpFIR T1l1F89GEJE4s78SqDF8Ra6zr5btychnfEn8lx5auz4g45URvreXuIeZW1bY1dJ3bTW8 DayFogA5LfbV0jBS7sQzV57JQ6N2uxcsb/D/Ba7c10TPG9cnDzMe8J1spRm1qBMs+pr9 aHFearYlToNazlJjYJteBPAL1tPhggMspLWxMq/IQl7DNCDd7RKlJaLTEb6q47INs26K EE/ZmA7kqdUG7McCTzqa65WNvU/o7ohSAPVGudH6hb+3GpGFxWBJdQMRzYfQvn2NNZsI a4hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8mcWCk+F/IBWwXvhKbnxTqcaoOyfb1WMgSJrKKWGvds=; b=PNNanHYVja+ZmOWM8YC2AT5glaE5pqW4okm/QynoiUeFAjNrLFo+j5tuSgWs9DF7aD yFRLdp13gS805WHvi5LQr1+w2JoBSreL3cDbjG6AYEVmyxl7XxOrOX6in29ByNdmfk5Z PPDKfo3OzNd37lfj2CUtDiPytKX19N+S6EdvMzs6j3fCYlNLku1x5TtncdMX55hAsybK FMDnDUtZ64qvXCvEjHJ/4ZZ0PDjlldkbG7+RC9ii1jX33DI4azbr2/gRhpXBVsaoxYI3 RDxSregAHUZh6MErPIWp4T4cEnTBqxTYvbgloyH0Xmv3wmPNGRDCgzfMT853O4fi8yiW Gn2w== X-Gm-Message-State: AOAM53212eFR/Ye2EAACRX1S36ckPd39ai3srlKVYJachnl5HItXeYQW PgKcXdf4fPpJ6s4No03R0ZeHwLZ7J+k= X-Google-Smtp-Source: ABdhPJzGrpCMHm6dd+5wGkTpU7TnPFgGVkom8Xpvt4DjDD4iqg9Uvlp4bmfLh28zaOXJlbK/GjKqaA== X-Received: by 2002:ac2:4acd:: with SMTP id m13mr620430lfp.134.1642776827223; Fri, 21 Jan 2022 06:53:47 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id q2sm96526lfb.111.2022.01.21.06.53.46 for <53313@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jan 2022 06:53:46 -0800 (PST) Subject: Re: bug#53313: [ERT] EMACS_TEST_VERBOSE can not be explicitly disabled To: 53313@debbugs.gnu.org References: <7b4db8e7-2457-c291-7c38-2844bc921858@gmail.com> <87k0ets4sb.fsf@gnus.org> From: Max Nikulin Message-ID: Date: Fri, 21 Jan 2022 21:53:45 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <87k0ets4sb.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 53313 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 21/01/2022 18:32, Lars Ingebrigtsen wrote: > Max Nikulin writes: > >> At least empty value of EMACS_TEST_VERBOSE environment variable >> should be considered as false value that disables verbose ERT summary. > > I've now fixed this in Emacs 29. Thank you, Lars. It works accordingly may expectation in its minimal variant. Just to have it clearly stated in the bug tracker: strings like "0", "no", etc. are considered as true value as any other non-empty strings. Only unset variable or empty value disables verbose summary. Commit 4d866fc0f5 From unknown Fri Aug 15 21:22:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Feb 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator