GNU bug report logs - #53309
Newly-added python-piexif fails to patch source due to CRLF(?)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53309 in the body.
You can then email your comments to 53309 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: Newly-added python-piexif fails to patch source due to CRLF(?)
Date: Sun, 16 Jan 2022 23:44:46 +0100

[Message part 1 (text/plain, inline)]

Hullo Hartmut,

I'm strangely unable to build python-piexif:

patching file tests/s_test.py
Hunk #1 FAILED at 9 (different line endings).
Hunk #2 FAILED at 580 (different line endings).
2 out of 2 hunks FAILED -- saving rejects to file 
tests/s_test.py.rej

Indeed:

$ file tests/s_test.py
tests/s_test.py: Python script, ASCII text executable, with CRLF 
line terminators

$ file python-piexif-fix-tests-with-pillow-7.2.pat>
python-piexif-fix-tests-with-pillow-7.2.patch: ASCII text

At least that's what I guess is the problem.

This is worrying since I'd expect all this to be 100% 
reproducible, and it seems to work fine for both you & Ludo'…

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 53309 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 53309 <at> debbugs.gnu.org, Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: Re: bug#53309: Newly-added python-piexif fails to patch source due
 to CRLF(?)
Date: Mon, 17 Jan 2022 17:18:58 +0100

Hi,

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> This is worrying since I'd expect all this to be 100% reproducible,
> and it seems to work fine for both you & Ludo'…

Applying the patch also fails for me (I think I didn’t test it when
reviewing Hartmut’s patches.)

Ludo’.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Bug reports for GNU Guix <bug-guix <at> gnu.org>
Subject: Re: Newly-added python-piexif fails to patch source due to CRLF(?)
Date: Tue, 18 Jan 2022 19:25:15 +0100

Hi,

Am 16.01.22 um 23:44 schrieb Tobias Geerinckx-Rice:
> This is worrying since I'd expect all this to be 100% reproducible, 
> and it seems to work fine for both you & Ludo'… 

I have to admit that I did not test the patch again after converting the 
line-endings - which Ludo asked for. Changing the line-endings was too 
simple FMPOV - I trusted Ludo's recommendation.

I'll fix this.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #16 received at 53309-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 53309-close <at> debbugs.gnu.org
Subject: Re: Newly-added python-piexif fails to patch source due to CRLF(?)
Date: Tue, 18 Jan 2022 20:12:58 +0100

Fixed in af47145e995c9d3d116a60053648b4f35e2ed125

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: Bug reports for GNU Guix <bug-guix <at> gnu.org>
Subject: Re: Newly-added python-piexif fails to patch source due to CRLF(?)
Date: Tue, 18 Jan 2022 20:29:45 +0100

[Message part 1 (text/plain, inline)]

Hartmut Goebel 写道：
> I have to admit that I did not test the patch again after 
> converting
> the line-endings - which Ludo asked for. Changing the 
> line-endings was
> too simple FMPOV - I trusted Ludo's recommendation.

All good, I'm just glad it's not due to some spooky gremlin 
(similar to the locale orcs that still occasionally haunt our 
lands).

> I'll fix this.

Thanks!

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.