GNU bug report logs - #53295
[PATCH] gnu: Add FFmpeg 5.0.

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Sun, 16 Jan 2022 05:36:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 53295 <at> debbugs.gnu.org
Subject: [bug#53295] [PATCH] gnu: Add FFmpeg 5.0.
Date: Mon, 24 Jan 2022 10:24:06 +0100
Hi,

Leo Famulari <leo <at> famulari.name> skribis:

> Here's the new major release of FFmpeg.
>
> We can add it right away and move users over to it incrementally as we
> test them — having this new version is useful for people like me who use
> FFmpeg directly.
>
> Also, I always found our FFmpeg packages' use of inheritance to be
> confusing when making changes to them, so I didn't use it here.
>
> * gnu/packages/video.scm (ffmpeg-5): New variable.

Could you remove input labels?  (I think ‘guix style’ can’t help because
of the conditional in the middle.)

That said, it seems to me there’s a lot of duplication here compared to
version 4.  So I’d be in favor of inheriting from that one.

Now, I agree that sometimes attempting to factorize every bit can lead
to hard-to-read packages.  Perhaps the solution is to duplicate and
tweak just those bits where factorization would make things less clear?

Thanks,
Ludo’.




This bug report was last modified 3 years and 53 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.