From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 00:35:44 2022 Received: (at submit) by debbugs.gnu.org; 16 Jan 2022 05:35:45 +0000 Received: from localhost ([127.0.0.1]:42324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8yCW-0002xa-Co for submit@debbugs.gnu.org; Sun, 16 Jan 2022 00:35:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:47788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8yCR-0002xK-5F for submit@debbugs.gnu.org; Sun, 16 Jan 2022 00:35:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8yCQ-0006RL-IZ for guix-patches@gnu.org; Sun, 16 Jan 2022 00:35:30 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:46231) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8yCN-0004db-9J for guix-patches@gnu.org; Sun, 16 Jan 2022 00:35:30 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 77A835C0091; Sun, 16 Jan 2022 00:35:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 16 Jan 2022 00:35:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=3epKWnAn9UmlV3AnSV6UOnA Ouay6wc0L1M+MuiPe5Mo=; b=Jtg/stwiZMJCnViraJlWGBCetkAUde/xUoF3Zyv WhLlY3u/U6Kj+UYChKjGoWbIcHPs3xeeqbgR2GOwERn+kOKSOo43TAuGG5w2pwWJ y1QRH0HPi7NDPbvpmOGF6WQJVuzhaSKeVbnOTRj4PY7rlk+SACxo8WF6tdcxJ3pb IV04= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3epKWn An9UmlV3AnSV6UOnAOuay6wc0L1M+MuiPe5Mo=; b=bqPiE6gDZ/AZGi66ruICv8 4AG+vpvGL1o29HsVAealA2peGrT7WHldWXepQIWCxHDGsxEE9kkRsQuAVYW8aJ72 CxRcnJoeUG1zLIS7GoCd7FC5oZv9VL9+z+cdbaMJ3JGJjaF1V5WYJfEaQ0RNPdzS T/qSxM789JZ0VJCnXfD7KnEP5O1WGb31t1viB+8ocTXaOHQ/nmnNYEnIrCY0YOBT E7CE5t2x48c9u5axG2Oo+5T1258j7JuE3sFfVM3WnIWHrlUuDvs+BJBgr3QzPiu6 Gq69Msy1H7w5HDlfmBqApI7rCBwNOXfbnOgmpDiaO0UCxxZFalxAyHUDCtjIbDsw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtdekgdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdduuddmnecujfgurhephffvuf ffkffogggtgfesthekredtredtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceo lhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepudetveeufe egkeeiffdvveehuefhffeutdeiiedtudeujedvtdeuledvieeitdetnecuffhomhgrihhn pehffhhmphgvghdrohhrghdpvhhiuggvohhlrghnrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhn rghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 16 Jan 2022 00:35:25 -0500 (EST) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] gnu: Add FFmpeg 5.0. Date: Sun, 16 Jan 2022 00:35:21 -0500 Message-Id: X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.29; envelope-from=leo@famulari.name; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Here's the new major release of FFmpeg. We can add it right away and move users over to it incrementally as we test them — having this new version is useful for people like me who use FFmpeg directly. Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ambrevar.xyz (xyz)] 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=leo%40famulari.name;ip=209.51.188.17;r=debbugs.gnu.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Here's the new major release of FFmpeg. We can add it right away and move users over to it incrementally as we test them — having this new version is useful for people like me who use FFmpeg directly. Also, I always found our FFmpeg packages' use of inheritance to be confusing when making changes to them, so I didn't use it here. * gnu/packages/video.scm (ffmpeg-5): New variable. --- gnu/packages/video.scm | 206 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 205 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index a9996e477e..74012ab76d 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -24,7 +24,7 @@ ;;; Copyright © 2018 Roel Janssen ;;; Copyright © 2018, 2019, 2020, 2021 Marius Bakke ;;; Copyright © 2018, 2019, 2020 Pierre Neidhardt -;;; Copyright © 2018, 2019, 2020 Leo Famulari +;;; Copyright © 2018, 2019, 2020, 2022 Leo Famulari ;;; Copyright © 2018 Brendan Tildesley ;;; Copyright © 2018 Arun Isaac ;;; Copyright © 2018 Björn Höfling @@ -1530,6 +1530,210 @@ (define-public libva-utils operate properly.") (license license:expat))) +(define-public ffmpeg-5 + (package + (name "ffmpeg") + (version "5.0") + (source (origin + (method url-fetch) + (uri (string-append "https://ffmpeg.org/releases/ffmpeg-" + version ".tar.xz")) + (sha256 + (base32 + "163jmk03nwsiqkpz3k04a48r20w5hhx29rpssh7jq1h5sbviksai")))) + (build-system gnu-build-system) + (inputs + `(("dav1d" ,dav1d) + ("fontconfig" ,fontconfig) + ("freetype" ,freetype) + ("frei0r-plugins" ,frei0r-plugins) + ("gnutls" ,gnutls) + ("opus" ,opus) + ("ladspa" ,ladspa) + ("lame" ,lame) + ("libaom" ,libaom) + ("libass" ,libass) + ("libbluray" ,libbluray) + ("libcaca" ,libcaca) + ("libcdio-paranoia" ,libcdio-paranoia) + ("libdrm" ,libdrm) + ("libtheora" ,libtheora) + ("libva" ,libva) + ("libvdpau" ,libvdpau) + ("libvorbis" ,libvorbis) + ("libvpx" ,libvpx) + ("libx11" ,libx11) + ("libx264" ,libx264) + ("mesa" ,mesa) + ("openal" ,openal) + ("pulseaudio" ,pulseaudio) + ;; XXX: rav1e depends on rust, which currently only works on x86_64. + ;; See also the related configure flag when changing this. + ,@(if (string-prefix? "x86_64" (or (%current-target-system) + (%current-system))) + `(("rav1e" ,rav1e)) + '()) + ("sdl" ,sdl2) + ("soxr" ,soxr) + ("speex" ,speex) + ("srt" ,srt) + ("twolame" ,twolame) + ("vidstab" ,vidstab) + ("x265" ,x265) + ("xvid" ,xvid) + ("zlib" ,zlib))) + (native-inputs + (list bc + perl + pkg-config + texinfo + speex + yasm)) + (arguments + `(#:test-target "fate" + #:configure-flags + ;; possible additional inputs: + ;; --enable-avisynth enable reading of AviSynth script + ;; files [no] + ;; --enable-libaacplus enable AAC+ encoding via libaacplus [no] + ;; --enable-libcelt enable CELT decoding via libcelt [no] + ;; --enable-libdc1394 enable IIDC-1394 grabbing using libdc1394 + ;; and libraw1394 [no] + ;; --enable-libfaac enable AAC encoding via libfaac [no] + ;; --enable-libfdk-aac enable AAC de/encoding via libfdk-aac [no] + ;; --enable-libflite enable flite (voice synthesis) support via + ;; libflite [no] + ;; --enable-libgme enable Game Music Emu via libgme [no] + ;; --enable-libgsm enable GSM de/encoding via libgsm [no] + ;; --enable-libiec61883 enable iec61883 via libiec61883 [no] + ;; --enable-libilbc enable iLBC de/encoding via libilbc [no] + ;; --enable-libmodplug enable ModPlug via libmodplug [no] + ;; --enable-libnut enable NUT (de)muxing via libnut, + ;; native (de)muxer exists [no] + ;; --enable-libopencore-amrnb enable AMR-NB de/encoding via + ;; libopencore-amrnb [no] + ;; --enable-libopencore-amrwb enable AMR-WB decoding via + ;; libopencore-amrwb [no] + ;; --enable-libopencv enable video filtering via libopencv [no] + ;; --enable-libopenjpeg enable JPEG 2000 de/encoding via + ;; OpenJPEG [no] + ;; --enable-librtmp enable RTMP[E] support via librtmp [no] + ;; --enable-libschroedinger enable Dirac de/encoding via + ;; libschroedinger [no] + ;; --enable-libshine enable fixed-point MP3 encoding via + ;; libshine [no] + ;; --enable-libssh enable SFTP protocol via libssh [no] + ;; (libssh2 does not work) + ;; --enable-libstagefright-h264 enable H.264 decoding via + ;; libstagefright [no] + ;; --enable-libutvideo enable Ut Video encoding and decoding via + ;; libutvideo [no] + ;; --enable-libv4l2 enable libv4l2/v4l-utils [no] + ;; --enable-libvo-aacenc enable AAC encoding via libvo-aacenc [no] + ;; --enable-libvo-amrwbenc enable AMR-WB encoding via + ;; libvo-amrwbenc [no] + ;; --enable-libwavpack enable wavpack encoding via libwavpack [no] + ;; --enable-libxavs enable AVS encoding via xavs [no] + ;; --enable-libzmq enable message passing via libzmq [no] + ;; --enable-libzvbi enable teletext support via libzvbi [no] + ;; --enable-opencl enable OpenCL code + '("--enable-gpl" ; enable optional gpl licensed parts + "--enable-shared" + "--enable-frei0r" + "--enable-fontconfig" + "--enable-gnutls" + "--enable-ladspa" + "--enable-libaom" + "--enable-libass" + "--enable-libbluray" + "--enable-libcaca" + "--enable-libcdio" + "--enable-libdav1d" + "--enable-libfreetype" + "--enable-libmp3lame" + "--enable-libopus" + "--enable-libpulse" + ,@(if (string-prefix? "x86_64" (or (%current-target-system) + (%current-system))) + '("--enable-librav1e") + '()) + "--enable-libsoxr" + "--enable-libspeex" + "--enable-libsrt" + "--enable-libtheora" + "--enable-libtwolame" + "--enable-libvidstab" + "--enable-libvorbis" + "--enable-libvpx" + "--enable-libxvid" + "--enable-libx264" + "--enable-libx265" + "--enable-openal" + "--enable-opengl" + "--enable-libdrm" + "--enable-vaapi" + + "--enable-runtime-cpudetect" + + ;; The HTML pages take 7.2 MiB + "--disable-htmlpages" + + ;; The static libraries are 23 MiB + "--disable-static" + + ;; Runtime cpu detection is not implemented on + ;; MIPS, so we disable some features. + "--disable-mips32r2" + "--disable-mipsdsp" + "--disable-mipsdspr2" + "--disable-mipsfpu") + #:phases + (modify-phases %standard-phases + (replace + 'configure + ;; configure does not work followed by "SHELL=..." and + ;; "CONFIG_SHELL=..."; set environment variables instead + (lambda* (#:key outputs configure-flags #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (substitute* "configure" + (("#! /bin/sh") (string-append "#!" (which "sh")))) + (setenv "SHELL" (which "bash")) + (setenv "CONFIG_SHELL" (which "bash")) + (apply invoke + "./configure" + (string-append "--prefix=" out) + ;; Add $libdir to the RUNPATH of all the binaries. + (string-append "--extra-ldflags=-Wl,-rpath=" + out "/lib") + configure-flags)))) + ;; For FFmpeg 5.0, correctly mark all tests that require the + ;; downloadble test samples as such. This fixes an error when the test + ;; suite tries to build a test image from a source that it cannot + ;; download in the build container. Adapted from the upstream source + ;; repository: + ;; https://git.videolan.org/?p=ffmpeg.git;a=commit;h=b1ef5882e35d1a95e9c4838d0933084773055345 + (add-before 'check 'fix-tests + (lambda _ + (substitute* "tests/fate/ffmpeg.mak" + (("FATE_FFMPEG-\\$\\(call ALLYES, FILE") + "FATE_SAMPLES_FFMPEG-$(call ALLYES, FILE")))) + (add-before + 'check 'set-ld-library-path + (lambda _ + ;; Allow $(top_builddir)/ffmpeg to find its dependencies when + ;; running tests. + (let* ((dso (find-files "." "\\.so$")) + (path (string-join (map dirname dso) ":"))) + (format #t "setting LD_LIBRARY_PATH to ~s~%" path) + (setenv "LD_LIBRARY_PATH" path) + #t)))))) + (home-page "https://www.ffmpeg.org/") + (synopsis "Audio and video framework") + (description "FFmpeg is a complete, cross-platform solution to record, +convert and stream audio and video. It includes the libavcodec +audio/video codec library.") + (license license:gpl2+))) + (define-public ffmpeg (package (name "ffmpeg") -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 24 04:24:14 2022 Received: (at 53295) by debbugs.gnu.org; 24 Jan 2022 09:24:14 +0000 Received: from localhost ([127.0.0.1]:42080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBva9-0005bC-Un for submit@debbugs.gnu.org; Mon, 24 Jan 2022 04:24:14 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:41944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBva9-0005b0-8a for 53295@debbugs.gnu.org; Mon, 24 Jan 2022 04:24:13 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C189F2FE; Mon, 24 Jan 2022 10:24:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qtej1erkQZzf; Mon, 24 Jan 2022 10:24:07 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DCEC2BD; Mon, 24 Jan 2022 10:24:06 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Leo Famulari Subject: Re: bug#53295: [PATCH] gnu: Add FFmpeg 5.0. References: Date: Mon, 24 Jan 2022 10:24:06 +0100 In-Reply-To: (Leo Famulari's message of "Sun, 16 Jan 2022 00:35:21 -0500") Message-ID: <87pmohwkp5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: C189F2FE X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 53295 Cc: 53295@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Leo Famulari skribis: > Here's the new major release of FFmpeg. > > We can add it right away and move users over to it incrementally as we > test them =E2=80=94 having this new version is useful for people like me = who use > FFmpeg directly. > > Also, I always found our FFmpeg packages' use of inheritance to be > confusing when making changes to them, so I didn't use it here. > > * gnu/packages/video.scm (ffmpeg-5): New variable. Could you remove input labels? (I think =E2=80=98guix style=E2=80=99 can= =E2=80=99t help because of the conditional in the middle.) That said, it seems to me there=E2=80=99s a lot of duplication here compare= d to version 4. So I=E2=80=99d be in favor of inheriting from that one. Now, I agree that sometimes attempting to factorize every bit can lead to hard-to-read packages. Perhaps the solution is to duplicate and tweak just those bits where factorization would make things less clear? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 13:59:12 2022 Received: (at 53295-done) by debbugs.gnu.org; 23 May 2022 17:59:12 +0000 Received: from localhost ([127.0.0.1]:50173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntCKk-0004p7-1K for submit@debbugs.gnu.org; Mon, 23 May 2022 13:59:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntCKV-0004oO-JP for 53295-done@debbugs.gnu.org; Mon, 23 May 2022 13:59:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntCKQ-0003kx-7b; Mon, 23 May 2022 13:58:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=57kqkRPNmLD9UWUjd+wv1PCW6P2q9S5e53nMx7Uc5Bs=; b=hhB1FfgVuZw9nsQ4GPsW mQBbuMdltiLgBBbx4T+VfwgjrOJfcjxgaGIKF+e9De3O9AZPOoPBrOv0/9f3X2aAj4d+nC2fUCLAB zEx4wtC+dTPbWP6OQNF4EWwBLktBgbJ1MEWTJU5WaEGU+YJ40+dLGY90t4XWTyfHvoz0hm9jlUc2/ GB464ZzIY+DHklj2CdZryt14xsVoAQcYhWZ3i6TcbNtSrl1sYTgzyulB9tfOy57E3qhiuDTeLNKBx HkzPJrr1mmCKPpU1ESLJM6VO2uTcqUFzVb7KO20jQRNllb+tXyd1O3agD/ZDPjEaospCF19mqvj/Y ttvh/q/D4iiyeA==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:42462 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntCKO-0008Lz-KN; Mon, 23 May 2022 13:58:49 -0400 From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Leo Famulari Subject: Re: [bug#53295] [PATCH] gnu: Add FFmpeg 5.0. In-Reply-To: <87pmohwkp5.fsf@gnu.org> References: <87pmohwkp5.fsf@gnu.org> Date: Mon, 23 May 2022 19:58:46 +0200 Message-ID: <87h75g2krt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53295-done Cc: 53295-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s skriver: > Hi, > > Leo Famulari skribis: > >> Here's the new major release of FFmpeg. >> >> We can add it right away and move users over to it incrementally as we >> test them =E2=80=94 having this new version is useful for people like me= who use >> FFmpeg directly. >> >> Also, I always found our FFmpeg packages' use of inheritance to be >> confusing when making changes to them, so I didn't use it here. >> >> * gnu/packages/video.scm (ffmpeg-5): New variable. > > Could you remove input labels? (I think =E2=80=98guix style=E2=80=99 can= =E2=80=99t help because > of the conditional in the middle.) > > That said, it seems to me there=E2=80=99s a lot of duplication here compa= red to > version 4. So I=E2=80=99d be in favor of inheriting from that one. I went ahead and pushed this patch in 1cb10f696813ef23678029, with the adjustments Ludo recommended + G-expressions; as well as a follow-up that makes ffmpeg@4 inherit from it. Thanks Leo & Ludo! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYovLVg8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcRNAEAxUD960WhKtcFX2zmTFSoAdnNG3pdhUplOHDZ M/DD074BAMgpXHXdgvmcWDPr0pJO5m6dfgIAZTBwvT/a1i0mLvUP =76G/ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 23 21:03:50 2022 Received: (at 53295-done) by debbugs.gnu.org; 24 May 2022 01:03:50 +0000 Received: from localhost ([127.0.0.1]:50479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntIxi-00018x-K9 for submit@debbugs.gnu.org; Mon, 23 May 2022 21:03:50 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntIxe-00018i-9u for 53295-done@debbugs.gnu.org; Mon, 23 May 2022 21:03:49 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3DE2F5C0273; Mon, 23 May 2022 21:03:41 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute5.internal (MEProxy); Mon, 23 May 2022 21:03:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; t=1653354221; x=1653440621; bh=tBurBcRL1QaMq1p3MEIWx33LloHfQxpyOe1uA/MbDt0=; b= Ci/ZqDdQhUXsZnE330m/PNXrv6W7WgFEFdBlB2s13PydyOZc6FWqgDIF2qalFyO5 kw5H1Eqzy2WHWi6n8UU6YDFZMvlXxPC9lbcI6re1SkoARqV2wU0JxgI34RIWux/y /cLrO9M7TqSdmuu0Z6uW/giA7Plv3TrNjy0scIfVZmc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653354221; x= 1653440621; bh=tBurBcRL1QaMq1p3MEIWx33LloHfQxpyOe1uA/MbDt0=; b=t YpQuLRs68d4A06oJrZHSs2cw3uATO2OqW9U8F2jf09EM86DzCFO9yGXIWk+9MPsC WDQPvoulvbGk6uma7VgcuFXIolMMkjKxh22hPAZXvbZan9nVV4+jykQTWPIrDQaA sY+e3tSdlZfffTV62craQCPxj9uyQ7l6+CO9KvYEHtdC0XldNEe8pAUBH88w3vfU OCnntl0PEJaAIC9sPjgMIWApiAo3R3B9bXL+eRDoCaHlfIp6LWNa7PtshltZoyMR CgdhgeJDDztrVU46QiUj4yNKkj73oK7BHPj33aEccozPr+ifWqVVP1gXdoR34FpI tFGiVsjZk3hlFTJNQ6dCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjedvgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedfnfgv ohcuhfgrmhhulhgrrhhifdcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtf frrghtthgvrhhnpeejvdelfefhueeugedutdehlefgueeuveeileevfedugeelhffhhfek hfeghfekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1F94031A0061; Mon, 23 May 2022 21:03:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-591-gfe6c3a2700-fm-20220427.001-gfe6c3a27 Mime-Version: 1.0 Message-Id: In-Reply-To: <87h75g2krt.fsf@gnu.org> References: <87pmohwkp5.fsf@gnu.org> <87h75g2krt.fsf@gnu.org> Date: Mon, 23 May 2022 21:03:20 -0400 From: "Leo Famulari" To: "Marius Bakke" , =?UTF-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: [bug#53295] [PATCH] gnu: Add FFmpeg 5.0. Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53295-done Cc: 53295-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thank you Marius! I've been distracted and busy offline so I very much a= ppreciate you finishing this work! On Mon, May 23, 2022, at 13:58, Marius Bakke wrote: > Ludovic Court=C3=A8s skriver: > >> Hi, >> >> Leo Famulari skribis: >> >>> Here's the new major release of FFmpeg. >>> >>> We can add it right away and move users over to it incrementally as = we >>> test them =E2=80=94 having this new version is useful for people lik= e me who use >>> FFmpeg directly. >>> >>> Also, I always found our FFmpeg packages' use of inheritance to be >>> confusing when making changes to them, so I didn't use it here. >>> >>> * gnu/packages/video.scm (ffmpeg-5): New variable. >> >> Could you remove input labels? (I think =E2=80=98guix style=E2=80=99= can=E2=80=99t help because >> of the conditional in the middle.) >> >> That said, it seems to me there=E2=80=99s a lot of duplication here c= ompared to >> version 4. So I=E2=80=99d be in favor of inheriting from that one. > > I went ahead and pushed this patch in 1cb10f696813ef23678029, with the > adjustments Ludo recommended + G-expressions; as well as a follow-up > that makes ffmpeg@4 inherit from it. > > Thanks Leo & Ludo! > > Attachments: > * signature.asc From unknown Fri Aug 15 21:22:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Jun 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator