From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 05:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 53294@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16423100209101 (code B ref -1); Sun, 16 Jan 2022 05:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jan 2022 05:13:40 +0000 Received: from localhost ([127.0.0.1]:42306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8xrI-0002Mi-0r for submit@debbugs.gnu.org; Sun, 16 Jan 2022 00:13:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:44124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8xrC-0002MT-4N for submit@debbugs.gnu.org; Sun, 16 Jan 2022 00:13:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8xrB-0002LZ-8m for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 00:13:33 -0500 Received: from [2607:f8b0:4864:20::f2e] (port=33589 helo=mail-qv1-xf2e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8xr9-0007er-JX for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 00:13:32 -0500 Received: by mail-qv1-xf2e.google.com with SMTP id t7so14615022qvj.0 for ; Sat, 15 Jan 2022 21:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=WJLqghft047QIcu13q/kkzQ2lMsf+mT+7oybmZ4M4TI=; b=RHA0/fjVkjipE5391Jjud9NjKJX+Tt2Ribw/o9D6/bHfijDhbWaUkzW9ERmU97ynOV 9WCQ85NLSeWB0V8Nwvh/TSt3qCx6Knp8FRyOg/ydI0Uhfd4JryFZJIIQHzW/PyTGDR/R 3xFtu8EmTUH0yBfsd5fD51yy7e/Y0EAI0cfiZDaZRNQk9I7QQZS73XRKbB2ASRJOcgki gCdDhqbNJPVQSfgU86vz2tEaw87v5cXfNiBbZ7txB0MXipBGhSX509gJe/8eG0AtLg4D 8i7Zt2p/0aUUVk5KXZMVRFGWrTKhSAwklSfh0Y4+t8ZdjhCyr9YTiFEcf6IzLwK9wir8 FHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=WJLqghft047QIcu13q/kkzQ2lMsf+mT+7oybmZ4M4TI=; b=FO1SYnG/w2j7D7nwDrTKQ6zSpfHELWC5DcKnLv0I+gThiBoCfuLI0qMoBin+FbPszJ TttjCqSehQT/o/AvssrwC6ikiwYrTUMgiWO5+or7SjJ9XUE3xEA2BCngCUWmXdmjHVB5 yPmDeC0l/4P5ZdUIeR+G81V9AJy7P0agMfxkadmeW8OFYpXqhzZfA7Pj1M5QP4QwyLlw gLZv5OqlTAJkzvWRe+qCtmH/NwrdfxwfvIZgZuSrrBTytUhL7FUIvAlo0G9u6T/CkyWc pVk7LFn/2btURvUHrrlgrVVLUcRbYQG0mSmKmLD5/9g/B2iOKMirrl0r2d+jM+Iq3ebS cvmA== X-Gm-Message-State: AOAM5305z6lsUZ7DzuEi6ClPpl5Qszw4VCdPARxzobhGCSEBU70hASLP J7XgR9FWYtI58hDx3872qz0yXFIifQA= X-Google-Smtp-Source: ABdhPJza4xPNpZYS40Ym1+2sZsNvWR/AumTr4wkyjpNWbmk496y14akhpRD0XtISn5+7GFxDUd7VOA== X-Received: by 2002:a05:6214:1c09:: with SMTP id u9mr14367394qvc.4.1642310008599; Sat, 15 Jan 2022 21:13:28 -0800 (PST) Received: from andrews-mbp.lan (pool-173-56-75-166.nycmny.fios.verizon.net. [173.56.75.166]) by smtp.gmail.com with ESMTPSA id m13sm6183348qkk.122.2022.01.15.21.13.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 21:13:27 -0800 (PST) From: Andrew Hyatt Date: Sun, 16 Jan 2022 00:13:26 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f2e (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f2e; envelope-from=ahyatt@gmail.com; helo=mail-qv1-xf2e.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi all, I noticed a bug recently where if I scale up fonts in an org capture buffer, it affects the original buffer, which keeps getting bigger and bigger every time org-capture is run. However, you don't need org to reproduce this. Here's a quick way to reproduce, which works with emacs -Q: Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ahyatt[at]gmail.com) 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.51.188.17 listed in wl.mailspike.net] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.3 SPOOFED_FREEMAIL No description available. 1.5 SPOOF_GMAIL_MID From Gmail but it doesn't seem to be... X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=text-scale-patch Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZmFjZS1yZW1hcC5lbCBiL2xpc3AvZmFjZS1yZW1hcC5lbAppbmRl eCAwMDU2MGY5ZDJlLi5kZjM1ZDg4OTMzIDEwMDY0NAotLS0gYS9saXNwL2ZhY2UtcmVtYXAuZWwK KysrIGIvbGlzcC9mYWNlLXJlbWFwLmVsCkBAIC0xMzQsNiArMTM0LDExIEBAIGZhY2UtcmVtYXAt YWRkLXJlbGF0aXZlCiAgICAgKGxldCAoKGZhY2VzIChjZHIgZW50cnkpKSkKICAgICAgIChpZiAo c3ltYm9scCBmYWNlcykKIAkgIChzZXRxIGZhY2VzIChsaXN0IGZhY2VzKSkpCisgICAgICAoc2V0 cSBmYWNlLXJlbWFwcGluZy1hbGlzdAorCSAgICAobWFwY2FyIChsYW1iZGEgKGt2KQorCQkgICAg ICAoaWYgKGVxIChjYXIga3YpIGZhY2UpCisJCQkgIChjb25zIGZhY2UgKGZhY2UtcmVtYXAtb3Jk ZXIgKGNvbnMgc3BlY3MgZmFjZXMpKSkKKwkJCWt2KSkgZmFjZS1yZW1hcHBpbmctYWxpc3QpKQog ICAgICAgKHNldGNkciBlbnRyeSAoZmFjZS1yZW1hcC1vcmRlciAoY29ucyBzcGVjcyBmYWNlcykp KQogICAgICAgOzsgRm9yY2UgcmVkaXNwbGF5IG9mIHRoaXMgYnVmZmVyLgogICAgICAgKGZvcmNl LW1vZGUtbGluZS11cGRhdGUpKQo= --=-=-= Content-Type: text/plain; format=flowed Hi all, I noticed a bug recently where if I scale up fonts in an org capture buffer, it affects the original buffer, which keeps getting bigger and bigger every time org-capture is run. However, you don't need org to reproduce this. Here's a quick way to reproduce, which works with emacs -Q: (require 'face-remap) (defun ash/big-font () "Creates a font that is big enough for about 20 lines of text." (interactive) (let ((text-scale-mode-amount (/ (frame-height) 20))) (text-scale-mode 1))) (defun ash/reproduce-with-indirect-buffer () (interactive) (let ((buf (get-buffer-create "*Orig buffer*"))) (set-buffer buf) (variable-pitch-mode 1) ;; same way org mode creates indirect buffer (set-buffer (make-indirect-buffer buf "*Indirect buffer*" 'clone)) (ash/big-font-new) (kill-buffer (current-buffer)))) Running ash/reproduce-with-indirect-buffer will increase the indirect buffer in size each time. If you look at face-remapping-alist, it's clear that the original buffer's value is being altered by the indirect buffer. I traced this down to the setcdr in face-remove-add-relative, which is incorrectly alterting a buffer local variable, by setting parts of a variable in a way that will affect the original variable. Evidently making something buffer local doesn't clone it, it just copies the value, and so you can alter the original by operations such as setcdr. Assuming that the fixing how variables becomes buffer local is too much, I've fixed this in face-remap.el. The patch is attached. In GNU Emacs 29.0.50 (build 1, aarch64-apple-darwin21.2.0, NS appkit-2113.20 Version 12.1 (Build 21C52)) of 2021-12-26 built on andrews-mbp.lan Repository revision: 978987f7ad58cd66fe51cefde53ba4771b189aeb Repository branch: master Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.1 Configured using: 'configure --with-native- Configured features: ACL GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS XIM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix --=-=-=-- From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 09:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andrew Hyatt Cc: 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.16423249683050 (code B ref 53294); Sun, 16 Jan 2022 09:23:02 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 09:22:48 +0000 Received: from localhost ([127.0.0.1]:42479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91kN-0000n8-NG for submit@debbugs.gnu.org; Sun, 16 Jan 2022 04:22:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91kL-0000mv-GU for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 04:22:45 -0500 Received: from [2001:470:142:3::e] (port=45540 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91kG-0002kr-7m; Sun, 16 Jan 2022 04:22:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IXPUUJLLNywwtgNBbetMLoZhGLTYqyjHcUfsjCasli0=; b=Pj9K0MKejBZC MzD5a+tSsFSSWtxzYRbh8fEolMYDnKPlc2sSwtngiUr92Xc4g4zPdoWDocYL3MBlMkiAk+bcYSqLf SMiwMfIABlrckY64D4k8FAqBqeJ6vyzoDRMm/i7TqOaQiJBZV7PiKsbk5KC1DtXjrLHreI1NbZvFz BqdsuCJST3xEDkA5JHNAFMJV740e2X6jlrEULDEP/5iqI3DpqYl/PUVwzt88vBDWp1LdrbZ+BHJuz V9i5f00fKgsxj8iPWNLDrlsPJrN8tIqiNcoo2pJHzuh8gMrdD7V/3ySsFgcv+IMV8qR9Nayz/oPmF UoDj8EPgb6pmZj/Je7FvOw==; Received: from [87.69.77.57] (port=4672 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91kG-0005Gu-AK; Sun, 16 Jan 2022 04:22:40 -0500 Date: Sun, 16 Jan 2022 11:22:27 +0200 Message-Id: <835yqkyqzw.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Andrew Hyatt on Sun, 16 Jan 2022 00:13:26 -0500) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew Hyatt > Date: Sun, 16 Jan 2022 00:13:26 -0500 > > I noticed a bug recently where if I scale up fonts in an org > capture buffer, it affects the original buffer, which keeps > getting bigger and bigger every time org-capture is run. > > However, you don't need org to reproduce this. Here's a quick way > to reproduce, which works with emacs -Q: > > (require 'face-remap) (defun ash/big-font () > "Creates a font that is big enough for about 20 lines of text." > (interactive) (let ((text-scale-mode-amount (/ (frame-height) > 20))) > (text-scale-mode 1))) > > (defun ash/reproduce-with-indirect-buffer () > (interactive) (let ((buf (get-buffer-create "*Orig buffer*"))) > (set-buffer buf) (variable-pitch-mode 1) ;; same way org mode > creates indirect buffer (set-buffer (make-indirect-buffer buf > "*Indirect buffer*" 'clone)) (ash/big-font-new) (kill-buffer > (current-buffer)))) > > Running ash/reproduce-with-indirect-buffer will increase the > indirect buffer in size each time. If you look at > face-remapping-alist, it's clear that the original buffer's value > is being altered by the indirect buffer. I don't think I understand what I should see and pay attention to with this recipe (and it includes several errors that took me some time to fix, before I could run it), but isn't this because you used non-nil CLONE argument to make-indirect-buffer? From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164234420527477 (code B ref 53294); Sun, 16 Jan 2022 14:44:02 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 14:43:25 +0000 Received: from localhost ([127.0.0.1]:42738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n96ke-000796-MO for submit@debbugs.gnu.org; Sun, 16 Jan 2022 09:43:24 -0500 Received: from mail-qk1-f181.google.com ([209.85.222.181]:35352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n96kd-00078q-Sw for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 09:43:24 -0500 Received: by mail-qk1-f181.google.com with SMTP id j85so16434607qke.2 for <53294@debbugs.gnu.org>; Sun, 16 Jan 2022 06:43:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=rrM+YT3U5PVUvfuTGHcVpHYur+r1JJipxXtjqMXGJrA=; b=DEZU38tQqvX6XmnxntLJuSLhsvJLl5xcm60mewYYPKPNcimrc6R+LOjTFGjIInwFMh tys/pQLl8xFyO4inYUp95fbv+JQTpLiu6XQwyed1nqxqqTVeSRK3f88cPzqqaaR0snV9 ogtpD6e9Z/GQ6qw65H9LtF+LKoPLysx2UzrflrwPH20HdIUT+q/J8d9UFkQWJ4vmFipK a02fLHz8X4xNu71aw2jMRrW/fmHiYbquIpG2dDOjMOycGjiiS7SaNlWcaKINR+AWkAdl VpEXX4ud/BNg0pGRQzegq8KGMhjWLZLAAfTwXYU1xaiGV28lMU/N9mgRctzOvpi4EZ/m C4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=rrM+YT3U5PVUvfuTGHcVpHYur+r1JJipxXtjqMXGJrA=; b=RiAC9xfJbU8NREET2DraI3gKanRvrFxWrpRBbDdJGHil3dWkkTNCsF1jfrPd+Wn6FF i6LkUr1f2noVdcOje/MSC2+A/ZQx1uV1VI24SMQDdsqaqj3vDJ64xBReeOHJa7GBQ32V xG5jpiA5r2hm13VMOGq7e4BojxbBHGN5LVcQ2IQmhGO4nLAgkm4gbKxGmqr2bwTMLqXI EnSldXMdBa6ZF6CPCiibK+TuR4dEQAftK3YPK5h24Tty649RG4TSkrvnJZ4zL8KuvZbP RaW96ggs3P+pJOG5rs4rJ0XoXJIr/1TWhDxz3HCzHj7j+9kAITq7mmiF86fAtBb/fmmK 4eSQ== X-Gm-Message-State: AOAM531h1xRB7IDyhKZ9mZhu3FbhbsAcoHlxYwVPtduuoCEhSUQkLPsl GbGc0F40szsIjIgM4DmHCLIwmJQ8S5o= X-Google-Smtp-Source: ABdhPJzPVk+mmkRmV+KhYSAQjQ0tX1mNBJvKWKLmLRuSv/nmo2LpYxp2oWDRo959fbOqhda0hfvaaQ== X-Received: by 2002:a05:620a:1a97:: with SMTP id bl23mr12276965qkb.621.1642344197731; Sun, 16 Jan 2022 06:43:17 -0800 (PST) Received: from andrews-mbp.lan (pool-173-56-75-166.nycmny.fios.verizon.net. [173.56.75.166]) by smtp.gmail.com with ESMTPSA id u9sm7688982qkp.116.2022.01.16.06.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 06:43:17 -0800 (PST) From: Andrew Hyatt In-Reply-To: <835yqkyqzw.fsf@gnu.org> References: <835yqkyqzw.fsf@gnu.org> Date: Sun, 16 Jan 2022 09:43:16 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jan 16, 2022 at 11:22 AM Eli Zaretskii wrote: >> From: Andrew Hyatt Date: Sun, 16 Jan 2022 >> 00:13:26 -0500 I noticed a bug recently where if I scale up >> fonts in an org capture buffer, it affects the original >> buffer, which keeps getting bigger and bigger every time >> org-capture is run. However, you don't need org to reproduce >> this. Here's a quick way to reproduce, which works with emacs >> -Q: (require 'face-remap) (defun ash/big-font () >> "Creates a font that is big enough for about 20 lines of >> text." (interactive) (let ((text-scale-mode-amount (/ >> (frame-height) 20))) >> (text-scale-mode 1))) >> >> (defun ash/reproduce-with-indirect-buffer () >> (interactive) (let ((buf (get-buffer-create "*Orig >> buffer*"))) >> (set-buffer buf) (variable-pitch-mode 1) ;; same way org >> mode creates indirect buffer (set-buffer >> (make-indirect-buffer buf "*Indirect buffer*" 'clone)) >> (ash/big-font-new) (kill-buffer (current-buffer)))) >> Running ash/reproduce-with-indirect-buffer will increase the >> indirect buffer in size each time. If you look at >> face-remapping-alist, it's clear that the original buffer's >> value is being altered by the indirect buffer. > > I don't think I understand what I should see and pay attention > to with this recipe (and it includes several errors that took me > some time to fix, before I could run it), but isn't this because > you used non-nil CLONE argument to make-indirect-buffer? Sorry for any errors, I simplified it a bit before I sent it out and perhaps made a few mistakes. What you should see, if you go the *Orig Buffer*, is that the font scale keeps increasing. If you look at the face-remapping-alist of that buffer, it will be growing with duplicate height specs, one for every time you called the ash/reproduce-with-indirect-buffer. Yes, the non-nil CLONE argument is essential to reproduce. But that just means the indirect buffer will inherit the state from the direct buffer. It doesn't imply that changes made to the indirect buffer's state will affect the original buffer, which is what is happening here. From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 15:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andrew Hyatt , Stefan Monnier Cc: 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164234527630545 (code B ref 53294); Sun, 16 Jan 2022 15:02:02 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 15:01:16 +0000 Received: from localhost ([127.0.0.1]:44058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n971v-0007wa-Er for submit@debbugs.gnu.org; Sun, 16 Jan 2022 10:01:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n971g-0007vj-30 for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 10:01:14 -0500 Received: from [2001:470:142:3::e] (port=48818 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n971a-0003um-0w; Sun, 16 Jan 2022 10:00:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SHCHWeUStCmaLHVs2exUY+dQTKin+j1Ut/ORsryhIBo=; b=VadM/ToSJFe6 R9F201W9zfWaZi/K5Sz+uxUE7T0xOqQDHjWEbPTyaD0mxb39iVoAtzq96zYBZL3TTXG4rNKQMVucK kI873oOFER/VUNfxkjXiUyK76hgsQDVK2OwigFqfZ9wWSvGC+722p3zW1MDOo399UfKe6xW1e9eo8 jK0swxHbp5VULp08UTTZVe/7NwoYlDD5VGlNvu0/oQojHmXzDC6VYZYFD4ncl89iUNYCCSiSNDhlQ +24hXVn+NfeMVe27I5CLxh024sGWpQFgVn9Php+i6ErTOYKANi69u+ms2y7gG/bkvy/nzbw6uz0Jy no4YpUR2+MmnZv+lgH1UKQ==; Received: from [87.69.77.57] (port=1982 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n971X-0006vU-Gs; Sun, 16 Jan 2022 10:00:52 -0500 Date: Sun, 16 Jan 2022 17:00:38 +0200 Message-Id: <83lezfybc9.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Andrew Hyatt on Sun, 16 Jan 2022 09:43:16 -0500) References: <835yqkyqzw.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew Hyatt > Cc: 53294@debbugs.gnu.org > Date: Sun, 16 Jan 2022 09:43:16 -0500 > > Yes, the non-nil CLONE argument is essential to reproduce. But > that just means the indirect buffer will inherit the state from > the direct buffer. It doesn't imply that changes made to the > indirect buffer's state will affect the original buffer, which is > what is happening here. But "inheriting" the state means the indirect buffer gets the copy of the variables of the original buffer, and that is not a deep copy, AFAIU. Stefan, any comments on this issue? From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Stefan Monnier Cc: 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.1642346929673 (code B ref 53294); Sun, 16 Jan 2022 15:29:01 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 15:28:49 +0000 Received: from localhost ([127.0.0.1]:44069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n97Sb-0000An-KG for submit@debbugs.gnu.org; Sun, 16 Jan 2022 10:28:49 -0500 Received: from mail-qv1-f48.google.com ([209.85.219.48]:36475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n97SZ-0000Aa-Cu for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 10:28:47 -0500 Received: by mail-qv1-f48.google.com with SMTP id c2so6081775qvw.3 for <53294@debbugs.gnu.org>; Sun, 16 Jan 2022 07:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=S6uA7uUREWXz8k+8v3MqeHNVRdBkf+3CwQm66IVZMzw=; b=lR6JPC207eVPk7rINd2ciMAoY/lUO6mq4jzeWC5WyiG6Gzp0ba6nyuXuS/3c4GJ2tb 5eBLd3orvOE/yKgmYIXYRFsXPGSlQuvpeAlyhzk93DBS2q4xjeqPx6ciSAJvBSxxKZn8 eJE71jQk8nEz3f14SQQv2yFkTLcQrLNdPmp6PNtOl+Br+jmQ3Be3HdvYg0K99n9dI1Ob UDgDwXJUt3LekokakYNnevn/8E6iZdtk14S22EHYx4hoSuEDXgPSnW0XtGiBMSqDyeT4 eJZhHsYkYf1RS/qSepWP9jtCLOwmTWlGFZyuri13fu6zppSc8pcGkz6lgDUKCZxJ1SjS 146g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=S6uA7uUREWXz8k+8v3MqeHNVRdBkf+3CwQm66IVZMzw=; b=A2QAhhyEvcy6fVpMmCeRNlO+pYjFqeS1C5YJxsk3T40rjJ/Ab15bXv1rZ91QlIhqxp 5lT54g1sQhhI4N0vv42rkYNGRenSIf6WksL6qGOzakSu5RMHJTAAHBwGx0sWHDjJotbU b54FQY4TqrMCobvf0iLCAaECvftdPHq9g+wiJriK7GWOIBAqFcoKa1A1fSTsh4tNbtUr IkBYW6mDh35mEB8k1YYm0rvyEcLpaXA7s+NN7OFS9iOZkkscSRlFpXq7dOnfUeeuHOga 2UbpFoUMkLpsh8ksXpKwmv5xl2yZBk4iuYJQV3p79cGrcfLc+yoFhg6DC3r/9OIhnGQ2 1UsQ== X-Gm-Message-State: AOAM533Mm0DsPtH2W3uBBb190pRPbxJqNVRif1rsKhSB7IopHIWUFE4P GvSfK+aH97D7FFnHK/PDgOgfGaHUBfs= X-Google-Smtp-Source: ABdhPJwi9qqwvF+gJ0rzqikH1GANyLMdUv7nx6CW/Q4R8mLTRq2wDeEJLY6hg0Ko10TEOKgpIylm3g== X-Received: by 2002:a05:6214:2489:: with SMTP id gi9mr5841915qvb.114.1642346921350; Sun, 16 Jan 2022 07:28:41 -0800 (PST) Received: from andrews-mbp.lan (pool-173-56-75-166.nycmny.fios.verizon.net. [173.56.75.166]) by smtp.gmail.com with ESMTPSA id z20sm367796qtj.66.2022.01.16.07.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 07:28:40 -0800 (PST) From: Andrew Hyatt In-Reply-To: <83lezfybc9.fsf@gnu.org> References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> Date: Sun, 16 Jan 2022 10:28:40 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jan 16, 2022 at 05:00 PM Eli Zaretskii wrote: >> From: Andrew Hyatt Cc: 53294@debbugs.gnu.org >> Date: Sun, 16 Jan 2022 09:43:16 -0500 Yes, the non-nil CLONE >> argument is essential to reproduce. But that just means the >> indirect buffer will inherit the state from the direct buffer. >> It doesn't imply that changes made to the indirect buffer's >> state will affect the original buffer, which is what is >> happening here. > > But "inheriting" the state means the indirect buffer gets the > copy of the variables of the original buffer, and that is not a > deep copy, AFAIU. > > Stefan, any comments on this issue? Sorry, I may have been unclear. I'm not disagreeing - what you just said is correct. But, because of that, it's a bug for code to make an indirect buffer, then perform operations on it via setcdr or setf like things, which then will affect the original buffer's variables. Alternatively, it'd perhaps would be a better fix to make the indirect buffer's copy a deep copy instead of the shallow copy it is now, so that these situations don't arise. I don't have a patch for that, though, but could create one if you thought it was a good idea. From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 15:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andrew Hyatt Cc: 53294@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.16423477341955 (code B ref 53294); Sun, 16 Jan 2022 15:43:01 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 15:42:14 +0000 Received: from localhost ([127.0.0.1]:44079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n97fa-0000VT-66 for submit@debbugs.gnu.org; Sun, 16 Jan 2022 10:42:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n97fX-0000V9-Qn for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 10:42:12 -0500 Received: from [2001:470:142:3::e] (port=49348 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n97fS-0006jd-B9; Sun, 16 Jan 2022 10:42:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BMSZxhnd7gFP8lqv+5DvEiYCbJ0jlK43oLMb/sqNasI=; b=RNp2rAwjLzf4 1DdKZ3i2ieTdjqJ9XZ0alTvtONRJ7iuko3PfA8t5mYwVDXEDmxSSKLom9+i25RLIyb/7ZijLjEg3L Afw92qQ1VgOcNeXAnI6pV5539Vx75aLXG5D48hpeSaKkS1uMtOTYspJuRsu5gNgq6CpgF9Czz0EBo +aSLjAyUK+XyTZhNl0cLDL4QQSEAcNEGOu2V870a1JEMwMBNbAjy3jEMvB6J5CAfavtF+kB5IHeda qFniDX0Hx5f9I8JBD0osIupWyMY+0J16NkExjICrt7V9W8TShuSDHSv2nRXOrUbYdPCo9/lZdPXmg WeWGxiklUP+HhA0IdkIW+w==; Received: from [87.69.77.57] (port=4502 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n97fS-0007cn-AA; Sun, 16 Jan 2022 10:42:06 -0500 Date: Sun, 16 Jan 2022 17:41:53 +0200 Message-Id: <83ilujy9fi.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Andrew Hyatt on Sun, 16 Jan 2022 10:28:40 -0500) References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrew Hyatt > Cc: 53294@debbugs.gnu.org > Date: Sun, 16 Jan 2022 10:28:40 -0500 > > > But "inheriting" the state means the indirect buffer gets the > > copy of the variables of the original buffer, and that is not a > > deep copy, AFAIU. > > > > Stefan, any comments on this issue? > > Sorry, I may have been unclear. I'm not disagreeing - what you > just said is correct. But, because of that, it's a bug for code to > make an indirect buffer, then perform operations on it via setcdr > or setf like things, which then will affect the original buffer's > variables. I'm not sure it's a bug. It could be a "feature", not limited to face-remapping-alist, but instead affecting every buffer-local variable that is not a simple scalar. From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Andrew Hyatt , 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164235311010536 (code B ref 53294); Sun, 16 Jan 2022 17:12:02 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 17:11:50 +0000 Received: from localhost ([127.0.0.1]:44162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n994I-0002js-2d for submit@debbugs.gnu.org; Sun, 16 Jan 2022 12:11:50 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n994G-0002jf-FK for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 12:11:49 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D2083440C30; Sun, 16 Jan 2022 12:11:42 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 61551440C17; Sun, 16 Jan 2022 12:11:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642353101; bh=+N7erWjziUCdz4XWPdWES5Hp6R4fhUWRXobHLDSsuOw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bKatno6hWkjS4I7A43OME3/OY6F5tEfb5LPfYD2UshDhHKHztAW1U5CW3QtZjE/s6 iHoPZhuISvRnxAGBrtddEB9rjKPZ0xwPFCKhARUZYXaqlwbVpNDsl4Ysk7PBF9QPxI c2Xqg8gIG+3LZKs2pfkDo0nBmzn3OUzb0T50wGxqWhW7fFO05eJRlfrCHbUSoLAIKg 4SyWurYpNdz7m5jihgG3IDrxy2GIKHzcoGs1JzMJTQoJCNjtW42pHCRg7Le15IBou+ 61hJBh2Au4A26Z8SAYnWcV20SSZ9nwpOjvKB2ifTE5elQ69+kQms0wXXjDpG3TH/N/ DDKIQIHEyJ1BA== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 283C91207C9; Sun, 16 Jan 2022 12:11:41 -0500 (EST) From: Stefan Monnier Message-ID: References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> Date: Sun, 16 Jan 2022 12:11:39 -0500 In-Reply-To: <83ilujy9fi.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Jan 2022 17:41:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.536 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > But "inheriting" the state means the indirect buffer gets the >> > copy of the variables of the original buffer, and that is not a >> > deep copy, AFAIU. >> > Stefan, any comments on this issue? >> Sorry, I may have been unclear. I'm not disagreeing - what you >> just said is correct. But, because of that, it's a bug for code to >> make an indirect buffer, then perform operations on it via setcdr >> or setf like things, which then will affect the original buffer's >> variables. > I'm not sure it's a bug. It could be a "feature", not limited to > face-remapping-alist, but instead affecting every buffer-local > variable that is not a simple scalar. `make-indirect-buffer` can't do the right thing, indeed, because different variables need different handling. `clone-buffer` tries to handle these issues by relying on `clone-buffer-hook` to handle the various variables on a case-by-case basis, but `make-indirect-buffer` doesn't come with such a hook. Some ways we can fix this: - In `face-remap.el`, refrain from modifying the `face-remapping-alist` by side-effects (i.e. avoid `delq`, `setcdr`, and friends). - Add a `make-indirect-buffer-hook` and arrange for `face-remap.el` to add a function there that does a deep enough copy of `face-remapping-alist`. - Remember that indirect buffers are an attractive nuisance and should be deprecated (but note that I suspect the same bug affects `clone-buffer` because it doesn't make a deep enough copy of `face-remapping-alist` either). Stefan From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: ahyatt@gmail.com, 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164235699030607 (code B ref 53294); Sun, 16 Jan 2022 18:17:02 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 18:16:30 +0000 Received: from localhost ([127.0.0.1]:44239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9A4r-0007xL-Ut for submit@debbugs.gnu.org; Sun, 16 Jan 2022 13:16:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9A4p-0007rZ-PL for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 13:16:28 -0500 Received: from [2001:470:142:3::e] (port=51700 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9A4f-0006U3-Q2; Sun, 16 Jan 2022 13:16:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sIpZeMmGtXC4pdLTQN5y2F5t8lKRgzIQ+m0Di1I7tP4=; b=e5l3XDLsXVae 2Svye6n16ZtzINCxMNqbILX8vxspvVWDgUZVNQuYh8SFjwOgUnp1wz6pkoB1nwMKmvmcIavMzhTkY s6fTVd2bv4tJi402n4vfR3R6d0Zr6+AL2JhsP4cJdmeqkt8hUinmKQR+b4GpXgi9WRR+eG+kx6NGA ly1sdwM1Kl3syfODlvxypK0tS+4WgppxsKt66MnovZP9ZjcQLxoo4HE2xBW16ldJCYWHhN7XM7my7 Wm73084Deec0dHahgv+RoWQX6tZymta/+hqAwX9QptDB/9o1TqcmRpRHzeGEtbRMHBqjeaM/jxE8P wL+nhNdegFCfRZAtkTg11A==; Received: from [87.69.77.57] (port=2055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9A4f-0003nE-Nx; Sun, 16 Jan 2022 13:16:18 -0500 Date: Sun, 16 Jan 2022 20:16:06 +0200 Message-Id: <837dazy2ah.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Sun, 16 Jan 2022 12:11:39 -0500) References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Andrew Hyatt , 53294@debbugs.gnu.org > Date: Sun, 16 Jan 2022 12:11:39 -0500 > > Some ways we can fix this: > > - In `face-remap.el`, refrain from modifying the `face-remapping-alist` > by side-effects (i.e. avoid `delq`, `setcdr`, and friends). > > - Add a `make-indirect-buffer-hook` and arrange for `face-remap.el` to > add a function there that does a deep enough copy of > `face-remapping-alist`. > > - Remember that indirect buffers are an attractive nuisance and should > be deprecated (but note that I suspect the same bug affects > `clone-buffer` because it doesn't make a deep enough copy of > `face-remapping-alist` either). The last one tells me we are better with leaving this sleeping dog lie. From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Stefan Monnier Cc: 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.16423693145889 (code B ref 53294); Sun, 16 Jan 2022 21:42:02 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Jan 2022 21:41:54 +0000 Received: from localhost ([127.0.0.1]:44366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DHe-0001Wq-9Q for submit@debbugs.gnu.org; Sun, 16 Jan 2022 16:41:54 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:46028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DHc-0001Wa-08 for 53294@debbugs.gnu.org; Sun, 16 Jan 2022 16:41:52 -0500 Received: by mail-qk1-f175.google.com with SMTP id d11so4197455qkj.12 for <53294@debbugs.gnu.org>; Sun, 16 Jan 2022 13:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=EOPNKa/bf7FIjypBrvvWSP6JndN5+lSbNDfNAuBfVF8=; b=cpjSLD4fPmgYVYS+07L28GhevMgx7eJSH9VmekQ+DFA+rJlskqXKNcvutJlVgF9wWM b/2SNcW/cQ0HkjfWsgZroLveuGEqTks7XvWUC5KCdc7+Scb2888F/YGrc1MPxjOST/F2 WnEcgon/UEYzgx2/7TUdmBe+kLeqJpW00ysTefNa3mvbBYmPX2jLyBzxbh03dpOUaZAj CTXj6YZal3mDvc93tnkEJHTZWg5VmagVb32uVnh58TJHGSRfAamW/YtcOl5VylJiGiNI eyZiHxPj+MQFW+4jm+iRZxCClX4FEgev/L8iGg0yMKjytIKxKbypwI79zrPk7AIMnPHL S5gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=EOPNKa/bf7FIjypBrvvWSP6JndN5+lSbNDfNAuBfVF8=; b=BRmec3p4ykjNBl0kRbT/HchNnUR6pRjq6DG0b9sMxogaGagET5BIQm+OqwstgXT0Y2 Xufjduqu99oqGXxBMN929dwFVYrbXAsXumxpx48yMFP8b3PTtmJMvOyKzNBw/6uo9Jtd 8S/bmupg217yzz2jv2gSMEn+C4cTYenV662e9CkcMw/dr+5vMkJ7hAPOhbB/vbUHo1Kl 7qaq8M0b+0Ov4WDztFVB7i6kJVW+2M3siG4Tv/cOoPWtjcX4FvhHeHn5m0xrFTp2iaWY dIVb94LmOuHqbsUd8Np633qsglakcTwY5CP1Vf0FIrG3NwJjspaXROz1As/+FRsJveIl bO4g== X-Gm-Message-State: AOAM530xQk3JHQFOvdvCxCVEzi16D7zA3kPstzb5bi4djy7S4X52UA+S BJ2UKgQ2C2jaRcve7FjQIVWl0/xcXWg= X-Google-Smtp-Source: ABdhPJzubTVSozb3mmIx/ggMagWU2FRCfodBQ8orYn5kdPdcG5Y50vmGgHkcjg+h5KSYT4tBjCUMlg== X-Received: by 2002:a05:620a:22c4:: with SMTP id o4mr906772qki.534.1642369305985; Sun, 16 Jan 2022 13:41:45 -0800 (PST) Received: from andrews-mbp.lan (pool-173-56-75-166.nycmny.fios.verizon.net. [173.56.75.166]) by smtp.gmail.com with ESMTPSA id j9sm7630763qkp.111.2022.01.16.13.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 13:41:45 -0800 (PST) From: Andrew Hyatt In-Reply-To: <837dazy2ah.fsf@gnu.org> References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> Date: Sun, 16 Jan 2022 16:41:44 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jan 16, 2022 at 08:16 PM Eli Zaretskii wrote: >> From: Stefan Monnier Cc: Andrew >> Hyatt , 53294@debbugs.gnu.org Date: Sun, 16 >> Jan 2022 12:11:39 -0500 Some ways we can fix this: - In >> `face-remap.el`, refrain from modifying the >> `face-remapping-alist` >> by side-effects (i.e. avoid `delq`, `setcdr`, and friends). >> - Add a `make-indirect-buffer-hook` and arrange for >> `face-remap.el` to >> add a function there that does a deep enough copy of >> `face-remapping-alist`. >> - Remember that indirect buffers are an attractive nuisance >> and should >> be deprecated (but note that I suspect the same bug affects >> `clone-buffer` because it doesn't make a deep enough copy of >> `face-remapping-alist` either). > > The last one tells me we are better with leaving this sleeping > dog lie. I agree the use of indirect buffers is problematic, but this problem actually results in user-visible bugs. Anyone who likes their org-mode buffer to be variable-pitch, and likes their capture buffer to be in a larger font (both pretty reasonable things), will run into this problem. My patch fixes this in a way whose only downside is that it would be less efficient notably when you have a lot of face-remappings. But it's not clear to me that face-remapping-alist ever gets so big or is changed so often that this would be a problem. The only other option is to fix this in org-mode, but they are cloning their indirect buffer presumably so that the capture buffer looks and behaves like the parent buffer, which is reasonable. I'd have to break that, or maybe just add a hack to deep copy face-remapping-alist. Both options seem a bit wrong. From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jan 2022 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: ahyatt@gmail.com, 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164245604229403 (code B ref 53294); Mon, 17 Jan 2022 21:48:01 +0000 Received: (at 53294) by debbugs.gnu.org; 17 Jan 2022 21:47:22 +0000 Received: from localhost ([127.0.0.1]:48347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ZqU-0007eB-Gq for submit@debbugs.gnu.org; Mon, 17 Jan 2022 16:47:22 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ZqO-0007ds-9j for 53294@debbugs.gnu.org; Mon, 17 Jan 2022 16:47:20 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B826A4424D2; Mon, 17 Jan 2022 16:47:10 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 46DC74424CC; Mon, 17 Jan 2022 16:47:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642456029; bh=bMQIjQndQarwrbKJI3LWE3axHMq826VqGXxn+cXDGV4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iw83NEHlwsIdq8S/fwnqBDDb1ayMYAepwbs9o+P2u2rvg5Xcqk0vzr5euiLODneKB 4XjAUg8YIQeQBEJ1SIJsxoPeZA8ZJf2h2Po0DkS3dcEpPZ4jPOxkpi33QEJb0lIMSc Yig9OvspcqJsYaSGJ45vZJ0aC2BhRNJbRuPixmOWlJjFHZdEcdKz4ijhPIw57JANfs saJuOxtIwmQInaBpV6FhVkrkA5wMFch4JPSuP/O8M/E9WaziKoAJzDhnWUrqETNvvq NIupIw0OuimU0B+h333qf2LXb8HjG0VJpxtHonLmmgAzhdSdvx/curSmP3qytygFjt Vt2xix44SPz/Q== Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3B1DC1202BE; Mon, 17 Jan 2022 16:47:09 -0500 (EST) From: Stefan Monnier Message-ID: References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> Date: Mon, 17 Jan 2022 16:47:08 -0500 In-Reply-To: <837dazy2ah.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Jan 2022 20:16:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.201 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - In `face-remap.el`, refrain from modifying the `face-remapping-alist` >> by side-effects (i.e. avoid `delq`, `setcdr`, and friends). >> >> - Add a `make-indirect-buffer-hook` and arrange for `face-remap.el` to >> add a function there that does a deep enough copy of >> `face-remapping-alist`. >> >> - Remember that indirect buffers are an attractive nuisance and should >> be deprecated (but note that I suspect the same bug affects >> `clone-buffer` because it doesn't make a deep enough copy of >> `face-remapping-alist` either). > > The last one tells me we are better with leaving this sleeping dog > lie. Actually, looking back at the code, I see we already have the needed hook (tho called from `clone-indirect-buffer`), so I think the better option is to change `make-indirect-buffer` so it runs `clone-indirect-buffer-hook` (when called with a non-nil `clone` arg) instead of having `clone-indirect-buffer` run it. And then in `face-remap.el` add a function to that hook which copies `face-remapping-alist`. An intermediate option is to change the Org code to use `clone-indirect-buffer` instead of `make-indirect-buffer` (but that still requires the `face-remap.el` addition to the hook). [ Sorry Andrew for not noticing your earlier patch which does something similar to my first suggestion above. ] Andrew, would you be willing to write that patch? Stefan From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jan 2022 02:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , Eli Zaretskii Cc: 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164247267622809 (code B ref 53294); Tue, 18 Jan 2022 02:25:01 +0000 Received: (at 53294) by debbugs.gnu.org; 18 Jan 2022 02:24:36 +0000 Received: from localhost ([127.0.0.1]:48484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9eAm-0005vp-4Y for submit@debbugs.gnu.org; Mon, 17 Jan 2022 21:24:36 -0500 Received: from mail-qv1-f53.google.com ([209.85.219.53]:39842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9eAj-0005va-VW for 53294@debbugs.gnu.org; Mon, 17 Jan 2022 21:24:34 -0500 Received: by mail-qv1-f53.google.com with SMTP id k4so165332qvt.6 for <53294@debbugs.gnu.org>; Mon, 17 Jan 2022 18:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=M5s21t4/PHTUbG1Ud4W80VK7uVsxezG4fr6e6f8mm8I=; b=P/JH2+Q+HPTdPE2Uxhqo2F0owJHrzCkzU5356QKtLcf6oEBHD0Bc9RbK86RBbfjHEj IzYcDS4NQVD57ZTDP3FajdJEIMuh58EWd1nRznBWMVgFhRqF6GkIn5RjLJHzTeTx+2zT 2MWwP++6hR4ItaTo+MkimexcIPIpnvUJY/7kV28iAZvLgxYbRmzO0J+P0A+Kr64Ol6D/ XUk2sS5IZYylhfKlsPJhCvl7IKhof5V0g8dpy68FU7LR0pDBzgsaUwS2A/wwkCT/nnjJ 9hHL+xRc1J9iWs9RYY0WZwtUoNdDJ5JS1aKakF9O3MYgfbJdRdntrb2ubdyT8SnSrt4B htvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=M5s21t4/PHTUbG1Ud4W80VK7uVsxezG4fr6e6f8mm8I=; b=5JemRH/SpdaqNXr0azgUmowiaYdqdqfMbamKaVgfmA3N0ipnBHtfnb3H07ts5v6fcy Ytz6yATyT6k/DAUgbBi//Ymxf8otzdL5Duac9bpYFOplynO5MZKGgf7fTiGyGMaP78lR 4NaQYibEGHzkyNWDcFNFh2vgji34XdzNZcOofg0n7d74V4PisNyWA6ER1eKBE6CgdqxQ oOGpyYDkNbeAk9lCNHt/TQwey7n31doAG5SZf/T9hNf8Jnovd6y0LbSpL8JW++yR8Sxz 7YCplg2pLZWjNXNWbww2yWWGugCyznlpB0i5OZkQTqpuhdsLb7bntpV/HZtg1w9iydWO AFBA== X-Gm-Message-State: AOAM531wajxSc+YnSqevOKBoCpZZ4QSBXlrbNyHmHxOkKe2eMtYXnc9r YijnJ0cJ66HlNHqrwMupYnyhBndhhiE= X-Google-Smtp-Source: ABdhPJxE3nZOg+V/UARTY0aJbUwBWTYy/6ujukYCaaSVq1rqKpaNysAkdgnsYNsTaxE2VddEm/6qhA== X-Received: by 2002:ad4:5ba4:: with SMTP id 4mr21223650qvq.39.1642472666046; Mon, 17 Jan 2022 18:24:26 -0800 (PST) Received: from andrews-mbp.lan (pool-173-56-75-166.nycmny.fios.verizon.net. [173.56.75.166]) by smtp.gmail.com with ESMTPSA id l22sm9242268qtj.68.2022.01.17.18.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jan 2022 18:24:24 -0800 (PST) From: Andrew Hyatt In-Reply-To: References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> Date: Mon, 17 Jan 2022 21:24:24 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed On Mon, Jan 17, 2022 at 04:47 PM Stefan Monnier wrote: >>> - In `face-remap.el`, refrain from modifying the >>> `face-remapping-alist` >>> by side-effects (i.e. avoid `delq`, `setcdr`, and friends). >>> - Add a `make-indirect-buffer-hook` and arrange for >>> `face-remap.el` to >>> add a function there that does a deep enough copy of >>> `face-remapping-alist`. >>> - Remember that indirect buffers are an attractive nuisance >>> and should >>> be deprecated (but note that I suspect the same bug affects >>> `clone-buffer` because it doesn't make a deep enough copy of >>> `face-remapping-alist` either). >> >> The last one tells me we are better with leaving this sleeping >> dog lie. > > Actually, looking back at the code, I see we already have the > needed hook (tho called from `clone-indirect-buffer`), so I > think the better option is to change `make-indirect-buffer` so > it runs `clone-indirect-buffer-hook` (when called with a non-nil > `clone` arg) instead of having `clone-indirect-buffer` run it. > And then in `face-remap.el` add a function to that hook which > copies `face-remapping-alist`. > > An intermediate option is to change the Org code to use > `clone-indirect-buffer` instead of `make-indirect-buffer` (but > that still requires the `face-remap.el` addition to the hook). > > [ Sorry Andrew for not noticing your earlier patch which does > something > similar to my first suggestion above. ] > > Andrew, would you be willing to write that patch? > > Stefan That sounds reasonable, I can do that. In fact, I just did this based on your suggestions, and it does work well. The only weird thing is that I had to pull `clone-indirect-buffer-hook' into the c code, because that's where `make-indirect-buffer' is. Let me know if that seems wrong. I've attached the patch, please let me know if there is an issue. I have commit access, so I can just commit it myself after your OK (if so, I'll wait for a week or so to see if Eli has a comment as well before checkin). --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=text-scale-patch-v2 Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZmFjZS1yZW1hcC5lbCBiL2xpc3AvZmFjZS1yZW1hcC5lbAppbmRl eCAwMDU2MGY5ZDJlLi5mYzBlZGI3MTE5IDEwMDY0NAotLS0gYS9saXNwL2ZhY2UtcmVtYXAuZWwK KysrIGIvbGlzcC9mYWNlLXJlbWFwLmVsCkBAIC03MCw2ICs3MCwxNCBAQCBpbnRlcm5hbC1saXNw LWZhY2UtYXR0cmlidXRlcwogICAgOmZvcmVncm91bmQgOmJhY2tncm91bmQgOnN0aXBwbGUgOm92 ZXJsaW5lIDpzdHJpa2UtdGhyb3VnaCA6Ym94CiAgICA6Zm9udCA6aW5oZXJpdCA6Zm9udHNldCA6 ZGlzdGFudC1mb3JlZ3JvdW5kIDpleHRlbmQgOnZlY3Rvcl0pCiAKKyhkZWZ1biBmYWNlLWF0dHJz LS1tYWtlLWluZGlyZWN0LXNhZmUgKCkKKyAgIkRvIGEgZGVlcCBjb3B5IG9mIGBmYWNlLXJlbWFw cGluZy1hbGlzdCcgdG8ga2VlcCB0aGUgb3JpZ2luYWwgYnVmZmVyIHNhZmUuIgorICAoc2V0cS1s b2NhbCBmYWNlLXJlbWFwcGluZy1hbGlzdAorICAgICAgICAgICAgICAoY29weS10cmVlCisgICAg ICAgICAgICAgICAoYnVmZmVyLWxvY2FsLXZhbHVlICdmYWNlLXJlbWFwcGluZy1hbGlzdCAoYnVm ZmVyLWJhc2UtYnVmZmVyKSkpKSkKKworKGFkZC1ob29rICdjbG9uZS1pbmRpcmVjdC1idWZmZXIt aG9vayAjJ2ZhY2UtYXR0cnMtLW1ha2UtaW5kaXJlY3Qtc2FmZSkKKwogKGRlZnVuIGZhY2UtYXR0 cnMtbW9yZS1yZWxhdGl2ZS1wIChhdHRyczEgYXR0cnMyKQogICAiUmV0dXJuIHRydWUgaWYgQVRU UlMxIGNvbnRhaW5zIGEgZ3JlYXRlciBudW1iZXIgb2YgcmVsYXRpdmUKIGZhY2UtYXR0cmlidXRl cyB0aGFuIEFUVFJTMi4gIEEgZmFjZSBhdHRyaWJ1dGUgaXMgY29uc2lkZXJlZApkaWZmIC0tZ2l0 IGEvbGlzcC9zaW1wbGUuZWwgYi9saXNwL3NpbXBsZS5lbAppbmRleCBjYmNkZTlmYjhkLi4zZWY5 Y2NhMjQ5IDEwMDY0NAotLS0gYS9saXNwL3NpbXBsZS5lbAorKysgYi9saXNwL3NpbXBsZS5lbApA QCAtOTQ0MSw5ICs5NDQxLDYgQEAgZnVuY3Rpb24ta2V5LW1hcAogKGRlZnZhciBjbG9uZS1idWZm ZXItaG9vayBuaWwKICAgIk5vcm1hbCBob29rIHRvIHJ1biBpbiB0aGUgbmV3IGJ1ZmZlciBhdCB0 aGUgZW5kIG9mIGBjbG9uZS1idWZmZXInLiIpCiAKLShkZWZ2YXIgY2xvbmUtaW5kaXJlY3QtYnVm ZmVyLWhvb2sgbmlsCi0gICJOb3JtYWwgaG9vayB0byBydW4gaW4gdGhlIG5ldyBidWZmZXIgYXQg dGhlIGVuZCBvZiBgY2xvbmUtaW5kaXJlY3QtYnVmZmVyJy4iKQotCiAoZGVmdW4gY2xvbmUtcHJv Y2VzcyAocHJvY2VzcyAmb3B0aW9uYWwgbmV3bmFtZSkKICAgIkNyZWF0ZSBhIHR3aW4gY29weSBv ZiBQUk9DRVNTLgogSWYgTkVXTkFNRSBpcyBuaWwsIGl0IGRlZmF1bHRzIHRvIFBST0NFU1MnIG5h bWU7CmRpZmYgLS1naXQgYS9zcmMvYnVmZmVyLmMgYi9zcmMvYnVmZmVyLmMKaW5kZXggMTBhYzkx OTE1Yy4uMDA2NDZmODc3OSAxMDA2NDQKLS0tIGEvc3JjL2J1ZmZlci5jCisrKyBiL3NyYy9idWZm ZXIuYwpAQCAtOTEyLDYgKzkxMiwxMCBAQCBERUZVTiAoIm1ha2UtaW5kaXJlY3QtYnVmZmVyIiwg Rm1ha2VfaW5kaXJlY3RfYnVmZmVyLCBTbWFrZV9pbmRpcmVjdF9idWZmZXIsCiAgICAgICBGc2V0 IChpbnRlcm4gKCJidWZmZXItc2F2ZS13aXRob3V0LXF1ZXJ5IiksIFFuaWwpOwogICAgICAgRnNl dCAoaW50ZXJuICgiYnVmZmVyLWZpbGUtbnVtYmVyIiksIFFuaWwpOwogICAgICAgRnNldCAoaW50 ZXJuICgiYnVmZmVyLXN0YWxlLWZ1bmN0aW9uIiksIFFuaWwpOworICAgICAgLyogQ2xvbmVkIGJ1 ZmZlcnMgbmVlZCBleHRyYSBzZXR1cCwgdG8gZG8gdGhpbmdzIHN1Y2ggYXMgZGVlcAorCSB2YXJp YWJsZSBjb3BpZXMgZm9yIGxpc3QgdmFyaWFibGVzIHRoYXQgbWlnaHQgYmUgbWFuZ2xlZCBkdWUK KwkgdG8gZGVzdHJ1Y3RpdmUgb3BlcmF0aW9ucyBpbiB0aGUgaW5kaXJlY3QgYnVmZmVyLiAqLwor ICAgICAgc2FmZV9ydW5faG9va3MgKFFjbG9uZV9pbmRpcmVjdF9idWZmZXJfaG9vayk7CiAgICAg ICBzZXRfYnVmZmVyX2ludGVybmFsXzEgKG9sZF9iKTsKICAgICB9CiAKQEAgLTU1NjgsNiArNTU3 Miw5IEBAIHN5bXNfb2ZfYnVmZmVyICh2b2lkKQogCXB1cmVfbGlzdCAoUXByb3RlY3RlZF9maWVs ZCwgUWVycm9yKSk7CiAgIEZwdXQgKFFwcm90ZWN0ZWRfZmllbGQsIFFlcnJvcl9tZXNzYWdlLAog CWJ1aWxkX3B1cmVfY19zdHJpbmcgKCJBdHRlbXB0IHRvIG1vZGlmeSBhIHByb3RlY3RlZCBmaWVs ZCIpKTsKKyAgCisgIERFRlNZTSAoUWNsb25lX2luZGlyZWN0X2J1ZmZlcl9ob29rLCAiY2xvbmUt aW5kaXJlY3QtYnVmZmVyLWhvb2siKTsKKyAKIAogICBERUZWQVJfUEVSX0JVRkZFUiAoInRhYi1s aW5lLWZvcm1hdCIsCiAJCSAgICAgJkJWQVIgKGN1cnJlbnRfYnVmZmVyLCB0YWJfbGluZV9mb3Jt YXQpLApAQCAtNjM5Miw2ICs2Mzk5LDEwIEBAIEZ1bmN0aW9ucyAoaW1wbGljaXRseSkgcnVubmlu ZyB0aGlzIGhvb2sgYXJlIGBnZXQtYnVmZmVyLWNyZWF0ZScsCiBUaGlzIGlzIHRoZSBkZWZhdWx0 LiAgSWYgbmlsLCBhdXRvLXNhdmUgZmlsZSBkZWxldGlvbiBpcyBpbmhpYml0ZWQuICAqLyk7CiAg IGRlbGV0ZV9hdXRvX3NhdmVfZmlsZXMgPSAxOwogCisgIERFRlZBUl9MSVNQICgiY2xvbmUtaW5k aXJlY3QtYnVmZmVyLWhvb2siLCBWY2xvbmVfaW5kaXJlY3RfYnVmZmVyX2hvb2ssCisJICAgICAg IGRvYzogLyogTm9ybWFsIGhvb2sgdG8gcnVuIGluIHRoZSBuZXcgYnVmZmVyIGF0IHRoZSBlbmQg b2YgYGNsb25lLWluZGlyZWN0LWJ1ZmZlcicuICovKTsKKyAgVmNsb25lX2luZGlyZWN0X2J1ZmZl cl9ob29rID0gUW5pbDsKKwogICBkZWZzdWJyICgmU2J1ZmZlcl9saXZlX3ApOwogICBkZWZzdWJy ICgmU2J1ZmZlcl9saXN0KTsKICAgZGVmc3ViciAoJlNnZXRfYnVmZmVyKTsK --=-=-=-- From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jan 2022 02:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andrew Hyatt Cc: Eli Zaretskii , 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164247406125046 (code B ref 53294); Tue, 18 Jan 2022 02:48:01 +0000 Received: (at 53294) by debbugs.gnu.org; 18 Jan 2022 02:47:41 +0000 Received: from localhost ([127.0.0.1]:48508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9eX6-0006Vs-Sb for submit@debbugs.gnu.org; Mon, 17 Jan 2022 21:47:41 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9eX5-0006V8-3P for 53294@debbugs.gnu.org; Mon, 17 Jan 2022 21:47:39 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1C2614424F6; Mon, 17 Jan 2022 21:47:33 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A5BCD4406DB; Mon, 17 Jan 2022 21:47:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642474051; bh=M/J1Z8YMQ6xMAqi8rbxCm833t5G6SgSitPWZzqLCGjg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eCZGfMyDgsof9bYSdHwHa6Sz5j/+nT82mnfubR/kj1IBrOLecTc5QWqf2zuH/6QgK GaaBV8fLDXzi/86aBDlMfLD9+VYf5aO2gdY8ed751GT3vW8TRWpWMFNTlJX9n8HNzz uTsfEiRolW2onOg32zFb+zxNpzTDo2o2bB/Q/Ojyta06/c06rOkfrKxuLFQPKryysR ZHK5K+nLCWBn/MUJnQG6/PyH/dsun3c8Phq8Wt1n2gM1F/iYPEN7tiNqnI/cyEN0zo 2EGB2dPgIefJFis3uYCDwotzGDpLjI22ZrXIiVsxulZZDSbQjbmE+HY71MWmlIUPgo hLO29E4scrvlA== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7769D12023B; Mon, 17 Jan 2022 21:47:31 -0500 (EST) From: Stefan Monnier Message-ID: References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> Date: Mon, 17 Jan 2022 21:47:30 -0500 In-Reply-To: (Andrew Hyatt's message of "Mon, 17 Jan 2022 21:24:24 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.528 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > That sounds reasonable, I can do that. In fact, I just did this based on > your suggestions, and it does work well. The only weird thing is that I had > to pull `clone-indirect-buffer-hook' into the c code, because that's where > `make-indirect-buffer' is. You could leave the `defvar` in Lisp and only pull the DEFSYM, but yes, you need to pull at least part of it into C. > Let me know if that seems wrong. Nope. > I've attached the patch, please let me know if there is an issue. I have > commit access, so I can just commit it myself after your OK (if so, I'll > wait for a week or so to see if Eli has a comment as well before checkin). Comments below, thanks, Stefan > diff --git a/lisp/face-remap.el b/lisp/face-remap.el > index 00560f9d2e..fc0edb7119 100644 > --- a/lisp/face-remap.el > +++ b/lisp/face-remap.el > @@ -70,6 +70,14 @@ internal-lisp-face-attributes > :foreground :background :stipple :overline :strike-through :box > :font :inherit :fontset :distant-foreground :extend :vector]) > > +(defun face-attrs--make-indirect-safe () > + "Do a deep copy of `face-remapping-alist' to keep the original buffer safe." > + (setq-local face-remapping-alist > + (copy-tree > + (buffer-local-value 'face-remapping-alist (buffer-base-buffer))))) I think `mapcar #'copy-sequence` is slightly more correct than `copy-tree`, and you shouldn't need (buffer-local-value 'face-remapping-alist (buffer-base-buffer)) because that buffer's value should already have been copied to the current buffer. > @@ -912,6 +912,10 @@ DEFUN ("make-indirect-buffer", Fmake_indirect_buffer, Smake_indirect_buffer, > Fset (intern ("buffer-save-without-query"), Qnil); > Fset (intern ("buffer-file-number"), Qnil); > Fset (intern ("buffer-stale-function"), Qnil); > + /* Cloned buffers need extra setup, to do things such as deep > + variable copies for list variables that might be mangled due > + to destructive operations in the indirect buffer. */ > + safe_run_hooks (Qclone_indirect_buffer_hook); I think you want to use just `run_hook` here because there's no need to catch errors. More importantly, you need to remove the corresponding `run-hook` from `clone-indirect-buffer`. Stefan From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jan 2022 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.16425598916384 (code B ref 53294); Wed, 19 Jan 2022 02:39:02 +0000 Received: (at 53294) by debbugs.gnu.org; 19 Jan 2022 02:38:11 +0000 Received: from localhost ([127.0.0.1]:52042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA0rT-0001es-6D for submit@debbugs.gnu.org; Tue, 18 Jan 2022 21:38:11 -0500 Received: from mail-qv1-f45.google.com ([209.85.219.45]:44595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA0rP-0001eO-FR for 53294@debbugs.gnu.org; Tue, 18 Jan 2022 21:38:10 -0500 Received: by mail-qv1-f45.google.com with SMTP id bc19so668676qvb.11 for <53294@debbugs.gnu.org>; Tue, 18 Jan 2022 18:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Jxyb8e6xHydaD8SkCxNXaAcUk1Xo3PyLVXaGdz1L6uM=; b=VEGNtsTrGiWnz8o00oidLNXllq8/JuzDYJEKbR07FJXkxGBw367cqSlBiomLf2IZ9m dLn9oCaoiyoLq4yDPawBi/nWD5NozlIrmAthaP7l2c+zCoSyE54fuDyM80TpOnDNmJPN s//MsnDGnN+n7gH16Q7SP+oNgYe+vatOnPjNLq2zuQp0M4Mq0GuLxUrltEdORK7hfTQk LXClsyON4IE/OWjl3s/r6ZbOk5YxKjPdtCnWl5GJe6vmrJ5pjQgC8gspxBKnCCIDJFj4 5DeerdWBESDYPFE03JQn1YZfcOCTcHEwG8Z/TxqXE2gez9filE2MGx184MOG0SESZ8Ag BBkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Jxyb8e6xHydaD8SkCxNXaAcUk1Xo3PyLVXaGdz1L6uM=; b=7ivjWbbKo0dhGEjCD/bGqJ2SaFcxiUazwe9YNXIQCb5Po+1TCEL854Oi2wkt2oGxNC rrJD6rFpL2nmRQ8xLZi8hsMPpAZZFwNvZ+0xLE8sv43bgwfjHY0ELDAsCr1aoaXD4bqi Ummdrbeei0k/5mjLnPDKdAJgvQwqhbsT5uNwertLzI2sKVP8jy7s12wkIql/wrn9VbTZ xOlaj5j4lqK2sRCveqO0FyES3uEGgfY91SVQgaa+tmg4GFyF2lV/Y1PMeDfN4jvFnv/j 1s0u/I7xVNY8pcwC7+2JwcaRzBqwmRXQgPMNR8PlElmjalpu5RSPE9VuQEDYLVL7ISWZ 5Pjg== X-Gm-Message-State: AOAM53214Gzdv9fOzufLDU+Eb/D7zOuOMRGd8n325PUQ7FxQCJ5rqg9S DJaN6jGpFcm1vWDim8gKb/Awl9/TUSw= X-Google-Smtp-Source: ABdhPJxumwBO8HG3kN5/D8E6q5OzVyjhTrJdqYYKK5U4j/PqZU+FvytWWIlKwKhX3H/m0uyAushQtg== X-Received: by 2002:a05:6214:2a4d:: with SMTP id jf13mr25729378qvb.28.1642559881229; Tue, 18 Jan 2022 18:38:01 -0800 (PST) Received: from andrews-mbp.lan (pool-173-56-75-166.nycmny.fios.verizon.net. [173.56.75.166]) by smtp.gmail.com with ESMTPSA id u17sm11521208qko.133.2022.01.18.18.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 18:37:59 -0800 (PST) From: Andrew Hyatt In-Reply-To: References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> Date: Tue, 18 Jan 2022 21:37:59 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed On Mon, Jan 17, 2022 at 09:47 PM Stefan Monnier wrote: >> That sounds reasonable, I can do that. In fact, I just did this >> based on your suggestions, and it does work well. The only >> weird thing is that I had to pull `clone-indirect-buffer-hook' >> into the c code, because that's where `make-indirect-buffer' >> is. > > You could leave the `defvar` in Lisp and only pull the DEFSYM, > but yes, you need to pull at least part of it into C. > >> Let me know if that seems wrong. > > Nope. > >> I've attached the patch, please let me know if there is an >> issue. I have commit access, so I can just commit it myself >> after your OK (if so, I'll wait for a week or so to see if Eli >> has a comment as well before checkin). > > Comments below, thanks, > > Stefan > >> diff --git a/lisp/face-remap.el b/lisp/face-remap.el index >> 00560f9d2e..fc0edb7119 100644 --- a/lisp/face-remap.el +++ >> b/lisp/face-remap.el @@ -70,6 +70,14 @@ >> internal-lisp-face-attributes >> :foreground :background :stipple :overline :strike-through >> :box :font :inherit :fontset :distant-foreground :extend >> :vector]) >> >> +(defun face-attrs--make-indirect-safe () + "Do a deep copy of >> `face-remapping-alist' to keep the original buffer safe." + >> (setq-local face-remapping-alist + (copy-tree + >> (buffer-local-value 'face-remapping-alist >> (buffer-base-buffer))))) > > I think `mapcar #'copy-sequence` is slightly more correct than > `copy-tree`, and you shouldn't need (buffer-local-value > 'face-remapping-alist (buffer-base-buffer)) because that > buffer's value should already have been copied to the current > buffer. > >> @@ -912,6 +912,10 @@ DEFUN ("make-indirect-buffer", >> Fmake_indirect_buffer, Smake_indirect_buffer, >> Fset (intern ("buffer-save-without-query"), Qnil); Fset >> (intern ("buffer-file-number"), Qnil); Fset (intern >> ("buffer-stale-function"), Qnil); >> + /* Cloned buffers need extra setup, to do things such as >> deep + variable copies for list variables that might be >> mangled due + to destructive operations in the indirect >> buffer. */ + safe_run_hooks (Qclone_indirect_buffer_hook); > > I think you want to use just `run_hook` here because there's no > need to catch errors. > > More importantly, you need to remove the corresponding > `run-hook` from `clone-indirect-buffer`. > > Stefan Makes sense, thanks for the suggestions. I've included the revised patch. --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=text-scale-patch-v3 Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZmFjZS1yZW1hcC5lbCBiL2xpc3AvZmFjZS1yZW1hcC5lbAppbmRl eCAwMDU2MGY5ZDJlLi45NWRmZmNhZGQ2IDEwMDY0NAotLS0gYS9saXNwL2ZhY2UtcmVtYXAuZWwK KysrIGIvbGlzcC9mYWNlLXJlbWFwLmVsCkBAIC03MCw2ICs3MCwxMyBAQCBpbnRlcm5hbC1saXNw LWZhY2UtYXR0cmlidXRlcwogICAgOmZvcmVncm91bmQgOmJhY2tncm91bmQgOnN0aXBwbGUgOm92 ZXJsaW5lIDpzdHJpa2UtdGhyb3VnaCA6Ym94CiAgICA6Zm9udCA6aW5oZXJpdCA6Zm9udHNldCA6 ZGlzdGFudC1mb3JlZ3JvdW5kIDpleHRlbmQgOnZlY3Rvcl0pCiAKKyhkZWZ1biBmYWNlLWF0dHJz LS1tYWtlLWluZGlyZWN0LXNhZmUgKCkKKyAgIkRlZXAgY29weSBgZmFjZS1yZW1hcHBpbmctYWxp c3QnIG9uIGNsb25pbmcgZm9yIHNhZmV0eS4iCisgIChzZXRxLWxvY2FsIGZhY2UtcmVtYXBwaW5n LWFsaXN0CisgICAgICAgICAgICAgIChtYXBjYXIgIydjb3B5LXNlcXVlbmNlIGZhY2UtcmVtYXBw aW5nLWFsaXN0KSkpCisKKyhhZGQtaG9vayAnY2xvbmUtaW5kaXJlY3QtYnVmZmVyLWhvb2sgIydm YWNlLWF0dHJzLS1tYWtlLWluZGlyZWN0LXNhZmUpCisKIChkZWZ1biBmYWNlLWF0dHJzLW1vcmUt cmVsYXRpdmUtcCAoYXR0cnMxIGF0dHJzMikKICAgIlJldHVybiB0cnVlIGlmIEFUVFJTMSBjb250 YWlucyBhIGdyZWF0ZXIgbnVtYmVyIG9mIHJlbGF0aXZlCiBmYWNlLWF0dHJpYnV0ZXMgdGhhbiBB VFRSUzIuICBBIGZhY2UgYXR0cmlidXRlIGlzIGNvbnNpZGVyZWQKZGlmZiAtLWdpdCBhL2xpc3Av c2ltcGxlLmVsIGIvbGlzcC9zaW1wbGUuZWwKaW5kZXggY2JjZGU5ZmI4ZC4uOGQwNTIwZDY2MyAx MDA2NDQKLS0tIGEvbGlzcC9zaW1wbGUuZWwKKysrIGIvbGlzcC9zaW1wbGUuZWwKQEAgLTk0NDEs OSArOTQ0MSw2IEBAIGZ1bmN0aW9uLWtleS1tYXAKIChkZWZ2YXIgY2xvbmUtYnVmZmVyLWhvb2sg bmlsCiAgICJOb3JtYWwgaG9vayB0byBydW4gaW4gdGhlIG5ldyBidWZmZXIgYXQgdGhlIGVuZCBv ZiBgY2xvbmUtYnVmZmVyJy4iKQogCi0oZGVmdmFyIGNsb25lLWluZGlyZWN0LWJ1ZmZlci1ob29r IG5pbAotICAiTm9ybWFsIGhvb2sgdG8gcnVuIGluIHRoZSBuZXcgYnVmZmVyIGF0IHRoZSBlbmQg b2YgYGNsb25lLWluZGlyZWN0LWJ1ZmZlcicuIikKLQogKGRlZnVuIGNsb25lLXByb2Nlc3MgKHBy b2Nlc3MgJm9wdGlvbmFsIG5ld25hbWUpCiAgICJDcmVhdGUgYSB0d2luIGNvcHkgb2YgUFJPQ0VT Uy4KIElmIE5FV05BTUUgaXMgbmlsLCBpdCBkZWZhdWx0cyB0byBQUk9DRVNTJyBuYW1lOwpAQCAt OTU5Niw4ICs5NTkzLDYgQEAgY2xvbmUtaW5kaXJlY3QtYnVmZmVyCiAgICAgICAoc2V0cSBuZXdu YW1lIChzdWJzdHJpbmcgbmV3bmFtZSAwIChtYXRjaC1iZWdpbm5pbmcgMCkpKSkKICAgKGxldCog KChuYW1lIChnZW5lcmF0ZS1uZXctYnVmZmVyLW5hbWUgbmV3bmFtZSkpCiAJIChidWZmZXIgKG1h a2UtaW5kaXJlY3QtYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikgbmFtZSB0KSkpCi0gICAgKHdpdGgt Y3VycmVudC1idWZmZXIgYnVmZmVyCi0gICAgICAocnVuLWhvb2tzICdjbG9uZS1pbmRpcmVjdC1i dWZmZXItaG9vaykpCiAgICAgKHdoZW4gZGlzcGxheS1mbGFnCiAgICAgICAocG9wLXRvLWJ1ZmZl ciBidWZmZXIgbmlsIG5vcmVjb3JkKSkKICAgICBidWZmZXIpKQpkaWZmIC0tZ2l0IGEvc3JjL2J1 ZmZlci5jIGIvc3JjL2J1ZmZlci5jCmluZGV4IDEwYWM5MTkxNWMuLjNiMTdkNmM5Y2UgMTAwNjQ0 Ci0tLSBhL3NyYy9idWZmZXIuYworKysgYi9zcmMvYnVmZmVyLmMKQEAgLTkxMiw2ICs5MTIsMTAg QEAgREVGVU4gKCJtYWtlLWluZGlyZWN0LWJ1ZmZlciIsIEZtYWtlX2luZGlyZWN0X2J1ZmZlciwg U21ha2VfaW5kaXJlY3RfYnVmZmVyLAogICAgICAgRnNldCAoaW50ZXJuICgiYnVmZmVyLXNhdmUt d2l0aG91dC1xdWVyeSIpLCBRbmlsKTsKICAgICAgIEZzZXQgKGludGVybiAoImJ1ZmZlci1maWxl LW51bWJlciIpLCBRbmlsKTsKICAgICAgIEZzZXQgKGludGVybiAoImJ1ZmZlci1zdGFsZS1mdW5j dGlvbiIpLCBRbmlsKTsKKyAgICAgIC8qIENsb25lZCBidWZmZXJzIG5lZWQgZXh0cmEgc2V0dXAs IHRvIGRvIHRoaW5ncyBzdWNoIGFzIGRlZXAKKwkgdmFyaWFibGUgY29waWVzIGZvciBsaXN0IHZh cmlhYmxlcyB0aGF0IG1pZ2h0IGJlIG1hbmdsZWQgZHVlCisJIHRvIGRlc3RydWN0aXZlIG9wZXJh dGlvbnMgaW4gdGhlIGluZGlyZWN0IGJ1ZmZlci4gKi8KKyAgICAgIHJ1bl9ob29rIChRY2xvbmVf aW5kaXJlY3RfYnVmZmVyX2hvb2spOwogICAgICAgc2V0X2J1ZmZlcl9pbnRlcm5hbF8xIChvbGRf Yik7CiAgICAgfQogCkBAIC01NTY5LDYgKzU1NzMsOSBAQCBzeW1zX29mX2J1ZmZlciAodm9pZCkK ICAgRnB1dCAoUXByb3RlY3RlZF9maWVsZCwgUWVycm9yX21lc3NhZ2UsCiAJYnVpbGRfcHVyZV9j X3N0cmluZyAoIkF0dGVtcHQgdG8gbW9kaWZ5IGEgcHJvdGVjdGVkIGZpZWxkIikpOwogCisgIERF RlNZTSAoUWNsb25lX2luZGlyZWN0X2J1ZmZlcl9ob29rLCAiY2xvbmUtaW5kaXJlY3QtYnVmZmVy LWhvb2siKTsKKworCiAgIERFRlZBUl9QRVJfQlVGRkVSICgidGFiLWxpbmUtZm9ybWF0IiwKIAkJ ICAgICAmQlZBUiAoY3VycmVudF9idWZmZXIsIHRhYl9saW5lX2Zvcm1hdCksCiAJCSAgICAgUW5p bCwKQEAgLTYzOTIsNiArNjM5OSwxMCBAQCBGdW5jdGlvbnMgKGltcGxpY2l0bHkpIHJ1bm5pbmcg dGhpcyBob29rIGFyZSBgZ2V0LWJ1ZmZlci1jcmVhdGUnLAogVGhpcyBpcyB0aGUgZGVmYXVsdC4g IElmIG5pbCwgYXV0by1zYXZlIGZpbGUgZGVsZXRpb24gaXMgaW5oaWJpdGVkLiAgKi8pOwogICBk ZWxldGVfYXV0b19zYXZlX2ZpbGVzID0gMTsKIAorICBERUZWQVJfTElTUCAoImNsb25lLWluZGly ZWN0LWJ1ZmZlci1ob29rIiwgVmNsb25lX2luZGlyZWN0X2J1ZmZlcl9ob29rLAorCSAgICAgICBk b2M6IC8qIE5vcm1hbCBob29rIHRvIHJ1biBpbiB0aGUgbmV3IGJ1ZmZlciBhdCB0aGUgZW5kIG9m IGBjbG9uZS1pbmRpcmVjdC1idWZmZXInLiAqLyk7CisgIFZjbG9uZV9pbmRpcmVjdF9idWZmZXJf aG9vayA9IFFuaWw7CisKICAgZGVmc3ViciAoJlNidWZmZXJfbGl2ZV9wKTsKICAgZGVmc3ViciAo JlNidWZmZXJfbGlzdCk7CiAgIGRlZnN1YnIgKCZTZ2V0X2J1ZmZlcik7Cg== --=-=-=-- From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jan 2022 03:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andrew Hyatt Cc: Eli Zaretskii , 53294@debbugs.gnu.org Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164256374112842 (code B ref 53294); Wed, 19 Jan 2022 03:43:01 +0000 Received: (at 53294) by debbugs.gnu.org; 19 Jan 2022 03:42:21 +0000 Received: from localhost ([127.0.0.1]:52079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA1rZ-0003L4-MH for submit@debbugs.gnu.org; Tue, 18 Jan 2022 22:42:21 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA1rW-0003Kn-3R for 53294@debbugs.gnu.org; Tue, 18 Jan 2022 22:42:20 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id ACD6C10012B; Tue, 18 Jan 2022 22:42:11 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 89D8F100084; Tue, 18 Jan 2022 22:42:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642563730; bh=7NIYilqQH+w8OiZ1/jlA4AhVt0RO7OcjOOeVR7U93xc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WTbw0FmrNG4qOv5FDUWLUs7hF7D8THS0vrrSQiNpa5OL01zk70JZKGoMdv1Cyqr2k v53zZoqjAen7rloy+0RRyOBk7kwqgULDC+L9BbyMb+Y60yrqer7USdGVTtFMPpFHM3 yzNZYdEglxmvUS3upYQwnf94jHvPTISCjuVYVXurrfOnRDLtsdVk/B4TcIU4O1TKNj OafmorDimr2/Hk3MK4s8c0iC7oiIJAKqpfGjtFZQeJl4CkEDjIxi+ZhO+gIgsx6zlq +NQo0q+rCTZZxF9KVeJyoxy7u/oeAJCP9a8MfHBJ7TZIq3f5qsG5Ov3SvX/kVfucQz V47mTDOoBnzOA== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 502F31205E6; Tue, 18 Jan 2022 22:42:10 -0500 (EST) From: Stefan Monnier Message-ID: References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> Date: Tue, 18 Jan 2022 22:42:08 -0500 In-Reply-To: (Andrew Hyatt's message of "Tue, 18 Jan 2022 21:37:59 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Makes sense, thanks for the suggestions. I've included the revised patch. Looks good to me, thanks, Stefan From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jan 2022 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Andrew Hyatt , 53294@debbugs.gnu.org, Eli Zaretskii Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164268617631113 (code B ref 53294); Thu, 20 Jan 2022 13:43:02 +0000 Received: (at 53294) by debbugs.gnu.org; 20 Jan 2022 13:42:56 +0000 Received: from localhost ([127.0.0.1]:56840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAXiK-00085l-Ir for submit@debbugs.gnu.org; Thu, 20 Jan 2022 08:42:56 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAXiJ-00085V-AV for 53294@debbugs.gnu.org; Thu, 20 Jan 2022 08:42:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t4YyfeFGr0XY8LvQmQbDpFpvuOeo4ztb107+IT/bYEM=; b=u1G+AofKSAx3XkIv6dt5mXBTFu RfIz+XnmurcOQ+o9oF8RzUAUKvdmTV4P8Pwwr/TM1f1IGho4O2FcR7WU+iNYMnUUquOeAidXMx5A3 7h3PvwrXwGfq7ZVCnje1Xf3buAOzQW5EpbZI98/YjgUG1rsA4fIq/PPeBOEKoO4nNESk=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAXi9-0006An-OS; Thu, 20 Jan 2022 14:42:48 +0100 From: Lars Ingebrigtsen References: <835yqkyqzw.fsf@gnu.org> <83lezfybc9.fsf@gnu.org> <83ilujy9fi.fsf@gnu.org> <837dazy2ah.fsf@gnu.org> X-Now-Playing: Various's _ZUSHI_: "14" Date: Thu, 20 Jan 2022 14:42:45 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 18 Jan 2022 22:42:08 -0500") Message-ID: <87pmomzfoq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> Makes sense, thanks for the suggestions. I've included the revised patch. > > Looks good to me, thanks, So I've pushed the patch to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> Makes sense, thanks for the suggestions. I've included the revised patch. > > Looks good to me, thanks, So I've pushed the patch to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 08:43:02 2022 Received: (at control) by debbugs.gnu.org; 20 Jan 2022 13:43:02 +0000 Received: from localhost ([127.0.0.1]:56843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAXiP-000863-Pj for submit@debbugs.gnu.org; Thu, 20 Jan 2022 08:43:02 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAXiN-00085d-Qc for control@debbugs.gnu.org; Thu, 20 Jan 2022 08:43:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dHC8IX9HW73UbW18wSpuGHnNM/VKhn4doUkwMQEQ4iM=; b=h8kiCncv0HTzKgj71ycEKxx0VJ a3vpKcuFulIZnJLizBDu71bnzYzXA7Av9glbb4qYZbgy9lvuZP9nd5Tle9VQc2w5M/BPPIYE117ko LhxdDU6l0c3svUFX6Y4am+ffBHIk9N3fpclwb/WzXrM4AHmoROJqwP0dD0I5qahRHgF0=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAXiG-0006Au-01 for control@debbugs.gnu.org; Thu, 20 Jan 2022 14:42:54 +0100 Date: Thu, 20 Jan 2022 14:42:51 +0100 Message-Id: <87o846zfok.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53294 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 53294 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 53294 29.1 quit From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer References: In-Reply-To: Resent-From: Anders Johansson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Feb 2022 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen , Stefan Monnier , Andrew Hyatt , 53294@debbugs.gnu.org, Eli Zaretskii Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164503329417299 (code B ref 53294); Wed, 16 Feb 2022 17:42:02 +0000 Received: (at 53294) by debbugs.gnu.org; 16 Feb 2022 17:41:34 +0000 Received: from localhost ([127.0.0.1]:49382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKOJ4-0004Ux-Aa for submit@debbugs.gnu.org; Wed, 16 Feb 2022 12:41:34 -0500 Received: from mail-lf1-f45.google.com ([209.85.167.45]:34390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKOJ2-0004Uk-NT for 53294@debbugs.gnu.org; Wed, 16 Feb 2022 12:41:33 -0500 Received: by mail-lf1-f45.google.com with SMTP id o2so5271818lfd.1 for <53294@debbugs.gnu.org>; Wed, 16 Feb 2022 09:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=nbtuS0h8iV8d8QVP12QZtJ5s1+eXOXjE1II2BehJ3Fw=; b=X7q318c3Kc9+i45Z4Al1pYQ/8C0S3OJLNlhgmoLwJM6IFXNYIAOdA+7gj2+RthfRuX FJBq+x+p2ev4KBPoKAJQ44n+GAmSkaHR5z+ZFd2ukaIrHGyz3eysRI1Ti4lHMnCi0Ymi VQ+He0P0YL6W1M9BOliOzGFziy/75h6CNCEw5T5jjAb2ZKsSQVYYFL61P2ZnzovtBgR8 xRYwzPH7D6yU9+nrTYaYxDo0KYcNFcGaLX8Pv2waLdTshABXIbIa+5ulDmopaHW6/vLt JQqcmullIB+jhc4e3YwU9nkW7AwdmG9nM5crh1hJJ5L1SQfYFAqR2EP9U7fGslMzkKCl 4Qig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=nbtuS0h8iV8d8QVP12QZtJ5s1+eXOXjE1II2BehJ3Fw=; b=kpGcdvW0K2zYQDKEpCX8zqByMMRPgkT/Gk2CRqdxMxExkRTvY/cXMKjinQcfxZeHJT ++n4NCXP0e8r/RM04RjgbQatN/w3j61PD1mLz9KmCwykkgrTq78vEgEjEsWTvUy6lBxm o5B1dls9vTPY/2O2HVL4plfva62E/ZLTFr7yQ7z/aJTBO5RgOd7nr00IiEyGwR8E+Xxf nA5E8S6MygZ3A2SeeJ8+vkU+B9Ax5RW9G3r6xo7ln0DFBvaRKbSmeUYcyJh/NPrCzoWQ weowIUMSnGxHK1mZfVZGN3j+9YEPwjkywHVXuTv8ldrX2P9RT5xEnuSepfj1F8WBSt1a Kr9A== X-Gm-Message-State: AOAM531Neby0DspwOAJJckV10oB1127g+hesUoapbO5eCS0OXiuGurIV 3hXV7uVTl5sHlv7AxvlyaFEYznGMT2LBp1ZpBLg= X-Google-Smtp-Source: ABdhPJxzRvG2EwVJsfTv45HbbhCY609fzMuOFi6yU67VD6LG5sNPXdEzlFlw/PwMjMrZfQRZ/PEG5taYQ6E/6/TA1Rs= X-Received: by 2002:ac2:5c48:0:b0:442:eada:dc45 with SMTP id s8-20020ac25c48000000b00442eadadc45mr2697665lfp.640.1645033286196; Wed, 16 Feb 2022 09:41:26 -0800 (PST) MIME-Version: 1.0 From: Anders Johansson Date: Wed, 16 Feb 2022 18:41:15 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Stefan wrote: > I think `mapcar #'copy-sequence` is slightly more correct than > `copy-tree`, This gives me "Wrong type argument: listp, mini-modeline-mode-line-active" For a face-remapping-alist that looks like: ((mode-line-active . mini-modeline-mode-line-active) (mode-line-inactive . mini-modeline-mode-line-inactive)) According to my reading of the docstring of face-remapping-alist, this should be allowed, and does work (except for indirect buffers perhaps) face-remap-add-relative would generate: ((mode-line-active mini-modeline-mode-line-active) (mode-line-inactive mini-modeline-mode-line-inactive)) mini-modeline (https://github.com/kiennq/emacs-mini-modeline/) sets face-remapping-alist directly for various reasons. I guess this is not really recommended. But this fix seems to cause problems in an otherwise "correct" use of face-remapping-alist. Best, Anders Johansson From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Feb 2022 11:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Anders Johansson Cc: Andrew Hyatt , 53294@debbugs.gnu.org, Stefan Monnier , Eli Zaretskii Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164509807620808 (code B ref 53294); Thu, 17 Feb 2022 11:42:01 +0000 Received: (at 53294) by debbugs.gnu.org; 17 Feb 2022 11:41:16 +0000 Received: from localhost ([127.0.0.1]:50320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKf9w-0005PY-Il for submit@debbugs.gnu.org; Thu, 17 Feb 2022 06:41:16 -0500 Received: from quimby.gnus.org ([95.216.78.240]:39318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKf9u-0005PJ-Ty for 53294@debbugs.gnu.org; Thu, 17 Feb 2022 06:41:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w5+FZE4Hu8/xGAu7S9Vm/qBaKu3BaVa53cIAeFReiCQ=; b=p54JF9lx2iHRz6o5qCDsmVYQqW hGkiOgaIPre088zc907r8xTZzKSsn9KOpA1LoKHJIDnS9vikiJapMuKmgxFEPzhbg3d0Q4NMGnFEH WAmJo77PFpREJTb/SHsSXYfTF4j+TtJwj/+2I2yEf+XTiAkUfo9/FQ9BJVDvna5rBcc4=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKf9k-0006en-4y; Thu, 17 Feb 2022 12:41:07 +0100 From: Lars Ingebrigtsen References: X-Now-Playing: Cat Power's _Covers_: "Pa Pa Power" Date: Thu, 17 Feb 2022 12:41:03 +0100 In-Reply-To: (Anders Johansson's message of "Wed, 16 Feb 2022 18:41:15 +0100") Message-ID: <87h78xn2k0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Anders Johansson writes: > This gives me "Wrong type argument: listp, mini-modeline-mode-line-active" > For a face-remapping-alist that looks like: > ((mode-line-active . mini-modeline-mode-line-active) > (mode-line-inactive [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Anders Johansson writes: > This gives me "Wrong type argument: listp, mini-modeline-mode-line-active" > For a face-remapping-alist that looks like: > ((mode-line-active . mini-modeline-mode-line-active) > (mode-line-inactive . mini-modeline-mode-line-inactive)) Do you have a recipe to reproduce the problem, starting from "emacs -Q"? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 00:12:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53294: 29.0.50; Indirect font changes incorrectly affecting original buffer Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Feb 2022 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Anders Johansson Cc: Lars Ingebrigtsen , 53294@debbugs.gnu.org, Andrew Hyatt , Eli Zaretskii Received: via spool by 53294-submit@debbugs.gnu.org id=B53294.164510510426224 (code B ref 53294); Thu, 17 Feb 2022 13:39:02 +0000 Received: (at 53294) by debbugs.gnu.org; 17 Feb 2022 13:38:24 +0000 Received: from localhost ([127.0.0.1]:50498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKgzH-0006ou-QQ for submit@debbugs.gnu.org; Thu, 17 Feb 2022 08:38:23 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKgzF-0006og-Vy for 53294@debbugs.gnu.org; Thu, 17 Feb 2022 08:38:22 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4854380620; Thu, 17 Feb 2022 08:38:16 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B30D6805D6; Thu, 17 Feb 2022 08:38:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1645105090; bh=xL5M7JDh2GjBrB7mAu41aqo03g58L65kaebhOX9uOaQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=C5sECpi3C40L9Zzv4WJ3YNpg2K6cbQJwkPY8ymI2NOWuJ5vgmwn4Wbx3zyCEn7b9Z DPAyZtdN1bEtU48fTt1DAzQzxX0ZgEj4mX2WaBo6K48z3z1NEwVXmzHOfUQxRViaVi 3mUl3sgkz2wcytt/YRhvQ5oOkza/lcxCnruln7vbqLLQ4it427lJhaXw6UljxeiYyy /8Cxco9FaJqMz1zKy1saxnZ2O88SiEHw7PMP+Sf/piogBoJE5IGLrqj0Ir+LN/Leo6 I83lJVQwlOp73EQ6L9DYDzKnTu53ipk23NTkhqkX3fZLW35FnVm2uoIbtPu44ALAmU 33vCsqinx2QSA== Received: from pastel (unknown [45.72.237.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 780A6120E4F; Thu, 17 Feb 2022 08:38:10 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Thu, 17 Feb 2022 08:38:08 -0500 In-Reply-To: (Anders Johansson's message of "Wed, 16 Feb 2022 18:41:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I think `mapcar #'copy-sequence` is slightly more correct than >> `copy-tree`, > > This gives me "Wrong type argument: listp, mini-modeline-mode-line-active" > For a face-remapping-alist that looks like: > ((mode-line-active . mini-modeline-mode-line-active) > (mode-line-inactive . mini-modeline-mode-line-inactive)) I pushed a patch to `master` which should fix it. Can you confirm that it fixes it for you? Stefan