From unknown Sun Jun 22 17:15:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 04:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 53293@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16423058362246 (code B ref -1); Sun, 16 Jan 2022 04:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jan 2022 04:03:56 +0000 Received: from localhost ([127.0.0.1]:42291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8wlo-0000a9-0a for submit@debbugs.gnu.org; Sat, 15 Jan 2022 23:03:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:55322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8wlj-0000Zy-HM for submit@debbugs.gnu.org; Sat, 15 Jan 2022 23:03:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8wlj-00037y-AG for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 23:03:51 -0500 Received: from [2607:f8b0:4864:20::52e] (port=44927 helo=mail-pg1-x52e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8wlh-0003ov-GX for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 23:03:51 -0500 Received: by mail-pg1-x52e.google.com with SMTP id h23so6499949pgk.11 for ; Sat, 15 Jan 2022 20:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language; bh=5jyUfxx9YtRQ4VekxJAqks51bdq7U7YriPXg/TnAvUQ=; b=Pi8oCkVD1gJ7F22lY+A+zYQs7K/3JFaqprymchMUeGJuvx5ymzzpG9GP/2sqlMTmIN F75b/w5cPVB7ERcs40YZKAiYVq0XOEGepURVTB+EmUFiLS7WVOMdiZ3PrgDsRNWlQFT2 R7Iuuj/7eeF8nsFOB4Cf1djREYwKooew9rpRsE5VE6UQjdz5bl5X98ct2NEp/rXldbZZ ZfzNFG67R9NdtjTdRk8nNFP0QgYqoTXFly11GidAhTKb0t6/2uLPrvWaBqX6dV6YXETy LwTJ2LQga0X+TpyhtEba8HR1DnSLDx0d9DIYRrM3s4wNfsW9nu7IpA08GA0kH1JIbMyL o6lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language; bh=5jyUfxx9YtRQ4VekxJAqks51bdq7U7YriPXg/TnAvUQ=; b=Lcf2+2j0+7FcAWChLmYLwKpJm1b+ONAhuKQVbabat0BEds1OHWep8sBpXwxaT3MytH WG3iv772/2Wc50c7PPf7iI49AXIp6cnTgqpo0opahe6BnHh9K3kBRgwtdLvyY2sDuw8W 4sflD+V45f+gCq3ggjUCe25MKY09yX0PW96KF88D6/5PtaBmoZjpqU+VfGghqQV77AMw 9D7i3eZMpSq2d7xbfFZc0D6mrqUpZ7kJAo40iSoGAxMy1cdVxuNHL+XIcD83yuQ+whmw C/Ki3gq+XRIJm/FL6DZDaopWknNMJ1ifAy7c6fRK6GF/48pcCmYjLdP/aWAqkT2RY/1r D9BQ== X-Gm-Message-State: AOAM533zXtbwq5tF1iaKEEMhar2SL+W7hRHdatnk5LWKc6Z75bMMRIN8 t77GxFa4+a4mssfi5qZkRXjUbsjJ8PtNrw== X-Google-Smtp-Source: ABdhPJzxu8vgoQbCLwW74dtq0Jh90TtlHzOSz3AMqcnTbNw2zqMVf6gi7s+ytnKRqWUq19t4oxl1xQ== X-Received: by 2002:a63:3dcb:: with SMTP id k194mr13948650pga.619.1642305827747; Sat, 15 Jan 2022 20:03:47 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h4sm10034978pfi.79.2022.01.15.20.03.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jan 2022 20:03:46 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Message-ID: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> Date: Sat, 15 Jan 2022 20:03:46 -0800 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------B244AFE5FDA641F708BE78AF" Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52e (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------B244AFE5FDA641F708BE78AF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Currently, `eshell-eval-using-options' reports an error if the user passes an unrecognized option, but only if 1) the :external keyword has been set and 2) the external program can't actually be found. If you'd like to see this in action, you can run "echo -Z hi" in Eshell. It just silently discards the "-Z". Editing `eshell/echo' to include `:external "nonexist"' in its option spec instead results in an error being reported to the user. I think this might be simply an oversight in the implementation. The documentation of `eshell--process-option' states: If no matching [option] handler is found, and an :external command is defined (and available), it will be called; otherwise, an error will be triggered to say that the switch is unrecognized. I would interpret this to mean the following: (if (and (not handler-found) external-cmd-available) (call-external) (error "unrecognized option")) Attached is a patch that ensures unrecognized options report an error even when there's no :external command. This *is* a slightly incompatible change though. The following Eshell commands use `eshell-eval-using-options' with no :external command, so they'll start erroring out if you pass unrecognized arguments to them with this patch: addpath echo history source / . su sudo umask Despite this incompatibility, I still think this is the right change to make for all these commands. If a user passes unrecognized options to any of these, they should be informed of that fact. For example, `su' is used in Eshell to invoke TRAMP's su method. It would likely be an unpleasant surprise for a user if they tried to pass flags to it that only work with /bin/su, only for those options to be silently ignored. One of the nastiest parts of the pre-patch behavior is that something like "su -c CMD" simply drops the "-c", which results in CMD being treated as the USER instead. I'm not sure if this should be explicitly called out in the manual or whether it warrants a NEWS entry. To me, it just seems like a bug, and one that was already documented as working the way it does with this patch applied. That said, if others think this warrants some more documentation, I'm happy to add some. --------------B244AFE5FDA641F708BE78AF Content-Type: text/plain; charset=UTF-8; name="0001-Raise-an-error-from-eval-eval-using-options-for-unkn.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Raise-an-error-from-eval-eval-using-options-for-unkn.pa"; filename*1="tch" RnJvbSBkOTlkMGY1ZmMxNTVjNDUwYWNjOTNhNzA3OTg4OThhYTlhMTNlMGQ3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgNiBKYW4gMjAyMiAxODowNjowNiAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFJhaXNlIGFuIGVycm9yIGZyb20gJ2V2YWwtZXZhbC11c2luZy1vcHRpb25zJyBmb3Ig dW5rbm93bgogb3B0aW9ucwoKKiBsaXNwL2VzaGVsbC9lc2gtb3B0LmVsIChlc2hlbGwtLXBy b2Nlc3Mtb3B0aW9uKTogUmFpc2UgYW4gZXJyb3IgaWYKYW4gdW5rbm93biBvcHRpb24gaXMg ZW5jb3VudGVyZWQsIGV2ZW4gd2hlbiA6ZXh0ZXJuYWwgaXMgbmlsLgoqIHRlc3QvbGlzcC9l c2hlbGwvZXNoLW9wdC10ZXN0cy5lbCAoZXNoLW9wdC1wcm9jZXNzLWFyZ3MtdGVzdCkKKHRl c3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucyk6IEFkZCB0ZXN0IGNhc2VzIGZvciB0aGlz LgotLS0KIGxpc3AvZXNoZWxsL2VzaC1vcHQuZWwgICAgICAgICAgICB8IDEyICsrLS0tCiB0 ZXN0L2xpc3AvZXNoZWxsL2VzaC1vcHQtdGVzdHMuZWwgfCA4NiArKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDcwIGluc2VydGlvbnMoKyksIDI4 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1vcHQuZWwgYi9s aXNwL2VzaGVsbC9lc2gtb3B0LmVsCmluZGV4IGJiYTFjNGFkMjUuLmM4MDJiZWUzYWYgMTAw NjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1vcHQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNo LW9wdC5lbApAQCAtMjU3LDEyICsyNTcsMTIgQEAgZXNoZWxsLS1wcm9jZXNzLW9wdGlvbgog ICAgICAgICByZW1haW5pbmcKICAgICAgIChsZXQgKChleHRjbWQgKG1lbXEgJzpleHRlcm5h bCBvcHRpb25zKSkpCiAJKHdoZW4gZXh0Y21kCi0JICAoc2V0cSBleHRjbWQgKGVzaGVsbC1z ZWFyY2gtcGF0aCAoY2FkciBleHRjbWQpKSkKLQkgIChpZiBleHRjbWQKLQkgICAgICAodGhy b3cgJ2VzaGVsbC1leHQtY29tbWFuZCBleHRjbWQpCi0gICAgICAgICAgICAoZXJyb3IgKGlm IChjaGFyYWN0ZXJwIChjYXIgc3dpdGNoKSkgIiVzOiB1bnJlY29nbml6ZWQgb3B0aW9uIC0l YyIKLSAgICAgICAgICAgICAgICAgICAgICIlczogdW5yZWNvZ25pemVkIG9wdGlvbiAtLSVz IikKLSAgICAgICAgICAgICAgICAgICBuYW1lIChjYXIgc3dpdGNoKSkpKSkpKSkKKwkgIChz ZXRxIGV4dGNtZCAoZXNoZWxsLXNlYXJjaC1wYXRoIChjYWRyIGV4dGNtZCkpKSkKKwkoaWYg ZXh0Y21kCisJICAgICh0aHJvdyAnZXNoZWxsLWV4dC1jb21tYW5kIGV4dGNtZCkKKyAgICAg ICAgICAoZXJyb3IgKGlmIChjaGFyYWN0ZXJwIChjYXIgc3dpdGNoKSkgIiVzOiB1bnJlY29n bml6ZWQgb3B0aW9uIC0lYyIKKyAgICAgICAgICAgICAgICAgICAiJXM6IHVucmVjb2duaXpl ZCBvcHRpb24gLS0lcyIpCisgICAgICAgICAgICAgICAgIG5hbWUgKGNhciBzd2l0Y2gpKSkp KSkpCiAKIChkZWZ1biBlc2hlbGwtLXByb2Nlc3MtYXJncyAobmFtZSBhcmdzIG9wdGlvbnMp CiAgICJQcm9jZXNzIHRoZSBnaXZlbiBBUkdTIHVzaW5nIE9QVElPTlMuIgpkaWZmIC0tZ2l0 IGEvdGVzdC9saXNwL2VzaGVsbC9lc2gtb3B0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVs bC9lc2gtb3B0LXRlc3RzLmVsCmluZGV4IDI1NTc2ODYzNWIuLmI3NmVkODg2NmQgMTAwNjQ0 Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLW9wdC10ZXN0cy5lbAorKysgYi90ZXN0L2xp c3AvZXNoZWxsL2VzaC1vcHQtdGVzdHMuZWwKQEAgLTI3LDQxICsyNyw2MyBAQCBlc2gtb3B0 LXByb2Nlc3MtYXJncy10ZXN0CiAgIChzaG91bGQKICAgIChlcXVhbCAnKHQpCiAgICAgICAg ICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCi0gICAgICAgICAgICJzdWRvIgotICAgICAgICAg ICAnKCItYSIpCi0gICAgICAgICAgICcoKD9hICJhbGwiIG5pbCBzaG93LWFsbCAiIikpKSkp Ci0gIChzaG91bGQKLSAgIChlcXVhbCAnKG5pbCkKLSAgICAgICAgICAoZXNoZWxsLS1wcm9j ZXNzLWFyZ3MKLSAgICAgICAgICAgInN1ZG8iCi0gICAgICAgICAgICcoIi1nIikKLSAgICAg ICAgICAgJygoP2EgImFsbCIgbmlsIHNob3ctYWxsICIiKSkpKSkKKyAgICAgICAgICAgInN1 ZG8iICcoIi1hIikKKyAgICAgICAgICAgJygoP2EgImFsbCIgbmlsIHNob3ctYWxsCisgICAg ICAgICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikp KSkpCiAgIChzaG91bGQKICAgIChlcXVhbCAnKCJyb290IiAid29ybGQiKQogICAgICAgICAg IChlc2hlbGwtLXByb2Nlc3MtYXJncwotICAgICAgICAgICAic3VkbyIKLSAgICAgICAgICAg JygiLXUiICJyb290IiAid29ybGQiKQotICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2Vy ICJleGVjdXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVTRVIiKSkpKSkKKyAgICAgICAgICAg InN1ZG8iICcoIi11IiAicm9vdCIgIndvcmxkIikKKyAgICAgICAgICAgJygoP3UgInVzZXIi IHQgdXNlcgorICAgICAgICAgICAgICAgICAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhl ciBVU0VSIikpKSkpCiAgIChzaG91bGQKICAgIChlcXVhbCAnKG5pbCAiZW1lcmdlIiAiLXVE TiIgIndvcmxkIikKICAgICAgICAgICAoZXNoZWxsLS1wcm9jZXNzLWFyZ3MKLSAgICAgICAg ICAgInN1ZG8iCi0gICAgICAgICAgICcoImVtZXJnZSIgIi11RE4iICJ3b3JsZCIpCi0gICAg ICAgICAgICcoKD91ICJ1c2VyIiB0IHVzZXIgImV4ZWN1dGUgYSBjb21tYW5kIGFzIGFub3Ro ZXIgVVNFUiIpCisgICAgICAgICAgICJzdWRvIiAnKCJlbWVyZ2UiICItdUROIiAid29ybGQi KQorICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2VyCisgICAgICAgICAgICAgICAgICJl eGVjdXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVTRVIiKQogICAgICAgICAgICAgIDpwYXJz ZS1sZWFkaW5nLW9wdGlvbnMtb25seSkpKSkKICAgKHNob3VsZAogICAgKGVxdWFsICcoInJv b3QiICJlbWVyZ2UiICItdUROIiAid29ybGQiKQogICAgICAgICAgIChlc2hlbGwtLXByb2Nl c3MtYXJncwotICAgICAgICAgICAic3VkbyIKLSAgICAgICAgICAgJygiLXUiICJyb290IiAi ZW1lcmdlIiAiLXVETiIgIndvcmxkIikKLSAgICAgICAgICAgJygoP3UgInVzZXIiIHQgdXNl ciAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhlciBVU0VSIikKKyAgICAgICAgICAgInN1 ZG8iICcoIi11IiAicm9vdCIgImVtZXJnZSIgIi11RE4iICJ3b3JsZCIpCisgICAgICAgICAg ICcoKD91ICJ1c2VyIiB0IHVzZXIKKyAgICAgICAgICAgICAgICAgImV4ZWN1dGUgYSBjb21t YW5kIGFzIGFub3RoZXIgVVNFUiIpCiAgICAgICAgICAgICAgOnBhcnNlLWxlYWRpbmctb3B0 aW9ucy1vbmx5KSkpKQogICAoc2hvdWxkCiAgICAoZXF1YWwgJygiRE4iICJlbWVyZ2UiICJ3 b3JsZCIpCiAgICAgICAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCi0gICAgICAgICAgICJz dWRvIgotICAgICAgICAgICAnKCItdSIgInJvb3QiICJlbWVyZ2UiICItdUROIiAid29ybGQi KQotICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2VyICJleGVjdXRlIGEgY29tbWFuZCBh cyBhbm90aGVyIFVTRVIiKSkpKSkpCisgICAgICAgICAgICJzdWRvIiAnKCItdSIgInJvb3Qi ICJlbWVyZ2UiICItdUROIiAid29ybGQiKQorICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1 c2VyCisgICAgICAgICAgICAgICAgICJleGVjdXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVT RVIiKSkpKSkKKworICA7OyBUZXN0IDpleHRlcm5hbC4KKyAgKGNsLWxldGYgKCgoc3ltYm9s LWZ1bmN0aW9uICdlc2hlbGwtc2VhcmNoLXBhdGgpICMnaWdub3JlKSkKKyAgICAoc2hvdWxk CisgICAgIChlcXVhbCAnKG5pbCAiL3NvbWUvcGF0aCIpCisgICAgICAgICAgICAoZXNoZWxs LS1wcm9jZXNzLWFyZ3MKKyAgICAgICAgICAgICAibHMiICcoIi9zb21lL3BhdGgiKQorICAg ICAgICAgICAgICcoKD9hICJhbGwiIG5pbCBzaG93LWFsbAorICAgICAgICAgICAgICAgICAg ICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikKKyAgICAgICAgICAg ICAgIDpleHRlcm5hbCAibHMiKSkpKSkKKyAgKGNsLWxldGYgKCgoc3ltYm9sLWZ1bmN0aW9u ICdlc2hlbGwtc2VhcmNoLXBhdGgpICMnaWRlbnRpdHkpKQorICAgIChzaG91bGQKKyAgICAg KGVxdWFsICcobm8tY2F0Y2ggZXNoZWxsLWV4dC1jb21tYW5kICJscyIpCisgICAgICAgICAg ICAoc2hvdWxkLWVycm9yCisgICAgICAgICAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCisg ICAgICAgICAgICAgICJscyIgJygiLXUiICIvc29tZS9wYXRoIikKKyAgICAgICAgICAgICAg JygoP2EgImFsbCIgbmlsIHNob3ctYWxsCisgICAgICAgICAgICAgICAgICAgICJkbyBub3Qg aWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikKKyAgICAgICAgICAgICAgICA6ZXh0 ZXJuYWwgImxzIikpCisgICAgICAgICAgICAgOnR5cGUgJ25vLWNhdGNoKSkpKQorICAoY2wt bGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ2VzaGVsbC1zZWFyY2gtcGF0aCkgIydpZ25vcmUp KQorICAgIChzaG91bGQtZXJyb3IKKyAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCisgICAg ICAibHMiICcoIi11IiAiL3NvbWUvcGF0aCIpCisgICAgICAnKCg/YSAiYWxsIiBuaWwgc2hv dy1hbGwKKyAgICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0 aCAuIikKKyAgICAgICAgOmV4dGVybmFsICJscyIpKQorICAgICA6dHlwZSAnZXJyb3IpKSkK IAogKGVydC1kZWZ0ZXN0IHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucyAoKQogICAi VGVzdHMgZm9yIGBlc2hlbGwtZXZhbC11c2luZy1vcHRpb25zJy4iCkBAIC0xOTAsNyArMjEy LDI3IEBAIHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucwogICAgJygoP3UgInVzZXIi IHQgdXNlciAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhlciBVU0VSIikKICAgICAgOnBh cnNlLWxlYWRpbmctb3B0aW9ucy1vbmx5KQogICAgKHNob3VsZCAoZXEgdXNlciBuaWwpKQot ICAgKHNob3VsZCAoZXF1YWwgYXJncyAnKCJlbWVyZ2UiICItdUROIiAid29ybGQiKSkpKSkK KyAgIChzaG91bGQgKGVxdWFsIGFyZ3MgJygiZW1lcmdlIiAiLXVETiIgIndvcmxkIikpKSkK KworICA7OyBUZXN0IHVucmVjb2duaXplZCBvcHRpb25zLgorICAoc2hvdWxkLWVycm9yCisg ICAoZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucworICAgICJscyIgJygiLXUiICIvc29tZS9w YXRoIikKKyAgICAnKCg/YSAiYWxsIiBuaWwgc2hvdy1hbGwKKyAgICAgICAgICAiZG8gbm90 IGlnbm9yZSBlbnRyaWVzIHN0YXJ0aW5nIHdpdGggLiIpKQorICAgIChpZ25vcmUgc2hvdy1h bGwpKSkKKyAgKHNob3VsZC1lcnJvcgorICAgKGVzaGVsbC1ldmFsLXVzaW5nLW9wdGlvbnMK KyAgICAibHMiICcoIi1hdSIgIi9zb21lL3BhdGgiKQorICAgICcoKD9hICJhbGwiIG5pbCBz aG93LWFsbAorICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0 aCAuIikpCisgICAgKGlnbm9yZSBzaG93LWFsbCkpKQorICAoc2hvdWxkLWVycm9yCisgICAo ZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucworICAgICJscyIgJygiLS11bnJlY29nbml6ZWQi ICIvc29tZS9wYXRoIikKKyAgICAnKCg/YSAiYWxsIiBuaWwgc2hvdy1hbGwKKyAgICAgICAg ICAiZG8gbm90IGlnbm9yZSBlbnRyaWVzIHN0YXJ0aW5nIHdpdGggLiIpKQorICAgIChpZ25v cmUgc2hvdy1hbGwpKSkpCiAKIChwcm92aWRlICdlc2gtb3B0LXRlc3RzKQogCi0tIAoyLjI1 LjEKCg== --------------B244AFE5FDA641F708BE78AF-- From unknown Sun Jun 22 17:15:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 53293@debbugs.gnu.org Received: via spool by 53293-submit@debbugs.gnu.org id=B53293.16423238911280 (code B ref 53293); Sun, 16 Jan 2022 09:05:02 +0000 Received: (at 53293) by debbugs.gnu.org; 16 Jan 2022 09:04:51 +0000 Received: from localhost ([127.0.0.1]:42442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91T1-0000KZ-Kc for submit@debbugs.gnu.org; Sun, 16 Jan 2022 04:04:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91Sz-0000KM-Kl for 53293@debbugs.gnu.org; Sun, 16 Jan 2022 04:04:50 -0500 Received: from [2001:470:142:3::e] (port=44976 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91St-00068d-E0; Sun, 16 Jan 2022 04:04:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3fRGMapulYKPDSa32bH9vb9EKjQXtmy1SQ+It60PCuc=; b=oyauapgYQ+sz LP6vhVmVbeWchB77ndD+WfnT0MqTDybllUOYk8zyeUW/DuqtlYqAN7daNpROI94NKzboMSuTSWuob i4m+6brn+Rl58vuTchfAQxML4ZWgdoUDPZc8iHvLBJobC+sngthPaty/F8GS2tDArOQYSGMmdKBOy MZt07pyOEvFNbUZdiyz84lVkgnT77udAbEG+Ygk9iclnvARFC47l09CM6S7WNVytjDaGukHD1pRqd 0v1cGtuLQvLAUn0h3nMBGMmd3NMYgns/aO+r+X4toFfkXgJlbX4CUCTpz9D9FUb/EXk7AvhQpnxYi C1S2i7EwPZtnpSqxC+xvuQ==; Received: from [87.69.77.57] (port=3578 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n91St-0000gP-0N; Sun, 16 Jan 2022 04:04:43 -0500 Date: Sun, 16 Jan 2022 11:04:29 +0200 Message-Id: <838rvgyrtu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> (message from Jim Porter on Sat, 15 Jan 2022 20:03:46 -0800) References: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Date: Sat, 15 Jan 2022 20:03:46 -0800 > > Despite this incompatibility, I still think this is the right change to > make for all these commands. If a user passes unrecognized options to > any of these, they should be informed of that fact. OTOH, with the current behavior shell scripts that use options not supported by Eshell commands will silently run unaltered, wheres with your change they will error out. Do we care about this? From unknown Sun Jun 22 17:15:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 53293@debbugs.gnu.org Received: via spool by 53293-submit@debbugs.gnu.org id=B53293.164236511023288 (code B ref 53293); Sun, 16 Jan 2022 20:32:01 +0000 Received: (at 53293) by debbugs.gnu.org; 16 Jan 2022 20:31:50 +0000 Received: from localhost ([127.0.0.1]:44311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9CBo-00063V-NA for submit@debbugs.gnu.org; Sun, 16 Jan 2022 15:31:50 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:35713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9CBl-00063F-BW for 53293@debbugs.gnu.org; Sun, 16 Jan 2022 15:31:47 -0500 Received: by mail-pf1-f170.google.com with SMTP id r5so793948pfl.2 for <53293@debbugs.gnu.org>; Sun, 16 Jan 2022 12:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=DfIS5RAi0mybx9NMCOphxDUn1Nvu60D7cXcwDm3JWWM=; b=mmgvi0WbxyUxQXaaaXHTMtpkH+WN24eRnRg8lv9fPbjF+JLQarlM0TyFy0tGhqwu/d /X6EO7f2ycPL97fLWoEzAEezZeOoVsYF/PLR4t1/mqZj0VJIa7CPAUBaqE2wUqyER6Q8 aEYijOOIuGwdXamP5+5e8UeWm7q1D7OYVMTyGs5I3r7uotUMyyQH7S5JT15l67H/W/5z 30Ug/6ZPJ5zg4i5ekRrruR+T049uHPSWId9tqYcUIyIlo6Lv2mIAPrVb9RJxubL5vb8a NRlyL1xjo6pxh8QEni/4CT9ev9ny9YyeZD4KNho7f7uVNrZtwl+8e3Pv2SkbeRTMsI+i 9VqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DfIS5RAi0mybx9NMCOphxDUn1Nvu60D7cXcwDm3JWWM=; b=zj/2EzW8f2jLSsQS8TIGSk76JAIteKL0/puEvJu7ZxGREK9mWUGz7s8Nyvnf7knle1 5wojk6ukVhA/HwSaxBzRAinN0td6NlxsX+8qpzFkOob9o/ESkwYoLg8Si7m3WjIVFx5u jVllJwVYn6vhhjBwsshH5CKTxMOtlLfhOBCj+2n5ShHbgyi7Jp5TSx8Nw3RdqSfnzmVQ 45jgHxOJvaqLscIJoarzusy+Og2MK8odfMmVrxyLziRFVKZuw9ykU9fzpdoyPLbDgUQD 6D3ilDUUY7vnvMl3+qMXg6qKnwa0suHe25erg4XZRBJYSSk51/rPmHVTwktu3IozGeFH Z7/g== X-Gm-Message-State: AOAM530gsPnFPAYr9xTbjT8IFdRGndvQc5RhFLynnmL/WoqLD7yfCsCt tm1g20nKmqd4xWCDW9aRHYgJkvCc5e7bBw== X-Google-Smtp-Source: ABdhPJxcDsgbnz99wBTR6ats6YClHT/1Uoz3ze4TvjMBtkjp2Rb3M8ueK7pGHxlLw5vkiES3ZiNH5A== X-Received: by 2002:a63:ad4a:: with SMTP id y10mr16130563pgo.413.1642365098909; Sun, 16 Jan 2022 12:31:38 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a1sm12299893pfv.99.2022.01.16.12.31.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jan 2022 12:31:38 -0800 (PST) References: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> <838rvgyrtu.fsf@gnu.org> From: Jim Porter Message-ID: Date: Sun, 16 Jan 2022 12:31:37 -0800 MIME-Version: 1.0 In-Reply-To: <838rvgyrtu.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/16/2022 1:04 AM, Eli Zaretskii wrote: >> From: Jim Porter >> Date: Sat, 15 Jan 2022 20:03:46 -0800 >> >> Despite this incompatibility, I still think this is the right change to >> make for all these commands. If a user passes unrecognized options to >> any of these, they should be informed of that fact. > > OTOH, with the current behavior shell scripts that use options not > supported by Eshell commands will silently run unaltered, wheres with > your change they will error out. Do we care about this? Yeah, that's one of the tricky parts about this. On the one hand, some options (boolean flags) can be silently ignored without altering the meaning of the command *too* much; on the other hand, some options (especially those taking an argument) can't be ignored without drastically changing the meaning. The latter case comes up with commands like "su -c CMD". In a regular shell, this will run CMD as root, but in Eshell, it silently ignores the "-c", so the command looks like "su CMD"; thus, it means "switch to the user named CMD (via the TRAMP su method)". Since some options can be (relatively) safely ignored and others can't, maybe the best approach would be to audit the list of commands I posted in the original message to see if there are any options that users might specify that we can silently ignore. Then we can update the option spec for those commands to parse those options but not do anything with them. Here are all the affected Eshell commands compared to their shell equivalents: addpath No direct shell equivalent. Erroring out on unrecognized options should therefore be safe. echo Eshell echo works quite a bit differently by default. From eshell/em-basic.el, it outputs "in a Lisp-friendly fashion (so that the value of echo is useful to a Lisp command using the result of echo as an argument)". However, with `eshell-plain-echo-behavior' set to non-nil, it works more like shell echo. I'm aware of 3 options for various implementations of shell echo: -n: suppress trailing newline This is recognized by Eshell echo, but actually does the opposite: it *inserts* a trailing newline. I posted a patch to help improve this to bug#27361. -e: enable interpretation of escape sequences This could probably be accepted by Eshell echo and ignored for now, though it would cause some behavioral differences. Warning or erroring out when seeing this option would also be reasonable, I think. -E: disable interpretation of escape sequences This is the default behavior for echo, so there's really no reason *not* to support this option. --version: display the version I doubt this option is used much in scripts, but it wouldn't be hard to support. history Eshell history has some similar options to Bash history. It supports -r, -w, and -a to read, write, and append to the history file, respectively. It also supports getting the Nth history item via "history N". However, Bash history has some additional options: -c: clear history This could theoretically be accepted by Eshell history and ignored, but that would be pretty surprising. If a script is clearing history, there's probably a reason for it, so I think it's best to error out when seeing this option for now. However, it shouldn't be too hard to implement in Eshell if people want it. -d offset / -d start-end: delete history at offset or in range For the same reasons as -c, I think it's best to error out when seeing this option. -p args: perform history substitution on args Since this is supposed to show the result of a history substitution, I think it should error out so as not to cause any confusion or return an invalid result. -s: add history-substituted args to history list This is just an additional option to control the behavior of -p, so the same logic as above applies to this too. source / . It seems Eshell's implementation of these actually has a bug! In a regular shell, running "source file.sh -a -b" would pass -a and -b to file.sh. However, Eshell's source command currently drops -a and -b silently. There are two ways I can think of to fix this: a) stop using `eshell-eval-using-options' entirely. This means that "source --help" changes from showing the help message to sourcing a file named "--help" (this is consistent with source in regular shells) b) using :parse-leading-options-only, which will stop looking for options once it sees a non-option argument like "file.sh". su This (and sudo) both use the TRAMP methods of the same name, so there are probably pretty significant differences between the shell meaning and the Eshell meaning. I'm not super-familiar with how these TRAMP methods work though. Here are the options available: -c / --command CMD: run command CMD -s / --shell SHELL: run the specified shell --session-command CMD: run command CMD with no new session All of these take an argument that should affect what gets run by su. I think erroring out makes sense for all of them. -g / --group GROUP: specify a group -G / --supp-group GROUP: specify a supplemental group -w / --whitelist-environment LIST These are all options that take an argument and which users would probably expect to do what they say, since they affect security. I think erroring out makes sense for all of them. -f / --fast: pass -f to the shell Since the manual for su says this "may or may not be useful, depending on the shell", it would probably be ok to ignore. However, I'm not sure this is a very common option, so maybe erroring out is fine too. - / -l / --login: provide a login environment This is supported by Eshell's su command. -m / -p / --preserve-environment: preserve all env vars If a user wants to preserve the environment, we shouldn't just ignore that. However, since the shell su command ignores this when --login is set, we could ignore it then too. That's probably not particularly useful though. When would a user explicitly pass both --login and --preserve-environment? -P / --pty: create a pseudo-terminal I'm not sure what to do about this one. It might be reasonable to ignore this, but on the other hand, a user requesting a PTY probably has a reason for it and might be unpleasantly surprised if we just ignore that request. -V / --version: display version As with echo --version, I doubt this option is used much in scripts, but it wouldn't be hard to support. sudo This is similar to the su command above, but sudo has a lot more options. -E / --preserve-env[=LIST]: preserve all/selected env vars -g / --group GROUP: specify a group These work like the corresponding su options and so I think erroring out is best here too. -A / --askpass: use a helper program to ask for the password -C / --close-from NUM: close file descriptors >= NUM -H / --set-home: set the HOME env var -K / --remove-timestamp: remove cached credentials -k / --reset-timestamp: invalidate cached credentials -P / --preserve-groups: preserve invoking user's group -r / --role ROLE: set SELinux role -t / --type TYPE: set SELinux type -v / --validate: validate cached credentials These all directly affect security, so we should be safe and error out instead of ignoring them. -B / --bell: ring the bell in the password prompt Since this is just a beep, it would probably be ok to ignore. However, I'm not sure this is a very common option, so maybe erroring out is fine too. -b / --background: run command in background It might be ok to ignore this, but I'm not sure what the implications of doing so would be. I'd err on the side of caution and report an error for this option. -e / --edit: edit a file instead of running command -i / --login: run the user's login shell -s / --shell: run the shell set in SHELL env var These all affect what command is actually run, so we should error out instead of silently running the wrong command. -h / --host HOST: run command on specified HOST This isn't supported, but unfortunately, we use "-h" to mean "help", which could result in confusing output. (sudo uses a "-h" without an argument for "help" and a -h with one for "host".) However, I don't think it will *do* anything invalid (aside from printing the help message), so it should be ok for now. -l / --list: list allowed/forbidden commands for user -u / --user USER: set user for --list These both drastically change what sudo does, so erroring out is the right thing to do, I think. -n / --non-interactive: don't prompt user -p / --prompt PROMPT: customize the password prompt -S / --stdin: read password from stdin I think these are mostly applicable to using sudo from a script, but I'm not sure there's an easy analogue for using them in Eshell. I don't know what to do about these. -V / --version: display version As with echo --version, I doubt this option is used much in scripts, but it wouldn't be hard to support. umask Eshell's version of this is a bit limited in that it can only set the umask if you pass a numeric value. It also only supports the -S (symbolic format) option. -p: output in a form reusable as input I don't think Eshell's umask really supports this properly (in part because it can't accept symbol umasks as input), so it's probably good to error out in this case. ---------------------------------------- In conclusion, I think it would make sense to do the following: * Add support for "echo -E" (no-op) and possibly ignore "echo -e". * Fix the bug with the source command * Consider whether to add support for --version to various Eshell commands. * Decide what, if anything, to do with some of the su/sudo options listed above. However, I welcome other people's thoughts on this. Hopefully the audit above will be enough for people to make an informed opinion about the right thing to do. From unknown Sun Jun 22 17:15:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jan 2022 03:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 53293@debbugs.gnu.org Received: via spool by 53293-submit@debbugs.gnu.org id=B53293.164264842424073 (code B ref 53293); Thu, 20 Jan 2022 03:14:02 +0000 Received: (at 53293) by debbugs.gnu.org; 20 Jan 2022 03:13:44 +0000 Received: from localhost ([127.0.0.1]:55971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nANtQ-0006GC-0B for submit@debbugs.gnu.org; Wed, 19 Jan 2022 22:13:44 -0500 Received: from mail-pf1-f169.google.com ([209.85.210.169]:35477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nANtM-0006Fu-HU for 53293@debbugs.gnu.org; Wed, 19 Jan 2022 22:13:43 -0500 Received: by mail-pf1-f169.google.com with SMTP id y28so820284pff.2 for <53293@debbugs.gnu.org>; Wed, 19 Jan 2022 19:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:mime-version :in-reply-to:content-language; bh=p2f54chnBmxEAP2s1fqzhCIjgBC//0jjoq7j5Gch370=; b=brcCk5pzTMYma15wZoSBjypTUFcVkOSqohFjHQij8eJnliiFklM2c+2NFWibzfsyH8 ge7yh4JUBJxvLC/g7VEhzWGFnqMhNcyAT8BCyN3TrouL7FoWuthkstMIQ94m/ozkMGXc eXYNeLsqHTglyKS/T4ufQBlaVWY5LgajO0XXpzSAKG2t/91SIps9NbwOAos75ID55mhD TD3g3cVScnun4K9hjqjZNiRm6VR8YDt7iwTCI4QgpVncU6xB4H49xFBJ22pCrlB36Jj/ 18jOJXRu/K+FGfM2iCsJXJU19z0WDisr6B8jMMelNVtZeOq2loNFS35Zr7MLQkSp7/zS py8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-language; bh=p2f54chnBmxEAP2s1fqzhCIjgBC//0jjoq7j5Gch370=; b=SvrBnYEzwlcmIAbpe8UWSFVNBA7Ia9JauC18LKkHuI7c8gKF7zk2mdZ4Rc5q7S3M/h PyUp6vcCXSXdjsQe5lWGaKEIOf1sUABYFmDnq1qNQsQ1FpyT3JsvA4gqCaTeGMjVger+ +qZ25De1QzPdOGc1GDYV7lePBLOtLaiAk3Lexl1oY8lAfEsAfnip2GlZyIWZQh05TiMH vQsjHa2fEnuzYF6QsIq70vcHAP+taUTp6KGkNhCIlkQ3e0Ax6lFzKbRchzW02QD/T6Ww l1rMqnOh488RWcMs3bgi/gEkx/00WwGEkRe3BnDSqTqOXc78eXYu8UnZ/R/oQoAKPeEH AwCw== X-Gm-Message-State: AOAM532UQhuueJ0F3D8pAj2rUh2OBZUSA70d9T1fuBJA2z5we4MpCHIU rJG3NznP8ZjYWIq1lIseC7Klk723nVhZ2g== X-Google-Smtp-Source: ABdhPJxDHZu2ubXBX8XywKBFbpJUsRqzpaQrNjbPjiJpEmxqIQcRsdK7VnpUjrXetxheaOI5jdEEtg== X-Received: by 2002:a63:7d3:: with SMTP id 202mr27484499pgh.130.1642648414440; Wed, 19 Jan 2022 19:13:34 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id oa13sm7683794pjb.33.2022.01.19.19.13.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jan 2022 19:13:33 -0800 (PST) From: Jim Porter References: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> <838rvgyrtu.fsf@gnu.org> Message-ID: <632df5ab-007a-d859-fea6-89861c03ff1c@gmail.com> Date: Wed, 19 Jan 2022 19:13:33 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------5133BB3124A20282F2DA2973" Content-Language: en-US X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------5133BB3124A20282F2DA2973 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/16/2022 12:31 PM, Jim Porter wrote: > In conclusion, I think it would make sense to do the following: > > * Add support for "echo -E" (no-op) and possibly ignore "echo -e". > * Fix the bug with the source command > * Consider whether to add support for --version to various Eshell commands. > * Decide what, if anything, to do with some of the su/sudo options > listed above. While it would probably make sense to wait a bit longer to see if anyone has comments on my audit of the existing Eshell built-in commands, I've implemented the first two points here (not "echo -e", though). The changes to `source' and `.' might warrant a NEWS entry, since it's a (small) incompatible change; however, I think it's so rare that someone would call "source --help" that it might not be worth adding to NEWS. I'll do whatever others think is best here, though. --------------5133BB3124A20282F2DA2973 Content-Type: text/plain; charset=UTF-8; name="0001-Raise-an-error-from-eval-eval-using-options-for-unkn.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Raise-an-error-from-eval-eval-using-options-for-unkn.pa"; filename*1="tch" RnJvbSBjYmY2M2FkOTU0MDAyZTU4N2E3YzY3NGUyZjMzYTM3YWU5OWIyMWI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMTkgSmFuIDIwMjIgMTg6NTk6MjMgLTA4MDAKU3ViamVjdDogW1BB VENIIDEvMl0gUmFpc2UgYW4gZXJyb3IgZnJvbSAnZXZhbC1ldmFsLXVzaW5nLW9wdGlvbnMn IGZvciB1bmtub3duCiBvcHRpb25zCgoqIGxpc3AvZXNoZWxsL2VtLWJhc2ljLmVsIChlc2hl bGwvZWNobyk6IEFkZCAtRSBvcHRpb24uCgoqIGxpc3AvZXNoZWxsL2VzaC1vcHQuZWwgKGVz aGVsbC0tcHJvY2Vzcy1vcHRpb24pOiBSYWlzZSBhbiBlcnJvciBpZgphbiB1bmtub3duIG9w dGlvbiBpcyBlbmNvdW50ZXJlZCwgZXZlbiB3aGVuIDpleHRlcm5hbCBpcyBuaWwuCgoqIHRl c3QvbGlzcC9lc2hlbGwvZXNoLW9wdC10ZXN0cy5lbCAoZXNoLW9wdC1wcm9jZXNzLWFyZ3Mt dGVzdCkKKHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucyk6IEFkZCB0ZXN0IGNhc2Vz IGZvciB0aGlzLgotLS0KIGxpc3AvZXNoZWxsL2VtLWJhc2ljLmVsICAgICAgICAgICB8ICAz ICstCiBsaXNwL2VzaGVsbC9lc2gtb3B0LmVsICAgICAgICAgICAgfCAxMiArKy0tLQogdGVz dC9saXNwL2VzaGVsbC9lc2gtb3B0LXRlc3RzLmVsIHwgODYgKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA3MiBpbnNlcnRpb25zKCspLCAyOSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lbS1iYXNpYy5lbCBiL2xp c3AvZXNoZWxsL2VtLWJhc2ljLmVsCmluZGV4IDI3YjM0M2FkMzkuLjViMTc0ZGU0MjAgMTAw NjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWJhc2ljLmVsCisrKyBiL2xpc3AvZXNoZWxsL2Vt LWJhc2ljLmVsCkBAIC0xMTAsOSArMTEwLDEwIEBAIGVzaGVsbC9lY2hvCiAgIChlc2hlbGwt ZXZhbC11c2luZy1vcHRpb25zCiAgICAiZWNobyIgYXJncwogICAgJygoP24gbmlsIG5pbCBv dXRwdXQtbmV3bGluZSAidGVybWluYXRlIHdpdGggYSBuZXdsaW5lIikKKyAgICAgKD9FIG5p bCBuaWwgX2Rpc2FibGUtZXNjYXBlcyAiZG9uJ3QgaW50ZXJwcmV0IGJhY2tzbGFzaCBlc2Nh cGVzIChkZWZhdWx0KSIpCiAgICAgICg/aCAiaGVscCIgbmlsIG5pbCAib3V0cHV0IHRoaXMg aGVscCBzY3JlZW4iKQogICAgICA6cHJlc2VydmUtYXJncwotICAgICA6dXNhZ2UgIlstbl0g W29iamVjdF0iKQorICAgICA6dXNhZ2UgIltPUFRJT05dLi4uIFtPQkpFQ1RdLi4uIikKICAg IChlc2hlbGwtZWNobyBhcmdzIG91dHB1dC1uZXdsaW5lKSkpCiAKIChkZWZ1biBlc2hlbGwv cHJpbnRubCAoJnJlc3QgYXJncykKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1vcHQu ZWwgYi9saXNwL2VzaGVsbC9lc2gtb3B0LmVsCmluZGV4IGJiYTFjNGFkMjUuLmM4MDJiZWUz YWYgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1vcHQuZWwKKysrIGIvbGlzcC9lc2hl bGwvZXNoLW9wdC5lbApAQCAtMjU3LDEyICsyNTcsMTIgQEAgZXNoZWxsLS1wcm9jZXNzLW9w dGlvbgogICAgICAgICByZW1haW5pbmcKICAgICAgIChsZXQgKChleHRjbWQgKG1lbXEgJzpl eHRlcm5hbCBvcHRpb25zKSkpCiAJKHdoZW4gZXh0Y21kCi0JICAoc2V0cSBleHRjbWQgKGVz aGVsbC1zZWFyY2gtcGF0aCAoY2FkciBleHRjbWQpKSkKLQkgIChpZiBleHRjbWQKLQkgICAg ICAodGhyb3cgJ2VzaGVsbC1leHQtY29tbWFuZCBleHRjbWQpCi0gICAgICAgICAgICAoZXJy b3IgKGlmIChjaGFyYWN0ZXJwIChjYXIgc3dpdGNoKSkgIiVzOiB1bnJlY29nbml6ZWQgb3B0 aW9uIC0lYyIKLSAgICAgICAgICAgICAgICAgICAgICIlczogdW5yZWNvZ25pemVkIG9wdGlv biAtLSVzIikKLSAgICAgICAgICAgICAgICAgICBuYW1lIChjYXIgc3dpdGNoKSkpKSkpKSkK KwkgIChzZXRxIGV4dGNtZCAoZXNoZWxsLXNlYXJjaC1wYXRoIChjYWRyIGV4dGNtZCkpKSkK KwkoaWYgZXh0Y21kCisJICAgICh0aHJvdyAnZXNoZWxsLWV4dC1jb21tYW5kIGV4dGNtZCkK KyAgICAgICAgICAoZXJyb3IgKGlmIChjaGFyYWN0ZXJwIChjYXIgc3dpdGNoKSkgIiVzOiB1 bnJlY29nbml6ZWQgb3B0aW9uIC0lYyIKKyAgICAgICAgICAgICAgICAgICAiJXM6IHVucmVj b2duaXplZCBvcHRpb24gLS0lcyIpCisgICAgICAgICAgICAgICAgIG5hbWUgKGNhciBzd2l0 Y2gpKSkpKSkpCiAKIChkZWZ1biBlc2hlbGwtLXByb2Nlc3MtYXJncyAobmFtZSBhcmdzIG9w dGlvbnMpCiAgICJQcm9jZXNzIHRoZSBnaXZlbiBBUkdTIHVzaW5nIE9QVElPTlMuIgpkaWZm IC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lc2gtb3B0LXRlc3RzLmVsIGIvdGVzdC9saXNw L2VzaGVsbC9lc2gtb3B0LXRlc3RzLmVsCmluZGV4IDI1NTc2ODYzNWIuLmI3NmVkODg2NmQg MTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLW9wdC10ZXN0cy5lbAorKysgYi90 ZXN0L2xpc3AvZXNoZWxsL2VzaC1vcHQtdGVzdHMuZWwKQEAgLTI3LDQxICsyNyw2MyBAQCBl c2gtb3B0LXByb2Nlc3MtYXJncy10ZXN0CiAgIChzaG91bGQKICAgIChlcXVhbCAnKHQpCiAg ICAgICAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCi0gICAgICAgICAgICJzdWRvIgotICAg ICAgICAgICAnKCItYSIpCi0gICAgICAgICAgICcoKD9hICJhbGwiIG5pbCBzaG93LWFsbCAi IikpKSkpCi0gIChzaG91bGQKLSAgIChlcXVhbCAnKG5pbCkKLSAgICAgICAgICAoZXNoZWxs LS1wcm9jZXNzLWFyZ3MKLSAgICAgICAgICAgInN1ZG8iCi0gICAgICAgICAgICcoIi1nIikK LSAgICAgICAgICAgJygoP2EgImFsbCIgbmlsIHNob3ctYWxsICIiKSkpKSkKKyAgICAgICAg ICAgInN1ZG8iICcoIi1hIikKKyAgICAgICAgICAgJygoP2EgImFsbCIgbmlsIHNob3ctYWxs CisgICAgICAgICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0 aCAuIikpKSkpCiAgIChzaG91bGQKICAgIChlcXVhbCAnKCJyb290IiAid29ybGQiKQogICAg ICAgICAgIChlc2hlbGwtLXByb2Nlc3MtYXJncwotICAgICAgICAgICAic3VkbyIKLSAgICAg ICAgICAgJygiLXUiICJyb290IiAid29ybGQiKQotICAgICAgICAgICAnKCg/dSAidXNlciIg dCB1c2VyICJleGVjdXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVTRVIiKSkpKSkKKyAgICAg ICAgICAgInN1ZG8iICcoIi11IiAicm9vdCIgIndvcmxkIikKKyAgICAgICAgICAgJygoP3Ug InVzZXIiIHQgdXNlcgorICAgICAgICAgICAgICAgICAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMg YW5vdGhlciBVU0VSIikpKSkpCiAgIChzaG91bGQKICAgIChlcXVhbCAnKG5pbCAiZW1lcmdl IiAiLXVETiIgIndvcmxkIikKICAgICAgICAgICAoZXNoZWxsLS1wcm9jZXNzLWFyZ3MKLSAg ICAgICAgICAgInN1ZG8iCi0gICAgICAgICAgICcoImVtZXJnZSIgIi11RE4iICJ3b3JsZCIp Ci0gICAgICAgICAgICcoKD91ICJ1c2VyIiB0IHVzZXIgImV4ZWN1dGUgYSBjb21tYW5kIGFz IGFub3RoZXIgVVNFUiIpCisgICAgICAgICAgICJzdWRvIiAnKCJlbWVyZ2UiICItdUROIiAi d29ybGQiKQorICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2VyCisgICAgICAgICAgICAg ICAgICJleGVjdXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVTRVIiKQogICAgICAgICAgICAg IDpwYXJzZS1sZWFkaW5nLW9wdGlvbnMtb25seSkpKSkKICAgKHNob3VsZAogICAgKGVxdWFs ICcoInJvb3QiICJlbWVyZ2UiICItdUROIiAid29ybGQiKQogICAgICAgICAgIChlc2hlbGwt LXByb2Nlc3MtYXJncwotICAgICAgICAgICAic3VkbyIKLSAgICAgICAgICAgJygiLXUiICJy b290IiAiZW1lcmdlIiAiLXVETiIgIndvcmxkIikKLSAgICAgICAgICAgJygoP3UgInVzZXIi IHQgdXNlciAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhlciBVU0VSIikKKyAgICAgICAg ICAgInN1ZG8iICcoIi11IiAicm9vdCIgImVtZXJnZSIgIi11RE4iICJ3b3JsZCIpCisgICAg ICAgICAgICcoKD91ICJ1c2VyIiB0IHVzZXIKKyAgICAgICAgICAgICAgICAgImV4ZWN1dGUg YSBjb21tYW5kIGFzIGFub3RoZXIgVVNFUiIpCiAgICAgICAgICAgICAgOnBhcnNlLWxlYWRp bmctb3B0aW9ucy1vbmx5KSkpKQogICAoc2hvdWxkCiAgICAoZXF1YWwgJygiRE4iICJlbWVy Z2UiICJ3b3JsZCIpCiAgICAgICAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCi0gICAgICAg ICAgICJzdWRvIgotICAgICAgICAgICAnKCItdSIgInJvb3QiICJlbWVyZ2UiICItdUROIiAi d29ybGQiKQotICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2VyICJleGVjdXRlIGEgY29t bWFuZCBhcyBhbm90aGVyIFVTRVIiKSkpKSkpCisgICAgICAgICAgICJzdWRvIiAnKCItdSIg InJvb3QiICJlbWVyZ2UiICItdUROIiAid29ybGQiKQorICAgICAgICAgICAnKCg/dSAidXNl ciIgdCB1c2VyCisgICAgICAgICAgICAgICAgICJleGVjdXRlIGEgY29tbWFuZCBhcyBhbm90 aGVyIFVTRVIiKSkpKSkKKworICA7OyBUZXN0IDpleHRlcm5hbC4KKyAgKGNsLWxldGYgKCgo c3ltYm9sLWZ1bmN0aW9uICdlc2hlbGwtc2VhcmNoLXBhdGgpICMnaWdub3JlKSkKKyAgICAo c2hvdWxkCisgICAgIChlcXVhbCAnKG5pbCAiL3NvbWUvcGF0aCIpCisgICAgICAgICAgICAo ZXNoZWxsLS1wcm9jZXNzLWFyZ3MKKyAgICAgICAgICAgICAibHMiICcoIi9zb21lL3BhdGgi KQorICAgICAgICAgICAgICcoKD9hICJhbGwiIG5pbCBzaG93LWFsbAorICAgICAgICAgICAg ICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikKKyAgICAg ICAgICAgICAgIDpleHRlcm5hbCAibHMiKSkpKSkKKyAgKGNsLWxldGYgKCgoc3ltYm9sLWZ1 bmN0aW9uICdlc2hlbGwtc2VhcmNoLXBhdGgpICMnaWRlbnRpdHkpKQorICAgIChzaG91bGQK KyAgICAgKGVxdWFsICcobm8tY2F0Y2ggZXNoZWxsLWV4dC1jb21tYW5kICJscyIpCisgICAg ICAgICAgICAoc2hvdWxkLWVycm9yCisgICAgICAgICAgICAgKGVzaGVsbC0tcHJvY2Vzcy1h cmdzCisgICAgICAgICAgICAgICJscyIgJygiLXUiICIvc29tZS9wYXRoIikKKyAgICAgICAg ICAgICAgJygoP2EgImFsbCIgbmlsIHNob3ctYWxsCisgICAgICAgICAgICAgICAgICAgICJk byBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikKKyAgICAgICAgICAgICAg ICA6ZXh0ZXJuYWwgImxzIikpCisgICAgICAgICAgICAgOnR5cGUgJ25vLWNhdGNoKSkpKQor ICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ2VzaGVsbC1zZWFyY2gtcGF0aCkgIydp Z25vcmUpKQorICAgIChzaG91bGQtZXJyb3IKKyAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdz CisgICAgICAibHMiICcoIi11IiAiL3NvbWUvcGF0aCIpCisgICAgICAnKCg/YSAiYWxsIiBu aWwgc2hvdy1hbGwKKyAgICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRp bmcgd2l0aCAuIikKKyAgICAgICAgOmV4dGVybmFsICJscyIpKQorICAgICA6dHlwZSAnZXJy b3IpKSkKIAogKGVydC1kZWZ0ZXN0IHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucyAo KQogICAiVGVzdHMgZm9yIGBlc2hlbGwtZXZhbC11c2luZy1vcHRpb25zJy4iCkBAIC0xOTAs NyArMjEyLDI3IEBAIHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucwogICAgJygoP3Ug InVzZXIiIHQgdXNlciAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhlciBVU0VSIikKICAg ICAgOnBhcnNlLWxlYWRpbmctb3B0aW9ucy1vbmx5KQogICAgKHNob3VsZCAoZXEgdXNlciBu aWwpKQotICAgKHNob3VsZCAoZXF1YWwgYXJncyAnKCJlbWVyZ2UiICItdUROIiAid29ybGQi KSkpKSkKKyAgIChzaG91bGQgKGVxdWFsIGFyZ3MgJygiZW1lcmdlIiAiLXVETiIgIndvcmxk IikpKSkKKworICA7OyBUZXN0IHVucmVjb2duaXplZCBvcHRpb25zLgorICAoc2hvdWxkLWVy cm9yCisgICAoZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucworICAgICJscyIgJygiLXUiICIv c29tZS9wYXRoIikKKyAgICAnKCg/YSAiYWxsIiBuaWwgc2hvdy1hbGwKKyAgICAgICAgICAi ZG8gbm90IGlnbm9yZSBlbnRyaWVzIHN0YXJ0aW5nIHdpdGggLiIpKQorICAgIChpZ25vcmUg c2hvdy1hbGwpKSkKKyAgKHNob3VsZC1lcnJvcgorICAgKGVzaGVsbC1ldmFsLXVzaW5nLW9w dGlvbnMKKyAgICAibHMiICcoIi1hdSIgIi9zb21lL3BhdGgiKQorICAgICcoKD9hICJhbGwi IG5pbCBzaG93LWFsbAorICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRp bmcgd2l0aCAuIikpCisgICAgKGlnbm9yZSBzaG93LWFsbCkpKQorICAoc2hvdWxkLWVycm9y CisgICAoZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucworICAgICJscyIgJygiLS11bnJlY29n bml6ZWQiICIvc29tZS9wYXRoIikKKyAgICAnKCg/YSAiYWxsIiBuaWwgc2hvdy1hbGwKKyAg ICAgICAgICAiZG8gbm90IGlnbm9yZSBlbnRyaWVzIHN0YXJ0aW5nIHdpdGggLiIpKQorICAg IChpZ25vcmUgc2hvdy1hbGwpKSkpCiAKIChwcm92aWRlICdlc2gtb3B0LXRlc3RzKQogCi0t IAoyLjI1LjEKCg== --------------5133BB3124A20282F2DA2973 Content-Type: text/plain; charset=UTF-8; name="0002-Don-t-use-eshell-eval-using-options-for-eshell-sourc.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0002-Don-t-use-eshell-eval-using-options-for-eshell-sourc.pa"; filename*1="tch" RnJvbSA3MGM1YTg4YmZkYWQ5ZGExZjI3MzJiODJlOGE5ZTMxNjlmZTIwZWRkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMTkgSmFuIDIwMjIgMTk6MDE6NDIgLTA4MDAKU3ViamVjdDogW1BB VENIIDIvMl0gRG9uJ3QgdXNlICdlc2hlbGwtZXZhbC11c2luZy1vcHRpb25zJyBmb3IgJ2Vz aGVsbC9zb3VyY2UnCiBvciAnZXNoZWxsLy4nCgpUaGlzIG1ha2VzICdzb3VyY2UnIGFuZCAn LicgaW4gRXNoZWxsIG1vcmUgY29tcGF0aWJsZSB3aXRoIHJlZ3VsYXIKc2hlbGxzLCB3aGlj aCBqdXN0IHRyZWF0IHRoZSBmaXJzdCBhcmd1bWVudCBhcyB0aGUgZmlsZSB0byBzb3VyY2Ug YW5kCmFsbCBzdWJzZXF1ZW50IGFyZ3VtZW50cyBhcyBhcmd1bWVudHMgdG8gdGhhdCBmaWxl LgoKKiBsaXNwL2VzaGVsbC9lbS1zY3JpcHQuZWwgKGVzaGVsbC9zb3VyY2UsIGVzaGVsbC8u KTogRG9uJ3QgdXNlCidlc2hlbGwtZXZhbC11c2luZy1vcHRpb25zJy4KLS0tCiBsaXNwL2Vz aGVsbC9lbS1zY3JpcHQuZWwgfCAxOCArKy0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvZXNoZWxsL2VtLXNjcmlwdC5lbCBiL2xpc3AvZXNoZWxsL2VtLXNjcmlwdC5lbAppbmRl eCBlODQ1OTUxM2YzLi5lMGJjZDhiMDk5IDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lbS1z Y3JpcHQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZW0tc2NyaXB0LmVsCkBAIC0xMTMsMjcgKzEx MywxMyBAQCBlc2hlbGwtc291cmNlLWZpbGUKIAogKGRlZnVuIGVzaGVsbC9zb3VyY2UgKCZy ZXN0IGFyZ3MpCiAgICJTb3VyY2UgYSBmaWxlIGluIGEgc3Vic2hlbGwgZW52aXJvbm1lbnQu IgotICAoZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucwotICAgInNvdXJjZSIgYXJncwotICAg JygoP2ggImhlbHAiIG5pbCBuaWwgInNob3cgdGhpcyB1c2FnZSBzY3JlZW4iKQotICAgICA6 c2hvdy11c2FnZQotICAgICA6dXNhZ2UgIkZJTEUgW0FSR1NdCi1JbnZva2UgdGhlIEVzaGVs bCBjb21tYW5kcyBpbiBGSUxFIGluIGEgc3Vic2hlbGwsIGJpbmRpbmcgQVJHUyB0byAkMSwK LSQyLCBldGMuIikKLSAgIChlc2hlbGwtc291cmNlLWZpbGUgKGNhciBhcmdzKSAoY2RyIGFy Z3MpIHQpKSkKKyAgKGVzaGVsbC1zb3VyY2UtZmlsZSAoY2FyIGFyZ3MpIChjZHIgYXJncykg dCkpCiAKIChwdXQgJ2VzaGVsbC9zb3VyY2UgJ2VzaGVsbC1uby1udW1lcmljLWNvbnZlcnNp b25zIHQpCiAKIChkZWZ1biBlc2hlbGwvLiAoJnJlc3QgYXJncykKICAgIlNvdXJjZSBhIGZp bGUgaW4gdGhlIGN1cnJlbnQgZW52aXJvbm1lbnQuIgotICAoZXNoZWxsLWV2YWwtdXNpbmct b3B0aW9ucwotICAgIi4iIGFyZ3MKLSAgICcoKD9oICJoZWxwIiBuaWwgbmlsICJzaG93IHRo aXMgdXNhZ2Ugc2NyZWVuIikKLSAgICAgOnNob3ctdXNhZ2UKLSAgICAgOnVzYWdlICJGSUxF IFtBUkdTXQotSW52b2tlIHRoZSBFc2hlbGwgY29tbWFuZHMgaW4gRklMRSB3aXRoaW4gdGhl IGN1cnJlbnQgc2hlbGwKLWVudmlyb25tZW50LCBiaW5kaW5nIEFSR1MgdG8gJDEsICQyLCBl dGMuIikKLSAgIChlc2hlbGwtc291cmNlLWZpbGUgKGNhciBhcmdzKSAoY2RyIGFyZ3MpKSkp CisgIChlc2hlbGwtc291cmNlLWZpbGUgKGNhciBhcmdzKSAoY2RyIGFyZ3MpKSkKIAogKHB1 dCAnZXNoZWxsLy4gJ2VzaGVsbC1uby1udW1lcmljLWNvbnZlcnNpb25zIHQpCiAKLS0gCjIu MjUuMQoK --------------5133BB3124A20282F2DA2973-- From unknown Sun Jun 22 17:15:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jan 2022 11:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 53293@debbugs.gnu.org Received: via spool by 53293-submit@debbugs.gnu.org id=B53293.164267931416999 (code B ref 53293); Thu, 20 Jan 2022 11:49:02 +0000 Received: (at 53293) by debbugs.gnu.org; 20 Jan 2022 11:48:34 +0000 Received: from localhost ([127.0.0.1]:56564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAVve-0004Q7-B0 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 06:48:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAVvc-0004Pt-NP for 53293@debbugs.gnu.org; Thu, 20 Jan 2022 06:48:33 -0500 Received: from [2001:470:142:3::e] (port=39434 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAVvX-0001Jb-CW; Thu, 20 Jan 2022 06:48:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=STbPLUA4GZOCCsSoXUf1qwzqhNDiLln0832wwbVWyDM=; b=Id49iHSq+7K8 uQZzYwmh6xLzmsK56SoVqbU/r+qXFZDvfNM1fDF1Poieo2U8keoHzoLxzcLJRD5EfAKD+2eOlS0cB 1SRDhbKoBTGNycrT8EeghDZTbdbZcCf5KMVK0XNuHey6TOUTz0BsWmBF4bSNF0RbarMmSS/KAYiqQ QqSvquIlIONjre/lI3/1Y62736q1UMn0S1xSH2Ur3+B+afhIaC0t7YKLN6FvJl8LezrC9Hl7VQiUX FdGFbeCINCJdGiP33O7+DriA0eKhK664YcB9hGp/XjrKSkhC2c6FDzflIY0zpz5ye8Fwqpgu+wVB3 qKdAPUHX1WEj6lLP3+xP3Q==; Received: from [87.69.77.57] (port=1921 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAVvX-0000gX-FP; Thu, 20 Jan 2022 06:48:27 -0500 Date: Thu, 20 Jan 2022 13:48:26 +0200 Message-Id: <83y23apr05.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <632df5ab-007a-d859-fea6-89861c03ff1c@gmail.com> (message from Jim Porter on Wed, 19 Jan 2022 19:13:33 -0800) References: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> <838rvgyrtu.fsf@gnu.org> <632df5ab-007a-d859-fea6-89861c03ff1c@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Cc: 53293@debbugs.gnu.org > Date: Wed, 19 Jan 2022 19:13:33 -0800 > > While it would probably make sense to wait a bit longer to see if anyone > has comments on my audit of the existing Eshell built-in commands, I've > implemented the first two points here (not "echo -e", though). Thanks, LGTM. > The changes to `source' and `.' might warrant a NEWS entry, since it's a > (small) incompatible change; however, I think it's so rare that someone > would call "source --help" that it might not be worth adding to NEWS. > I'll do whatever others think is best here, though. I think a NEWS entry is called for, since the change in behavior is not backward-compatible. From unknown Sun Jun 22 17:15:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 04:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 53293@debbugs.gnu.org Received: via spool by 53293-submit@debbugs.gnu.org id=B53293.164273760919019 (code B ref 53293); Fri, 21 Jan 2022 04:01:01 +0000 Received: (at 53293) by debbugs.gnu.org; 21 Jan 2022 04:00:09 +0000 Received: from localhost ([127.0.0.1]:59823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAl5t-0004wf-64 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 23:00:09 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:53019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAl5r-0004vJ-J3 for 53293@debbugs.gnu.org; Thu, 20 Jan 2022 23:00:08 -0500 Received: by mail-pj1-f41.google.com with SMTP id o64so8275884pjo.2 for <53293@debbugs.gnu.org>; Thu, 20 Jan 2022 20:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=3YJl8WcVPNcUbZaVlllzAIzMejSthc+yYjGrDK4IJBQ=; b=DYXpZMmDwWhnc3+rP5vEPBuhoU4SITXZWeG0KkDLSQDEqZNujzEysrmOgxqR+6hhix FqL+bxgumnpwprcAD43MLMiIDaVc43fSNsoINz/Zstn56CUn9qKDxR4cspg72CHe8Ler HnOLVX6kBfwY68VwS6IHIkbPw2+rQoMV6D2mOaBSzHBdFMm4xRzkiVFAoiG/VdclVRLu retbXaDd/LY5tkLNWny1GogoBtChbxGHmydHxd/WIDjPXfA+JI6qgfCHuztGLqBzNfty WnVK7AVItFuAX4gB2bAHMoCKeIjckUzuASMgQznRA9njHhxucc8ydnK3B9392d0L+XPd vZ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=3YJl8WcVPNcUbZaVlllzAIzMejSthc+yYjGrDK4IJBQ=; b=SzDI89t0JcWR2AXXyODVJTRcEbgRFx+DCSLxcO9jv5PRyQ1rctm6nNE98rSqm5tGdV KJ9nMklZB86UcTa5+yXueJS4M2/UFSOWvHUSjCKHFhAu8H7eiFJW78jtLLVfZrri2Z1Z KERhBBjte75rT2RItLPSY54qAT096+IpdR1bGWfUveZAeLyNofVCZoAyhQ+uFeeF19os eHu1sh/J7bUnbvrRCum1ioquiLs4lz7K9SZlmfPf7HXo5lWJHIp4er8q15VNpW6Ed6on gs4+0B49mYcVI23IXLZKgB6bejBpZ8f8L97R25nL1tj2v3qY4bx4CFkB7Dua5peh/BaG NTnw== X-Gm-Message-State: AOAM530bwpWxbhAMg8ntrX68xPLtPQN57Tmr8wIMAJqFwWIjWt/0HqrT 09xCjZ/gIKDFxEr+qDrXmIBqIROFw2HTAw== X-Google-Smtp-Source: ABdhPJxRd6WSXuScql4tRva5Do0BsyhsQZjHJII7W+3S3zka5WNYjf5aveJnnr+a3+udYBqC0JjBQg== X-Received: by 2002:a17:902:e552:b0:149:b7bf:9b42 with SMTP id n18-20020a170902e55200b00149b7bf9b42mr1963913plf.70.1642737601393; Thu, 20 Jan 2022 20:00:01 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o1sm5353664pfu.101.2022.01.20.20.00.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jan 2022 20:00:00 -0800 (PST) References: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> <838rvgyrtu.fsf@gnu.org> <632df5ab-007a-d859-fea6-89861c03ff1c@gmail.com> <83y23apr05.fsf@gnu.org> From: Jim Porter Message-ID: Date: Thu, 20 Jan 2022 20:00:00 -0800 MIME-Version: 1.0 In-Reply-To: <83y23apr05.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------593DC222E3FC59E0D7B8133C" Content-Language: en-US X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------593DC222E3FC59E0D7B8133C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/20/2022 3:48 AM, Eli Zaretskii wrote: >> From: Jim Porter >> Cc: 53293@debbugs.gnu.org >> Date: Wed, 19 Jan 2022 19:13:33 -0800 >> >> The changes to `source' and `.' might warrant a NEWS entry, since it's a >> (small) incompatible change; however, I think it's so rare that someone >> would call "source --help" that it might not be worth adding to NEWS. >> I'll do whatever others think is best here, though. > > I think a NEWS entry is called for, since the change in behavior is > not backward-compatible. Thanks. Here are updated patches with a NEWS entry to explain the change to `source' and `.'. I also rebased the first patch to fix a merge conflict with the patch for bug#27361. --------------593DC222E3FC59E0D7B8133C Content-Type: text/plain; charset=UTF-8; name="0001-Raise-an-error-from-eval-eval-using-options-for-unkn.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Raise-an-error-from-eval-eval-using-options-for-unkn.pa"; filename*1="tch" RnJvbSBhZjA4OWMxNjQ1NmNkOGVjMDg4YzE2NmViYjIyMTcwYTg4MTkzNDE3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMTkgSmFuIDIwMjIgMTg6NTk6MjMgLTA4MDAKU3ViamVjdDogW1BB VENIIDEvMl0gUmFpc2UgYW4gZXJyb3IgZnJvbSAnZXZhbC1ldmFsLXVzaW5nLW9wdGlvbnMn IGZvciB1bmtub3duCiBvcHRpb25zCgoqIGxpc3AvZXNoZWxsL2VtLWJhc2ljLmVsIChlc2hl bGwvZWNobyk6IEFkZCAtRSBvcHRpb24uCgoqIGxpc3AvZXNoZWxsL2VzaC1vcHQuZWwgKGVz aGVsbC0tcHJvY2Vzcy1vcHRpb24pOiBSYWlzZSBhbiBlcnJvciBpZgphbiB1bmtub3duIG9w dGlvbiBpcyBlbmNvdW50ZXJlZCwgZXZlbiB3aGVuIDpleHRlcm5hbCBpcyBuaWwuCgoqIHRl c3QvbGlzcC9lc2hlbGwvZXNoLW9wdC10ZXN0cy5lbCAoZXNoLW9wdC1wcm9jZXNzLWFyZ3Mt dGVzdCkKKHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucyk6IEFkZCB0ZXN0IGNhc2Vz IGZvciB0aGlzLgotLS0KIGxpc3AvZXNoZWxsL2VtLWJhc2ljLmVsICAgICAgICAgICB8IDEz ICsrKy0tCiBsaXNwL2VzaGVsbC9lc2gtb3B0LmVsICAgICAgICAgICAgfCAxMiArKy0tLQog dGVzdC9saXNwL2VzaGVsbC9lc2gtb3B0LXRlc3RzLmVsIHwgODYgKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA3OSBpbnNlcnRpb25zKCspLCAz MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lbS1iYXNpYy5lbCBi L2xpc3AvZXNoZWxsL2VtLWJhc2ljLmVsCmluZGV4IGQzYjE1YzkwMGIuLmJhODY4Y2VlNTkg MTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWJhc2ljLmVsCisrKyBiL2xpc3AvZXNoZWxs L2VtLWJhc2ljLmVsCkBAIC0xMTMsMTEgKzExMywxNiBAQCBlc2hlbGwvZWNobwogICAiSW1w bGVtZW50YXRpb24gb2YgYGVjaG8nLiAgU2VlIGBlc2hlbGwtcGxhaW4tZWNoby1iZWhhdmlv cicuIgogICAoZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucwogICAgImVjaG8iIGFyZ3MKLSAg ICcoKD9uIG5pbCAobmlsKSBvdXRwdXQtbmV3bGluZSAiZG8gbm90IG91dHB1dCB0aGUgdHJh aWxpbmcgbmV3bGluZSIpCi0gICAgICg/TiBuaWwgKHQpICAgb3V0cHV0LW5ld2xpbmUgInRl cm1pbmF0ZSB3aXRoIGEgbmV3bGluZSIpCi0gICAgICg/aCAiaGVscCIgbmlsIG5pbCAib3V0 cHV0IHRoaXMgaGVscCBzY3JlZW4iKQorICAgJygoP24gbmlsIChuaWwpIG91dHB1dC1uZXds aW5lCisgICAgICAgICAiZG8gbm90IG91dHB1dCB0aGUgdHJhaWxpbmcgbmV3bGluZSIpCisg ICAgICg/TiBuaWwgKHQpICAgb3V0cHV0LW5ld2xpbmUKKyAgICAgICAgICJ0ZXJtaW5hdGUg d2l0aCBhIG5ld2xpbmUiKQorICAgICAoP0UgbmlsIG5pbCAgIF9kaXNhYmxlLWVzY2FwZXMK KyAgICAgICAgICJkb24ndCBpbnRlcnByZXQgYmFja3NsYXNoIGVzY2FwZXMgKGRlZmF1bHQp IikKKyAgICAgKD9oICJoZWxwIiBuaWwgbmlsCisgICAgICAgICAib3V0cHV0IHRoaXMgaGVs cCBzY3JlZW4iKQogICAgICA6cHJlc2VydmUtYXJncwotICAgICA6dXNhZ2UgIlstbiB8IC1O XSBbb2JqZWN0XSIpCisgICAgIDp1c2FnZSAiW09QVElPTl0uLi4gW09CSkVDVF0uLi4iKQog ICAgKGlmIGVzaGVsbC1wbGFpbi1lY2hvLWJlaGF2aW9yCiAgICAgICAgKGVzaGVsbC1lY2hv IGFyZ3MgKGlmIG91dHB1dC1uZXdsaW5lIChjYXIgb3V0cHV0LW5ld2xpbmUpIHQpKQogICAg ICA7OyBJbiBFbWFjcyAyOC4xIGFuZCBlYXJsaWVyLCAiLW4iIHdhcyB1c2VkIHRvIGFkZCBh IG5ld2xpbmUgdG8KZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1vcHQuZWwgYi9saXNw L2VzaGVsbC9lc2gtb3B0LmVsCmluZGV4IGJiYTFjNGFkMjUuLmM4MDJiZWUzYWYgMTAwNjQ0 Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1vcHQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLW9w dC5lbApAQCAtMjU3LDEyICsyNTcsMTIgQEAgZXNoZWxsLS1wcm9jZXNzLW9wdGlvbgogICAg ICAgICByZW1haW5pbmcKICAgICAgIChsZXQgKChleHRjbWQgKG1lbXEgJzpleHRlcm5hbCBv cHRpb25zKSkpCiAJKHdoZW4gZXh0Y21kCi0JICAoc2V0cSBleHRjbWQgKGVzaGVsbC1zZWFy Y2gtcGF0aCAoY2FkciBleHRjbWQpKSkKLQkgIChpZiBleHRjbWQKLQkgICAgICAodGhyb3cg J2VzaGVsbC1leHQtY29tbWFuZCBleHRjbWQpCi0gICAgICAgICAgICAoZXJyb3IgKGlmIChj aGFyYWN0ZXJwIChjYXIgc3dpdGNoKSkgIiVzOiB1bnJlY29nbml6ZWQgb3B0aW9uIC0lYyIK LSAgICAgICAgICAgICAgICAgICAgICIlczogdW5yZWNvZ25pemVkIG9wdGlvbiAtLSVzIikK LSAgICAgICAgICAgICAgICAgICBuYW1lIChjYXIgc3dpdGNoKSkpKSkpKSkKKwkgIChzZXRx IGV4dGNtZCAoZXNoZWxsLXNlYXJjaC1wYXRoIChjYWRyIGV4dGNtZCkpKSkKKwkoaWYgZXh0 Y21kCisJICAgICh0aHJvdyAnZXNoZWxsLWV4dC1jb21tYW5kIGV4dGNtZCkKKyAgICAgICAg ICAoZXJyb3IgKGlmIChjaGFyYWN0ZXJwIChjYXIgc3dpdGNoKSkgIiVzOiB1bnJlY29nbml6 ZWQgb3B0aW9uIC0lYyIKKyAgICAgICAgICAgICAgICAgICAiJXM6IHVucmVjb2duaXplZCBv cHRpb24gLS0lcyIpCisgICAgICAgICAgICAgICAgIG5hbWUgKGNhciBzd2l0Y2gpKSkpKSkp CiAKIChkZWZ1biBlc2hlbGwtLXByb2Nlc3MtYXJncyAobmFtZSBhcmdzIG9wdGlvbnMpCiAg ICJQcm9jZXNzIHRoZSBnaXZlbiBBUkdTIHVzaW5nIE9QVElPTlMuIgpkaWZmIC0tZ2l0IGEv dGVzdC9saXNwL2VzaGVsbC9lc2gtb3B0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVsbC9l c2gtb3B0LXRlc3RzLmVsCmluZGV4IDI1NTc2ODYzNWIuLmI3NmVkODg2NmQgMTAwNjQ0Ci0t LSBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLW9wdC10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3Av ZXNoZWxsL2VzaC1vcHQtdGVzdHMuZWwKQEAgLTI3LDQxICsyNyw2MyBAQCBlc2gtb3B0LXBy b2Nlc3MtYXJncy10ZXN0CiAgIChzaG91bGQKICAgIChlcXVhbCAnKHQpCiAgICAgICAgICAg KGVzaGVsbC0tcHJvY2Vzcy1hcmdzCi0gICAgICAgICAgICJzdWRvIgotICAgICAgICAgICAn KCItYSIpCi0gICAgICAgICAgICcoKD9hICJhbGwiIG5pbCBzaG93LWFsbCAiIikpKSkpCi0g IChzaG91bGQKLSAgIChlcXVhbCAnKG5pbCkKLSAgICAgICAgICAoZXNoZWxsLS1wcm9jZXNz LWFyZ3MKLSAgICAgICAgICAgInN1ZG8iCi0gICAgICAgICAgICcoIi1nIikKLSAgICAgICAg ICAgJygoP2EgImFsbCIgbmlsIHNob3ctYWxsICIiKSkpKSkKKyAgICAgICAgICAgInN1ZG8i ICcoIi1hIikKKyAgICAgICAgICAgJygoP2EgImFsbCIgbmlsIHNob3ctYWxsCisgICAgICAg ICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikpKSkp CiAgIChzaG91bGQKICAgIChlcXVhbCAnKCJyb290IiAid29ybGQiKQogICAgICAgICAgIChl c2hlbGwtLXByb2Nlc3MtYXJncwotICAgICAgICAgICAic3VkbyIKLSAgICAgICAgICAgJygi LXUiICJyb290IiAid29ybGQiKQotICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2VyICJl eGVjdXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVTRVIiKSkpKSkKKyAgICAgICAgICAgInN1 ZG8iICcoIi11IiAicm9vdCIgIndvcmxkIikKKyAgICAgICAgICAgJygoP3UgInVzZXIiIHQg dXNlcgorICAgICAgICAgICAgICAgICAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhlciBV U0VSIikpKSkpCiAgIChzaG91bGQKICAgIChlcXVhbCAnKG5pbCAiZW1lcmdlIiAiLXVETiIg IndvcmxkIikKICAgICAgICAgICAoZXNoZWxsLS1wcm9jZXNzLWFyZ3MKLSAgICAgICAgICAg InN1ZG8iCi0gICAgICAgICAgICcoImVtZXJnZSIgIi11RE4iICJ3b3JsZCIpCi0gICAgICAg ICAgICcoKD91ICJ1c2VyIiB0IHVzZXIgImV4ZWN1dGUgYSBjb21tYW5kIGFzIGFub3RoZXIg VVNFUiIpCisgICAgICAgICAgICJzdWRvIiAnKCJlbWVyZ2UiICItdUROIiAid29ybGQiKQor ICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2VyCisgICAgICAgICAgICAgICAgICJleGVj dXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVTRVIiKQogICAgICAgICAgICAgIDpwYXJzZS1s ZWFkaW5nLW9wdGlvbnMtb25seSkpKSkKICAgKHNob3VsZAogICAgKGVxdWFsICcoInJvb3Qi ICJlbWVyZ2UiICItdUROIiAid29ybGQiKQogICAgICAgICAgIChlc2hlbGwtLXByb2Nlc3Mt YXJncwotICAgICAgICAgICAic3VkbyIKLSAgICAgICAgICAgJygiLXUiICJyb290IiAiZW1l cmdlIiAiLXVETiIgIndvcmxkIikKLSAgICAgICAgICAgJygoP3UgInVzZXIiIHQgdXNlciAi ZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhlciBVU0VSIikKKyAgICAgICAgICAgInN1ZG8i ICcoIi11IiAicm9vdCIgImVtZXJnZSIgIi11RE4iICJ3b3JsZCIpCisgICAgICAgICAgICco KD91ICJ1c2VyIiB0IHVzZXIKKyAgICAgICAgICAgICAgICAgImV4ZWN1dGUgYSBjb21tYW5k IGFzIGFub3RoZXIgVVNFUiIpCiAgICAgICAgICAgICAgOnBhcnNlLWxlYWRpbmctb3B0aW9u cy1vbmx5KSkpKQogICAoc2hvdWxkCiAgICAoZXF1YWwgJygiRE4iICJlbWVyZ2UiICJ3b3Js ZCIpCiAgICAgICAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCi0gICAgICAgICAgICJzdWRv IgotICAgICAgICAgICAnKCItdSIgInJvb3QiICJlbWVyZ2UiICItdUROIiAid29ybGQiKQot ICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2VyICJleGVjdXRlIGEgY29tbWFuZCBhcyBh bm90aGVyIFVTRVIiKSkpKSkpCisgICAgICAgICAgICJzdWRvIiAnKCItdSIgInJvb3QiICJl bWVyZ2UiICItdUROIiAid29ybGQiKQorICAgICAgICAgICAnKCg/dSAidXNlciIgdCB1c2Vy CisgICAgICAgICAgICAgICAgICJleGVjdXRlIGEgY29tbWFuZCBhcyBhbm90aGVyIFVTRVIi KSkpKSkKKworICA7OyBUZXN0IDpleHRlcm5hbC4KKyAgKGNsLWxldGYgKCgoc3ltYm9sLWZ1 bmN0aW9uICdlc2hlbGwtc2VhcmNoLXBhdGgpICMnaWdub3JlKSkKKyAgICAoc2hvdWxkCisg ICAgIChlcXVhbCAnKG5pbCAiL3NvbWUvcGF0aCIpCisgICAgICAgICAgICAoZXNoZWxsLS1w cm9jZXNzLWFyZ3MKKyAgICAgICAgICAgICAibHMiICcoIi9zb21lL3BhdGgiKQorICAgICAg ICAgICAgICcoKD9hICJhbGwiIG5pbCBzaG93LWFsbAorICAgICAgICAgICAgICAgICAgICJk byBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikKKyAgICAgICAgICAgICAg IDpleHRlcm5hbCAibHMiKSkpKSkKKyAgKGNsLWxldGYgKCgoc3ltYm9sLWZ1bmN0aW9uICdl c2hlbGwtc2VhcmNoLXBhdGgpICMnaWRlbnRpdHkpKQorICAgIChzaG91bGQKKyAgICAgKGVx dWFsICcobm8tY2F0Y2ggZXNoZWxsLWV4dC1jb21tYW5kICJscyIpCisgICAgICAgICAgICAo c2hvdWxkLWVycm9yCisgICAgICAgICAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCisgICAg ICAgICAgICAgICJscyIgJygiLXUiICIvc29tZS9wYXRoIikKKyAgICAgICAgICAgICAgJygo P2EgImFsbCIgbmlsIHNob3ctYWxsCisgICAgICAgICAgICAgICAgICAgICJkbyBub3QgaWdu b3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAuIikKKyAgICAgICAgICAgICAgICA6ZXh0ZXJu YWwgImxzIikpCisgICAgICAgICAgICAgOnR5cGUgJ25vLWNhdGNoKSkpKQorICAoY2wtbGV0 ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ2VzaGVsbC1zZWFyY2gtcGF0aCkgIydpZ25vcmUpKQor ICAgIChzaG91bGQtZXJyb3IKKyAgICAgKGVzaGVsbC0tcHJvY2Vzcy1hcmdzCisgICAgICAi bHMiICcoIi11IiAiL3NvbWUvcGF0aCIpCisgICAgICAnKCg/YSAiYWxsIiBuaWwgc2hvdy1h bGwKKyAgICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAu IikKKyAgICAgICAgOmV4dGVybmFsICJscyIpKQorICAgICA6dHlwZSAnZXJyb3IpKSkKIAog KGVydC1kZWZ0ZXN0IHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucyAoKQogICAiVGVz dHMgZm9yIGBlc2hlbGwtZXZhbC11c2luZy1vcHRpb25zJy4iCkBAIC0xOTAsNyArMjEyLDI3 IEBAIHRlc3QtZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucwogICAgJygoP3UgInVzZXIiIHQg dXNlciAiZXhlY3V0ZSBhIGNvbW1hbmQgYXMgYW5vdGhlciBVU0VSIikKICAgICAgOnBhcnNl LWxlYWRpbmctb3B0aW9ucy1vbmx5KQogICAgKHNob3VsZCAoZXEgdXNlciBuaWwpKQotICAg KHNob3VsZCAoZXF1YWwgYXJncyAnKCJlbWVyZ2UiICItdUROIiAid29ybGQiKSkpKSkKKyAg IChzaG91bGQgKGVxdWFsIGFyZ3MgJygiZW1lcmdlIiAiLXVETiIgIndvcmxkIikpKSkKKwor ICA7OyBUZXN0IHVucmVjb2duaXplZCBvcHRpb25zLgorICAoc2hvdWxkLWVycm9yCisgICAo ZXNoZWxsLWV2YWwtdXNpbmctb3B0aW9ucworICAgICJscyIgJygiLXUiICIvc29tZS9wYXRo IikKKyAgICAnKCg/YSAiYWxsIiBuaWwgc2hvdy1hbGwKKyAgICAgICAgICAiZG8gbm90IGln bm9yZSBlbnRyaWVzIHN0YXJ0aW5nIHdpdGggLiIpKQorICAgIChpZ25vcmUgc2hvdy1hbGwp KSkKKyAgKHNob3VsZC1lcnJvcgorICAgKGVzaGVsbC1ldmFsLXVzaW5nLW9wdGlvbnMKKyAg ICAibHMiICcoIi1hdSIgIi9zb21lL3BhdGgiKQorICAgICcoKD9hICJhbGwiIG5pbCBzaG93 LWFsbAorICAgICAgICAgICJkbyBub3QgaWdub3JlIGVudHJpZXMgc3RhcnRpbmcgd2l0aCAu IikpCisgICAgKGlnbm9yZSBzaG93LWFsbCkpKQorICAoc2hvdWxkLWVycm9yCisgICAoZXNo ZWxsLWV2YWwtdXNpbmctb3B0aW9ucworICAgICJscyIgJygiLS11bnJlY29nbml6ZWQiICIv c29tZS9wYXRoIikKKyAgICAnKCg/YSAiYWxsIiBuaWwgc2hvdy1hbGwKKyAgICAgICAgICAi ZG8gbm90IGlnbm9yZSBlbnRyaWVzIHN0YXJ0aW5nIHdpdGggLiIpKQorICAgIChpZ25vcmUg c2hvdy1hbGwpKSkpCiAKIChwcm92aWRlICdlc2gtb3B0LXRlc3RzKQogCi0tIAoyLjI1LjEK Cg== --------------593DC222E3FC59E0D7B8133C Content-Type: text/plain; charset=UTF-8; name="0002-Don-t-use-eshell-eval-using-options-for-eshell-sourc.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0002-Don-t-use-eshell-eval-using-options-for-eshell-sourc.pa"; filename*1="tch" RnJvbSAzNjMxYmVhZGRmMmZmNzg2OWNiYTVkYWU2ZjBlOWI0OTkxZTdlM2Q2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMjAgSmFuIDIwMjIgMTk6NTE6MzkgLTA4MDAKU3ViamVjdDogW1BB VENIIDIvMl0gRG9uJ3QgdXNlICdlc2hlbGwtZXZhbC11c2luZy1vcHRpb25zJyBmb3IgJ2Vz aGVsbC9zb3VyY2UnCiBvciAnZXNoZWxsLy4nCgpUaGlzIG1ha2VzICdzb3VyY2UnIGFuZCAn LicgaW4gRXNoZWxsIG1vcmUgY29tcGF0aWJsZSB3aXRoIHJlZ3VsYXIKc2hlbGxzLCB3aGlj aCBqdXN0IHRyZWF0IHRoZSBmaXJzdCBhcmd1bWVudCBhcyB0aGUgZmlsZSB0byBzb3VyY2Ug YW5kCmFsbCBzdWJzZXF1ZW50IGFyZ3VtZW50cyBhcyBhcmd1bWVudHMgdG8gdGhhdCBmaWxl LgoKKiBsaXNwL2VzaGVsbC9lbS1zY3JpcHQuZWwgKGVzaGVsbC9zb3VyY2UsIGVzaGVsbC8u KTogRG9uJ3QgdXNlCidlc2hlbGwtZXZhbC11c2luZy1vcHRpb25zJy4KCiogZXRjL05FV1M6 IEFubm91bmNlIHRoZSBjaGFuZ2UuCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICAgIHwg IDUgKysrKysKIGxpc3AvZXNoZWxsL2VtLXNjcmlwdC5lbCB8IDE4ICsrLS0tLS0tLS0tLS0t LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggYWU0YmY3ZTRkMy4u YjRiNjZiZWMwZSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTEw NCw2ICsxMDQsMTEgQEAgZmlsZXMgdGhhdCB3ZXJlIGNvbXBpbGVkIHdpdGggYW4gb2xkIEVJ RUlPIChFbWFjczwyNSkuCiAqKiAnQy14IDggLicgaGFzIGJlZW4gbW92ZWQgdG8gJ0MteCA4 IC4gLicuCiBUaGlzIGlzIHRvIG9wZW4gdXAgdGhlICdDLXggOCAuJyBtYXAgdG8gYmluZCBm dXJ0aGVyIGNoYXJhY3RlcnMgdGhlcmUuCiAKKy0tLQorKiogJ3NvdXJjZScgYW5kICcuJyBp biBFc2hlbGwgbm8gbG9uZ2VyIGFjY2VwdCB0aGUgJy0taGVscCcgb3B0aW9uLgorVGhpcyBp cyBmb3IgY29tcGF0aWJpbGl0eSB3aXRoIHRoZSBzaGVsbCB2ZXJzaW9ucyBvZiB0aGVzZSBj b21tYW5kcywKK3doaWNoIGRvbid0IGhhbmRsZSBvcHRpb25zIGxpa2UgJy0taGVscCcgaW4g YW55IHNwZWNpYWwgd2F5LgorCiAMCiAqIENoYW5nZXMgaW4gRW1hY3MgMjkuMQogCmRpZmYg LS1naXQgYS9saXNwL2VzaGVsbC9lbS1zY3JpcHQuZWwgYi9saXNwL2VzaGVsbC9lbS1zY3Jp cHQuZWwKaW5kZXggZTg0NTk1MTNmMy4uZTBiY2Q4YjA5OSAxMDA2NDQKLS0tIGEvbGlzcC9l c2hlbGwvZW0tc2NyaXB0LmVsCisrKyBiL2xpc3AvZXNoZWxsL2VtLXNjcmlwdC5lbApAQCAt MTEzLDI3ICsxMTMsMTMgQEAgZXNoZWxsLXNvdXJjZS1maWxlCiAKIChkZWZ1biBlc2hlbGwv c291cmNlICgmcmVzdCBhcmdzKQogICAiU291cmNlIGEgZmlsZSBpbiBhIHN1YnNoZWxsIGVu dmlyb25tZW50LiIKLSAgKGVzaGVsbC1ldmFsLXVzaW5nLW9wdGlvbnMKLSAgICJzb3VyY2Ui IGFyZ3MKLSAgICcoKD9oICJoZWxwIiBuaWwgbmlsICJzaG93IHRoaXMgdXNhZ2Ugc2NyZWVu IikKLSAgICAgOnNob3ctdXNhZ2UKLSAgICAgOnVzYWdlICJGSUxFIFtBUkdTXQotSW52b2tl IHRoZSBFc2hlbGwgY29tbWFuZHMgaW4gRklMRSBpbiBhIHN1YnNoZWxsLCBiaW5kaW5nIEFS R1MgdG8gJDEsCi0kMiwgZXRjLiIpCi0gICAoZXNoZWxsLXNvdXJjZS1maWxlIChjYXIgYXJn cykgKGNkciBhcmdzKSB0KSkpCisgIChlc2hlbGwtc291cmNlLWZpbGUgKGNhciBhcmdzKSAo Y2RyIGFyZ3MpIHQpKQogCiAocHV0ICdlc2hlbGwvc291cmNlICdlc2hlbGwtbm8tbnVtZXJp Yy1jb252ZXJzaW9ucyB0KQogCiAoZGVmdW4gZXNoZWxsLy4gKCZyZXN0IGFyZ3MpCiAgICJT b3VyY2UgYSBmaWxlIGluIHRoZSBjdXJyZW50IGVudmlyb25tZW50LiIKLSAgKGVzaGVsbC1l dmFsLXVzaW5nLW9wdGlvbnMKLSAgICIuIiBhcmdzCi0gICAnKCg/aCAiaGVscCIgbmlsIG5p bCAic2hvdyB0aGlzIHVzYWdlIHNjcmVlbiIpCi0gICAgIDpzaG93LXVzYWdlCi0gICAgIDp1 c2FnZSAiRklMRSBbQVJHU10KLUludm9rZSB0aGUgRXNoZWxsIGNvbW1hbmRzIGluIEZJTEUg d2l0aGluIHRoZSBjdXJyZW50IHNoZWxsCi1lbnZpcm9ubWVudCwgYmluZGluZyBBUkdTIHRv ICQxLCAkMiwgZXRjLiIpCi0gICAoZXNoZWxsLXNvdXJjZS1maWxlIChjYXIgYXJncykgKGNk ciBhcmdzKSkpKQorICAoZXNoZWxsLXNvdXJjZS1maWxlIChjYXIgYXJncykgKGNkciBhcmdz KSkpCiAKIChwdXQgJ2VzaGVsbC8uICdlc2hlbGwtbm8tbnVtZXJpYy1jb252ZXJzaW9ucyB0 KQogCi0tIAoyLjI1LjEKCg== --------------593DC222E3FC59E0D7B8133C-- From unknown Sun Jun 22 17:15:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53293: 29.0.50; [PATCH] `eshell-eval-using-options' should report error for unrecognized option, even with no :external Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 12:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: Eli Zaretskii , 53293@debbugs.gnu.org Received: via spool by 53293-submit@debbugs.gnu.org id=B53293.164276683727045 (code B ref 53293); Fri, 21 Jan 2022 12:08:01 +0000 Received: (at 53293) by debbugs.gnu.org; 21 Jan 2022 12:07:17 +0000 Received: from localhost ([127.0.0.1]:60492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAshJ-000729-Em for submit@debbugs.gnu.org; Fri, 21 Jan 2022 07:07:17 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAshI-00071t-CD for 53293@debbugs.gnu.org; Fri, 21 Jan 2022 07:07:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pSxuz5SeFd5BIbvhC2kmmYq6z3bpgn7opbds3fCkKKo=; b=rzjcqU1Q5bNN5vQC6JwtxtgpiC vPs1tLXKnGijsLOmjslo1fsvaf/ExZIaxnX08Y7761zknoJO/BlUEHJQ/QkhaopWIQYpu9qlrjYvQ msE3SV8BFDityf3Z8TGTFEH1QYpVh4r+tjjEuT6iSxkUzO2fyxg7ZkNkciOhAjtILXGo=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAsh9-00045Q-OZ; Fri, 21 Jan 2022 13:07:10 +0100 From: Lars Ingebrigtsen References: <60740b82-3bea-7fb9-bfc6-617488f656a8@gmail.com> <838rvgyrtu.fsf@gnu.org> <632df5ab-007a-d859-fea6-89861c03ff1c@gmail.com> <83y23apr05.fsf@gnu.org> X-Now-Playing: David Bowie's _Brilliant Adventure (1): Black Tie White Noise_: "The Wedding" Date: Fri, 21 Jan 2022 13:07:07 +0100 In-Reply-To: (Jim Porter's message of "Thu, 20 Jan 2022 20:00:00 -0800") Message-ID: <875yqdqolw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Thanks. Here are updated patches with a NEWS entry to explain the > change to `source' and `.'. I also rebased the first patch to fix a > merge conflict with the patch for bug#27361. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Thanks. Here are updated patches with a NEWS entry to explain the > change to `source' and `.'. I also rebased the first patch to fix a > merge conflict with the patch for bug#27361. Thanks; skimming the patch, it looks OK to me, and I've now pushed it to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 07:07:23 2022 Received: (at control) by debbugs.gnu.org; 21 Jan 2022 12:07:23 +0000 Received: from localhost ([127.0.0.1]:60495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAshO-00072Q-Lb for submit@debbugs.gnu.org; Fri, 21 Jan 2022 07:07:23 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAshN-000722-LO for control@debbugs.gnu.org; Fri, 21 Jan 2022 07:07:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oVGYghtZFC5CygLI0ex889nXc/kszgDYhm6j2tq17iY=; b=UFm2Po9mW0lVpqHJEFGocBUXmF 5xsooxw8RAOyq2ANO3pverapsO20sRg9oKOUZZvTg1iGvLHY0FS4X3HSlQcF6azNBsUWkfG3LcmqI R8Icm/XyyWVJSy3nBC0YTuFwrAg8PCDQnwd8b9hMo7P7JjyOv/Utx0o1Rpw3t8/kbcUY=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAshG-00045X-3P for control@debbugs.gnu.org; Fri, 21 Jan 2022 13:07:16 +0100 Date: Fri, 21 Jan 2022 13:07:13 +0100 Message-Id: <874k5xqolq.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53293 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 53293 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 53293 29.1 quit