GNU bug report logs - #53291
[PATCH] build: clojure-build-system: Exit with non-zero if tests fail.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53291: closed ([PATCH] build: clojure-build-system: Exit with
 non-zero if tests fail.)
Date: Mon, 24 Jan 2022 09:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 24 Jan 2022 10:11:21 +0100
with message-id <87y235wlae.fsf <at> gnu.org>
and subject line Re: bug#53291: [PATCH] build: clojure-build-system: Exit with non-zero if tests fail.
has caused the debbugs.gnu.org bug report #53291,
regarding [PATCH] build: clojure-build-system: Exit with non-zero if tests fail.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53291
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Reily Siegel <mail <at> reilysiegel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] build: clojure-build-system: Exit with non-zero if tests fail.
Date: Sat, 15 Jan 2022 20:03:25 -0500

* guix/build/clojure-build-system.scm (check): Exit test process with a
non-zero exit code if tests fail.
---
 guix/build/clojure-build-system.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/guix/build/clojure-build-system.scm b/guix/build/clojure-build-system.scm
index 91d6122afe..22e90581a5 100644
--- a/guix/build/clojure-build-system.scm
+++ b/guix/build/clojure-build-system.scm
@@ -99,8 +99,11 @@ (define* (check #:key
         (for-each (lambda (jar)
                     (eval-with-clojure `(do (apply require
                                                    '(clojure.test ,@libs*))
-                                            (apply clojure.test/run-tests
-                                                   ',libs*))
+                                            (if (clojure.test/successful?
+                                                 (apply clojure.test/run-tests
+                                                        ',libs*))
+                                                (System/exit 0)
+                                                (System/exit 1)))
                                        (cons jar test-dirs)))
                   jar-names)))
   #t)
-- 
2.34.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Reily Siegel <mail <at> reilysiegel.com>
Cc: 53291-done <at> debbugs.gnu.org
Subject: Re: bug#53291: [PATCH] build: clojure-build-system: Exit with
 non-zero if tests fail.
Date: Mon, 24 Jan 2022 10:11:21 +0100

Hi,

Reily Siegel <mail <at> reilysiegel.com> skribis:

> * guix/build/clojure-build-system.scm (check): Exit test process with a
> non-zero exit code if tests fail.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.