GNU bug report logs - #53290
[PATCH] gnu: Add emacs-fennel-mode.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brandon Lucas <br <at> ndon.dk>
Cc: 53290 <at> debbugs.gnu.org
Subject: [bug#53290] [PATCH] gnu: Add emacs-fennel-mode.
Date: Sun, 16 Jan 2022 10:17:16 +0100

Hello,

Brandon Lucas <br <at> ndon.dk> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable.

Thank you for this. Some comments follow.

> +(define-public emacs-fennel-mode
> +  (let ((commit "54ed0792d0ac43a2d5db39741cf070c627368419")
> +        (revision "0"))
> +    (package
> +      (name "emacs-fennel-mode")
> +      (version (git-version "0.4.1" revision commit))

The commit hash you use matches the "0.4.1" version bump. Therefore you
can drop commit and revision binding, and use "0.4.1" in the version
field.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://gitlab.com/technomancy/fennel-mode.git")

You can drop the ".git" suffix here. I think "./pre-inst-env guix lint
emacs-fennel-mode" should warn you about it.

> +               (commit commit)))

Since you dropped commit binding, this should be (commit version)

> +      (description
> +       "Provides font-lock, indentation, navigation, and repl for Fennel code
> + within Emacs.")

Descriptions are expected to be full sentences. I suggest:

  Fennel mode provides font-lock, indentation, navigation and REPL for
  Fennel code within Emacs.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.