From unknown Tue Jun 24 05:08:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53290 <53290@debbugs.gnu.org> To: bug#53290 <53290@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add emacs-fennel-mode. Reply-To: bug#53290 <53290@debbugs.gnu.org> Date: Tue, 24 Jun 2025 12:08:03 +0000 retitle 53290 [PATCH] gnu: Add emacs-fennel-mode. reassign 53290 guix-patches submitter 53290 Brandon Lucas severity 53290 normal tag 53290 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 17:23:42 2022 Received: (at submit) by debbugs.gnu.org; 15 Jan 2022 22:23:42 +0000 Received: from localhost ([127.0.0.1]:42170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8rSW-0006Qq-4z for submit@debbugs.gnu.org; Sat, 15 Jan 2022 17:23:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:49272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8r6P-0005pa-1P for submit@debbugs.gnu.org; Sat, 15 Jan 2022 17:00:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8r6D-0001YF-BG for guix-patches@gnu.org; Sat, 15 Jan 2022 17:00:42 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:10534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8r65-00013B-0X for guix-patches@gnu.org; Sat, 15 Jan 2022 17:00:32 -0500 Date: Sat, 15 Jan 2022 22:00:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndon.dk; s=protonmail; t=1642284018; bh=Xng64vAm42HAeLFJAsEH8DRwPRb/DCUJ2J3eeAC7IBk=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:From:To:Cc; b=TWS52Bpul2mdNjYurwZQSvNxbxO17tlgtyVXMnZKWM9mSjysE1MTfCBixK2HtphLK 4qPRPKLyzC4pHcHI34DVfeOmLFnl9EHjPOmIniAd53UIGVebQvQU+ZmDcJZob2RlL1 nkaZvSzlnA0492oUBcwF7VE8k1FdOvZ1DnjgfS9E8V+JJVMxdelUqVlhjzG+870QTS MMp1eg2IPkXRq6nEWR6bTz9u99ATl5r1nXl1eNCoXAeUbDIfS+BDJiIzw6g1zUeRFc 7cbbqeI6OFcI7SgUdj7ags86Dh22UscSiz1Qh6vZQ2LibgitiE/XZ++CDAMe2nu+so Um6fBG4YSqoug== To: guix-patches@gnu.org From: Brandon Lucas Subject: [PATCH] gnu: Add emacs-fennel-mode. Message-ID: <20220115215925.1542641-1-br@ndon.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.43.23; envelope-from=br@ndon.dk; helo=mail-4323.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 15 Jan 2022 17:23:39 -0500 Cc: Brandon Lucas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Brandon Lucas Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable. --- gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c5cb07e16e..8175c48478 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -106,6 +106,7 @@ ;;; Copyright =C2=A9 2021 la snesne ;;; Copyright =C2=A9 2021 Brian Kubisiak ;;; Copyright =C2=A9 2021, 2022 Taiju HIGASHI +;;; Copyright =C2=A9 2022 Brandon Lucas ;;; ;;; This file is part of GNU Guix. ;;; @@ -29754,3 +29755,25 @@ (define-public emacs-global-tags wraps GNU Global calls and integration to editor using this API with project.el and xref.el.") (license license:gpl3+)))) + +(define-public emacs-fennel-mode + (let ((commit "54ed0792d0ac43a2d5db39741cf070c627368419") + (revision "0")) + (package + (name "emacs-fennel-mode") + (version (git-version "0.4.1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/technomancy/fennel-mode.git") + (commit commit))) + (sha256 + (base32 "0dwas3ivhxdyw6njkcadc8c17cirq325cmby04qls8zkmrvlil1w"))= )) + (build-system emacs-build-system) + (home-page "https://gitlab.com/technomancy/fennel-mode") + (synopsis "Emacs major-mode for editing Fennel code") + (description + "Provides font-lock, indentation, navigation, and repl for Fennel c= ode + within Emacs.") + (license license:gpl3+)))) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 04:17:28 2022 Received: (at 53290) by debbugs.gnu.org; 16 Jan 2022 09:17:28 +0000 Received: from localhost ([127.0.0.1]:42469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91fD-0000eQ-Ti for submit@debbugs.gnu.org; Sun, 16 Jan 2022 04:17:28 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:44281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n91fB-0000e8-D4 for 53290@debbugs.gnu.org; Sun, 16 Jan 2022 04:17:26 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 1A14A40004; Sun, 16 Jan 2022 09:17:17 +0000 (UTC) From: Nicolas Goaziou To: Brandon Lucas Subject: Re: [bug#53290] [PATCH] gnu: Add emacs-fennel-mode. References: <20220115215925.1542641-1-br@ndon.dk> Date: Sun, 16 Jan 2022 10:17:16 +0100 In-Reply-To: <20220115215925.1542641-1-br@ndon.dk> (Brandon Lucas's message of "Sat, 15 Jan 2022 22:00:02 +0000") Message-ID: <87lezg11lv.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53290 Cc: 53290@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Brandon Lucas writes: > * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable. Thank you for this. Some comments follow. > +(define-public emacs-fennel-mode > + (let ((commit "54ed0792d0ac43a2d5db39741cf070c627368419") > + (revision "0")) > + (package > + (name "emacs-fennel-mode") > + (version (git-version "0.4.1" revision commit)) The commit hash you use matches the "0.4.1" version bump. Therefore you can drop commit and revision binding, and use "0.4.1" in the version field. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/technomancy/fennel-mode.git") You can drop the ".git" suffix here. I think "./pre-inst-env guix lint emacs-fennel-mode" should warn you about it. > + (commit commit))) Since you dropped commit binding, this should be (commit version) > + (description > + "Provides font-lock, indentation, navigation, and repl for Fennel code > + within Emacs.") Descriptions are expected to be full sentences. I suggest: Fennel mode provides font-lock, indentation, navigation and REPL for Fennel code within Emacs. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 12:07:16 2022 Received: (at 53290) by debbugs.gnu.org; 16 Jan 2022 17:07:16 +0000 Received: from localhost ([127.0.0.1]:44153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n98zr-0002d2-Np for submit@debbugs.gnu.org; Sun, 16 Jan 2022 12:07:16 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:32960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n937Y-0005Hu-3y for 53290@debbugs.gnu.org; Sun, 16 Jan 2022 05:50:52 -0500 Date: Sun, 16 Jan 2022 10:50:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndon.dk; s=protonmail; t=1642330240; bh=77LyLUnl7gsO4emSR3Z6SZaKb3S6zuBltugXu+Egmrw=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:From:To:Cc; b=C/5SZ29Rf/nqBoPuK7EjaHTpNXx0YxCVldo2Kf2peVR8ymv0jtUgG7aJ9GjSxSuZY h9zBrN+ckTQ7q4QASvyBjLwU9XtTGiyS77dUYUXhEXu30Rdg8yk3bpOueBt+RQRM+8 DOxlTtpFPCLBTziquxi1b+xgKdCCFr5iAiBZGT0DkzE7FwnOUeSEh0TQf0s8XPAn19 6atQrjrg0BGeToe8rd8TxKkpyrhO8N8yXi+AWzHdGRY/k04hzlUs3s27rh3ZHQc4Ec Lhn4lEGQQiWzJFLtTx/k9CzSwwll2AN3PPejomrVfy07nA3rFJaKCcEyNDBE1PXKlg QZsS0aSl1Ow4g== To: 53290@debbugs.gnu.org From: Brandon Lucas Subject: [PATCH v2] gnu: Add emacs-fennel-mode. Message-ID: <20220116104949.1618147-1-br@ndon.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53290 X-Mailman-Approved-At: Sun, 16 Jan 2022 12:07:14 -0500 Cc: Brandon Lucas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Brandon Lucas Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable. --- Thanks for the review. :) Here's a better commit. gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c5cb07e16e..27b5c14fc5 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -106,6 +106,7 @@ ;;; Copyright =C2=A9 2021 la snesne ;;; Copyright =C2=A9 2021 Brian Kubisiak ;;; Copyright =C2=A9 2021, 2022 Taiju HIGASHI +;;; Copyright =C2=A9 2022 Brandon Lucas ;;; ;;; This file is part of GNU Guix. ;;; @@ -29754,3 +29755,23 @@ (define-public emacs-global-tags wraps GNU Global calls and integration to editor using this API with project.el and xref.el.") (license license:gpl3+)))) + +(define-public emacs-fennel-mode + (package + (name "emacs-fennel-mode") + (version "0.4.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/technomancy/fennel-mode") + (commit version))) + (sha256 + (base32 "0dwas3ivhxdyw6njkcadc8c17cirq325cmby04qls8zkmrvlil1w")))) + (build-system emacs-build-system) + (home-page "https://gitlab.com/technomancy/fennel-mode") + (synopsis "Emacs major-mode for editing Fennel code") + (description + "Fennel mode provides font-lock, indentation, navigation, and REPL fo= r + Fennel code within Emacs.") + (license license:gpl3+))) -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 17:37:19 2022 Received: (at 53290-done) by debbugs.gnu.org; 16 Jan 2022 22:37:20 +0000 Received: from localhost ([127.0.0.1]:44409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9E9H-00057V-Nm for submit@debbugs.gnu.org; Sun, 16 Jan 2022 17:37:19 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9E9F-00057F-TU for 53290-done@debbugs.gnu.org; Sun, 16 Jan 2022 17:37:18 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id EB79C240004; Sun, 16 Jan 2022 22:37:10 +0000 (UTC) From: Nicolas Goaziou To: Brandon Lucas Subject: Re: [bug#53290] [PATCH v2] gnu: Add emacs-fennel-mode. References: <20220115215925.1542641-1-br@ndon.dk> <20220116104949.1618147-1-br@ndon.dk> Date: Sun, 16 Jan 2022 23:37:09 +0100 In-Reply-To: <20220116104949.1618147-1-br@ndon.dk> (Brandon Lucas's message of "Sun, 16 Jan 2022 10:50:33 +0000") Message-ID: <87a6fv1f56.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53290-done Cc: 53290-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Brandon Lucas writes: > * gnu/packages/emacs-xyz.scm (emacs-fennel-mode): New variable. Applied, thank you! As a side note, it is usually a bad idea to add a new package at the end of a file, because this location is likely to introduce merge conflicts. Regards, -- Nicolas Goaziou From unknown Tue Jun 24 05:08:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Feb 2022 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator