GNU bug report logs - #53286
[PATCH 0/3] Small fixes for some matrix packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 53286 in the body.
You can then email your comments to 53286 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Small fixes for some matrix packages
Date: Sat, 15 Jan 2022 11:28:55 -0500

So emacs-ement doesn't work without its inputs being propagated.  I think pantalaimon works with its current inputs but the panctl program to control pantalaimon (which is part of the pantalaimon package) doesn't work without these inputs.

[PATCH 1/3] gnu: emacs-ement: Propagate inputs.
[PATCH 2/3] gnu: Add python-pydbus.
[PATCH 3/3] gnu: pantalaimon: Add needed inputs

Message #8 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 53286 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 1/3] gnu: emacs-ement: Propagate inputs.
Date: Sat, 15 Jan 2022 11:52:41 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/emacs-xyz (emacs-ement) <inputs>: Change to propagated-inputs.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4a701d21e3..80d4228e64 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15244,7 +15244,7 @@ (define-public emacs-ement
       (build-system emacs-build-system)
       (arguments
        `(#:emacs ,emacs))               ;need libxml support
-      (inputs
+      (propagated-inputs
        (list emacs-plz emacs-ts))
       (home-page "https://github.com/alphapapa/ement.el")
       (synopsis "Matrix client for Emacs")
-- 
2.34.0

Message #11 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 53286 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 2/3] gnu: Add python-pydbus.
Date: Sat, 15 Jan 2022 11:52:42 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/python-xyz.scm (python-pydbus): New variable.
---
 gnu/packages/python-xyz.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 3f8f6d4618..ba8f4af6fd 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9121,6 +9121,23 @@ (define-public python-user-agents
 (define-public python2-user-agents
   (package-with-python2 python-user-agents))
 
+(define-public python-pydbus
+  (package
+    (name "python-pydbus")
+    (version "0.6.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pydbus" version))
+        (sha256
+          (base32 "0b0gipvz7vcfa9ddmwq2jrx16d4apb0hdnl5q4i3h8jlzwp1c1s2"))))
+    (build-system python-build-system)
+    (propagated-inputs (list python-pygobject))
+    (home-page "https://github.com/LEW21/pydbus")
+    (synopsis "Pythonic DBus library")
+    (description "Pythonic DBus library")
+    (license #f)))
+
 (define-public python-dbus
   (package
     (name "python-dbus")
-- 
2.34.0

Message #14 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: 53286 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH 3/3] gnu: pantalaimon: Add needed inputs
Date: Sat, 15 Jan 2022 11:52:43 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/matrix.scm (pantalaimon) <propagated-inputs>: Add python-dbus,
python-notify2, python-pydbus, and python-pygobject.
---
 gnu/packages/matrix.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/matrix.scm b/gnu/packages/matrix.scm
index e2c27f5a4c..0c59a20306 100644
--- a/gnu/packages/matrix.scm
+++ b/gnu/packages/matrix.scm
@@ -24,6 +24,7 @@ (define-module (gnu packages matrix)
   #:use-module (gnu packages check)
   #:use-module (gnu packages crypto)
   #:use-module (gnu packages databases)
+  #:use-module (gnu packages glib)
   #:use-module (gnu packages monitoring)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-check)
@@ -270,12 +271,16 @@ (define-public pantalaimon
            python-attrs
            python-cachetools
            python-click
+           python-dbus
            python-janus
            python-keyring
            python-logbook
            python-matrix-nio
+           python-notify2
            python-peewee
-           python-prompt-toolkit))
+           python-prompt-toolkit
+           python-pydbus
+           python-pygobject))
     (home-page "https://github.com/matrix-org/pantalaimon")
     (synopsis "Matrix proxy daemon that adds E2E encryption capabilities")
     (description
-- 
2.34.0

Message #17 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: Morgan.J.Smith <at> outlook.com
Cc: 53286 <at> debbugs.gnu.org
Subject: Re: bug#53286: [PATCH 0/3] Small fixes for some matrix packages
Date: Sat, 15 Jan 2022 17:02:46 +0000

Hi,
On 2022-01-15, 11:28 -0500, Morgan.J.Smith <at> outlook.com wrote:

> So emacs-ement doesn't work without its inputs being propagated.  I think pantalaimon works with its
> current inputs but the panctl program to control pantalaimon (which is part of the pantalaimon
> package) doesn't work without these inputs.
>
> [PATCH 1/3] gnu: emacs-ement: Propagate inputs.
> [PATCH 2/3] gnu: Add python-pydbus.
> [PATCH 3/3] gnu: pantalaimon: Add needed inputs
>

Patches for pantalaimon have been submitted before:
https://issues.guix.gnu.org/52700

-- 
Best regards,
Aleksandr Vityazev

Message #20 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Morgan.J.Smith <at> outlook.com, 53286 <at> debbugs.gnu.org
Subject: Re: [bug#53286] [PATCH 2/3] gnu: Add python-pydbus.
Date: Sat, 15 Jan 2022 18:44:05 +0100

[Message part 1 (text/plain, inline)]

Hi,

Morgan.J.Smith <at> outlook.com schreef op za 15-01-2022 om 11:52 [-0500]:
> +    (license #f)))

According to the README it is lgpl2.1+.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: avityazev <at> posteo.org,
	maximedevos <at> telenet.be
Cc: 53286 <at> debbugs.gnu.org
Subject: [PATCH v2 0/3] Small fixes for some matrix packages
Date: Sat, 15 Jan 2022 14:59:39 -0500

Thanks for catching that Maxime!  That'll teach me to run guix lint before submitting patches :P

Thanks for pointing me to Bug#52700 Aleksandr!  I've combined your changes into mine and made you a co-author.  I hope that's ok with you.

These changes have been tested by installing them and using them.  So I setup pantalaimon and had it decrypt some matrix messages for me which I viewed using emacs-ement.

[PATCH v2 1/3] gnu: emacs-ement: Propagate inputs.
[PATCH v2 2/3] gnu: Add python-pydbus.
[PATCH v2 3/3] gnu: pantalaimon: Add needed inputs

Message #26 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: avityazev <at> posteo.org,
	maximedevos <at> telenet.be
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 53286 <at> debbugs.gnu.org
Subject: [PATCH v2 1/3] gnu: emacs-ement: Propagate inputs.
Date: Sat, 15 Jan 2022 14:59:40 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/emacs-xyz (emacs-ement) <inputs>: Change to propagated-inputs.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4a701d21e3..80d4228e64 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15244,7 +15244,7 @@ (define-public emacs-ement
       (build-system emacs-build-system)
       (arguments
        `(#:emacs ,emacs))               ;need libxml support
-      (inputs
+      (propagated-inputs
        (list emacs-plz emacs-ts))
       (home-page "https://github.com/alphapapa/ement.el")
       (synopsis "Matrix client for Emacs")
-- 
2.34.0

Message #29 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: avityazev <at> posteo.org,
	maximedevos <at> telenet.be
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 53286 <at> debbugs.gnu.org
Subject: [PATCH v2 2/3] gnu: Add python-pydbus.
Date: Sat, 15 Jan 2022 14:59:41 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/python-xyz.scm (python-pydbus): New variable.

Co-authored-by: Aleksandr Vityazev <avityazev <at> posteo.org>
---
 gnu/packages/python-xyz.scm | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 3f8f6d4618..11219749a4 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -92,8 +92,8 @@
 ;;; Copyright © 2020 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
 ;;; Copyright © 2019 Kristian Trandem <kristian <at> devup.no>
 ;;; Copyright © 2020, 2021 Zheng Junjie <873216071 <at> qq.com>
-;;; Copyright © 2021 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2020 EuAndreh <eu <at> euandre.org>
+;;; Copyright © 2021, 2022 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2021 Ellis Kenyő <me <at> elken.dev>
 ;;; Copyright © 2021 LibreMiami <packaging-guix <at> libremiami.org>
@@ -115,6 +115,7 @@
 ;;; Copyright © 2021 Filip Lajszczak <filip <at> lajszczak.dev>
 ;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
+;;; Copyright © 2022 Aleksandr Vityazev <avityazev <at> posteo.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -9121,6 +9122,26 @@ (define-public python-user-agents
 (define-public python2-user-agents
   (package-with-python2 python-user-agents))
 
+(define-public python-pydbus
+  (package
+    (name "python-pydbus")
+    (version "0.6.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pydbus" version))
+        (sha256
+          (base32 "0b0gipvz7vcfa9ddmwq2jrx16d4apb0hdnl5q4i3h8jlzwp1c1s2"))))
+    (build-system python-build-system)
+    (propagated-inputs (list python-pygobject))
+    (home-page "https://github.com/LEW21/pydbus")
+    (synopsis "Pythonic D-Bus library")
+    (description "Pydbus provides a pythonic interface to the D-Bus
+message bus system.  Pydbus can be used to access remote objects and
+also for object publication.  It is based on PyGI, the Python GObject
+Introspection bindings, which is the recommended way to use GLib from Python.")
+    (license license:lgpl2.1+)))
+
 (define-public python-dbus
   (package
     (name "python-dbus")
-- 
2.34.0

Message #32 received at 53286 <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: avityazev <at> posteo.org,
	maximedevos <at> telenet.be
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 53286 <at> debbugs.gnu.org
Subject: [PATCH v2 3/3] gnu: pantalaimon: Add needed inputs
Date: Sat, 15 Jan 2022 14:59:42 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/matrix.scm (pantalaimon)
<propagated-inputs>: Add python-dbus, python-notify2, python-pydbus, and
python-pygobject.
<arguments>: Run sanity-check phase.

Co-authored-by: Aleksandr Vityazev <avityazev <at> posteo.org>
---
 gnu/packages/matrix.scm | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/matrix.scm b/gnu/packages/matrix.scm
index e2c27f5a4c..5f94eb2075 100644
--- a/gnu/packages/matrix.scm
+++ b/gnu/packages/matrix.scm
@@ -3,6 +3,8 @@
 ;;; Copyright © 2020 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2020, 2021 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul <at> autistici.org>
+;;; Copyright © 2022 Aleksandr Vityazev <avityazev <at> posteo.org>
+;;; Copyright © 2022 Morgan Smith <Morgan.J.Smith <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,6 +26,7 @@ (define-module (gnu packages matrix)
   #:use-module (gnu packages check)
   #:use-module (gnu packages crypto)
   #:use-module (gnu packages databases)
+  #:use-module (gnu packages glib)
   #:use-module (gnu packages monitoring)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-check)
@@ -257,25 +260,28 @@ (define-public pantalaimon
            (lambda* (#:key tests? inputs outputs #:allow-other-keys)
              (when tests?
                (add-installed-pythonpath inputs outputs)
-               (invoke "pytest" "-vv" "tests"))))
-         ;; XXX: The sanity check trips on optional GUI libraries for the
-         ;; panctl command.
-         (delete 'sanity-check))))
+               (invoke "pytest" "-vv" "tests")))))))
     (native-inputs
-     (list python-pytest python-faker python-pytest-aiohttp
-           python-aioresponses))
+     (list python-aioresponses
+           python-faker
+           python-pytest
+           python-pytest-aiohttp))
     (propagated-inputs
      (list python-aiohttp
            python-appdirs
            python-attrs
            python-cachetools
            python-click
+           python-dbus
            python-janus
            python-keyring
            python-logbook
            python-matrix-nio
+           python-notify2
            python-peewee
-           python-prompt-toolkit))
+           python-prompt-toolkit
+           python-pydbus
+           python-pygobject))
     (home-page "https://github.com/matrix-org/pantalaimon")
     (synopsis "Matrix proxy daemon that adds E2E encryption capabilities")
     (description
-- 
2.34.0

Message #37 received at 53286-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Morgan.J.Smith <at> outlook.com
Cc: 53286-done <at> debbugs.gnu.org, maximedevos <at> telenet.be, avityazev <at> posteo.org
Subject: Re: [bug#53286] [PATCH v2 0/3] Small fixes for some matrix packages
Date: Mon, 17 Jan 2022 00:19:45 +0100

Hello,

Morgan.J.Smith <at> outlook.com writes:

> Thanks for catching that Maxime!  That'll teach me to run guix lint before submitting patches :P
>
> Thanks for pointing me to Bug#52700 Aleksandr!  I've combined your changes into mine and made you a co-author.  I hope that's ok with you.
>
> These changes have been tested by installing them and using them.  So I setup pantalaimon and had it decrypt some matrix messages for me which I viewed using emacs-ement.
>
> [PATCH v2 1/3] gnu: emacs-ement: Propagate inputs.
> [PATCH v2 2/3] gnu: Add python-pydbus.
> [PATCH v2 3/3] gnu: pantalaimon: Add needed inputs

I applied the patch set. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.