GNU bug report logs - #53279
[PATCH] gnu: Add emacs-dtache

Previous Next

Package: guix-patches;

Reported by: Niklas Eklund <niklas.eklund <at> posteo.net>

Date: Sat, 15 Jan 2022 08:36:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 53279 <at> debbugs.gnu.org (full text, mbox):

From: Niklas Eklund <niklas.eklund <at> posteo.net>
To: 53279 <at> debbugs.gnu.org
Subject: Re: [bug#53279] [PATCH] gnu: Add emacs-dtache
Date: Sat, 15 Jan 2022 14:31:27 +0000

[Message part 1 (text/plain, inline)]
Maxime Devos <maximedevos <at> telenet.be> writes:

> Hi,
>
> Niklas Eklund schreef op za 15-01-2022 om 08:35 [+0000]:
>> +      (modify-phases %standard-phases
>> +        (add-before 'install 'install-dtache-env
>> +          (lambda* (#:key outputs #:allow-other-keys)
>> +            (let* ((out  (assoc-ref outputs "out"))
>> +                   (bin  (string-append out "/bin")))
>> +              (mkdir-p bin)
>> +              (copy-file "dtache-env"
>> +                         (string-append bin "/dtache-env"))))))))
>
> FWIW you can eliminate (#:key outputs #:allow-other-keys) here:
>
>    ,#~(modify-phases %standard-phases
>         (add-before 'install 'install-dtache-env
>           (lambda _
>             (let ((bin (string-append #$output "/bin)))
>               (mkdir-p bin)
>               (copy-file "dtache-env"
>                          (string-append bin "/dtache-env"))))))))
>
> YMMV on whether that's an improvement or not -- technically
> they are equivalent.
>
> Greetings,
> Maxime.

Hi Maxime,

thanks for the suggestion :). Here is a new patch with the changes.

Cheers
Niklas


[0001-gnu-Add-emacs-dtache-package.patch (text/x-patch, attachment)]
This bug report was last modified 3 years and 181 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.