GNU bug report logs - #53270
[PATCH] gnu: Add yubikey-oath-dmenu.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53270: closed ([PATCH] gnu: Add yubikey-oath-dmenu.)
Date: Mon, 24 Jan 2022 09:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 24 Jan 2022 10:10:00 +0100
with message-id <8735ldxzx3.fsf_-_ <at> gnu.org>
and subject line Re: bug#53270: [PATCH] gnu: Add yubikey-oath-dmenu.
has caused the debbugs.gnu.org bug report #53270,
regarding [PATCH] gnu: Add yubikey-oath-dmenu.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53270: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53270
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add yubikey-oath-dmenu.
Date: Fri, 14 Jan 2022 21:15:10 +0000

[Message part 3 (text/plain, inline)]

Hello!

Here is a patch to add yubikey-oath-dmenu, a handy way to get OATH codes from a Yubikey with a dmenu interface. I use it all the time (though through rofi). It seemed the best place was in the security-token module with similar yubikey packages. This is written in python but meant to run as a program rather than used as a library, so I called it without a python- prefix (and it runs with just non-propagated inputs).

Thanks!
John

[0001-gnu-Add-yubikey-oath-dmenu.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: "53270 <at> debbugs.gnu.org" <53270-done <at> debbugs.gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#53270: [PATCH] gnu: Add yubikey-oath-dmenu.
Date: Mon, 24 Jan 2022 10:10:00 +0100

[Message part 6 (text/plain, inline)]

Hi,

John Kehayias <john.kehayias <at> protonmail.com> skribis:

> From a5958b588cebd23012d7d9cbeb8f1e22a3802ea2 Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias <at> protonmail.com>
> Date: Fri, 14 Jan 2022 16:11:47 -0500
> Subject: [PATCH] gnu: Add yubikey-oath-dmenu.
>
> * gnu/packages/security-token.scm (yubikey-oath-dmenu): New variable.

Applied.  I took the liberty to make the change below, to avoid using a
non-literal string as the ‘substitute*’ pattern (it’s possible to use a
non-literal string but more error prone).

Thanks John and Maxime!

Ludo’.

[Message part 7 (text/x-patch, inline)]

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index b2f9f83ba2..8190e1e1e2 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -471,14 +471,12 @@ (define-public yubikey-oath-dmenu
           (delete 'build)     ; or build
           (add-after 'unpack 'fix-paths
             (lambda* (#:key inputs #:allow-other-keys)
-              (for-each (lambda (tool)
-                          (substitute* "yubikey-oath-dmenu.py"
-                            (((string-append "'" tool))
-                             (string-append
-                              "'"
-                              (search-input-file inputs
-                                                 (string-append "/bin/" tool))))))
-                        (list "dmenu" "notify-send" "wl-copy" "xclip" "xdotool"))))
+              (substitute* "yubikey-oath-dmenu.py"
+                (("'(dmenu|notify-send|wl-copy|xclip|xdotool)" _ tool)
+                 (string-append
+                  "'"
+                  (search-input-file inputs
+                                     (string-append "/bin/" tool)))))))
           (replace 'install
             (lambda _
               (invoke "make" "install"

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.