GNU bug report logs - #53270
[PATCH] gnu: Add yubikey-oath-dmenu.

Previous Next

Package: guix-patches;

Reported by: John Kehayias <john.kehayias <at> protonmail.com>

Date: Fri, 14 Jan 2022 21:16:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: John Kehayias <john.kehayias <at> protonmail.com>, "53270 <at> debbugs.gnu.org" <53270 <at> debbugs.gnu.org>
Subject: [bug#53270] [PATCH v2] gnu: Add yubikey-oath-dmenu.
Date: Sat, 15 Jan 2022 12:27:24 +0100

[Message part 1 (text/plain, inline)]
John Kehayias via Guix-patches via schreef op vr 14-01-2022 om 23:01
[+0000]:
> +          (replace 'install
> +            (lambda _
> +              (invoke "make" "install"
> +                      (string-append "DESTDIR=" #$output)
> +                      "PREFIX="))))))

Guix doesn't do staged installation
(https://www.gnu.org/software/automake/manual/html_node/DESTDIR.html),
so I would avoid (ab)using DESTDIR here.  Instead of this phase,
maybe do

          (replace 'install
            (lambda _
              (invoke "make" "install"
                      (string-append "PREFIX=" #$output)))))))

instead (untested)?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.