From unknown Sat Aug 16 18:16:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5327 <5327@debbugs.gnu.org> To: bug#5327 <5327@debbugs.gnu.org> Subject: Status: 23.1; unload-feature-special-hooks add fill-nobreak-predicate Reply-To: bug#5327 <5327@debbugs.gnu.org> Date: Sun, 17 Aug 2025 01:16:26 +0000 retitle 5327 23.1; unload-feature-special-hooks add fill-nobreak-predicate reassign 5327 emacs submitter 5327 Kevin Ryde severity 5327 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 18:39:43 2010 Received: (at submit) by debbugs.gnu.org; 5 Jan 2010 23:39:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSJ03-0001j2-He for submit@debbugs.gnu.org; Tue, 05 Jan 2010 18:39:43 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSJ01-0001iu-3c for submit@debbugs.gnu.org; Tue, 05 Jan 2010 18:39:41 -0500 Received: from mail.gnu.org ([199.232.76.166]:52094 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSIzt-0001Sz-SM for submit@debbugs.gnu.org; Tue, 05 Jan 2010 18:39:37 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NSIzo-0004dg-TY for submit@debbugs.gnu.org; Tue, 05 Jan 2010 18:39:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO,UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:32830) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSIzo-0004dU-IV for submit@debbugs.gnu.org; Tue, 05 Jan 2010 18:39:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSIzn-0003JX-Vk for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 18:39:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSIzi-0003JL-MM for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 18:39:27 -0500 Received: from [199.232.76.173] (port=55169 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSIzi-0003JI-GF for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 18:39:22 -0500 Received: from mx20.gnu.org ([199.232.41.8]:42372) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSIzf-0004Yc-Is for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 18:39:22 -0500 Received: from mailout1-6.pacific.net.au ([61.8.2.213] helo=mailout1.pacific.net.au) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NSIz0-0002xm-6O for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2010 18:38:38 -0500 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 0AB085148A3 for ; Wed, 6 Jan 2010 10:38:21 +1100 (EST) Received: from blah.blah (ppp26FC.dyn.pacific.net.au [61.8.38.252]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 69FEC27407 for ; Wed, 6 Jan 2010 10:38:20 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.71) (envelope-from ) id 1NSIya-000374-1K for bug-gnu-emacs@gnu.org; Wed, 06 Jan 2010 10:38:12 +1100 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.1; unload-feature-special-hooks add fill-nobreak-predicate Date: Wed, 06 Jan 2010 10:38:11 +1100 Message-ID: <87eim4t95o.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) While nosing around the unload-feature stuff I wondered if unload-feature-special-hooks should include fill-nobreak-predicate, as it's a hook now. The damage from leaving an unloaded func there is limited to paragraph filling, and is likely to be either buffer local, or be autoloaded and then end up ok anyway. You can see a bad effect currently for instance with M-x sgml-mode M-x unload-feature sgml-mode type in a long line to be filled M-q => Symbol's function definition is void: sgml-fill-nobreak In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 20:30:53 2010 Received: (at 5327) by debbugs.gnu.org; 6 Jan 2010 01:30:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSKjd-00046U-7I for submit@debbugs.gnu.org; Tue, 05 Jan 2010 20:30:53 -0500 Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSKjb-00046P-Es for 5327@debbugs.gnu.org; Tue, 05 Jan 2010 20:30:52 -0500 Received: by bwz8 with SMTP id 8so10794324bwz.39 for <5327@debbugs.gnu.org>; Tue, 05 Jan 2010 17:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=aeqOHaHHyEcaVL/EFYnOZ4ip5yAqmfjVg+vZ95jcUfk=; b=YIpgTaMuEzz+vPIDBjNYRmeJy2L4Y7ncf+jp+rTfK2Y6UX1Dm4djP0ZnIg6kwcXecL MAYJ3Z8tJI/06A0wyUHQHoMYSEk5O1O5DaA+zVnq8KKqdJemznUtifs/mI8aayh5sYsP 4yJD3RKwEL5PBEZ4aY+/aTTDlYMzpSjnl/3Dc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=eN9oEBupUfT6EUQt6fUhP5N0sSYqVpwOKQIxVLgqyDbkwUP4i0s5IpKzaXfB1gYMme i6YJ/42GDcRpat3RmwXX/z2VrS4dLXJzN3+6+1ERThYtIV3VVptZo4XsVNoN5SWoR1+z v+C6czhaqJR4euhWh3jNybhaFhMFJWvAZIGAA= MIME-Version: 1.0 Received: by 10.204.33.131 with SMTP id h3mr1038752bkd.53.1262741446112; Tue, 05 Jan 2010 17:30:46 -0800 (PST) In-Reply-To: <87eim4t95o.fsf@blah.blah> References: <87eim4t95o.fsf@blah.blah> From: Juanma Barranquero Date: Wed, 6 Jan 2010 02:30:26 +0100 Message-ID: Subject: Re: bug#5327: 23.1; unload-feature-special-hooks add fill-nobreak-predicate To: Kevin Ryde Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5327 Cc: 5327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Wed, Jan 6, 2010 at 00:38, Kevin Ryde wrote: > While nosing around the unload-feature stuff I wondered if > unload-feature-special-hooks should include fill-nobreak-predicate, as > it's a hook now. It's a hook or hook-like, and its name does not end in -hooks?, so yes. As an aside, perhaps unload-feature should also remove automatically unloaded funcs from symbols called *-functions, which would eliminate much cruft from `unload-feature-special-hooks'. The question is whether there are many variables called -functions which are not really hooks. Juanma From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 07 16:46:24 2010 Received: (at control) by debbugs.gnu.org; 7 Jan 2010 21:46:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NT0BU-0002Kc-9Z for submit@debbugs.gnu.org; Thu, 07 Jan 2010 16:46:24 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NT0BR-0002KT-Fx for control@debbugs.gnu.org; Thu, 07 Jan 2010 16:46:22 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NT0BN-0007Nk-Fp; Thu, 07 Jan 2010 16:46:17 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19270.22057.471140.62769@fencepost.gnu.org> Date: Thu, 7 Jan 2010 16:46:17 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: 6FkqiEb_n:'MzWdv:@VuHO?)|TFAlr]M(}~|1S[^}^5eyTDOm)C5S%DhvfG/'xcuv@&m>g X-Debbugs-No-Ack: yes X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) tags 5272 moreinfo tags 5279 patch severity 5282 minor reassign 5284 emacs,gnus severity 5304 minor tags 5304 wontfix notabug tags 5310 patch severity 5327 minor reassign 5330 emacs,ns reassign 5331 emacs,ns reassign 5333 emacs,ns From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 08 16:28:35 2010 Received: (at 5327) by debbugs.gnu.org; 8 Jan 2010 21:28:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTMNn-0007uS-AL for submit@debbugs.gnu.org; Fri, 08 Jan 2010 16:28:35 -0500 Received: from mailout1-12.pacific.net.au ([125.255.80.131] helo=mailout1.pacific.net.au) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTMNl-0007uN-D7 for 5327@debbugs.gnu.org; Fri, 08 Jan 2010 16:28:34 -0500 Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout1.pacific.net.au (Postfix) with ESMTP id D1BFB5164E9; Sat, 9 Jan 2010 08:28:27 +1100 (EST) Received: from blah.blah (ppp2E37.dyn.pacific.net.au [61.8.46.55]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id A584D8C08; Sat, 9 Jan 2010 08:28:26 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.71) (envelope-from ) id 1NTMNP-0001hw-GT; Sat, 09 Jan 2010 08:28:11 +1100 From: Kevin Ryde To: Juanma Barranquero Subject: Re: bug#5327: 23.1; unload-feature-special-hooks add fill-nobreak-predicate References: <87eim4t95o.fsf@blah.blah> Date: Sat, 09 Jan 2010 08:28:10 +1100 In-Reply-To: (Juanma Barranquero's message of "Wed, 6 Jan 2010 02:30:26 +0100") Message-ID: <87ocl4e179.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 5327 Cc: 5327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Juanma Barranquero writes: > > The question is > whether there are many variables called -functions which are not > really hooks. That'd be the dangerous bit. I've got a defconst called -functions in some of my code, but it wouldn't be hurt. Those with a custom-type of 'hook or '(repeat function) could be likely. In fact any var with that custom-type might be ok to act on. A grep finds me three called -functions (code below) find-directory-functions auto-coding-functions compile-command-default-functions of which auto-coding-functions may be the only important one not presently in unload-feature-special-hooks. (pp (let (ret) (mapatoms (lambda (sym) (and (boundp sym) (get sym 'custom-type) (not (memq sym unload-feature-special-hooks)) (string-match "-functions\\'" (symbol-name sym)) (push (list sym (get sym 'custom-type)) ret)))) ret) (current-buffer)) From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 12:25:50 2011 Received: (at 5327-done) by debbugs.gnu.org; 11 Jul 2011 16:25:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgJIr-0002ld-Qh for submit@debbugs.gnu.org; Mon, 11 Jul 2011 12:25:49 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgJIp-0002lR-OP for 5327-done@debbugs.gnu.org; Mon, 11 Jul 2011 12:25:48 -0400 Received: by gyd5 with SMTP id 5so1681226gyd.3 for <5327-done@debbugs.gnu.org>; Mon, 11 Jul 2011 09:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=+UvpM//8MOl78FRfIgiGK2Krma85boiXnUuRkx+Wdgo=; b=dlynrsAxL8r+pibgFuh8UfhLOTwTZD0AFbBSOdEjiK99QncdthwfwLH3fvLpb6MnfF qyWLAiesCsL0aPdCWLbPrYXr6RgPb5ER2FRN32T0PvkjNZ2Lnh5o6XaJ69fxQC9ZJk2W stpQwuniqUji6LSA7vIdUe4AI7EWbL5nvzyxE= Received: by 10.143.90.11 with SMTP id s11mr272195wfl.366.1310401541411; Mon, 11 Jul 2011 09:25:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.144.4 with HTTP; Mon, 11 Jul 2011 09:25:01 -0700 (PDT) In-Reply-To: <87eim4t95o.fsf@blah.blah> References: <87eim4t95o.fsf@blah.blah> From: Juanma Barranquero Date: Mon, 11 Jul 2011 18:25:01 +0200 Message-ID: Subject: Re: bug#5327: 23.1; unload-feature-special-hooks add fill-nobreak-predicate To: Kevin Ryde Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 5327-done Cc: 5327-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Wed, Jan 6, 2010 at 00:38, Kevin Ryde wrote: > =C2=A0 =C2=A0M-x sgml-mode > =C2=A0 =C2=A0M-x unload-feature sgml-mode > =C2=A0 =C2=A0type in a long line to be filled > =C2=A0 =C2=A0M-q > =C2=A0 =C2=A0=3D> Symbol's function definition is void: sgml-fill-nobreak `fill-nobreak-predicate' was set locally, so it would be removed when the mode for the buffer was changed. Previously, `unload-feature' failed to do so unless the mode package's FEATURE-unload-function, assuming one existed, did by itself. Since revno:104702 `unload-feature' does so automatically, so the above case should work (i.e, unloading sgml-mode will change the buffer's major mode to text-mode). That said, I'll add that variable and some of the others you mentioned to `unload-feature-special-hooks' because it's better to be safe than sorry. But, what would be nice is some way to identify hook variables in a generic way, instead of special-casing still more of them. :-( > find-directory-functions > auto-coding-functions OK. > compile-command-default-functions I cannot find that one in the Emacs sources. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 21:52:26 2011 Received: (at 5327) by debbugs.gnu.org; 16 Jul 2011 01:52:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qhu3N-000132-Kz for submit@debbugs.gnu.org; Fri, 15 Jul 2011 21:52:25 -0400 Received: from mailout1-7.pacific.net.au ([61.8.2.214] helo=mailout1.pacific.net.au) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qhu3L-00012m-0D for 5327@debbugs.gnu.org; Fri, 15 Jul 2011 21:52:24 -0400 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id B51D05F236F; Sat, 16 Jul 2011 11:52:15 +1000 (EST) Received: from blah.blah (unknown [203.26.175.216]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 777FA2740E; Sat, 16 Jul 2011 11:52:14 +1000 (EST) Received: from gg by blah.blah with local (Exim 4.72) (envelope-from ) id 1Qhu3K-0004MV-4V; Sat, 16 Jul 2011 11:52:22 +1000 From: Kevin Ryde To: Juanma Barranquero Subject: Re: bug#5327: 23.1; unload-feature-special-hooks add fill-nobreak-predicate References: <87eim4t95o.fsf@blah.blah> Date: Sat, 16 Jul 2011 11:52:22 +1000 In-Reply-To: (Juanma Barranquero's message of "Mon, 11 Jul 2011 18:25:01 +0200") Message-ID: <87mxgfc7qh.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 5327 Cc: 5327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) Juanma Barranquero writes: > >> compile-command-default-functions > > I cannot find that one in the Emacs sources. Ah yes, sorry, that's one of my own slipped through. (Which I jigged up to add to unload-feature-special-hooks too anyway.) -- The sigfile one-line movie reviews series: "Les Amants du Pont Neuf" -- fine sequel to Les Amants du Pont Huit. From unknown Sat Aug 16 18:16:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Aug 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator