From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 11:43:13 2022 Received: (at submit) by debbugs.gnu.org; 14 Jan 2022 16:43:14 +0000 Received: from localhost ([127.0.0.1]:37958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8PfV-0006BD-Lg for submit@debbugs.gnu.org; Fri, 14 Jan 2022 11:43:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:36318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8PfS-0006B1-9v for submit@debbugs.gnu.org; Fri, 14 Jan 2022 11:43:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8PfR-0008Qq-GU for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 11:43:09 -0500 Received: from mail235c50.megamailservers.eu ([91.136.10.245]:59376 helo=mail56c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8PfP-0003sk-1U for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 11:43:09 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642178583; bh=fLUw87GwKJG8MqLQfRlIzucolAC4C36rpdLbKEz848I=; h=From:Subject:Date:To:From; b=J14XSLmm91HH3qzroj/Ye51bvtC880sl8q8ROr8bQ+/h01y1h+CTQNouC/Zet0IM+ Oc0OUKlJ+Bgs3maSvz+tMapZdnYlQM4zlBxdVsKNzj8oHn2NAzWbR4TbYOIBj7C5ig IjR0nsxtrg/If5256AyuH6nwwxivQ769+arp63Qw= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20EGh1Li023455 for ; Fri, 14 Jan 2022 16:43:03 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: char-syntax differs in interpreter and bytecode Message-Id: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> Date: Fri, 14 Jan 2022 17:43:00 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F27.61E1A817.003E, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.245; envelope-from=mattiase@acm.org; helo=mail56c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Fchar_syntax and the bytecode Bchar_syntax differ: Fchar_syntax calls SETUP_BUFFER_SYNTAX_TABLE. Bchar_syntax does not. Bchar_syntax converts arguments to multibyte. Fchar_syntax does not. The last property can be used to get different behaviour: (let ((cs (byte-compile (lambda (x) (char-syntax x))))) (with-temp-buffer (let ((st (make-syntax-table))) (set-buffer-multibyte nil) (modify-syntax-entry 128 "_" st) (set-syntax-table st) (list (funcall cs 128) (char-syntax 128))))) -> (119 95) Not sure how to expose the presence or absence of = SETUP_BUFFER_SYNTAX_TABLE. Suggestions? And, most importantly, what would be the correct code? (I suppose char-syntax is rare enough that we could call Fchar_syntax = from Bchar_syntax and thus avoid any future divergence.) From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 03:36:30 2022 Received: (at 53260) by debbugs.gnu.org; 15 Jan 2022 08:36:30 +0000 Received: from localhost ([127.0.0.1]:38938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8eY1-0008D2-VE for submit@debbugs.gnu.org; Sat, 15 Jan 2022 03:36:30 -0500 Received: from quimby.gnus.org ([95.216.78.240]:46536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8eXz-0008Ck-K5 for 53260@debbugs.gnu.org; Sat, 15 Jan 2022 03:36:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qaeis2wTkA2khsynrrk8h3unvSr0Y0Ehe7Rzh2Er+4Q=; b=ApvArmraYjrj6J/MzYNvTSg2b5 qhuk+ETfq1H6EK+d79iTwCEWpe5Ma4PbqAMBqXVJra2R/p8LPPyYvpjRdYBf6RnBcpXVFyqAQDnS9 9HM0tSR+chyLjqGjruqGObRvNkzADfXW7Nu1TJ9ManZAK+hhbM+xDEtMUuqI5KdAD/08=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8eXp-0002eg-L3; Sat, 15 Jan 2022 09:36:20 +0100 From: Lars Ingebrigtsen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> X-Now-Playing: Joni Mitchell's _Archives: The Early Years (3)_: "I Don't Know Where I Stand" Date: Sat, 15 Jan 2022 09:36:16 +0100 In-Reply-To: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Fri, 14 Jan 2022 17:43:00 +0100") Message-ID: <8735lpmm4f.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias Engdegård writes: > Fchar_syntax and the bytecode Bchar_syntax differ: > > Fchar_syntax calls SETUP_BUFFER_SYNTAX_TABLE. Bchar_syntax does not. > Bchar_syntax converts arguments to multibyte. Fchar_syntax does not. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53260 Cc: 53260@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > Fchar_syntax and the bytecode Bchar_syntax differ: > > Fchar_syntax calls SETUP_BUFFER_SYNTAX_TABLE. Bchar_syntax does not. > Bchar_syntax converts arguments to multibyte. Fchar_syntax does not. [...] > And, most importantly, what would be the correct code? Hm. Perhaps Stefan has an opinion; added to the CCs. > (I suppose char-syntax is rare enough that we could call Fchar_syntax > from Bchar_syntax and thus avoid any future divergence.) Used 172 times in-core, which isn't that rare... --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 09:46:41 2022 Received: (at 53260) by debbugs.gnu.org; 15 Jan 2022 14:46:42 +0000 Received: from localhost ([127.0.0.1]:39602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8kKH-0003ME-Lm for submit@debbugs.gnu.org; Sat, 15 Jan 2022 09:46:41 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8kKE-0003Lx-Uj for 53260@debbugs.gnu.org; Sat, 15 Jan 2022 09:46:40 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BA767440CB2; Sat, 15 Jan 2022 09:46:32 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5DCF0440C89; Sat, 15 Jan 2022 09:46:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642257991; bh=yXyo3veV8B+Ukq7PiACYOu6IEcQPDV0pRHezAB2AKrg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RD4Vyqn+hlhdTkTAm2J0wbi4NXsJGid6zmdCztXgXtCECimgLehGgRegjKs0zQ01U FhZDuQ6BIZQdsdX3sTdT/bEG0jitagWiGNzlzMhsTvVf7CLQFlljyAEUxoOfzOGGNP Lk5Ok4X/xTt3mL4EYojd6JJziWcMwZVrv8Gxq20atJvb4/cvgmNX5l8UkAj0H40/XX vFfuFXLi054UKms5q0VsRsBAg/KblnrXs13HGib2CxJ+2BIESD7nV9GdSPgYeSvslv GMMXyKdSMbdOvpPtMDpWdbxeEARrLPzEZ1RbtOpx3c5DVcl48IoGOxnoHhROMARQZR Tqrbl4QGwJZLw== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1E335120403; Sat, 15 Jan 2022 09:46:31 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode Message-ID: References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> <8735lpmm4f.fsf@gnus.org> Date: Sat, 15 Jan 2022 09:46:30 -0500 In-Reply-To: <8735lpmm4f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 15 Jan 2022 09:36:16 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.542 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53260 Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= , 53260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-01-15 09:36:16] wrote: > Mattias Engdeg=C3=A5rd writes: >> Fchar_syntax and the bytecode Bchar_syntax differ: >> Fchar_syntax calls SETUP_BUFFER_SYNTAX_TABLE. Bchar_syntax does not. >> Bchar_syntax converts arguments to multibyte. Fchar_syntax does not. > [...] >> And, most importantly, what would be the correct code? > Hm. Perhaps Stefan has an opinion; added to the CCs. My past opinion is in its docstring: If you=E2=80=99re trying to determine the syntax of characters in the b= uffer, this is probably the wrong function to use, because it can=E2=80=99t ta= ke =E2=80=98syntax-table=E2=80=99 text properties into account. Consider = using =E2=80=98syntax-after=E2=80=99 instead. The "can't" is because `char-syntax` doesn't know where the char comes from. >> (I suppose char-syntax is rare enough that we could call Fchar_syntax >> from Bchar_syntax and thus avoid any future divergence.) > Used 172 times in-core, which isn't that rare... I think he meant "rare" w.r.t dynamic count rather than static count. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 12:29:56 2022 Received: (at 53260) by debbugs.gnu.org; 15 Jan 2022 17:29:56 +0000 Received: from localhost ([127.0.0.1]:41643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8msG-0008O0-C0 for submit@debbugs.gnu.org; Sat, 15 Jan 2022 12:29:56 -0500 Received: from mail1450c50.megamailservers.eu ([91.136.14.50]:52520 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8msC-0008Nj-Ol for 53260@debbugs.gnu.org; Sat, 15 Jan 2022 12:29:55 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642267785; bh=4J+jkEMHIslKO91n4EwKmB209GcdjcaXAB4VGcCh58w=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gYOCv8zcIVwoeESNl3e9ZcZiq54sZZ4FOSXjb9IQ5UOA/zMmDLk5rdN0RRql1zqNI UB7pXTUSngTm47/dkiDyEeXpa2qyE83dFWm3E9VGVuBGljNE6cA2NqV64sF0WaB+nq 9/Owptqx+Keo+akXWpLvJ1eMrWS4hA9VEb+yrGWA= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20FHTgVw002298; Sat, 15 Jan 2022 17:29:44 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sat, 15 Jan 2022 18:29:41 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> <8735lpmm4f.fsf@gnus.org> To: Stefan Monnier X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F24.61E30489.001C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 15 jan. 2022 kl. 15.46 skrev Stefan Monnier : > If you’re trying to determine the syntax of characters in the buffer, > this is probably the wrong function to use, because it can’t take > ‘syntax-table’ text properties into account. Consi [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 53260 Cc: Lars Ingebrigtsen , 53260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 15 jan. 2022 kl. 15.46 skrev Stefan Monnier : > If you=E2=80=99re trying to determine the syntax of characters in = the buffer, > this is probably the wrong function to use, because it can=E2=80=99t = take > =E2=80=98syntax-table=E2=80=99 text properties into account. = Consider using > =E2=80=98syntax-after=E2=80=99 instead. >=20 > The "can't" is because `char-syntax` doesn't know where the char comes = from. This is true and it leaves a narrower use for `char-syntax` in = mode-specific code -- ie, when syntax-table text properties do not need = to be taken into account. I propose we do the following: 1. Remove SETUP_BUFFER_SYNTAX_TABLE() from Fchar_syntax because as far = as I can tell it has no effect at all. 2. Remove make_char_multibyte(c) from Bchar_syntax because it seems to = be the wrong thing to do: in a unibyte buffer, wouldn't the syntax table = be indexed by byte value (so that char 255 in the buffer corresponds to = entry 255 in the syntax table rather than entry 0x3fffff)? 3. Now both implementations are identical. Replace the one in the = byte-code interpreter with a call to Fchar_syntax. > I think he meant "rare" w.r.t dynamic count rather than static count. Yes, that's right. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 12:58:25 2022 Received: (at 53260) by debbugs.gnu.org; 15 Jan 2022 17:58:26 +0000 Received: from localhost ([127.0.0.1]:41694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8nJp-0002xE-O4 for submit@debbugs.gnu.org; Sat, 15 Jan 2022 12:58:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8nJo-0002x2-8V for 53260@debbugs.gnu.org; Sat, 15 Jan 2022 12:58:24 -0500 Received: from [2001:470:142:3::e] (port=33632 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8nJd-0007S4-I6; Sat, 15 Jan 2022 12:58:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tVrBWb2MiM8otWXzAs0wlMDHDqOPR1Kd1f7RnaC5TGs=; b=SdLUeHESYYOJR5G2jsRZ Lfpmuk36aFjTV8WHELwWVQf8c8hk44uOqE3T8VlX7veqWYA5ZfThh+q4kZNFbK/kmXzjdfON1dbT+ SEQadHdc3426kdOCvYJzcB1inCGPDNllEJsfBYfA57NSlwk5U9CrQ2imq9hkiGsJZubvSprsLaDHX 2NBKS/jjIpSy451akaHlzy/h/HC/1J1XWHlZ7tXTaUBLHcEo9abMOzJ//koxku4E+rod5aCpTYKaY vBGOmNVWEMpq8LtSnrxJQLYv4tW+zkBpC1D3h01cKftc9vePQp8JVUQ6aj+yqBnbZtglMQ8r98iDJ kUb5YBUnFZNHLg==; Received: from [87.69.77.57] (port=3955 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8nJc-0003gc-5h; Sat, 15 Jan 2022 12:58:13 -0500 Date: Sat, 15 Jan 2022 19:57:48 +0200 Message-Id: <83o84czxsz.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sat, 15 Jan 2022 18:29:41 +0100) Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> <8735lpmm4f.fsf@gnus.org> <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53260 Cc: larsi@gnus.org, 53260@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Sat, 15 Jan 2022 18:29:41 +0100 > Cc: Lars Ingebrigtsen , 53260@debbugs.gnu.org > > 2. Remove make_char_multibyte(c) from Bchar_syntax because it seems to be the wrong thing to do: in a unibyte buffer, wouldn't the syntax table be indexed by byte value (so that char 255 in the buffer corresponds to entry 255 in the syntax table rather than entry 0x3fffff)? I don't think we want to support unibyte buffers which have some text that is syntactically significant. A unibyte buffer is just a stream of raw bytes, they are not characters. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 17:51:38 2022 Received: (at 53260) by debbugs.gnu.org; 15 Jan 2022 22:51:38 +0000 Received: from localhost ([127.0.0.1]:42209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8rta-0007DU-MZ for submit@debbugs.gnu.org; Sat, 15 Jan 2022 17:51:38 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8rtY-0007DC-Sk for 53260@debbugs.gnu.org; Sat, 15 Jan 2022 17:51:37 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 650EA1001AC; Sat, 15 Jan 2022 17:51:30 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 944BA10008C; Sat, 15 Jan 2022 17:51:28 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642287088; bh=izLSPUVwWL/LKra3u/AYX0IaNOXi2RbKvdKIkS/DF90=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YrlIUxKOeVMsJo2A8KvNcHGHyb2vn0xU4sUb1XXhRSYVGfJegIme3l8CLqNP1ygPm fIHb9FBN1W2ewAIfcFMwAcR/8E5XHFZTXWwEJl17kJlOzar0dxD/29O4lvWTn0KEdH +fyw0axUw5HE2SkzKdkYNmYYWnB66RcFzQOmZbcai6AdiMP6NTgYWrQzmoQGNzTpBM DE5UAOXdtwb3oPwl9x0CuEAliHU5eLQJXJDmCVvZ03SwIamW0MTZIwOdPj+y0Lj/8U YcYL3854DlmpGgKa+fSWWpdnnxyG2UKZxB7YsnAYVrAnXlmUsX95BDn7cDwT2Yfu8f gou5rfAmCCmNA== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 38CC41203A9; Sat, 15 Jan 2022 17:51:28 -0500 (EST) From: Stefan Monnier To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode Message-ID: References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> <8735lpmm4f.fsf@gnus.org> <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> Date: Sat, 15 Jan 2022 17:51:26 -0500 In-Reply-To: <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Sat, 15 Jan 2022 18:29:41 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53260 Cc: Lars Ingebrigtsen , 53260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > 1. Remove SETUP_BUFFER_SYNTAX_TABLE() from Fchar_syntax because as far as > I can tell it has no effect at all. Sounds good. > 2. Remove make_char_multibyte(c) from Bchar_syntax because it seems to be > the wrong thing to do: in a unibyte buffer, wouldn't the syntax table be > indexed by byte value (so that char 255 in the buffer corresponds to entry > 255 in the syntax table rather than entry 0x3fffff)? Doesn't sound right: char tables are indexed by chars (i.e. Unicode code points) not by bytes, so we need to convert the byte into a char before indexing. > 3. Now both implementations are identical. Replace the one in the byte-code > interpreter with a call to Fchar_syntax. Sounds good. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 06:05:09 2022 Received: (at 53260) by debbugs.gnu.org; 16 Jan 2022 11:05:09 +0000 Received: from localhost ([127.0.0.1]:42597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n93LQ-0005g9-Sn for submit@debbugs.gnu.org; Sun, 16 Jan 2022 06:05:09 -0500 Received: from mail1435c50.megamailservers.eu ([91.136.14.35]:54748 helo=mail263c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n93LK-0005fM-EG for 53260@debbugs.gnu.org; Sun, 16 Jan 2022 06:05:08 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642331095; bh=eP0OdjGT/8u8GTWWcEqNnNX381ufA48pot1aglia6Gs=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=UKM5Wnk3endsAXJ9P430Z8Y+I+j4uFZqWAbOkqKesl4oX6gPpamoRXbNbJkIBYMnN QHkkfVeLfJxBQfh9XehxuYWvpL7MvGpiBh3YR9VIYaUHrxF8LyDZJdUbRq7AYeAa5J 8D7P3HFJWgK0RXv+6Pp/e9aJZm1CjX0y3FFJoJ5E= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20GB4qta009775; Sun, 16 Jan 2022 11:04:54 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_484B250A-F9B6-4D6B-8FC7-3F701E74A15C" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode [PATCH] Date: Sun, 16 Jan 2022 12:04:51 +0100 In-Reply-To: To: Stefan Monnier References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> <8735lpmm4f.fsf@gnus.org> <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F1A.61E3FBD7.0010, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 15 jan. 2022 kl. 23.51 skrev Stefan Monnier : > Doesn't sound right: char tables are indexed by chars (i.e. Unicode code > points) not by bytes, so we need to convert the byte into a char > before indexing. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 53260 Cc: Lars Ingebrigtsen , 53260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_484B250A-F9B6-4D6B-8FC7-3F701E74A15C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 15 jan. 2022 kl. 23.51 skrev Stefan Monnier : > Doesn't sound right: char tables are indexed by chars (i.e. Unicode = code > points) not by bytes, so we need to convert the byte into a char > before indexing. Sure, I'm happy to do it either way. Chars retrieved from unibyte = buffers or strings really should be converted to multibyte before used = with char-syntax; unibyte buffers are not very common but strings = slightly more so. --Apple-Mail=_484B250A-F9B6-4D6B-8FC7-3F701E74A15C Content-Disposition: attachment; filename=0001-Fix-Fchar_syntax-for-non-ASCII-in-unibyte-buffers.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-Fchar_syntax-for-non-ASCII-in-unibyte-buffers.patch" Content-Transfer-Encoding: quoted-printable =46rom=202adb5c862232abf126f73d0aa514f5ae8b6babba=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2016=20Jan=202022=2011:58:00=20+0100=0A= Subject:=20[PATCH]=20Fix=20Fchar_syntax=20for=20non-ASCII=20in=20unibyte=20= buffers=0A=0AFchar_syntax=20did=20not=20convert=20unibyte=20characters=20= to=20multibyte=20when=20the=0Acurrent=20buffer=20was=20unibyte,=20in=20= contrast=20to=20`char-syntax`=20in=0Abyte-compiled=20code=20(bug#53260).=0A= =0A*=20src/bytecode.c=20(exec_byte_code):=20Call=20out=20to=20= Fchar_syntax;=0Athe=20dynamic=20frequency=20is=20too=20low=20to=20= justify=20inlining=20here,=20and=20it=0Adid=20lead=20to=20= implementations=20diverging.=0A*=20src/syntax.c=20(Fchar_syntax):=20= Convert=20non-ASCII=20unibyte=20values=20to=0Amultibyte.=20=20Remove=20= useless=20SETUP_BUFFER_SYNTAX_TABLE=20which=20has=20no=0Aeffect=20here.=0A= *=20test/src/syntax-tests.el=20(syntax-char-syntax):=20New=20test.=0A---=0A= =20src/bytecode.c=20=20=20=20=20=20=20=20=20=20=20|=20=208=20+-------=0A=20= src/syntax.c=20=20=20=20=20=20=20=20=20=20=20=20=20|=20=206=20+++---=0A=20= test/src/syntax-tests.el=20|=2015=20+++++++++++++++=0A=203=20files=20= changed,=2019=20insertions(+),=2010=20deletions(-)=0A=0Adiff=20--git=20= a/src/bytecode.c=20b/src/bytecode.c=0Aindex=20472992be18..b7e65d05ae=20= 100644=0A---=20a/src/bytecode.c=0A+++=20b/src/bytecode.c=0A@@=20-1167,13=20= +1167,7=20@@=20#define=20DEFINE(name,=20value)=20LABEL=20(name)=20,=0A=20= =09=20=20NEXT;=0A=20=0A=20=09CASE=20(Bchar_syntax):=0A-=09=20=20{=0A-=09=20= =20=20=20CHECK_CHARACTER=20(TOP);=0A-=09=20=20=20=20int=20c=20=3D=20= XFIXNAT=20(TOP);=0A-=09=20=20=20=20if=20(NILP=20(BVAR=20(current_buffer,=20= enable_multibyte_characters)))=0A-=09=20=20=20=20=20=20c=20=3D=20= make_char_multibyte=20(c);=0A-=09=20=20=20=20XSETFASTINT=20(TOP,=20= syntax_code_spec[SYNTAX=20(c)]);=0A-=09=20=20}=0A+=09=20=20TOP=20=3D=20= Fchar_syntax=20(TOP);=0A=20=09=20=20NEXT;=0A=20=0A=20=09CASE=20= (Bbuffer_substring):=0Adiff=20--git=20a/src/syntax.c=20b/src/syntax.c=0A= index=209df878b8ed..c1e81dfa47=20100644=0A---=20a/src/syntax.c=0A+++=20= b/src/syntax.c=0A@@=20-1101,10=20+1101,10=20@@=20DEFUN=20("char-syntax",=20= Fchar_syntax,=20Schar_syntax,=201,=201,=200,=0A=20`syntax-after'=20= instead.=20=20*/)=0A=20=20=20(Lisp_Object=20character)=0A=20{=0A-=20=20= int=20char_int;=0A=20=20=20CHECK_CHARACTER=20(character);=0A-=20=20= char_int=20=3D=20XFIXNUM=20(character);=0A-=20=20= SETUP_BUFFER_SYNTAX_TABLE=20();=0A+=20=20int=20char_int=20=3D=20XFIXNAT=20= (character);=0A+=20=20if=20(NILP=20(BVAR=20(current_buffer,=20= enable_multibyte_characters)))=0A+=20=20=20=20char_int=20=3D=20= make_char_multibyte=20(char_int);=0A=20=20=20return=20make_fixnum=20= (syntax_code_spec[SYNTAX=20(char_int)]);=0A=20}=0A=20=0Adiff=20--git=20= a/test/src/syntax-tests.el=20b/test/src/syntax-tests.el=0Aindex=20= 3b9f21cde3..501b5e067f=20100644=0A---=20a/test/src/syntax-tests.el=0A+++=20= b/test/src/syntax-tests.el=0A@@=20-506,4=20+506,19=20@@=20= test-from-to-parse-partial-sexp=0A=20=20=20=20=20(should=20= (parse-partial-sexp=201=201))=0A=20=20=20=20=20(should-error=20= (parse-partial-sexp=202=201))))=0A=20=0A+(ert-deftest=20= syntax-char-syntax=20()=0A+=20=20;;=20Verify=20that=20char-syntax=20= behaves=20identically=20in=20interpreted=20and=0A+=20=20;;=20= byte-compiled=20code=20(bug#53260).=0A+=20=20(let=20((cs=20(byte-compile=20= (lambda=20(x)=20(char-syntax=20x)))))=0A+=20=20=20=20;;=20Use=20a=20= unibyte=20buffer=20with=20a=20syntax=20table=20using=20symbol=20syntax=0A= +=20=20=20=20;;=20for=20raw=20byte=20128.=0A+=20=20=20=20= (with-temp-buffer=0A+=20=20=20=20=20=20(set-buffer-multibyte=20nil)=0A+=20= =20=20=20=20=20(let=20((st=20(make-syntax-table)))=0A+=20=20=20=20=20=20=20= =20(modify-syntax-entry=20(unibyte-char-to-multibyte=20128)=20"_"=20st)=0A= +=20=20=20=20=20=20=20=20(set-syntax-table=20st)=0A+=20=20=20=20=20=20=20= =20(should=20(equal=20(char-syntax=20128)=20?_))=0A+=20=20=20=20=20=20=20= =20(should=20(equal=20(funcall=20cs=20128)=20?_))))=0A+=20=20=20=20(list=20= (char-syntax=20128)=20(funcall=20cs=20128))))=0A+=0A=20;;;=20= syntax-tests.el=20ends=20here=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_484B250A-F9B6-4D6B-8FC7-3F701E74A15C-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 04:30:35 2022 Received: (at 53260) by debbugs.gnu.org; 20 Jan 2022 09:30:35 +0000 Received: from localhost ([127.0.0.1]:56336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nATm6-0006hb-VJ for submit@debbugs.gnu.org; Thu, 20 Jan 2022 04:30:35 -0500 Received: from quimby.gnus.org ([95.216.78.240]:46948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nATm4-0006ZJ-U1 for 53260@debbugs.gnu.org; Thu, 20 Jan 2022 04:30:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=91Y+MljsybUNRf9Y10A6jM4P8NPesdvAPtTB9Y3c6YM=; b=CaEJoGoLY+avvEVtR2iMF5cdgv ZLnXU8rYm++jlGJUphlYTH5uikstktg71fAogbvisctP3SCzRqg1ifSz8SY3LVLmlSGk3FfNkeo9d pRlFRtezu6fnTn4dvbRAGji66VpJqU16Zh0KuQRQ4384MxAa5J4VxM4XUfmQ38VjkiV8=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nATlv-0003qn-Ql; Thu, 20 Jan 2022 10:30:26 +0100 From: Lars Ingebrigtsen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode [PATCH] References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> <8735lpmm4f.fsf@gnus.org> <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVgXV2gnZ3S0ND7 +/u7ZUcZFxj///8mNaidAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+YBFAkeAUJFj4EAAAGzSURBVDjL ddNLkuMgDAZgQYo9wsPewHhvo5oD9FRmj1Oj+1+lBfiVTsImLr6gH4QNCgBTjNQHAgRoT3Bv49ff DqO2o9IUMFX4ir+/OixWW6VulGMEBY6OsaAD6BP7bx9Zx9UrlKcACl06xWVtQRPNDAjq2JPUShbM QORZSikx3FbNQyhlTGQqGGZWqq+KLpu1pIUZLMg8l4h1DxmBTNESIRm+AuvcxbqakU0BtA14oCaj BRj6rpB3CTKzABQiCREwHUqqEgQGSpkhxmlbokQiKrO6TAIpLxuwZFgL0twUpFQm2mpxcZSVkg3c vBxQDvaHz2JZNmDTxAWkF3kHtqm1GLxvpc4lXDtOgwPJaN3bU2oM0QM1bXBsjMtNLmUcAvdXgvwp GF2o97HdKV/Gg5LZgcITyMF3oPEELZnrAWdMQYHHCYcIzKwvsEkRGFe8wn5OSFOxT1DPKQh6Xp+B Yi+mpst2tzWtWuEfGbUFVYqR+/gBRz9fYG/BK9BHwPbWvgEiedPgLZgPkD9k0FI+wPwC+dL+dysM /7//g3cR5l5hlA/oOWL1DTzltd1FXPofpmLkG/8GlCrpGDPPkmsAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjItMDEtMjBUMDk6MzA6MDArMDA6MDA/ZdMEAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTAx LTIwVDA5OjMwOjAwKzAwOjAwTjhruAAAAABJRU5ErkJggg== X-Now-Playing: Led Zeppelin's _Led Zeppelin_: "Babe I'm Gonna Leave You" Date: Thu, 20 Jan 2022 10:30:23 +0100 In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 16 Jan 2022 12:04:51 +0100") Message-ID: <87y23a4uvk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias Engdegård writes: > Sure, I'm happy to do it either way. Chars retrieved from unibyte > buffers or strings really should be converted to multibyte before used > with char-syntax; unibyte buffers are not very common but [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53260 Cc: 53260@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > Sure, I'm happy to do it either way. Chars retrieved from unibyte > buffers or strings really should be converted to multibyte before used > with char-syntax; unibyte buffers are not very common but strings > slightly more so. Makes sense to me. Unless Stefan has any further comments, please go ahead and push. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 05:47:10 2022 Received: (at 53260-done) by debbugs.gnu.org; 20 Jan 2022 10:47:10 +0000 Received: from localhost ([127.0.0.1]:56463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAUyE-0002Xn-6l for submit@debbugs.gnu.org; Thu, 20 Jan 2022 05:47:10 -0500 Received: from mail71c50.megamailservers.eu ([91.136.10.81]:60866 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAUyB-0002Xa-Jp for 53260-done@debbugs.gnu.org; Thu, 20 Jan 2022 05:47:08 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642675624; bh=pQzg1iQRFxamAam3sTuvvwhNx09HYKq2EhRyvNjbw28=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=eFmQOiIQQJ6b7jyGNWJ81YW15ArN3P65L10N0OsW4cQ0//YktLxMLGS0DXWn2ZkVV 4xETbwXMByNfmXNqLLch1L8t8SnQ7H3udWsM2J9+0IT48je/Log2//tsVlnKF3zCA7 irX1uL2u9ZvC704YGPRJvdTXXM1BWpdCDNYXXE7U= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20KAl2Cn008120; Thu, 20 Jan 2022 10:47:03 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#53260: char-syntax differs in interpreter and bytecode [PATCH] From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87y23a4uvk.fsf@gnus.org> Date: Thu, 20 Jan 2022 11:47:01 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <748AD547-562F-495C-9BEC-D406953CFE4D@acm.org> References: <0A87E4BA-4741-4688-A005-912ABFC86B83@acm.org> <8735lpmm4f.fsf@gnus.org> <978B1D34-1F52-4B3E-B2E2-7ADA95155068@acm.org> <87y23a4uvk.fsf@gnus.org> To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F16.61E93DA8.004F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 20 jan. 2022 kl. 10.30 skrev Lars Ingebrigtsen : > Makes sense to me. Unless Stefan has any further comments, please go > ahead and push. Thank you, pushed with a necessary modification: SETUP_BUFFER_SYNTAX_TABLE() is indeed necessary in Fchar_syntax because syntax.c has its own local #define SYNTAX() and doesn't use the one in syntax.h [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 53260-done Cc: Stefan Monnier , 53260-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 20 jan. 2022 kl. 10.30 skrev Lars Ingebrigtsen : > Makes sense to me. Unless Stefan has any further comments, please go > ahead and push. Thank you, pushed with a necessary modification: = SETUP_BUFFER_SYNTAX_TABLE() is indeed necessary in Fchar_syntax because = syntax.c has its own local #define SYNTAX() and doesn't use the one in = syntax.h. Lovely. From unknown Thu Jun 19 16:24:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Feb 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator