Subject: Re: bug#53250: icedove clears user data on upgrade

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 20 Feb 2023 13:46:30 -0500

Hi,

Nicholas von Klitzing <[email-masked]> writes:

> Hi Jonathan,
>
> Thanks for testing the patch. What exactly doesn't work?
>
> Is icedove still generating new profiles upon install?
>
> Even if it stops generating profiles, you still need to use `icedove -p` to select the correct default.

I believe the reason it wasn't working was because the substitution of
the MOZ_DEDICATED_PROFILES value to False was not effective:

I believe this should fix it:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/gnuzilla.scm
@@ -1335,8 +1335,8 @@ (define-public icedove-minimal
           (add-after 'patch-source-shebangs 'fix-profile-setting
             (lambda _
               (substitute* "comm/mail/moz.configure"
-                (("MOZ_DEDICATED_PROFILES, True")
-                 "MOZ_DEDICATED_PROFILES, False"))))
+                (("\"MOZ_DEDICATED_PROFILES\", True")
+                 "\"MOZ_DEDICATED_PROFILES\", False"))))
           (add-after 'build 'neutralize-store-references
             (lambda _
               ;; Mangle the store references to compilers & other build tools in
--8<---------------cut here---------------end--------------->8---

Pushed to master as c81d2d448c, after testing resolution on an affected
machine.

Closing!

-- 
Thanks,
Maxim