From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 18:03:39 2010 Received: (at submit) by debbugs.gnu.org; 5 Jan 2010 23:03:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSIR9-0000jj-9d for submit@debbugs.gnu.org; Tue, 05 Jan 2010 18:03:39 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSIR8-0000jc-3f for submit@debbugs.gnu.org; Tue, 05 Jan 2010 18:03:38 -0500 Received: from mail.gnu.org ([199.232.76.166]:51100 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NSIR3-0000Pj-Fs for emacs-pretest-bug@gnu.org; Tue, 05 Jan 2010 18:03:34 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NSIQz-0003SO-E4 for emacs-pretest-bug@gnu.org; Tue, 05 Jan 2010 18:03:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from rcsinet12.oracle.com ([148.87.113.124]:16916) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSIQy-0003RO-JW for emacs-pretest-bug@gnu.org; Tue, 05 Jan 2010 18:03:29 -0500 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet12.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o05N3K2P022121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Jan 2010 23:03:21 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o05LrGcc024869 for ; Tue, 5 Jan 2010 23:03:19 GMT Received: from abhmt005.oracle.com by acsmt354.oracle.com with ESMTP id 1286266041262732583; Tue, 05 Jan 2010 15:03:03 -0800 Received: from dradamslap1 (/141.144.224.23) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Jan 2010 15:03:03 -0800 From: "Drew Adams" To: Subject: 23.1.91; doc string of dired-insert-set-properties Date: Tue, 5 Jan 2010 15:02:53 -0800 Message-ID: <51DF2CBEF36C488F8C88AECE9E33471D@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcqOWzYkYHhnPEhUT1SytDhdbxKI1g== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt356.oracle.com [141.146.40.156] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4B43C538.0064:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) emacs -Q The doc string is: "Make the file names highlight when the mouse is on them." The function name does not at all reflect what the function does, for one thing. This makes it all the more important that the doc string does reflect what the function does. Prior to Emacs 23, the doc string was complete and accurate. Starting with Emacs 23, this function does something additional, which is quite important: it puts the `dired-filename' text property on the file name. This is at least as important as the fact that the function adds the `mouse-face' property to highlight the file name. Especially since property `dired-filename' is set here for use elsewhere. The connection between `dired-insert-set-properties' and `dired-move-to(-end-of)-filename' is not obvious. If there were more occurrences of `dired-filename' in the file it would be even harder to see this connection. A sentence such as this should be added to the doc string: "Add text property `dired-filename' to the file name." In GNU Emacs 23.1.91.1 (i386-mingw-nt5.1.2600) of 2010-01-02 on PRETEST Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 13 12:39:30 2010 Received: (at control) by debbugs.gnu.org; 13 Jan 2010 17:39:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NV7Bq-0005Bi-2S for submit@debbugs.gnu.org; Wed, 13 Jan 2010 12:39:30 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NV7Bn-0005Bb-KB for control@debbugs.gnu.org; Wed, 13 Jan 2010 12:39:27 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NV7Bi-00008A-3m; Wed, 13 Jan 2010 12:39:22 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19278.1354.66161.232229@fencepost.gnu.org> Date: Wed, 13 Jan 2010 12:39:22 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: Br14aVx1s"b%XZBACFejP="95+225[b<2X;?d6*Zi5tg3`Ay]KueFAKm`1I_ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) reassign 1184 emacs forcemerge 1184 5351 reassign 5367 emacs,gnus severity 5366 wishlist severity 5325 minor From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 11:16:34 2011 Received: (at 5325) by debbugs.gnu.org; 13 Jul 2011 15:16:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1As-0007Yx-4h for submit@debbugs.gnu.org; Wed, 13 Jul 2011 11:16:34 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1Am-0007Yd-FV for 5325@debbugs.gnu.org; Wed, 13 Jul 2011 11:16:28 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh1AY-0003EZ-8c; Wed, 13 Jul 2011 17:16:10 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 23.1.91; doc string of dired-insert-set-properties In-Reply-To: <51DF2CBEF36C488F8C88AECE9E33471D@us.oracle.com> (Drew Adams's message of "Tue, 5 Jan 2010 15:02:53 -0800") Date: Wed, 13 Jul 2011 17:15:57 +0200 Message-ID: References: <51DF2CBEF36C488F8C88AECE9E33471D@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Talking Heads's _Speaking in Tongues_: "Making Flippy Floppy" X-Hashcash: 1:23:110713:5325@debbugs.gnu.org::XeHO7hIQ3FhqNzoo:00000000000000000000000000000000000000000W5Ru X-Hashcash: 1:23:110713:drew.adams@oracle.com::NAus85biH1fuDlxJ:0000000000000000000000000000000000000001ya2X MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qh1AY-0003EZ-8c X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311174971.7107@5T+5zxUUjhkDYW8No1wrtA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 5325 Cc: 5325@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > Prior to Emacs 23, the doc string was complete and accurate. Starting > with Emacs 23, this function does something additional, which is quite > important: it puts the `dired-filename' text property on the file name. > This is at least as important as the fact that the function adds the > `mouse-face' property to highlight the file name. I've now updated the doc string. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 11:16:19 2011 Received: (at control) by debbugs.gnu.org; 13 Jul 2011 15:16:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1Ag-0007YZ-RP for submit@debbugs.gnu.org; Wed, 13 Jul 2011 11:16:19 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh1Af-0007YP-K5 for control@debbugs.gnu.org; Wed, 13 Jul 2011 11:16:17 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh1AT-0003EM-QE for control@debbugs.gnu.org; Wed, 13 Jul 2011 17:16:05 +0200 Date: Wed, 13 Jul 2011 17:16:02 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #5325 X-MailScanner-ID: 1Qh1AT-0003EM-QE X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311174965.8686@gI8G5WBWm5GUEcWKu9jI1g X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 5325 fixed close 5325 24.1 From unknown Fri Jun 20 07:14:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Aug 2011 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator