GNU bug report logs - #53239
[PATCH] gnu: openocd: Fix udev rules.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jorge Acereda <jacereda <at> gmail.com>
Subject: bug#53239: closed (Re: bug#53239: [PATCH] gnu: openocd: Fix udev
 rules.)
Date: Fri, 14 Jan 2022 03:24:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#53239: [PATCH] gnu: openocd: Fix udev rules.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 53239 <at> debbugs.gnu.org.

-- 
53239: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53239
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jorge Acereda <jacereda <at> gmail.com>
Cc: 53239-done <at> debbugs.gnu.org
Subject: Re: bug#53239: [PATCH] gnu: openocd: Fix udev rules.
Date: Thu, 13 Jan 2022 22:23:40 -0500

Hi Jorge!

Jorge Acereda <jacereda <at> gmail.com> writes:

> * gnu/packages/embedded.scm (openocd)[arguments]<#:phases>[change-udev-group]:
> Fix plugdev->dialout group replacement.
> ---
>  gnu/packages/embedded.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
> index ea1a585f0f..b33a23e9cb 100644
> --- a/gnu/packages/embedded.scm
> +++ b/gnu/packages/embedded.scm
> @@ -618,7 +618,7 @@ (define-public openocd
>                 (("-DPKGBLDDATE=") "-DDISABLED_PKGBLDDATE="))
>               (patch-shebang "bootstrap")
>               (invoke "./bootstrap" "nosubmodule")))
> -         (add-after 'autoreconf 'change-udev-group
> +         (add-after 'unpack 'change-udev-group
>             (lambda _
>               (substitute* "contrib/60-openocd.rules"
>                 (("plugdev") "dialout"))
> 2.34.0

Good catch!  I've deleted the phases trailing #t, normalized the commit
message a bit, and pushed as 1e8b999717.

Thank you!

Maxim

[Message part 3 (message/rfc822, inline)]

From: Jorge Acereda <jacereda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Jorge Acereda <jacereda <at> gmail.com>
Subject: [PATCH] gnu: openocd: Fix udev rules.
Date: Thu, 13 Jan 2022 21:53:14 +0100

* gnu/packages/embedded.scm (openocd)[arguments]<#:phases>[change-udev-group]:
Fix plugdev->dialout group replacement.
---
 gnu/packages/embedded.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
index ea1a585f0f..b33a23e9cb 100644
--- a/gnu/packages/embedded.scm
+++ b/gnu/packages/embedded.scm
@@ -618,7 +618,7 @@ (define-public openocd
                (("-DPKGBLDDATE=") "-DDISABLED_PKGBLDDATE="))
              (patch-shebang "bootstrap")
              (invoke "./bootstrap" "nosubmodule")))
-         (add-after 'autoreconf 'change-udev-group
+         (add-after 'unpack 'change-udev-group
            (lambda _
              (substitute* "contrib/60-openocd.rules"
                (("plugdev") "dialout"))
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.