GNU bug report logs - #53238
password-store fails to build with tree version 2

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <marius <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53238: closed (password-store fails to build with tree version 2)
Date: Mon, 17 Jan 2022 17:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 17 Jan 2022 18:37:26 +0100
with message-id <87sftm6z6x.fsf <at> gnu.org>
and subject line Re: bug#53238: [PATCH] gnu: tree: Remove stddata feature.
has caused the debbugs.gnu.org bug report #53238,
regarding password-store fails to build with tree version 2
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53238: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53238
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: guix-patches <at> gnu.org
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>
Subject: [PATCH] gnu: tree: Remove stddata feature.
Date: Thu, 13 Jan 2022 15:33:21 -0500

* gnu/packages/admin.scm (tree)
[arguments]: Add 'remove-stddata-feature phase after 'unpack phase.

Since version 2.0.0, there's a new feature call `stddata`.

From the ChangeLog:
--------------------------------------------------------------------------------
Output un-indented JSON on file descriptor 3 ("stddata") automatically if file
descriptor 3 is present (currently Linux only.) Maybe switch to BSON.
--------------------------------------------------------------------------------

This feature breaks some UNIX utilities.  Fix it by disabling the feature.
---
 gnu/packages/admin.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index f11374a439..3d4909176a 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2408,6 +2408,14 @@ (define-public tree
      (list
        #:phases
        #~(modify-phases %standard-phases
+           (add-after 'unpack 'remove-stddata-feature
+             (lambda _
+               (substitute* "tree.h"
+                 (("#  define STDDATA_FILENO 3")
+                  ""))
+               (substitute* "tree.c"
+                 (("#ifdef __linux__")
+                  "#ifdef STDDATA_FILENO"))))
            (delete 'configure))         ; No configure script.
        #:tests? #f                      ; No check target.
        #:make-flags
-- 
2.34.0

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <marius <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>, 53238-done <at> debbugs.gnu.org,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#53238: [PATCH] gnu: tree: Remove stddata feature.
Date: Mon, 17 Jan 2022 18:37:26 +0100

[Message part 4 (text/plain, inline)]

Upstream fix pushed in 5da4cbfbd94163f87f188355e5490f04dd6864c2.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.