From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 15:33:42 2022 Received: (at submit) by debbugs.gnu.org; 13 Jan 2022 20:33:42 +0000 Received: from localhost ([127.0.0.1]:34686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86n0-0001om-DB for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:33:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:52342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86mv-0001oY-EX for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:33:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n86mu-0007zu-3g for guix-patches@gnu.org; Thu, 13 Jan 2022 15:33:37 -0500 Received: from smtp.polymtl.ca ([132.207.4.11]:42042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n86mq-00066q-Cw for guix-patches@gnu.org; Thu, 13 Jan 2022 15:33:34 -0500 Received: from laura.hitronhub.home (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 20DKXMB9003161 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 13 Jan 2022 15:33:29 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 20DKXMB9003161 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1642106010; bh=ASeLr+ajKDXr1obrM9FFYIcIvZ08oaYL6guaEJfOwug=; h=From:To:Cc:Subject:Date:From; b=GT2NKY9xWDJkkkg6IyBXAGYx/5IuKH0as/cWXFuTke4mJrOjl+2I7/S/u8nsPQPDg 7rgwVSiAkirTyYfFShJtx/M8rsZv6WJqH+/T/FeZB7H0lJNe+EFFg+/Z5+/D44rZyU WY753mGP76jW5SWc5pcF0FF7DSLdSE+0IGCestfQ= From: Olivier Dion To: guix-patches@gnu.org Subject: [PATCH] gnu: tree: Remove stddata feature. Date: Thu, 13 Jan 2022 15:33:21 -0500 Message-Id: X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Thu, 13 Jan 2022 20:33:22 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Olivier Dion X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/admin.scm (tree) [arguments]: Add 'remove-stddata-feature phase after 'unpack phase. Since version 2.0.0, there's a new feature call `stddata`. >From the ChangeLog: -------------------------------------------------------------------------------- Output un-indented JSON on file descriptor 3 ("stddata") automatically if file descriptor 3 is present (currently Linux only.) Maybe switch to BSON. -------------------------------------------------------------------------------- This feature breaks some UNIX utilities. Fix it by disabling the feature. --- gnu/packages/admin.scm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index f11374a439..3d4909176a 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -2408,6 +2408,14 @@ (define-public tree (list #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'remove-stddata-feature + (lambda _ + (substitute* "tree.h" + (("# define STDDATA_FILENO 3") + "")) + (substitute* "tree.c" + (("#ifdef __linux__") + "#ifdef STDDATA_FILENO")))) (delete 'configure)) ; No configure script. #:tests? #f ; No check target. #:make-flags -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 15:46:54 2022 Received: (at 53238) by debbugs.gnu.org; 13 Jan 2022 20:46:54 +0000 Received: from localhost ([127.0.0.1]:34705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86zm-0002Ch-Ik for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:46:54 -0500 Received: from tobias.gr ([80.241.217.52]:33898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86zk-0002CU-D6 for 53238@debbugs.gnu.org; Thu, 13 Jan 2022 15:46:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=GAjB+q+AWgG+r jSxoflTKcjUv+yBGmKeiYRiJidnN4c=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=pHCxa0nfveafu5gvvp2kFmMb/uVIN3NnPQw1B1 INu6SCj16DpvjsmKlHTmz8lTosI9ze3L4QOQeEok0NtWT+ABhigZQamARUgtec7JN4L9B3 5gwfdJv2tCpL1kVUKcFsFFsyJn6c5vnd5/t162UPw3H1rXiXzLKwjpyLRnrbaKbKR13s2A AM8TfL35HMolT928R4x+36yswUTvM0UgL3FKtaSXTTjz5tbuPnDNKREwQpE/BMy0gQt+w6 sF8FsNgDmcr4GhGUZVtATfNwqkVsQu646VlMjX0WJFngRcoiJLcXRxjZwz+0xku/T2DBpk NyAaONlRCR31upGKzKrA0leA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id fedd90ed (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 13 Jan 2022 20:46:48 +0000 (UTC) References: From: Tobias Geerinckx-Rice To: Olivier Dion Subject: Re: [bug#53238] [PATCH] gnu: tree: Remove stddata feature. Date: Thu, 13 Jan 2022 21:44:31 +0100 In-reply-to: BIMI-Selector: v=BIMI1; s=default; Message-ID: <87ee5bcqhy.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 53238 Cc: 53238@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Olivier, Thanks again for tracking down this weird bug! Olivier Dion via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > This feature breaks some UNIX utilities. Fix it by disabling=20 > the feature. Hm=E2=80=A6 How long would we have to carry this fork? My fear is we'd=20 do so indefinitely. How about creating a (possibly hidden) tree-without-stddata=20 package variant, to use as input to packages who currently break=20 with this feature enabled? That lets us refcount the need for it. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYeCP2Q0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15XQwA/imzo8+dkAo/YNPVnciTjEWoUaAbwmVpv071kZrU 7NpxAP918Nm095sz8+/N9WJCEpdKGhfo+4+hBf3+WvDcIAAwAw== =SgBg -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 15:57:27 2022 Received: (at submit) by debbugs.gnu.org; 13 Jan 2022 20:57:28 +0000 Received: from localhost ([127.0.0.1]:34726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n879z-0002Xl-IE for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:57:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:57588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n879x-0002Xc-OF for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:57:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n879x-0008Pu-FS for guix-patches@gnu.org; Thu, 13 Jan 2022 15:57:25 -0500 Received: from smtp.polymtl.ca ([132.207.4.11]:42122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n879v-00015n-6J for guix-patches@gnu.org; Thu, 13 Jan 2022 15:57:24 -0500 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 20DKv8j0021614 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jan 2022 15:57:12 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 20DKv8j0021614 From: Olivier Dion To: Tobias Geerinckx-Rice Subject: Re: [bug#53238] [PATCH] gnu: tree: Remove stddata feature. In-Reply-To: <87ee5bcqhy.fsf@nckx> References: <87ee5bcqhy.fsf@nckx> Date: Thu, 13 Jan 2022 15:57:07 -0500 Message-ID: <87ee5bwdzw.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Thu, 13 Jan 2022 20:57:08 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 53238@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Thu, 13 Jan 2022, Tobias Geerinckx-Rice wrote: > Olivier, > > Thanks again for tracking down this weird bug! > > Olivier Dion via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A >> This feature breaks some UNIX utilities. Fix it by disabling=20 >> the feature. > > Hm=E2=80=A6 How long would we have to carry this fork? My fear is we'd= =20 > do so indefinitely. I've contacted the maintainer asking for removal of the feature in its next release. I'm not sure if this will have some impact. Feel free to do the same at , maybe adding more weight in the balance would help. > How about creating a (possibly hidden) tree-without-stddata=20 > package variant, to use as input to packages who currently break=20 > with this feature enabled? That lets us refcount the need for it. It's more than just packages, it's also user scripts that can be broken and believe me when I say that this is not an easy bug to track down ;-). --=20 Olivier Dion Polymtl From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 17:26:31 2022 Received: (at 53238) by debbugs.gnu.org; 13 Jan 2022 22:26:31 +0000 Received: from localhost ([127.0.0.1]:34819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n88YB-0005DX-0g for submit@debbugs.gnu.org; Thu, 13 Jan 2022 17:26:31 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:37415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n88Y6-0005DB-O3 for 53238@debbugs.gnu.org; Thu, 13 Jan 2022 17:26:29 -0500 Received: by mail-qv1-f42.google.com with SMTP id fo11so8379943qvb.4 for <53238@debbugs.gnu.org>; Thu, 13 Jan 2022 14:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+owQf6rbF8Em5c4wewuv8Ji1HUH7+LXzjgvlm51+Sb4=; b=GRiJavjYHJRGPIjwOgDz7IjzgO+yyfUiYxzjhi/R870EfCbdXvmzE6WiiyV+V/UrdZ Rd/DCA8Ed1xd/SIr1AJ38usPvMzt/Q7UbIurmFl2tqUB/mtuO8g53pMvk7KgBkqkCKYB 0SmMytgv/dyR2Vj1QsdU7yaQDMr9xJexPP5GOv+tBaBVJQCvSnu1f2Zyho3PGr1QFSnT 3drKtZhpiZBL009mX7uKFFXYCbi8stcwnbeaCIP+ljvoh9db3/qmT4QMqc91NrLXbRZk OiFRetWnpefSplZh1DRZwngr7rTCOaiH8kzZ0l3YZLRRYGGlZuh2bJsr60kb/yWeiLUT i2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+owQf6rbF8Em5c4wewuv8Ji1HUH7+LXzjgvlm51+Sb4=; b=JiLsxWuRt07xVEdd20FXbfo+mPtfcHoybw0XjwhU6mF5RQdtmqR4lkAzV/911dU069 i+3XVceHFsqdf3hrcam1xx6c6Mk8heiPSrO1MD0IoWePZi+VfG4JntNfqYytkzqOq88J 48/hWtEbKZVAafOdFQ701S0Ub0gOm6zXAvwJ8URu2GG+mMx1ViegNv8Oli98e8vMy0cA 9umxahUqM2uf8XwJYNRXKyhS1/v02n4slGgSr/gUV2MId8O1It1kraD8AQAEWRdn6RvU 0FiaCYeztYccQj07tKl5XshU5BeWY/462KGJ0Yl0BIU+FkJ59gm6u8pxog8WNhT49zxJ WoIQ== X-Gm-Message-State: AOAM530cnVZyUHoaGjf/r0Hk1dLluwpHMP2m+F+SlcF/KL47btyY6+yB bo3/TaCbRAoUG0wyjoM8dq1e0SAT4uL0ug== X-Google-Smtp-Source: ABdhPJxzTwz3/u6EkMzr+LKZKlUIHuFkeEU2hX8llucfxarXN9BUiLO3P7sNVCTkgZyEE2Pqrl6Czg== X-Received: by 2002:a05:6214:2686:: with SMTP id gm6mr6125706qvb.24.1642112780897; Thu, 13 Jan 2022 14:26:20 -0800 (PST) Received: from hurd (dsl-152-155.b2b2c.ca. [66.158.152.155]) by smtp.gmail.com with ESMTPSA id x10sm2906586qtw.60.2022.01.13.14.26.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 14:26:20 -0800 (PST) From: Maxim Cournoyer To: Olivier Dion Subject: Re: bug#53238: [PATCH] gnu: tree: Remove stddata feature. References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> Date: Thu, 13 Jan 2022 17:26:19 -0500 In-Reply-To: <87ee5bwdzw.fsf@laura> (Olivier Dion's message of "Thu, 13 Jan 2022 15:57:07 -0500") Message-ID: <87r19bxofo.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53238 Cc: Tobias Geerinckx-Rice , 53238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Olivier Dion writes: > On Thu, 13 Jan 2022, Tobias Geerinckx-Rice wrote: >> Olivier, >> >> Thanks again for tracking down this weird bug! >> >> Olivier Dion via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A >>> This feature breaks some UNIX utilities. Fix it by disabling=20 >>> the feature. >> >> Hm=E2=80=A6 How long would we have to carry this fork? My fear is we'd= =20 >> do so indefinitely. > > I've contacted the maintainer asking for removal of the feature in its > next release. I'm not sure if this will have some impact. Feel free to > do the same at , maybe adding more weight > in the balance would help. > >> How about creating a (possibly hidden) tree-without-stddata=20 >> package variant, to use as input to packages who currently break=20 >> with this feature enabled? That lets us refcount the need for it. > > It's more than just packages, it's also user scripts that can be broken > and believe me when I say that this is not an easy bug to track down ;-). I'm on the fence about this, it does indeed seem an undesirable change, especially since there's a --json option, but I am not the author of the 'tree' software. Attached is an alternative that adjusts password-store instead of removing this new tree "feature"... --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-password-store-Fix-test-failure-following-tree-u.patch >From 2a30d95c46ff1eb0bdac9307c5d6bb8e460de02f Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Thu, 13 Jan 2022 15:09:54 -0500 Subject: [PATCH] gnu: password-store: Fix test failure following 'tree' update. Thanks to Olivier Dion for diagnosing the source of the problem! * gnu/packages/password-utils.scm (password-store): Delete trailing #t. [phases]{adjust-for-tree-2}: New phase. --- gnu/packages/password-utils.scm | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm index 0ff8608c9c..16d889344b 100644 --- a/gnu/packages/password-utils.scm +++ b/gnu/packages/password-utils.scm @@ -487,6 +487,21 @@ (define-public password-store (arguments '(#:phases (modify-phases %standard-phases + (add-after 'unpack 'adjust-for-tree-2 + (lambda _ + ;; XXX: tree 2.0.1 has this new "stddata pipe" that is + ;; automatically used to output in JSON if the file descriptor 3 + ;; is available. This conflicts with the test harness use of + ;; file descriptor 3, causing one of the tests to fail. + ;; Increment the file descriptors used by the harness by one to + ;; avoid the conflict. + (substitute* "tests/sharness.sh" + (("exec 4>&2 3>&1") + "exec 5>&2 4>&1") + (("exec 4>/dev/null 3>/dev/null") + "exec 5>/dev/null 4>/dev/null") + (("&4") "&5") + (("&3") "&4")))) (delete 'configure) (delete 'build) (add-before 'install 'patch-system-extension-dir @@ -500,8 +515,7 @@ (define-public password-store (string-append " SYSTEM_EXTENSION_DIR=\"" "${PASSWORD_STORE_SYSTEM_EXTENSION_DIR:-" extension-dir - "}\"\n")))) - #t)) + "}\"\n")))))) (add-before 'install 'patch-passmenu-path ;; FIXME Wayland support requires ydotool and dmenu-wl packages ;; We are ignoring part of the script that gets executed if @@ -530,8 +544,7 @@ (define-public password-store '("coreutils" "getopt" "git" "gnupg" "qrencode" "sed" "tree" "which" "wl-clipboard" "xclip")))) (wrap-program (string-append out "/bin/pass") - `("PATH" ":" prefix (,(string-join path ":")))) - #t)))) + `("PATH" ":" prefix (,(string-join path ":")))))))) #:make-flags (list "CC=gcc" (string-append "PREFIX=" %output) "WITH_ALLCOMP=yes" (string-append "BASHCOMPDIR=" -- 2.34.0 --=-=-= Content-Type: text/plain Thanks, Maxim --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 19:01:17 2022 Received: (at submit) by debbugs.gnu.org; 14 Jan 2022 00:01:17 +0000 Received: from localhost ([127.0.0.1]:34856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8A1t-0001oW-22 for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:01:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:34286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8A1p-0001oN-RO for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:01:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8A1p-0000U6-4D for guix-patches@gnu.org; Thu, 13 Jan 2022 19:01:13 -0500 Received: from [2a02:c205:2020:6054::1] (port=41204 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8A1k-0001XB-Lz for guix-patches@gnu.org; Thu, 13 Jan 2022 19:01:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=Tke8oaw5ZXSEe WExEDHf8BXVMUFNR6uQ9xDOFfR5pIg=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=Nl4SFPApE/WAShhIlyZlX5Ned8F9AL3yJZeqzC cpSuyz4X4pB6ClR+2mLiLXEBDWOchHjsd9G2N9ts+UaPuWvleFFqD49qyk5XQoZ9G+nBY+ 05R5gIA+xHhGSmQcU3NqEhaCyRj7eMlW+YEpPlQtihIIzImk9FuwZdG1mQuOz8uqzEz27c P5cOzYs1zrN0+QEmDGcus2DggeCmU0nwYY9UB6qebnH48bEtt5l7uFELj2PzI1s5j3C719 kNQ/rao4/1XTeAMLOE5LM/dFqbebwIwjsgjnRxT5zTJ1gOTQq6lf5vu4mQztsD8SR6Nfwl m/Fe5jeC+1T3Xiz7jJI62jPA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id e86fcdbe (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 14 Jan 2022 00:01:03 +0000 (UTC) References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> From: Tobias Geerinckx-Rice To: Olivier Dion Subject: Re: [bug#53238] [PATCH] gnu: tree: Remove stddata feature. Date: Thu, 13 Jan 2022 23:33:29 +0100 In-reply-to: <87ee5bwdzw.fsf@laura> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87a6fzchid.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URI_DOTEDU=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 53238@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hullo Olivier, I was going to apply the patch below to fix the password-store=20 package, but Maxime just submitted another version which I prefer.=20 I'd rather not provide two trees in Guix. Olivier Dion =E5=86=99=E9=81=93=EF=BC=9A > I've contacted the maintainer asking for removal of the feature=20 > in its > next release. After some consideration, I think it's an interesting feature.=20 Something like this is long overdue. I don't know if this approach is the right one, but I'll=20 begrudgingly settle for JSON if it finally catches on=E2=80=A6 > It's more than just packages, it's also user scripts that can be=20 > broken They can be fixed, or better yet rewritten. tree(1) is not tr(1).=20 =E2=80=98Some lazy idiot could parse this with bash=E2=80=99 !=3D =E2=80=98= frozen API which=20 upstream can never improve=E2=80=99. Really. =E2=80=A6uh, I'm describing myself there, by the way ;-) I feel quite=20 seen. Not that they needed to, but upstream even bumped the major=20 revision along with this change. > and believe me when I say that this is not an easy bug to track=20 > down ;-). Fully agree! I wasted too much time trying to track it down=20 myself. I blame password-store's spaghetto of redirection more=20 than tree. Kind regards, T G-R --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0004-gnu-password-store-Fix-failing-test-suite.patch Content-Transfer-Encoding: quoted-printable From=20e100fedb52df07738c2d535928c6c9f98042e07f Mon Sep 17 00:00:00 2001 From: Tobias Geerinckx-Rice Date: Thu, 13 Jan 2022 13:45:25 +0000 Subject: [PATCH 04/26] gnu: password-store: Fix failing test suite. * gnu/packages/admin.scm (tree-1): New public variable. * gnu/packages/password-utils.scm (password-store)[inputs]: Use it rather than the default tree@2. Reported by Maxim Cournoyer and Olivier Dion . =2D-- gnu/packages/admin.scm | 20 ++++++++++++++++++++ gnu/packages/password-utils.scm | 3 ++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index f11374a439..c2e656db1a 100644 =2D-- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -2421,6 +2421,26 @@ (define-public tree (home-page "http://mama.indstate.edu/users/ice/tree/") (license license:gpl2+))) =20 +(define-public tree-1 + ;; tree 2.0.0 introduced a feature called =E2=80=98stddata=E2=80=99 that= emits JSON when + ;; output is directed to file descriptor 3. At least password-store sti= ll + ;; requires the old version. + (package + (inherit tree) + (version "1.8.0") + (source (origin + (method url-fetch) + (uri (string-append + "http://mama.indstate.edu/users/ice/tree/src/tree-" + version ".tgz")) + (sha256 + (base32 "1hmpz6k0mr6salv0nprvm1g0rdjva1kx03bdf1scw8a38d5msp= bi")))) + (arguments + (substitute-keyword-arguments (package-arguments tree) + ((#:make-flags flags '()) + #~(append #$flags + (list (string-append "prefix=3D" #$output)))))))) + (define-public lr (package (name "lr") diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.= scm index 0ff8608c9c..86af0deb47 100644 =2D-- a/gnu/packages/password-utils.scm +++ b/gnu/packages/password-utils.scm @@ -552,7 +552,8 @@ (define-public password-store ("gnupg" ,gnupg) ("qrencode" ,qrencode) ("sed" ,sed) =2D ("tree" ,tree) + ;; XXX v1.7.4 tests are broken with tree@2: . + ("tree" ,tree-1) ("which" ,which) ("wl-clipboard" ,wl-clipboard) ("xclip" ,xclip) =2D-=20 2.34.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYeC9Wg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15mZIBAMSOhfVhnZcXJiiLhaKMP8ZoKDViRaFPQdR7VmZV +cgHAP9wwCSzoWCmEFZ6uTiGV9O3yAZz0IKShu35MYI1lHYqDA== =rz+G -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 20:55:38 2022 Received: (at submit) by debbugs.gnu.org; 14 Jan 2022 01:55:38 +0000 Received: from localhost ([127.0.0.1]:34933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8BoY-0005B4-Fi for submit@debbugs.gnu.org; Thu, 13 Jan 2022 20:55:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:51972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8BoV-0005At-HK for submit@debbugs.gnu.org; Thu, 13 Jan 2022 20:55:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8BoU-0000SM-3C for guix-patches@gnu.org; Thu, 13 Jan 2022 20:55:35 -0500 Received: from smtp.polymtl.ca ([132.207.4.11]:43980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8BoL-0000U9-Po for guix-patches@gnu.org; Thu, 13 Jan 2022 20:55:31 -0500 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 20E1t9Ba025705 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jan 2022 20:55:14 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 20E1t9Ba025705 From: Olivier Dion To: Tobias Geerinckx-Rice Subject: Re: [bug#53238] [PATCH] gnu: tree: Remove stddata feature. In-Reply-To: <87a6fzchid.fsf@nckx> References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> <87a6fzchid.fsf@nckx> Date: Thu, 13 Jan 2022 20:55:09 -0500 Message-ID: <87bl0fw076.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Fri, 14 Jan 2022 01:55:09 +0000 Received-SPF: pass client-ip=132.207.4.11; envelope-from=olivier.dion@polymtl.ca; helo=smtp.polymtl.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 53238@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Thu, 13 Jan 2022, Tobias Geerinckx-Rice wrote: > Hullo Olivier, > > I was going to apply the patch below to fix the password-store=20 > package, but Maxime just submitted another version which I prefer.=20 > I'd rather not provide two trees in Guix. I'm fine with both solutions. In the end, password-store is not broken, only its test suite. > Olivier Dion =E5=86=99=E9=81=93=EF=BC=9A >> I've contacted the maintainer asking for removal of the feature in >> its next release. > > After some consideration, I think it's an interesting feature.=20 > Something like this is long overdue. > > I don't know if this approach is the right one, but I'll=20 > begrudgingly settle for JSON if it finally catches on=E2=80=A6 Just to be clear that the JSON is still there with the switch -J. I just think that using some random file descriptor like this is a path to break many tools. Any program that open a file and try to do a popen(3) with "tree" for its output will get bitten by it. It's not like if `stddata` is some common knowledge outside of the PowerShell world. >> and believe me when I say that this is not an easy bug to track=20 >> down ;-). > > Fully agree! I wasted too much time trying to track it down=20 > myself. I blame password-store's spaghetto of redirection more=20 > than tree. Happy to know I'm not the only one who spend way too much time on this ^^ --=20 Olivier Dion Polymtl From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 21:07:26 2022 Received: (at submit) by debbugs.gnu.org; 14 Jan 2022 02:07:26 +0000 Received: from localhost ([127.0.0.1]:34943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Bzx-0007jm-Qq for submit@debbugs.gnu.org; Thu, 13 Jan 2022 21:07:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:56958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Bzw-0007jf-32 for submit@debbugs.gnu.org; Thu, 13 Jan 2022 21:07:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8Bzv-00052I-VI for guix-patches@gnu.org; Thu, 13 Jan 2022 21:07:23 -0500 Received: from [2a02:c205:2020:6054::1] (port=41220 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8Bzp-0002Cs-Nh for guix-patches@gnu.org; Thu, 13 Jan 2022 21:07:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=p6bxpIQsr92DI RAo1hNHcV/DkCaENVfOKpaPwzOyV44=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=Tsztwq1YNA5iHcnSZELWOou5dyeHzilMsj0h9R jeO/kd+LBCOIn/9LAK5XTPe+mO42QEKqx7N+hyn82noAdNMlgHMRbxBk4TfsHGPORlHDcj twv5EaRzT0rXDWYtTGCk4vICp0FE4G0jobptspIMtGoCsIihVPf7ebQ9GnsDZ+Ly0kx2+l dg5z9Uu0U5ky1zRIMbGnIFIJYeinzjmh29aDDwO+O5CiIyeMehonXscN031MSvBpQPTc/e 6iWkypqgy16FPiJPzs904AfjZujd65DepRUL57qbfz9EQs6PXP8ER7TOH5r4gnb3jHLUiI ZrmB8LGpnu442BG1s98Oj9eg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 5a4c89dd (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 14 Jan 2022 02:07:11 +0000 (UTC) References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> <87a6fzchid.fsf@nckx> <87bl0fw076.fsf@laura> From: Tobias Geerinckx-Rice To: Olivier Dion Subject: Re: [bug#53238] [PATCH] gnu: tree: Remove stddata feature. Date: Fri, 14 Jan 2022 03:05:29 +0100 In-reply-to: <87bl0fw076.fsf@laura> BIMI-Selector: v=BIMI1; s=default; Message-ID: <871r1bcbo8.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 53238@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Olivier Dion =E5=86=99=E9=81=93=EF=BC=9A > It's not like if > `stddata` is some common knowledge outside of the PowerShell=20 > world. FWIW I had never heard of it. I'll admit it's not a good start in=20 life. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYeDa5w0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15+9UA/0lq/rGykgkPZhHTZvysZeOMi8+Mf0qqZowIviRc j1MWAQCTP8XYJhfBL53dJj7lUMMhNdo/thfJnVy2/BY2zhT1Aw== =phbs -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 17:34:45 2022 Received: (at control) by debbugs.gnu.org; 14 Jan 2022 22:34:45 +0000 Received: from localhost ([127.0.0.1]:38495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8V9g-0007tF-Pt for submit@debbugs.gnu.org; Fri, 14 Jan 2022 17:34:44 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:40873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8V9b-0007sw-5E for control@debbugs.gnu.org; Fri, 14 Jan 2022 17:34:42 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0C5E13201DA2; Fri, 14 Jan 2022 17:34:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 14 Jan 2022 17:34:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:message-id:mime-version:content-type; s=mesmtp; bh=gbmV5vbpZY3IbJKdgCPy/qE/5VFsnH9igpOJ+b94jA4=; b=ILBKThxiBJgC 0ZZDP+Cra5ySDYmsW9PHMJQdPWccq27mOC5T1td4fBMW8VnHkFTT+0Xo6KONNwfC +ofYYU6A0WThWPiOvSbetUNoivfBaD+KC925mzsFLYrnqjrCNlugUMysDCVpEIBG yLWEV1rttaCxeb8RX4Bd43beJ40cE60= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=gbmV5vbpZY3IbJKdgCPy/qE/5VFsnH9igpOJ+b94j A4=; b=ZTxjvW66Xa+t8ziHPeasNgQFqhFr4mb6WP00ztyc0A59hJ2QBS3D6KCUA w/KolpJ/ORlJbvf3cg+UVDhsfz6l49OCCvR3htsnsqCeRY86d5N5qAHFJLn/i/PK ztd1LL6iLTJCncddszW5uORPYg16yIzz1LzmhaPHt/FGEcGa2HG2t7KtMAzEBGrb fDXyIHtZt6/yfdAx9d9NMvYLYFaFi/Bf8rBR5KB4IUoxHFiwSJrbe7Gtzm73a8n0 DcowZLql0p0g6cLU67IcPjarcjQyJ/ZJOTG1CEZDWkU08XWp6/x01HlMkvlU2qrj w94627AgaHqoBqPhveulr3qoU21jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtdehgdduiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne fgmhhpthihuchsuhgsjhgvtghtucdluddtmdenucfjughrpeffhffvkfggtggusehttder tddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrg hrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpefhjeeigfefvedvfeetheegledtkeev uddtgedtudeiteehteegvdefffduffefffenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 14 Jan 2022 17:34:32 -0500 (EST) Date: Fri, 14 Jan 2022 17:34:29 -0500 From: Leo Famulari To: GNU bug tracker automated control server Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: reassign 53238 guix retitle 53238 password-store fails to build with tree version 2 merge 53238 53272 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.21 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [64.147.123.21 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) reassign 53238 guix retitle 53238 password-store fails to build with tree version 2 merge 53238 53272 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 09:39:43 2022 Received: (at submit) by debbugs.gnu.org; 15 Jan 2022 14:39:43 +0000 Received: from localhost ([127.0.0.1]:39592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8kDX-00039y-MS for submit@debbugs.gnu.org; Sat, 15 Jan 2022 09:39:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:38714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8kDU-00039g-2m for submit@debbugs.gnu.org; Sat, 15 Jan 2022 09:39:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8kDT-00025l-Mu for guix-patches@gnu.org; Sat, 15 Jan 2022 09:39:39 -0500 Received: from [2a02:c205:2020:6054::1] (port=41440 helo=tobias.gr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8kDR-0005UD-T8 for guix-patches@gnu.org; Sat, 15 Jan 2022 09:39:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=9F8HWunjWphgV jd/SDyPJXqRW+AENYWcEv9Sk9+ECmw=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=QDfSWmZGOhNGE5CVaAPK4wMRajYmIe7aqgjX34 Au9NTXdfOYm6nlep0w6l1Oinh9xP0RikcEkclDUKydQBrdIUWD3Zkls+OJ4ZerUUeWK6Zp dYyAXbTjPV+jhv6GIQbuNH0iYwKzQnWLtnvpNTDHU2DA4mlHEFnDgE/SIYF+R8spODWx1S qn3LMOWof9sw9oAe/U3LG9ArVwe784HwbWk1FQGi5felEhP6stUfQNpOAfFsJt3GrDJjv/ D+ilBo5ZaehvDi3i6LZtgXW9Fa1qothvsxre0UlZDf0qqACoEs5k/r8C2XW0V1iu/DEcGS LuF+lHUlBGGhDod/wOAf3XeA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 4bd074b2 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 15 Jan 2022 14:39:32 +0000 (UTC) References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> <87a6fzchid.fsf@nckx> From: Tobias Geerinckx-Rice To: Olivier Dion Subject: Re: [bug#53238] [PATCH] gnu: tree: Remove stddata feature. Date: Sat, 15 Jan 2022 15:37:04 +0100 In-reply-to: <87a6fzchid.fsf@nckx> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87pmotm58x.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:c205:2020:6054::1 (failed) Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 53238@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Olivier, Maxim(no -e, sorry! :-), Going by the number of bug reports, password-store is more popular=20 than I thought. Tobias Geerinckx-Rice =E5=86=99=E9=81=93=EF=BC=9A > I was going to apply the patch below to fix the password-store > package, but Maxime just submitted another version which I=20 > prefer. I'd > rather not provide two trees in Guix. I haven't changed my mind, but I did push the tree-1 solution as a=20 =E2=80=98temporary fix=E2=80=99 since it's the least invasive. If Maxim's patch LGTeveryone, please go ahead and replace. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYeLc7g0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15bEoA/1uf887e6ABjyEGXn4UJXWrZ/Ctd3VRr9c+oD6bO 8B2YAP4zyT/AWS8diYrwDVd8z4Amd/q537363cLTw59pe2qzBw== =+VHt -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 14:50:11 2022 Received: (at control) by debbugs.gnu.org; 15 Jan 2022 19:50:11 +0000 Received: from localhost ([127.0.0.1]:41935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8p3y-0008Nr-VJ for submit@debbugs.gnu.org; Sat, 15 Jan 2022 14:50:11 -0500 Received: from tobias.gr ([80.241.217.52]:34102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8p3w-0008Ng-LY for control@debbugs.gnu.org; Sat, 15 Jan 2022 14:50:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=X1udWioEgzBwM SKzT7VXi5EKg6DYMfsL++FO7osdD1U=; h=date:to:from; d=tobias.gr; b=Ihny0e 7pXYi/rTDo9d2A+WPL4M0cMzytfRntUhp0c5NyCDQhWop5EGXN84E24mQjt6NsqwxMtRQt nRxvIvv79IvCRUqfSEjTdEHAN7SIiIgdVv8JEH5jxSftUAkEnU4y/GbpEsgFyk4IA4RwBr /r482cQTjde8B76sD/oe5jTEkV3UvSznDr+m/6E3O4LYs1m4idVMBja2lsFfE3aVXSaE+1 KbDPSj09lp5smNg28eGNRUNNxpgeXdW/lO2h76Du+EMbQViCukQmUS5LFSMtLhuv5yVkKW CKjec/jSfeqi9nWUJfHGCPY2QI07RvNCJ/dkmTMKCUwOlpCJEqynU+bA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a2aaf35c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Sat, 15 Jan 2022 19:50:04 +0000 (UTC) From: Tobias Geerinckx-Rice To: GNU Debbugs Date: Sat, 15 Jan 2022 20:50:59 +0100 BIMI-Selector: v=BIMI1; s=default; Message-ID: <87zgnw4w23.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 53238 53288 Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 53238 53288 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 12:04:39 2022 Received: (at 53238) by debbugs.gnu.org; 16 Jan 2022 17:04:39 +0000 Received: from localhost ([127.0.0.1]:44150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n98xH-0002Yz-Du for submit@debbugs.gnu.org; Sun, 16 Jan 2022 12:04:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n98xD-0002Yi-97 for 53238@debbugs.gnu.org; Sun, 16 Jan 2022 12:04:34 -0500 Received: from [2001:470:142:3::e] (port=50126 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n98x7-0006go-6C; Sun, 16 Jan 2022 12:04:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=H4BF+36VdH1JD1r5Aqhvf7DytkqXZhhWr8CO8O7xZX8=; b=GjAiW49Y91MZko99QSAZ Vb03GueMjQlvEUgQJWXQ4T7Np5yMUYGw7NWFa1Gk9BvzkRJuDajx6NWuPtUd8xIFEVR/MPjbYhyVz MEY75cqQTeOgPJvKC8uc0ivsP0n0XtBmaYBnyAVdOkQBLMrvYomthNUjnVle8iKFtprH9YiviITcs RpJR90qc0O73ujGm9YWlGWz5ICzBQ9T0X7aVCoh9aZLonRJCLiSHKOeWgKjZiwXoFDgaIg399uU5L cqrnPfqzUwgfu+1A0gSlRrOtK7J8+5foZYyeKvYJrNsncn21RS84bQErCyy+nhZzVPSlk2OEJeky/ 1yN31FcNckjssg==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:57220 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n98x7-0006iG-A0; Sun, 16 Jan 2022 12:04:25 -0500 From: Marius Bakke To: Maxim Cournoyer , Olivier Dion Subject: Re: [bug#53238] [PATCH] gnu: tree: Remove stddata feature. In-Reply-To: <87r19bxofo.fsf_-_@gmail.com> References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> <87r19bxofo.fsf_-_@gmail.com> Date: Sun, 16 Jan 2022 18:04:22 +0100 Message-ID: <877daz8ve1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53238 Cc: Tobias Geerinckx-Rice , 53238@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! Apologies for missing this discussion earlier... Maxim Cournoyer skriver: > Hi, > > Olivier Dion writes: > >> On Thu, 13 Jan 2022, Tobias Geerinckx-Rice wrote: >>> Olivier, >>> >>> Thanks again for tracking down this weird bug! >>> >>> Olivier Dion via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A >>>> This feature breaks some UNIX utilities. Fix it by disabling=20 >>>> the feature. >>> >>> Hm=E2=80=A6 How long would we have to carry this fork? My fear is we'= d=20 >>> do so indefinitely. >> >> I've contacted the maintainer asking for removal of the feature in its >> next release. I'm not sure if this will have some impact. Feel free to >> do the same at , maybe adding more weight >> in the balance would help. >> >>> How about creating a (possibly hidden) tree-without-stddata=20 >>> package variant, to use as input to packages who currently break=20 >>> with this feature enabled? That lets us refcount the need for it. >> >> It's more than just packages, it's also user scripts that can be broken >> and believe me when I say that this is not an easy bug to track down ;-). > > I'm on the fence about this, it does indeed seem an undesirable change, > especially since there's a --json option, but I am not the author of the > 'tree' software. After some consideration (and emails with tree author), I think the best solution is to patch 'password-store' so that it DTRT even in the presence of fd 3. I sent a patch to that effect upstream: https://lists.zx2c4.com/pipermail/password-store/2022-January/004563.html ...and have local patches to apply that in Guix and revert bd4f314bbacaaa56751be3a4769f2082be747d24 and a40ac6271578ea061a8a07b2adbd6032a690ca70. WDYT? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYeRQFg8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHeJfgD+Okk6I9IHmRBtxcSgc1WNFLC0/Nwe2obqFYj+ A3fHQEkBALGIax0lOnjRXAtZkxx1B22uM9RXWwEE8w8pseblFqUC =AHF+ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 13:06:27 2022 Received: (at 53238) by debbugs.gnu.org; 16 Jan 2022 18:06:27 +0000 Received: from localhost ([127.0.0.1]:44214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n99v8-0006KA-Rk for submit@debbugs.gnu.org; Sun, 16 Jan 2022 13:06:27 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:37899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n99us-0006Ji-Kh for 53238@debbugs.gnu.org; Sun, 16 Jan 2022 13:06:25 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9723B3200C14; Sun, 16 Jan 2022 13:06:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 16 Jan 2022 13:06:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=+C6l0t0/c0EuOaFaSpEI9n2BMf7SUFZK6ATTb+RwQcA=; b=B8xnQtmS2ZV3 gircbevJPLLzGqy06WmT1V8WLmc/WrnFFmi03E85s6oqArE95wqqeLefR1a5aAdI 6HYAvhQthIyRMQlJhRoj256xl0nTr4bWWRyd+NCNeRWSy7uTpKimaJF9LKqvSDXa bBoCiyOmHUtNs33E4C1YxpXZC922WiE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+C6l0t0/c0EuOaFaSpEI9n2BMf7SUFZK6ATTb+RwQ cA=; b=AP4EOLPGo9oxKKt7J1q/qcDDGJxEX19MsSayNagqQ69G6/vTEFWT7Dk1f TJTNY6UITJlohmpqFSIq19MiEs1wtAemkDzSKofBSimqMP6xw4DPa9PrLZ4t1A57 DImIgmQgAuKK92N8476ZJE/p5OkKk3yVidE08145iuLrvgwz/b/u/1AdaVV8/L+Q /jm238Lu+ndVXQ/hy9um2zC5z8nBeuFr4WuMY7Jpnm0simr4mUvYjWHFIAvI5JV1 AYhLR+6MWC6qbwGiT0Rtql+eVbss9Qtzsl7hPeIhy7MVhxymGvk683naFnPRg7Q4 o7wp/qON9oT2EXAW8BRnMIMH62Deg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtdelgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepfeeitdfgieelveegvedtveektefggeffkeefgfefveffleehgfeifeeufffh jeelnecuffhomhgrihhnpeiigidvtgegrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Jan 2022 13:06:03 -0500 (EST) Date: Sun, 16 Jan 2022 13:06:01 -0500 From: Leo Famulari To: Marius Bakke Subject: Re: bug#53238: [PATCH] gnu: tree: Remove stddata feature. Message-ID: References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> <87r19bxofo.fsf_-_@gmail.com> <877daz8ve1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <877daz8ve1.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53238 Cc: Olivier Dion , 53238@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Jan 16, 2022 at 06:04:22PM +0100, Marius Bakke wrote: > After some consideration (and emails with tree author), I think the best > solution is to patch 'password-store' so that it DTRT even in the > presence of fd 3. >=20 > I sent a patch to that effect upstream: >=20 > https://lists.zx2c4.com/pipermail/password-store/2022-January/004563.ht= ml >=20 > ...and have local patches to apply that in Guix and revert > bd4f314bbacaaa56751be3a4769f2082be747d24 and > a40ac6271578ea061a8a07b2adbd6032a690ca70. >=20 > WDYT? Definitely, this is the right approach. I didn't participate in this bugfix but I think that removing or adding features to packages is not something we should be doing at the level of the distro, except with upstream coordination. Reporting this issue to password-store should have been one of the first steps we took. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 17 12:37:36 2022 Received: (at 53238-done) by debbugs.gnu.org; 17 Jan 2022 17:37:36 +0000 Received: from localhost ([127.0.0.1]:47855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Vwm-0000Y2-7w for submit@debbugs.gnu.org; Mon, 17 Jan 2022 12:37:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Vwk-0000Xn-Gp for 53238-done@debbugs.gnu.org; Mon, 17 Jan 2022 12:37:34 -0500 Received: from [2001:470:142:3::e] (port=43600 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9Vwe-0003UM-SF; Mon, 17 Jan 2022 12:37:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=TbbP7JAvDy6OYFhLvESmnH/7OeS23p5s/1amfGBSikY=; b=HhxuP2x2i8dVEbKQTzN3 c74h3CDX183mGPOvGweKGZnTLtaWswxYX2QTo8qJmbsSXEvmq6VsrfVUTmanwP8clV8gbGnJHVH9X /Cl5QSdHOji1dva7ar9hPw6WUPfcR3KjAUejJ5r8uNZVdyqWes0YjN/cS8TsRokZ6ykNjgmBs4kGl ahbkvE4CB5MFORCvlILogn55re4YDXGoWdZXUvlWjbNMpTst5IbPPExfjs27mLsQJmt4MZ+Sslbkh CJhv0+UmGH3vI/kxXT07p28G84jrEmQHqtCjHDQ3BmU6o0NHxsPxF1XpVBC/FDD3yc4eNI+cpV3vw J6tjHWYAiCLLeg==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:57248 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9Vwe-0000Wk-74; Mon, 17 Jan 2022 12:37:29 -0500 From: Marius Bakke To: Leo Famulari Subject: Re: bug#53238: [PATCH] gnu: tree: Remove stddata feature. In-Reply-To: References: <87ee5bcqhy.fsf@nckx> <87ee5bwdzw.fsf@laura> <87r19bxofo.fsf_-_@gmail.com> <877daz8ve1.fsf@gnu.org> Date: Mon, 17 Jan 2022 18:37:26 +0100 Message-ID: <87sftm6z6x.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53238-done Cc: Olivier Dion , 53238-done@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Upstream fix pushed in 5da4cbfbd94163f87f188355e5490f04dd6864c2. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYeWpVg8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcAigD9ENn/9k1Z5q3KCnbTFicAQy9hpYIDTx+fFlQk sjZqRwkBAP8tU9U8hVNjAnbzzH/pX9yYGdRDJ+Vb6EyqPn42ziAB =yXs0 -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 22:14:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Feb 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator