GNU bug report logs - #53227
master: Wrong error message with M-: (funcall).

Previous Next

Package: emacs;

Reported by: Alan Mackenzie <acm <at> muc.de>

Date: Thu, 13 Jan 2022 07:40:02 UTC

Severity: minor

Tags: patch

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #41 received at 53227 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 53227 <at> debbugs.gnu.org, acm <at> muc.de, larsi <at> gnus.org, rpluim <at> gmail.com
Subject: Re: bug#53227: master: Wrong error message with M-: (funcall).
Date: Thu, 13 Jan 2022 19:09:43 -0500

Andreas Schwab [2022-01-14 01:04:47] wrote:
> On Jan 13 2022, Stefan Monnier wrote:
>>> Why do you need the second pattern?
>> The second pattern should let `pcase` generate better code.
> But it is not needed for this bug.

The actual fix is in the change from

    (`(funcall . ,(or `(,exp . ,args) pcase--dontcare))

to

    (`(funcall ,exp . ,args)

which makes the pattern not match `(funcall . ,_) any more.
The explicit

    (`(funcall . ,_) form)            ;bug#53227

is then present to make sure the first change doesn't worsen the
rest of the resulting macroexpanded code.


        Stefan
This bug report was last modified 3 years and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.