From unknown Sun Jun 15 08:26:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53227 <53227@debbugs.gnu.org> To: bug#53227 <53227@debbugs.gnu.org> Subject: Status: master: Wrong error message with M-: (funcall). Reply-To: bug#53227 <53227@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:26:20 +0000 retitle 53227 master: Wrong error message with M-: (funcall). reassign 53227 emacs submitter 53227 Alan Mackenzie severity 53227 minor tag 53227 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 02:39:29 2022 Received: (at submit) by debbugs.gnu.org; 13 Jan 2022 07:39:29 +0000 Received: from localhost ([127.0.0.1]:59975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7uhl-0004Ji-E1 for submit@debbugs.gnu.org; Thu, 13 Jan 2022 02:39:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:47004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7uhi-0004Ja-Pk for submit@debbugs.gnu.org; Thu, 13 Jan 2022 02:39:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7uhh-0005RX-CR for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 02:39:26 -0500 Received: from colin.muc.de ([193.149.48.1]:64439 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1n7uhe-0006ym-CL for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 02:39:25 -0500 Received: (qmail 88579 invoked by uid 3782); 13 Jan 2022 07:39:06 -0000 Received: from acm.muc.de (p4fe1586e.dip0.t-ipconnect.de [79.225.88.110]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 13 Jan 2022 08:39:05 +0100 Received: (qmail 4695 invoked by uid 1000); 13 Jan 2022 07:39:05 -0000 Date: Thu, 13 Jan 2022 07:39:05 +0000 To: bug-gnu-emacs@gnu.org Subject: master: Wrong error message with M-: (funcall). Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Emacs. In the master branch, with emacs -Q, do M-: (funcall) RET .. The error message one sees is (void-function nil) .. This is wrong. There is no function, nil or otherwise, supplied to funcall. The error message ought to be "Too few arguments", or something like that. The cause of the bug lies in Ffuncall in .../src/eval.c. There, the code uses args[0] without first checking that nargs > 0. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 04:13:55 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 09:13:55 +0000 Received: from localhost ([127.0.0.1]:60189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7wB9-00018y-Fv for submit@debbugs.gnu.org; Thu, 13 Jan 2022 04:13:55 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:42730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7wB6-00018c-T8 for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 04:13:53 -0500 Received: by mail-wm1-f47.google.com with SMTP id ay4-20020a05600c1e0400b0034a81a94607so2279769wmb.1 for <53227@debbugs.gnu.org>; Thu, 13 Jan 2022 01:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=q7z2z76PgcXHGpFpCVCPRv7ZnsQJ5HLBP5YBtGOwn6g=; b=G9q+SZsw/zJQ8LkxxsIeuhDg+vO3VfU2u5bqBasqdhUuCl9XaqKWJjM9W//J1fX+c7 GPuPxOkOCbMrNkQvnwEfzUCIdW8aBZwEYcqdbBU5+Wx6lOVaSfuWxXFQtkRkX4L4o3SP b9DuElTlyjf1CF342OkZGFVJLrTCZl3ZZUEBIdE8wdHk6T4n+HwkcjeS3VKq6ftb4GQv vo5KRk5gmY1n5ZJRu93286EfL8SvvOjd0KQB9Jyf240fzQIXzy43K9/0VaLvDArrzlSD C24b8dPb0MNMFR8ysrTcWhwEvr0yBUwYSq6AgqM6Ka5M7wZTTI2dy5FNrqr04KT3OiD2 j5HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=q7z2z76PgcXHGpFpCVCPRv7ZnsQJ5HLBP5YBtGOwn6g=; b=D4hc+q/F3dFUJSd5WWWl30oJC0Bp+a1XmvjCGrpVxPZAS1v0VPUkSRPNGMlW65KHax c48bFPNotxCFpsvsyBVpx1xMUzzXd0cb6y0AAl0RnVVjMa1dh9/OlwZx40318dPjZYQT 0iXD7KE0xLeCNOFcm3b4h0QfhYntvziRpTxvm9GLusDg7nOKmerNKr+EW+rT7CYmuPqq k6gvHR0Y0IBVy3JxRTqFjzI1zNEUH5IaWY546hMbkTReQPyWv3u6HKNKaVhVjci0MehU 4NA4psuQ6I6/hvpAFglIBe3QT5Azf9MGP5MhTPvI3cHnRhUDmZQVbzGx2ukDdFfygCke lcOw== X-Gm-Message-State: AOAM533/uBdTGy//dKhqusNihkyV5c7HQwrXOdMlt8Ve+uy6OHNwNYcF KQ6stI26+Wuw8l90vtEDyYXJnnK6548= X-Google-Smtp-Source: ABdhPJyPEQLZvZJzM3AsUbSAANdNNchxiYxIa1sP4wQtJBwSKpHQ8c3tQojAH1W4pr9+kJ3cEjMTpg== X-Received: by 2002:a7b:c931:: with SMTP id h17mr10298105wml.49.1642065226510; Thu, 13 Jan 2022 01:13:46 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:da2c:6e12:f0db:3a30]) by smtp.gmail.com with ESMTPSA id r1sm2468438wrz.30.2022.01.13.01.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 01:13:46 -0800 (PST) From: Robert Pluim To: Alan Mackenzie Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: Date: Thu, 13 Jan 2022 10:13:45 +0100 In-Reply-To: (Alan Mackenzie's message of "Thu, 13 Jan 2022 07:39:05 +0000") Message-ID: <874k683smu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 13 Jan 2022 07:39:05 +0000, Alan Mackenzie said: Alan> Hello, Emacs. Alan> In the master branch, with emacs -Q, do Alan> M-: (funcall) RET Alan> .. The error message one sees is Alan> (void-function nil) Alan> .. This is wrong. There is no function, nil or otherwise, suppl= ied to Alan> funcall. The error message ought to be "Too few arguments", or Alan> something like that. Alan> The cause of the bug lies in Ffuncall in .../src/eval.c. There, = the Alan> code uses args[0] without first checking that nargs > 0. It=CA=BCs not Ffuncall's responsibility to check that, it=CA=BCs 'eval' that should be doing it. Compare with eg M-: (format), which correctly signals 'wrong-number-of-arguments. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 04:33:02 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 09:33:02 +0000 Received: from localhost ([127.0.0.1]:60219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7wTd-0003wX-VA for submit@debbugs.gnu.org; Thu, 13 Jan 2022 04:33:02 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7wTZ-0003vp-6k for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 04:33:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FVO4+Ld/9cmg6ZuPBhwcXQ4msy8aoEXrP1iI0BL32/g=; b=GLkrU1mj0JIbqpf6kYbsrpuChj 0bPcZPmRjmEeM6ktsj0W3BsKmwgcjdpTGFtYA38cXil1vSvndQVj+hsITTizSUhvLZ9OpXGH/Jnyt nL88FK8g36qabYx9mpCSZwlzZLumLQiV2oSSg/LhgKEYVHP/uowCYef224PWEvx9B90o=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7wTN-0000zR-C5; Thu, 13 Jan 2022 10:32:48 +0100 From: Lars Ingebrigtsen To: Robert Pluim Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEWol5Gvop1GQEfW z9Di2dvq5Nzz7+fGv77///8ehiGEAAAAAWJLR0QIht6VegAAAAd0SU1FB+YBDQkfDX/56v4AAAGw SURBVDjLlZMxT+QwEIWdlQ7a5BpaCAUtYnxJi5RxahC2+xWb1IBvlb/PG8frZJcViKc0zjdvxh6P lVpUVmVRVWUFlX/VWlVWBAURMRsnGkX+fgaX46kSKHZwGAS7wVs2XdscwGsgzQDWMHfcUb9yCHCW CZW6ZnxcAyRjZhQYfAaDgI6FjYMUXwEk10jkYcCenzPQSCUOCXe2f1ocFAH7GWQHJyCHGS0vYE7E DptFDeMXxxz/bo10zPhtBs7h6zd/XIzot1WVgEW89fVdsOgINdt1qk4/1HVNoiY74pLw/zokkBxY ttM7wM00hTWYRG9nAIlDwB0dp4rLD4BAabtqBR5VfcuHc5SbA0BXXuoLxgnRRDgimM/L/LGXxsQm zsDzsZpnlRyYnjF1Ei2Bo8igxwXNv6F/2aHlUgcbHUcgXupgiTAR3Qp4icWVSB59BGRkcNeUqhyA 8qiO0cREuBPQkY6HN3O+DNwUdBwgJ3NNtM8O0s649GgwJj6D0xf1MxiolUtsXZgotHsB8Tn7Hd54 od5UuKqmq+l/Bv2ZVN+DL8W3SC0g0KI2jlgC5/R7sPkEliLrwYPOoLsAAAAldEVYdGRhdGU6Y3Jl YXRlADIwMjItMDEtMTNUMDk6MzE6MTMrMDA6MDBXt01PAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIy LTAxLTEzVDA5OjMxOjEzKzAwOjAwJur18wAAAABJRU5ErkJggg== X-Now-Playing: Panoptique Electrical's _Decades (2001-2021)_: "In a Landscape of Faces" Date: Thu, 13 Jan 2022 10:32:44 +0100 In-Reply-To: <874k683smu.fsf@gmail.com> (Robert Pluim's message of "Thu, 13 Jan 2022 10:13:45 +0100") Message-ID: <87mtk0ugjn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Itʼs not Ffuncall's responsibility to check that, itʼs 'eval' that > should be doing it. Compare with eg M-: (format), which correctly > signals 'wrong-number-of-arguments. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, Alan Mackenzie , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > It=CA=BCs not Ffuncall's responsibility to check that, it=CA=BCs 'eval' t= hat > should be doing it. Compare with eg M-: (format), which correctly > signals 'wrong-number-of-arguments. Or rather macroexpand-all: (macroexpand-all '(format)) =3D> (format) (macroexpand-all '(funcall)) =3D> (funcall nil) Perhaps Stefan has some insights into this; added to the CCs. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 05:56:07 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 10:56:07 +0000 Received: from localhost ([127.0.0.1]:60308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7xm3-0006Rs-5B for submit@debbugs.gnu.org; Thu, 13 Jan 2022 05:56:07 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:36810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7xly-0006R2-OO for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 05:56:06 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JZLvN5kMgz1qwy3; Thu, 13 Jan 2022 11:56:00 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JZLvN3t9Bz1qqkB; Thu, 13 Jan 2022 11:56:00 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id KgbqPBegZA0m; Thu, 13 Jan 2022 11:55:59 +0100 (CET) X-Auth-Info: It5AC+PKedQP9/IgczRTWGeG0OEWONFHnQFDBUZZVGW8k/v6tNTSMoFfyAc3RAOK Received: from igel.home (ppp-46-244-187-161.dynamic.mnet-online.de [46.244.187.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 13 Jan 2022 11:55:59 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 19E122C3772; Thu, 13 Jan 2022 11:55:59 +0100 (CET) From: Andreas Schwab To: Lars Ingebrigtsen Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> X-Yow: Zippy's brain cells are straining to bridge synapses... Date: Thu, 13 Jan 2022 11:55:58 +0100 In-Reply-To: <87mtk0ugjn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 13 Jan 2022 10:32:44 +0100") Message-ID: <87pmov52gx.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, Alan Mackenzie , Robert Pluim , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 13 2022, Lars Ingebrigtsen wrote: > Robert Pluim writes: > >> Itʼs not Ffuncall's responsibility to check that, itʼs 'eval' that >> should be doing it. Compare with eg M-: (format), which correctly >> signals 'wrong-number-of-arguments. > > Or rather macroexpand-all: > > (macroexpand-all '(format)) > => (format) > > (macroexpand-all '(funcall)) > => (funcall nil) Same as bug #46636. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 09:37:00 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 14:37:00 +0000 Received: from localhost ([127.0.0.1]:60567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n81Do-0002v8-KL for submit@debbugs.gnu.org; Thu, 13 Jan 2022 09:37:00 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n81Dl-0002un-6y for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 09:36:59 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 16C52805CC; Thu, 13 Jan 2022 09:36:51 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 742448049E; Thu, 13 Jan 2022 09:36:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642084609; bh=FRdXXWSYhtrNWzpkUZR6L9I/I9Z2/KuvYKwbwpOUd14=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eImECKx9bsCCl41kDfjQF8alcIyI7mbTkz3Fs/7nEf+1b2cHcz7I7+IpGbUTAIT89 J8xhAr2r/N7OpV6K88C7fdyq4B/011jQuqB7dJsi7NexitpFTtjN1HjG59l7sAOHqw caJ9qrzmpilOrSoqEz79xcqt7GX82rS1bCOqESAU0RHza2RprsiSO3oi0oc+vHhrTR hUYncTGtcLr5ueZPgH9TwqzJ+QDfWKJGpWXuvBJwzKJ7/GkNTiifk/qVL3gUQc+pf4 rgzzfvdzUolF8EpHba8jdKy+2vdIaii9TngkuUOstnalcze+kouJuFZAUSQ3wqrIyB aDcMQ5niMGD1Q== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3A89E120297; Thu, 13 Jan 2022 09:36:49 -0500 (EST) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> Date: Thu, 13 Jan 2022 09:36:48 -0500 In-Reply-To: <87pmov52gx.fsf@igel.home> (Andreas Schwab's message of "Thu, 13 Jan 2022 11:55:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.148 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, Alan Mackenzie , Lars Ingebrigtsen , Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Same as bug #46636. Actually, it's a different bug, tho its origin might be the same commit. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 10:37:28 2022 Received: (at submit) by debbugs.gnu.org; 13 Jan 2022 15:37:28 +0000 Received: from localhost ([127.0.0.1]:34309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n82AJ-0005Gt-SG for submit@debbugs.gnu.org; Thu, 13 Jan 2022 10:37:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:54128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n82AG-0005Gh-U4 for submit@debbugs.gnu.org; Thu, 13 Jan 2022 10:37:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n82AG-0002p6-Ki for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 10:37:24 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:55998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n82AE-0001fb-Dc for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 10:37:24 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JZT7p6HDVz1qxH7; Thu, 13 Jan 2022 16:37:10 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JZT7p4JcCz1qqkB; Thu, 13 Jan 2022 16:37:10 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id hD8lniB4QC7M; Thu, 13 Jan 2022 16:37:09 +0100 (CET) X-Auth-Info: ZC+wVPSLjVjAmK9ZDOSyhto+IQXUdsJCz0nhfUXOU5aDza3unaCKRzy+yIU3Vt8D Received: from igel.home (ppp-46-244-187-161.dynamic.mnet-online.de [46.244.187.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 13 Jan 2022 16:37:09 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 360862C383C; Thu, 13 Jan 2022 16:37:09 +0100 (CET) From: Andreas Schwab To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> X-Yow: I feel like a wet parking meter on Darvon! Date: Thu, 13 Jan 2022 16:37:09 +0100 In-Reply-To: (Stefan Monnier via's message of "Thu, 13 Jan 2022 09:36:48 -0500") Message-ID: <87fspr4pga.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: 53227@debbugs.gnu.org, Alan Mackenzie , Lars Ingebrigtsen , Stefan Monnier , Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Jan 13 2022, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: >> Same as bug #46636. > > Actually, it's a different bug, tho its origin might be the same commit. It's coming from the same funcall rewrite rule. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 13:24:42 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 18:24:42 +0000 Received: from localhost ([127.0.0.1]:34559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n84mA-0004B4-BC for submit@debbugs.gnu.org; Thu, 13 Jan 2022 13:24:42 -0500 Received: from colin.muc.de ([193.149.48.1]:15285 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1n84m7-0004Ao-Vo for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 13:24:41 -0500 Received: (qmail 8133 invoked by uid 3782); 13 Jan 2022 18:24:32 -0000 Received: from acm.muc.de (p4fe1586e.dip0.t-ipconnect.de [79.225.88.110]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 13 Jan 2022 19:24:31 +0100 Received: (qmail 7706 invoked by uid 1000); 13 Jan 2022 18:24:30 -0000 Date: Thu, 13 Jan 2022 18:24:30 +0000 To: Lars Ingebrigtsen Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87mtk0ugjn.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, Robert Pluim , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Lars. On Thu, Jan 13, 2022 at 10:32:44 +0100, Lars Ingebrigtsen wrote: > Robert Pluim writes: > > Itʼs not Ffuncall's responsibility to check that, itʼs 'eval' that > > should be doing it. Compare with eg M-: (format), which correctly > > signals 'wrong-number-of-arguments. > Or rather macroexpand-all: > (macroexpand-all '(format)) > => (format) > (macroexpand-all '(funcall)) > => (funcall nil) Yes, it is the macro expansion causing the problem, thanks. The following fixes it (or, at least, "fixes" it; I'm not clear exactly what the pcase--dontcare clause is there for). diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el index 663856a8fb..eb5af9ece6 100644 --- a/lisp/emacs-lisp/macroexp.el +++ b/lisp/emacs-lisp/macroexp.el @@ -441,8 +373,9 @@ macroexp--expand-all (macroexp--all-forms args) form) (macroexp--expand-all newform)))) - - (`(funcall . ,(or `(,exp . ,args) pcase--dontcare)) + (`(funcall) + form) + (`(funcall . (,exp . ,args)) (let ((eexp (macroexp--expand-all exp)) (eargs (macroexp--all-forms args))) ;; Rewrite (funcall #'foo bar) to (foo bar), in case `foo' > Perhaps Stefan has some insights into this; added to the CCs. > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 15:37:22 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 20:37:22 +0000 Received: from localhost ([127.0.0.1]:34692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86qX-0001vb-Tw for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:37:22 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86qV-0001vK-Jm for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 15:37:20 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8BFE34423A7; Thu, 13 Jan 2022 15:37:13 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E847D44239C; Thu, 13 Jan 2022 15:37:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642106231; bh=IurxfF6TDQ9trRyDDO2FfkyeP+UgYwW98zrH4IO8ayY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OOE/rLI5RklizprF0UxnFVkPTBMs98NkkmAGEL2pAJdkEhfvpaZziJm0EKelMLSLq ZNvhPmJgEbbfiaYfxTHdQ0vPklzOa7Chw7ZbB76T8/cuvsW0Z6L9t7tFFGJ4BwrfyE L6U05eyOxJ5GXoJicnOgQgTSEI7S60QLf2p/GDSUUjjJUcl2dO/gnIpPrkn0mlX+vN KUAXoEdMciHAzNlH7sK5lCHipaSspOFzjKHMhNkNbfIIZRmW7oY1Qve/xaQldWv+Ib 7ZYkWuSwt0gES2rl28I0kARd4ZOAKCtWUO55bAHNHU+8MuHs8n+tc5+kI4GrM6MskM GYjeWJ2/VBtrg== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A3EC61204D4; Thu, 13 Jan 2022 15:37:11 -0500 (EST) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> Date: Thu, 13 Jan 2022 15:37:10 -0500 In-Reply-To: <87fspr4pga.fsf@igel.home> (Andreas Schwab's message of "Thu, 13 Jan 2022 16:37:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.556 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Andreas Schwab [2022-01-13 16:37:09] wrote: > On Jan 13 2022, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss > army knife of text editors" wrote: >>> Same as bug #46636. >> Actually, it's a different bug, tho its origin might be the same commit. > It's coming from the same funcall rewrite rule. I see you agree ;-) The patch should hopefully fix both cases, tho as you can see the two cases are fixed separately (which is what I mean by them being two different bugs). Stefan diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el index b44917f7d56..33ce55a3de8 100644 --- a/lisp/emacs-lisp/macroexp.el +++ b/lisp/emacs-lisp/macroexp.el @@ -366,14 +366,18 @@ macroexp--expand-all form) (macroexp--expand-all newform)))) - (`(funcall . ,(or `(,exp . ,args) pcase--dontcare)) + (`(funcall ,exp . ,args) (let ((eexp (macroexp--expand-all exp)) (eargs (macroexp--all-forms args))) ;; Rewrite (funcall #'foo bar) to (foo bar), in case `foo' ;; has a compiler-macro, or to unfold it. (pcase eexp - (`#',f (macroexp--expand-all `(,f . ,eargs))) + ((and `#',f + (guard (not (or (special-form-p f) (macrop f)))));; bug#46636 + (macroexp--expand-all `(,f . ,eargs))) (_ `(funcall ,eexp . ,eargs))))) + (`(funcall . ,_) form) ;bug#53227 + (`(,func . ,_) (let ((handler (function-get func 'compiler-macro)) (funargs (function-get func 'funarg-positions))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 16:28:07 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 21:28:07 +0000 Received: from localhost ([127.0.0.1]:34761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n87df-0003RT-1z for submit@debbugs.gnu.org; Thu, 13 Jan 2022 16:28:07 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:40352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n87db-0003RE-6m for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 16:28:05 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JZcwc6T2Hz1sBQy; Thu, 13 Jan 2022 22:28:00 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JZcwc429mz1qqkB; Thu, 13 Jan 2022 22:28:00 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id gNuVcMM6rBVj; Thu, 13 Jan 2022 22:27:59 +0100 (CET) X-Auth-Info: l+Jbv7pM09LrgranJ+9yJOjHxyaBYOX769fEKqCnRgV35tOVKCF9fR4U7WpRyv1N Received: from igel.home (ppp-46-244-187-161.dynamic.mnet-online.de [46.244.187.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 13 Jan 2022 22:27:59 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id C16262C389C; Thu, 13 Jan 2022 22:27:58 +0100 (CET) From: Andreas Schwab To: Stefan Monnier Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> X-Yow: RELAX!! ... This is gonna be a HEALING EXPERIENCE!! Besides, I work for DING DONGS! Date: Thu, 13 Jan 2022 22:27:58 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Jan 2022 15:37:10 -0500") Message-ID: <87pmov2un5.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 13 2022, Stefan Monnier wrote: > Andreas Schwab [2022-01-13 16:37:09] wrote: >> On Jan 13 2022, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss >> army knife of text editors" wrote: >>>> Same as bug #46636. >>> Actually, it's a different bug, tho its origin might be the same commit. >> It's coming from the same funcall rewrite rule. > > I see you agree ;-) > > The patch should hopefully fix both cases, tho as you can see the two > cases are fixed separately (which is what I mean by them being two > different bugs). Are they? Why do you need the second pattern? -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 18:52:28 2022 Received: (at 53227) by debbugs.gnu.org; 13 Jan 2022 23:52:29 +0000 Received: from localhost ([127.0.0.1]:34849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n89tM-0001XK-Oi for submit@debbugs.gnu.org; Thu, 13 Jan 2022 18:52:28 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n89tI-0001X2-Ox for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 18:52:26 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A4E6D8049E; Thu, 13 Jan 2022 18:52:18 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3FA5E80533; Thu, 13 Jan 2022 18:52:17 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642117937; bh=/KLVFkwxK6SJVomM3RGQj1AIEptOqv2pgbzwQO2+2Ek=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=h5z9FwX7AwIR0so4Zz2xd4X/CMSPbfPJbPwk1tjpA6S/L3Mtg1WzJd2g5X05ZFu6O Opq9ddaOUuf/0qTuzp+oWDFjHS/Q39V/SLmtCHcSM7BEnGEbj1wqzy/X7vpRDPWUF7 Y+6EubeFeJ+E+KvpDX6njN5qIKiSiBge32/5S162AJL+EF8Rw5bNu6NHQ/x5AWxk+7 5mEl3mgqNMv6gNJAPNMvar20HdBACPQGBKxhJnDHqZvS2Hn0lJsJWllC2w4lOrGiDN KZi1QzjV3dBmjvI2p22aE3Pi5U7UZqyaN0hpN1tSAW4qCsSXDtsc5n5PQ4rw47U+BE Z52rU4wDEJrRQ== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 09FE812022E; Thu, 13 Jan 2022 18:52:17 -0500 (EST) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> Date: Thu, 13 Jan 2022 18:52:15 -0500 In-Reply-To: <87pmov2un5.fsf@igel.home> (Andreas Schwab's message of "Thu, 13 Jan 2022 22:27:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.148 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Why do you need the second pattern? The second pattern should let `pcase` generate better code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 19:04:55 2022 Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 00:04:56 +0000 Received: from localhost ([127.0.0.1]:34861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8A5P-0001uf-NK for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:04:55 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:41700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8A5K-0001uS-Aj for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 19:04:54 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JZhPY0rwTz1qwxn; Fri, 14 Jan 2022 01:04:48 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JZhPX6974z1qqkD; Fri, 14 Jan 2022 01:04:48 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Y-TFf913yJu4; Fri, 14 Jan 2022 01:04:48 +0100 (CET) X-Auth-Info: PUl3VWcSf17wbSKsYbhlzSBVcDjueKcpi/E9hqv3ebsAhrCJQxLgzvAsmhsVLgLn Received: from igel.home (ppp-46-244-187-161.dynamic.mnet-online.de [46.244.187.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 14 Jan 2022 01:04:48 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 9007E2C36DA; Fri, 14 Jan 2022 01:04:47 +0100 (CET) From: Andreas Schwab To: Stefan Monnier Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> X-Yow: Hey, I LIKE that POINT!! Date: Fri, 14 Jan 2022 01:04:47 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Jan 2022 18:52:15 -0500") Message-ID: <87lezj2nds.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 13 2022, Stefan Monnier wrote: >> Why do you need the second pattern? > > The second pattern should let `pcase` generate better code. But it is not needed for this bug. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 19:09:56 2022 Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 00:09:56 +0000 Received: from localhost ([127.0.0.1]:34866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AAG-00023a-8g for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:09:56 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AAE-00023J-0a for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 19:09:54 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0AFF41001AC; Thu, 13 Jan 2022 19:09:48 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3CB3710018A; Thu, 13 Jan 2022 19:09:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642118986; bh=MmLkjGHCdu9NubT23iL9HNFREHztK4QHpv0EcoGwIrk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FV12eJ3If/ITIvzf3BfwkwK280O7KXPfa1ohWOBicE3L2/4CLOUg10hOn5cfEix6R 82Lb8K/OIZejX23QqM5Thl88Y0ivr9Jh47tAeCOiFi+WlzN5B/V7wCD7cgXG3WWjLT 5rrYSYxVykdSwk47bAMuoiR+6pgKuesjpXuH5vUOYTN4JMJ4BpttZSAgbKR6H+rBcr a4zKKh4NmN2KEinCouLo4vWsNHVwDPgij+CjXvd5SmWVDGYxxPrpT9VnCWtuNbh6aB PrBoAZ0Omp8zVGTeUqDPKJcITCzRPlY8q/JfnG6FZXvyelBh3C2A9+MDAiafP8UMs4 5QGl39dC1MNvg== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EC8431203CD; Thu, 13 Jan 2022 19:09:45 -0500 (EST) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> <87lezj2nds.fsf@igel.home> Date: Thu, 13 Jan 2022 19:09:43 -0500 In-Reply-To: <87lezj2nds.fsf@igel.home> (Andreas Schwab's message of "Fri, 14 Jan 2022 01:04:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Andreas Schwab [2022-01-14 01:04:47] wrote: > On Jan 13 2022, Stefan Monnier wrote: >>> Why do you need the second pattern? >> The second pattern should let `pcase` generate better code. > But it is not needed for this bug. The actual fix is in the change from (`(funcall . ,(or `(,exp . ,args) pcase--dontcare)) to (`(funcall ,exp . ,args) which makes the pattern not match `(funcall . ,_) any more. The explicit (`(funcall . ,_) form) ;bug#53227 is then present to make sure the first change doesn't worsen the rest of the resulting macroexpanded code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 19:17:11 2022 Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 00:17:11 +0000 Received: from localhost ([127.0.0.1]:34871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AHH-0002HZ-0m for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:17:11 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:58186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AHE-0002HQ-Av for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 19:17:10 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JZhgl4FNVz1s9N2; Fri, 14 Jan 2022 01:17:07 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JZhgl1Xndz1qqkB; Fri, 14 Jan 2022 01:17:07 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Vdymv7JDMfMy; Fri, 14 Jan 2022 01:17:06 +0100 (CET) X-Auth-Info: liTJH+8tEi3N+JWiJVjS5sbtLsn97BnKBmDSZ5g9oYSvjXIWe4OXZ2a6Ui2JUXrs Received: from igel.home (ppp-46-244-187-161.dynamic.mnet-online.de [46.244.187.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 14 Jan 2022 01:17:06 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id EE4F12C36DA; Fri, 14 Jan 2022 01:17:05 +0100 (CET) From: Andreas Schwab To: Stefan Monnier Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> <87lezj2nds.fsf@igel.home> X-Yow: But was he mature enough last night at the lesbian masquerade? Date: Fri, 14 Jan 2022 01:17:05 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Jan 2022 19:09:43 -0500") Message-ID: <87h7a72mta.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 13 2022, Stefan Monnier wrote: > The explicit > > (`(funcall . ,_) form) ;bug#53227 > > is then present to make sure the first change doesn't worsen the > rest of the resulting macroexpanded code. I don't understand. How much better than (funcall) can it get? -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 19:20:08 2022 Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 00:20:08 +0000 Received: from localhost ([127.0.0.1]:34876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AK4-0002Ml-Ef for submit@debbugs.gnu.org; Thu, 13 Jan 2022 19:20:08 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8AK1-0002M9-S5 for 53227@debbugs.gnu.org; Thu, 13 Jan 2022 19:20:03 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 841C0805B4; Thu, 13 Jan 2022 19:19:55 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AC07980533; Thu, 13 Jan 2022 19:19:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642119593; bh=yhrb7jN/MD0IKwnbPYLZ/HcucK0etfI9HCf8F96nFUw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oJhRM74RoyyawY/mokEmpfH9t9lfV0X4d35DjOh9eIcX1C0PZqgA54oXKxy//xt2r mBpOOgwgQKO16paa/6xW30Nt4XrbK4PVGGBGm4ZATGMwpcrgFPSw2MMaXuS7i7Ulj3 yWh2G+gbzwQANKipwRVFKun5UNEfXsKSOJf3xdaZAgWZ7S6y//P4kQ3TX64tPABca7 Xb0bLnbvII1S04owBLRZ2k+mb/UxL6AWSWmgMe94GF2YUnQ7DDHd3jjFtPzgGdehyV 5oa9aWxayJ1wr6JlwGvgkm3gzFXBTs37c/l2l/5pvSu/uk9tXs/z2MFZuQp4XrlbA0 YjFTa/4cFdcMw== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5B89A12041E; Thu, 13 Jan 2022 19:19:53 -0500 (EST) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> <87lezj2nds.fsf@igel.home> <87h7a72mta.fsf@igel.home> Date: Thu, 13 Jan 2022 19:19:50 -0500 In-Reply-To: <87h7a72mta.fsf@igel.home> (Andreas Schwab's message of "Fri, 14 Jan 2022 01:17:05 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.148 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> (`(funcall . ,_) form) ;bug#53227 >> >> is then present to make sure the first change doesn't worsen the >> rest of the resulting macroexpanded code. > > I don't understand. How much better than (funcall) can it get? I'm not talking about the quality of the code output by `macroexp--expand-all` but about the quality of the code *of* `macroexp--expand-all`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 20:53:37 2022 Received: (at control) by debbugs.gnu.org; 14 Jan 2022 01:53:37 +0000 Received: from localhost ([127.0.0.1]:34923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Bma-00056m-Sa for submit@debbugs.gnu.org; Thu, 13 Jan 2022 20:53:36 -0500 Received: from mail-pf1-f169.google.com ([209.85.210.169]:43664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8BmV-000569-Sd for control@debbugs.gnu.org; Thu, 13 Jan 2022 20:53:35 -0500 Received: by mail-pf1-f169.google.com with SMTP id 78so1467243pfu.10 for ; Thu, 13 Jan 2022 17:53:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=n8x1VFuvtuRnBebooBMBf/gby/i78fFTsBwjlp7PbZY=; b=j8MSqAG3lwunOubCcPolaPv6V/0D21kJmlcYQ2PBxHfpwNM3g5rmyCSRY3wOW8suZw rSmIrsRA5xju9B7eNPW1bK0brUl/1kMJiwUBB7i+ynEKEqonz1M/VdLcaPpcfQS6JxfE WSp7AgyJrSMVBQMcrUC+9wE3LNjwBe5we8kNLyE4gX0u925AV8XaFiJ2ur3/O9sqtuqT jcBzAdixYvKy4LRfFNRbS/hhkAWzgN6sks1Kt4QTAPbpiuHDJT9laI1XUS0syAXUe3Bg EjF8j3Pq189rDA7jZ686rueLaWZOH2DLtCtSxxHe1ravDN3J7EHjODvL8kUfW7CFfegY Y88A== X-Gm-Message-State: AOAM530mV7zN+/n3Oni1H3Wf7nZZlx/XZaKX5XpvfmktgJQLEdnNNdW9 R7XsCH8U54OQZJ43rNJ4QTdh4E6y9WZOzB5+bWFm1dpints= X-Google-Smtp-Source: ABdhPJwTIL7BmqeCmFg4sQ7LxntNc59fAl+I8C0U5eUIkH0BgT/0UW3T3pv03CYRmHBs8XzDgJqc7OahjSQsCdFMl/A= X-Received: by 2002:aa7:86c9:0:b0:4c2:61c:1888 with SMTP id h9-20020aa786c9000000b004c2061c1888mr4153099pfo.70.1642125206184; Thu, 13 Jan 2022 17:53:26 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Jan 2022 17:53:25 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 13 Jan 2022 17:53:25 -0800 Message-ID: Subject: control message for bug #53227 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 53227 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 02:36:39 2022 Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 07:36:39 +0000 Received: from localhost ([127.0.0.1]:35322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8H8Z-0000qF-Kb for submit@debbugs.gnu.org; Fri, 14 Jan 2022 02:36:39 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8H8Y-0000q2-9q for 53227@debbugs.gnu.org; Fri, 14 Jan 2022 02:36:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e03wa2NmUEa/xJURV1VuVfEP+DNhM46TotdRyQWNAd0=; b=e9L5LTpnncODAUubQBRdL8u7ix lWQusSWUMtl6FntNSI0LLwD6WBNL1bBfA+bwKfrmgNvVHyhJiSIZpqg1R5qbES51A36eiX/CjPhrj SvSt45+mjFyhu51txCatxZGjMM+h6j+S8AcYNFBp1TfcuFHe94Iwj8hp6d/LGPsV/Y/Y=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8H8N-0001K7-VA; Fri, 14 Jan 2022 08:36:30 +0100 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> X-Now-Playing: Various's _I Wanna Be Kate: The Songs of Kate Bush_: "Home For Christmas (2020 Remaster)" Date: Fri, 14 Jan 2022 08:36:27 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Jan 2022 15:37:10 -0500") Message-ID: <87tue6u5tw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > The patch should hopefully fix both cases, tho as you can see the two > cases are fixed separately (which is what I mean by them being two > different bugs). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, rpluim@gmail.com, Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > The patch should hopefully fix both cases, tho as you can see the two > cases are fixed separately (which is what I mean by them being two > different bugs). I can confirm that this fixes the reported problem (and it doesn't lead to any test suite regressions), so please do go ahead and push it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 04:55:48 2022 Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 09:55:48 +0000 Received: from localhost ([127.0.0.1]:35673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8JJE-0003xB-29 for submit@debbugs.gnu.org; Fri, 14 Jan 2022 04:55:48 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:59329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8JJA-0003wy-Iw for 53227@debbugs.gnu.org; Fri, 14 Jan 2022 04:55:46 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4JZxWL41PZz1s9RW; Fri, 14 Jan 2022 10:55:42 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4JZxWL1Ftcz1qqkJ; Fri, 14 Jan 2022 10:55:42 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id A1gesf0KoVGD; Fri, 14 Jan 2022 10:55:41 +0100 (CET) X-Auth-Info: 4JFVZywX1IFSKvUdxVaMvKi4yI6a3fb8nS5HMadOPp2ns0mnhlJjaThwTjnO2plv Received: from igel.home (ppp-46-244-178-192.dynamic.mnet-online.de [46.244.178.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 14 Jan 2022 10:55:41 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 9543E2C323E; Fri, 14 Jan 2022 10:55:40 +0100 (CET) From: Andreas Schwab To: Stefan Monnier Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> <87lezj2nds.fsf@igel.home> <87h7a72mta.fsf@igel.home> X-Yow: .. Now I think I just reached the state of HYPERTENSION that comes JUST BEFORE you see the TOTAL at the SAFEWAY CHECKOUT COUNTER! Date: Fri, 14 Jan 2022 10:55:40 +0100 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Jan 2022 19:19:50 -0500") Message-ID: <87wnj263qb.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jan 13 2022, Stefan Monnier wrote: >>> (`(funcall . ,_) form) ;bug#53227 >>> >>> is then present to make sure the first change doesn't worsen the >>> rest of the resulting macroexpanded code. >> >> I don't understand. How much better than (funcall) can it get? > > I'm not talking about the quality of the code output by > `macroexp--expand-all` but about the quality of the code *of* > `macroexp--expand-all`. You mean this? @@ -534,16 +534,14 @@ byte code for macroexp--expand-all: 431 stack-ref 3 432 call 2 433 return -434:28 stack-ref 2 -435 stack-ref 5 -436 stack-ref 3 -437 call 2 -438 return -439:29 stack-ref 1 -440 stack-ref 4 -441 stack-ref 2 -442 call 2 -443 return -444:30 stack-ref 2 -445 car-safe -446 return +434:28 stack-ref 4 +435 car-safe +436 return +437:29 stack-ref 1 +438 stack-ref 4 +439 stack-ref 2 +440 call 2 +441 return +442:30 stack-ref 2 +443 car-safe +444 return Hardly worth optimizing for a case that never occurs, IMHO. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 12:22:32 2022 Received: (at 53227) by debbugs.gnu.org; 14 Jan 2022 17:22:32 +0000 Received: from localhost ([127.0.0.1]:38004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8QHY-0007M1-Hv for submit@debbugs.gnu.org; Fri, 14 Jan 2022 12:22:32 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8QHU-0007Lg-4f for 53227@debbugs.gnu.org; Fri, 14 Jan 2022 12:22:30 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 08F9F804DD; Fri, 14 Jan 2022 12:22:22 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2FC4780066; Fri, 14 Jan 2022 12:22:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642180940; bh=cSlANYKH34+BFRaJRofMwPXZg9rrdr9S4xIkHO1zrlk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lAzDDAoqSTAkCYnnHxYwbnNdgQzuk1A3A/t3EINcZESRLZ9v1BtQOZ2Vp+iNcjsp3 KZ0ijLd4Kc4ipY2L+HT/4Ku2Y/IIe/2zwLRhQ2wgqv0K3Hg6739mu36qKtHc4YamV+ d+IlcFpfHJpA830Min4YxhBtd3jm9E+cLCc+FnZzZdt0zhvYdvqHSZhnUoMuomNzbK 8Sl6ARbDbG13CNHVPpEeS462Jye66nmvkwz16Brhb64uDJaOyhdyjMfbOOKswgVETC 2WgtWlPpTRWACWne7jEf2z7LdZN19lfyfhBGmWbsjudKVrpUN7oZlFnYvjJE5GbDvO QimB+DDjDzv6w== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E574A120476; Fri, 14 Jan 2022 12:22:19 -0500 (EST) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87pmov2un5.fsf@igel.home> <87lezj2nds.fsf@igel.home> <87h7a72mta.fsf@igel.home> <87wnj263qb.fsf@igel.home> Date: Fri, 14 Jan 2022 12:22:18 -0500 In-Reply-To: <87wnj263qb.fsf@igel.home> (Andreas Schwab's message of "Fri, 14 Jan 2022 10:55:40 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.148 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227 Cc: 53227@debbugs.gnu.org, acm@muc.de, larsi@gnus.org, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > You mean this? > > @@ -534,16 +534,14 @@ byte code for macroexp--expand-all: > 431 stack-ref 3 > 432 call 2 > 433 return > -434:28 stack-ref 2 > -435 stack-ref 5 > -436 stack-ref 3 > -437 call 2 > -438 return > -439:29 stack-ref 1 > -440 stack-ref 4 > -441 stack-ref 2 > -442 call 2 > -443 return > -444:30 stack-ref 2 > -445 car-safe > -446 return > +434:28 stack-ref 4 > +435 car-safe > +436 return > +437:29 stack-ref 1 > +438 stack-ref 4 > +439 stack-ref 2 > +440 call 2 > +441 return > +442:30 stack-ref 2 > +443 car-safe > +444 return Hmm... indeed a few of the other patterns, such as: (`(,(and fun `(lambda . ,_)) . ,args) already prevent the optimization I was aiming for :-( Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 12:27:07 2022 Received: (at 53227-done) by debbugs.gnu.org; 14 Jan 2022 17:27:07 +0000 Received: from localhost ([127.0.0.1]:38064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8QLz-0007Wb-7e for submit@debbugs.gnu.org; Fri, 14 Jan 2022 12:27:07 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:5067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8QLy-0007W0-GD for 53227-done@debbugs.gnu.org; Fri, 14 Jan 2022 12:27:06 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0AAB51001AC; Fri, 14 Jan 2022 12:27:01 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A67F4100121; Fri, 14 Jan 2022 12:26:59 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642181219; bh=dEo3yZnEHbsuZMAVkOW0T6fSiOiWK/UufbBxBEotALg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jRSB4+odFaipPnKKJQn07OGwjOvnr6man6ZyUMI3VVuqJkSByjk567a2D5xZ7CV7y aZB1FchaP6rAqzy0A7e/vzUIiEgXEIdrYy2qk1veeMfUhwBttVM0MjCquJ3zQ74D6E 0imtPCcUFmy9q0nDbrfSr6qXfkGu2C7Ob7zoqeDxDNw1CEflHBGw2Fo3uAYPSeYqH3 aAmaedItVqldCAEFL9Mwh11E0qZoA1/2QFU+ex5/gusTAI7l1T4BeiBkQbWRvfhOb6 MIh7R8Gw3EqnCTkSRBYmyh2MCYtBMtEG9eK9eOvx8Ea1pb2p/d2rNp4t9hjipU67j5 MXkdmy3iP+cIg== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4EAA21201B2; Fri, 14 Jan 2022 12:26:59 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#53227: master: Wrong error message with M-: (funcall). Message-ID: References: <874k683smu.fsf@gmail.com> <87mtk0ugjn.fsf@gnus.org> <87pmov52gx.fsf@igel.home> <87fspr4pga.fsf@igel.home> <87tue6u5tw.fsf@gnus.org> Date: Fri, 14 Jan 2022 12:26:58 -0500 In-Reply-To: <87tue6u5tw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 14 Jan 2022 08:36:27 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.116 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53227-done Cc: 53227-done@debbugs.gnu.org, acm@muc.de, rpluim@gmail.com, Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The patch should hopefully fix both cases, tho as you can see the two >> cases are fixed separately (which is what I mean by them being two >> different bugs). > I can confirm that this fixes the reported problem (and it doesn't lead > to any test suite regressions), so please do go ahead and push it. Done, thanks, Stefan From unknown Sun Jun 15 08:26:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 12 Feb 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator