Subject: Re: bug#53227: master: Wrong error message with M-: (funcall).

From: Stefan Monnier <[email-masked]>
Date: Thu, 13 Jan 2022 19:09:43 -0500

Andreas Schwab [2022-01-14 01:04:47] wrote:
> On Jan 13 2022, Stefan Monnier wrote:
>>> Why do you need the second pattern?
>> The second pattern should let `pcase` generate better code.
> But it is not needed for this bug.

The actual fix is in the change from

    (`(funcall . ,(or `(,exp . ,args) pcase--dontcare))

to

    (`(funcall ,exp . ,args)

which makes the pattern not match `(funcall . ,_) any more.
The explicit

    (`(funcall . ,_) form)            ;bug#53227

is then present to make sure the first change doesn't worsen the
rest of the resulting macroexpanded code.

        Stefan