GNU bug report logs - #53213
[PATCH] daemon: Always default to gzip for log compression.

Previous Next

Full log

Message #13 received at 53213-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 53213-done <at> debbugs.gnu.org
Subject: Re: bug#53213: [PATCH] daemon: Always default to gzip for log
 compression.
Date: Tue, 18 Jan 2022 18:53:05 +0100

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression'
>> default to COMPRESSION_GZIP unconditionally.
>> * gnu/services/base.scm (<guix-configuration>)[log-compression]: Default
>> to 'gzip.
>> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly.
>> ---
>>  doc/guix.texi           | 4 ++--
>>  gnu/services/base.scm   | 2 +-
>>  nix/libstore/globals.cc | 4 ----
>>  3 files changed, 3 insertions(+), 7 deletions(-)
>>
>> Hello!
>>
>> I think bzip2 compression of the build logs doesn’t buy us much, it
>> doesn’t play well with ‘guix publish’, and bzip2 is generally rather
>> uncommon these days—hence this patch.
>>
>> Thoughts?
>>
>> Ludo’.
>
> I haven't tried it, but the idea and code LGTM.

Pushed in 575e52ac2b090fd194086e9c1c53bbf8055acbc2, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.