From unknown Fri Sep 05 08:41:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53213 <53213@debbugs.gnu.org> To: bug#53213 <53213@debbugs.gnu.org> Subject: Status: [PATCH] daemon: Always default to gzip for log compression. Reply-To: bug#53213 <53213@debbugs.gnu.org> Date: Fri, 05 Sep 2025 15:41:18 +0000 retitle 53213 [PATCH] daemon: Always default to gzip for log compression. reassign 53213 guix-patches submitter 53213 Ludovic Court=C3=A8s severity 53213 normal tag 53213 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 12 12:21:40 2022 Received: (at submit) by debbugs.gnu.org; 12 Jan 2022 17:21:40 +0000 Received: from localhost ([127.0.0.1]:58874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7hJc-00082b-HS for submit@debbugs.gnu.org; Wed, 12 Jan 2022 12:21:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:35996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7hJX-00082N-IX for submit@debbugs.gnu.org; Wed, 12 Jan 2022 12:21:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7hJX-0004f1-Ap for guix-patches@gnu.org; Wed, 12 Jan 2022 12:21:35 -0500 Received: from [2001:470:142:3::e] (port=52122 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7hJS-0006oM-25; Wed, 12 Jan 2022 12:21:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=YY+vqVuBKnHv/aeJh08WFY6J4MSoyUS3px4dt16EEoo=; b=geZWfTtQj+FfvR Do+VR51ohKRMlgOtkiQ63U/PWmdkop5r7dlN+Bq5x24wMXma8UpKzK1y1b4oG4ANGhf/2nFpLai8O LTsBlZpyTqHEy8P43gPREPHWQASP+QuOGdXAxPNHikxkF98qGz5VV5fXYSfcKzCHOLsZ/imjvuLBe 0USKZ3aqbdtjlylX+UaLA1Rom18e+87dLQMn7m2HMUobinvV+yR2WE/Jg41rPqldtqxoKcSyj4U33 PAROPvhdm9O92f/J+R+2vadiSMQ0qKMHYs3edaGa9Kn8+xX/33NCTEiif7npP7J5OlslrTdcDKYOG iY5Kf/MqlLHgw9JDu4DA==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34738 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7hJQ-0005oK-0r; Wed, 12 Jan 2022 12:21:30 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] daemon: Always default to gzip for log compression. Date: Wed, 12 Jan 2022 18:21:18 +0100 Message-Id: <20220112172118.12250-1-ludo@gnu.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression' default to COMPRESSION_GZIP unconditionally. * gnu/services/base.scm ()[log-compression]: Default to 'gzip. * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly. --- doc/guix.texi | 4 ++-- gnu/services/base.scm | 2 +- nix/libstore/globals.cc | 4 ---- 3 files changed, 3 insertions(+), 7 deletions(-) Hello! I think bzip2 compression of the build logs doesn’t buy us much, it doesn’t play well with ‘guix publish’, and bzip2 is generally rather uncommon these days—hence this patch. Thoughts? Ludo’. diff --git a/doc/guix.texi b/doc/guix.texi index 876172fa3a..084d3c92fe 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -1690,7 +1690,7 @@ Compress build logs according to @var{type}, one of @code{gzip}, Unless @option{--lose-logs} is used, all the build logs are kept in the @var{localstatedir}. To save space, the daemon automatically compresses -them with Bzip2 by default. +them with gzip by default. @item --discover[=yes|no] Whether to discover substitute servers on the local network using mDNS @@ -16608,7 +16608,7 @@ The number of seconds of silence and the number of seconds of activity, respectively, after which a build process times out. A value of zero disables the timeout. -@item @code{log-compression} (default: @code{'bzip2}) +@item @code{log-compression} (default: @code{'gzip}) The type of compression used for build logs---one of @code{gzip}, @code{bzip2}, or @code{none}. diff --git a/gnu/services/base.scm b/gnu/services/base.scm index e46bb591a9..71e2baf959 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -1565,7 +1565,7 @@ (define-record-type* (timeout guix-configuration-timeout ;integer (default 0)) (log-compression guix-configuration-log-compression - (default 'bzip2)) + (default 'gzip)) (discover? guix-configuration-discover? (default #f)) (extra-options guix-configuration-extra-options ;list of strings diff --git a/nix/libstore/globals.cc b/nix/libstore/globals.cc index 0cc001fbe4..d4f9a46a74 100644 --- a/nix/libstore/globals.cc +++ b/nix/libstore/globals.cc @@ -45,11 +45,7 @@ Settings::Settings() useChroot = false; impersonateLinux26 = false; keepLog = true; -#if HAVE_BZLIB_H - logCompression = COMPRESSION_BZIP2; -#else logCompression = COMPRESSION_GZIP; -#endif maxLogSize = 0; cacheFailure = false; pollInterval = 5; base-commit: cd68fc1e42f3f233ba5ccfd1323e46509a970d6b -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 21:38:04 2022 Received: (at 53213) by debbugs.gnu.org; 14 Jan 2022 02:38:05 +0000 Received: from localhost ([127.0.0.1]:34972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8CTc-0000BW-NP for submit@debbugs.gnu.org; Thu, 13 Jan 2022 21:38:04 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:33758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8CTa-0000B1-7f for 53213@debbugs.gnu.org; Thu, 13 Jan 2022 21:38:02 -0500 Received: by mail-qt1-f181.google.com with SMTP id h15so5057610qtx.0 for <53213@debbugs.gnu.org>; Thu, 13 Jan 2022 18:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mSiBZwdBhGa8Mtp1x+GClslXCSvD3XB/naUr/+QFQkI=; b=X4EK0ryav1B15IPgyUkekSMzq7DIGPGF2lpzoqyNYroQ+P+amQChtHb3nDyIypoqUi D09Xs8Uv8QRvuqTnkm3hgratyShRtuz+5za15GqiEN4AnJFmaUWc80+MZE+vbAsH57AX 3sx7LNkbsX+5h68mXbmrpFnss7nPjuo3KOS6P2A6tWVelEBXXMuQEiEYlPZqX5fwW6UE inYl2bYgbYObs6hcuqpZPeX2Ho/4IE/w0uBK3dnb5KFvY4ss/XXYGeNzaALOQiPf1DOK kvaV9FaqSfEeXJHUm+wYRqpRYAlSCPhKQTNiQBeY3sHc+Ov4gwXlvWZe5DtfNNXNdDuB bljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=mSiBZwdBhGa8Mtp1x+GClslXCSvD3XB/naUr/+QFQkI=; b=wXsnKClGCVXQO/JeNBjfkYkCYF+IWbC0h0DR79BE0tfR6Jyq9GUZ7hUYp9V/VUusyJ 3/MAnub4SlHGtopsEwFC9vZhb96/xm7WF4Owy8vNwEu7yfSAMILm0Sc7v9Z4nZJ++oFX iP0W/01TSBcU7kJHxS36W9+i2ttKbnxqAjzdHWdM0COezluC+fKtCp+vCvOUHsQnVLBj 5/1Cj9d19FHh5DBlhSH35GPKP5N1DcS8qf+H8OciSswDkvv/U7pnhnl44smDMPN52TVk 47MtGYoYCk+YO4RrQ0449cs6XvO6nUfYmRQAiEET6wr5mgQ7239hB+06bvNI1cJH1vSQ JoRg== X-Gm-Message-State: AOAM530Ik95pAHqq5GSRc4gZe1wvdcO/Pkb3XxbbirsoYoo98ay1KIGw MOn6Ef0eeAQb1zsjeCgUWXpUKXTO3Lgqkw== X-Google-Smtp-Source: ABdhPJzK+AUbA0lYtbuiPLbPRM7FaPVYyBNzgJd+nSEpFSXOYlwd2a0mPB1Lexjl5tUgVx7zmUWqQA== X-Received: by 2002:ac8:5bd1:: with SMTP id b17mr6070909qtb.171.1642127876565; Thu, 13 Jan 2022 18:37:56 -0800 (PST) Received: from hurd (dsl-152-155.b2b2c.ca. [66.158.152.155]) by smtp.gmail.com with ESMTPSA id s9sm2956177qki.99.2022.01.13.18.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 18:37:56 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#53213: [PATCH] daemon: Always default to gzip for log compression. References: <20220112172118.12250-1-ludo@gnu.org> Date: Thu, 13 Jan 2022 21:37:55 -0500 In-Reply-To: <20220112172118.12250-1-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Wed, 12 Jan 2022 18:21:18 +0100") Message-ID: <87ilunxcsc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53213 Cc: 53213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, Ludovic Court=C3=A8s writes: > * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression' > default to COMPRESSION_GZIP unconditionally. > * gnu/services/base.scm ()[log-compression]: Default > to 'gzip. > * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly. > --- > doc/guix.texi | 4 ++-- > gnu/services/base.scm | 2 +- > nix/libstore/globals.cc | 4 ---- > 3 files changed, 3 insertions(+), 7 deletions(-) > > Hello! > > I think bzip2 compression of the build logs doesn=E2=80=99t buy us much, = it > doesn=E2=80=99t play well with =E2=80=98guix publish=E2=80=99, and bzip2 = is generally rather > uncommon these days=E2=80=94hence this patch. > > Thoughts? > > Ludo=E2=80=99. I haven't tried it, but the idea and code LGTM. Thanks! Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 18 12:53:14 2022 Received: (at 53213-done) by debbugs.gnu.org; 18 Jan 2022 17:53:14 +0000 Received: from localhost ([127.0.0.1]:51597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9sfR-0008Tv-Uf for submit@debbugs.gnu.org; Tue, 18 Jan 2022 12:53:14 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:57394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9sfQ-0008Ti-8z for 53213-done@debbugs.gnu.org; Tue, 18 Jan 2022 12:53:12 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id BD0AE838; Tue, 18 Jan 2022 18:53:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oSWfyLYFci9W; Tue, 18 Jan 2022 18:53:06 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id A2100780; Tue, 18 Jan 2022 18:53:05 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#53213: [PATCH] daemon: Always default to gzip for log compression. References: <20220112172118.12250-1-ludo@gnu.org> <87ilunxcsc.fsf@gmail.com> Date: Tue, 18 Jan 2022 18:53:05 +0100 In-Reply-To: <87ilunxcsc.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 13 Jan 2022 21:37:55 -0500") Message-ID: <87y23dc4n2.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: BD0AE838 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 53213-done Cc: 53213-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression' >> default to COMPRESSION_GZIP unconditionally. >> * gnu/services/base.scm ()[log-compression]: Default >> to 'gzip. >> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingl= y. >> --- >> doc/guix.texi | 4 ++-- >> gnu/services/base.scm | 2 +- >> nix/libstore/globals.cc | 4 ---- >> 3 files changed, 3 insertions(+), 7 deletions(-) >> >> Hello! >> >> I think bzip2 compression of the build logs doesn=E2=80=99t buy us much,= it >> doesn=E2=80=99t play well with =E2=80=98guix publish=E2=80=99, and bzip2= is generally rather >> uncommon these days=E2=80=94hence this patch. >> >> Thoughts? >> >> Ludo=E2=80=99. > > I haven't tried it, but the idea and code LGTM. Pushed in 575e52ac2b090fd194086e9c1c53bbf8055acbc2, thanks! Ludo=E2=80=99. From unknown Fri Sep 05 08:41:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Feb 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator