Subject: Re: bug#53213: [PATCH] daemon: Always default to gzip for log compression.

From: Maxim Cournoyer <[email-masked]>
Date: Thu, 13 Jan 2022 21:37:55 -0500

Hi Ludo,

Ludovic Courtès <[email-masked]> writes:

> * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression'
> default to COMPRESSION_GZIP unconditionally.
> * gnu/services/base.scm (<guix-configuration>)[log-compression]: Default
> to 'gzip.
> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly.
> ---
>  doc/guix.texi           | 4 ++--
>  gnu/services/base.scm   | 2 +-
>  nix/libstore/globals.cc | 4 ----
>  3 files changed, 3 insertions(+), 7 deletions(-)
>
> Hello!
>
> I think bzip2 compression of the build logs doesn’t buy us much, it
> doesn’t play well with ‘guix publish’, and bzip2 is generally rather
> uncommon these days—hence this patch.
>
> Thoughts?
>
> Ludo’.

I haven't tried it, but the idea and code LGTM.

Thanks!

Maxim