From unknown Mon Jun 23 07:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53178: ert should use existing explainers for aliases Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jan 2022 05:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 53178@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164187827017813 (code B ref -1); Tue, 11 Jan 2022 05:18:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jan 2022 05:17:50 +0000 Received: from localhost ([127.0.0.1]:53870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n79Xa-0004dF-K8 for submit@debbugs.gnu.org; Tue, 11 Jan 2022 00:17:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:34312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n79XW-0004d5-Hu for submit@debbugs.gnu.org; Tue, 11 Jan 2022 00:17:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n79XW-0006eR-EI for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 00:17:46 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:37720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n79XV-0000ZO-13 for bug-gnu-emacs@gnu.org; Tue, 11 Jan 2022 00:17:46 -0500 Received: by mail-pl1-f178.google.com with SMTP id q14so15438128plx.4 for ; Mon, 10 Jan 2022 21:17:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=nu/cRqQR5nKOntmQ7HJZ+JhW2z8tewinz+3VuP6HTCg=; b=nr62es0BCPT1gNEbgeZEarfWLP8X2LR4ZI9HRFlSH6uELmrtWHKPef+VEADutA7TTL q+kaeMunKaH5ShSMuwRHPcGmGk4eYpfbOvKCUX0xgf5HhFGQqARnSGfrxOsIuuFUP5Fq RBdgvYoImuEqTRaUbzNYSERwX3qcxHcjozY9xzv5+pUOv+qol7dT6YodEfXMNq+eYg7s bsDu3bL3KC78TEHlqIUcH1AQ+BV2SMB4ldQbjcVVrHHB5QPyfjSDvF4DZZ9hfH01MHFV IQGHr6mOvFjYu/tyfJHddAY5SIyc8S/Vm9Xvf8D/nwfuOzy00SmnfJzz3+zUWeAKhHfe IIdQ== X-Gm-Message-State: AOAM531N9IQhiKOMnlf1Dv4X1D/uGmfVgTmhvlIFsOnpzhFYPCm2Opgn 1iriCufovXi5SPtQxZi8U2epGIyGQ/WtwM7KYXglw3Euiyc= X-Google-Smtp-Source: ABdhPJyXAHWkHnTWc14cLaDSv2cG9zEpbYdS4JhNq+zsVcsi6kFLjPsQUNCky1Yplci9SpGnAeCg0rC2m9ukrtNtYKU= X-Received: by 2002:a17:903:41c4:b0:14a:4baa:4261 with SMTP id u4-20020a17090341c400b0014a4baa4261mr2769855ple.174.1641878261306; Mon, 10 Jan 2022 21:17:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 10 Jan 2022 23:17:40 -0600 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 10 Jan 2022 23:17:40 -0600 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.214.178; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f178.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Severity: minor There exists an ert explainer for `string-equal', but it is not used if `string=' (an alias for `string-equal') is used in the test. This should be fixed such that an existing explainer is always used for an alias. From unknown Mon Jun 23 07:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53178: ert should use existing explainers for aliases Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 53178@debbugs.gnu.org Received: via spool by 53178-submit@debbugs.gnu.org id=B53178.164206375425177 (code B ref 53178); Thu, 13 Jan 2022 08:50:02 +0000 Received: (at 53178) by debbugs.gnu.org; 13 Jan 2022 08:49:14 +0000 Received: from localhost ([127.0.0.1]:60089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7vnG-0006Y0-HL for submit@debbugs.gnu.org; Thu, 13 Jan 2022 03:49:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:51746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7vnC-0006Xd-Lv for 53178@debbugs.gnu.org; Thu, 13 Jan 2022 03:49:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SBNMmYgVvvE6xbxb+ZGZrUoTfYo88JUvsDDBrtFu/TM=; b=m6kjfxOoyB0tF24OLjglqvzuaU yewjxTqyry8qReUAT2hvH4p8/0aZv9FSWxUIkPv/5mSsgnRf8/gPCabNqPp74Igkhsl0NhBpkjlJA vzbgGDAqv7OiWgmw0ieryTtEJL4yGM0jcUAhaNmwchDxCQGWPVLOQfGJwwp1Otdb7BxI=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7vn3-0000bf-8X; Thu, 13 Jan 2022 09:49:04 +0100 From: Lars Ingebrigtsen References: X-Now-Playing: Alan Vega's _Alan Vega_: "Bye Bye Bayou" Date: Thu, 13 Jan 2022 09:48:56 +0100 In-Reply-To: (Stefan Kangas's message of "Mon, 10 Jan 2022 23:17:40 -0600") Message-ID: <87tue86mx3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > There exists an ert explainer for `string-equal', but it is not used if > `string=' (an alias for `string-equal') is used in the test. > > This should be fixed such that an existing explainer is alw [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > There exists an ert explainer for `string-equal', but it is not used if > `string=' (an alias for `string-equal') is used in the test. > > This should be fixed such that an existing explainer is always used for > an alias. I started implementing this, but then I ran into the problem of possible defalias loops. I thought we had a function somewhere that would just return the defalias chain, but I can't find it anywhere. And indeed: (defalias 'a 'b) (defalias 'b 'a) And then `C-h f a RET' will infloop because (defun help-fns--analyze-function (function) [...] ((and aliased (not (subrp def))) (let ((f real-function)) (while (and (fboundp f) (symbolp (symbol-function f))) (setq f (symbol-function f))) f)) So I've now added a new function for this, fixed the infloop in help-fns, and fixed the explainer lookup in ert. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 03:49:25 2022 Received: (at control) by debbugs.gnu.org; 13 Jan 2022 08:49:25 +0000 Received: from localhost ([127.0.0.1]:60092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7vnQ-0006YT-QH for submit@debbugs.gnu.org; Thu, 13 Jan 2022 03:49:25 -0500 Received: from quimby.gnus.org ([95.216.78.240]:51760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7vnJ-0006Xq-Hc for control@debbugs.gnu.org; Thu, 13 Jan 2022 03:49:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4+LR3OHBRW2h3fYhmkCZk76tKCu9rw46tmUZew7DA+o=; b=jhvifMgHz5ALxH48QS2lFbG4T8 z5R9Km3rrDU29Pp9QzIqtwmQorDhRP/mrkzTsNH4TXb7pHJ7R6lWUKkcxw+Jefj1sh8kww2wTArV3 iIfihs0KuhOrdU5m7qAVPDwzT9zlgsdIKmFmeBuLLgJoBB1ZtzqDcHf8GFhRK3oHmi+k=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7vnB-0000bv-I9 for control@debbugs.gnu.org; Thu, 13 Jan 2022 09:49:11 +0100 Date: Thu, 13 Jan 2022 09:49:07 +0100 Message-Id: <87sfts6mws.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #53178 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 53178 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 53178 29.1 quit