GNU bug report logs - #53169
[PATCH 1/8] gnu: Add rust-svgtypes-0.5.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: phodina via Guix-patches via <guix-patches <at> gnu.org>
Cc: phodina <phodina <at> protonmail.com>, 53169-done <at> debbugs.gnu.org
Subject: Re: [bug#53169] [PATCH 1/8] gnu: Add rust-svgtypes-0.5.
Date: Fri, 21 Jan 2022 01:21:35 +0100

Hello,

phodina via Guix-patches via <guix-patches <at> gnu.org> writes:

> this patch set updates and adds additional Lyon crates.

Thank you.

Note that some of your commit messages were misleading. E.g., when you
write "gnu: rust-euclid-0.22: Update to 0.22.6.", you actually create
a new variable `rust-euclid-0.22' and remove `rust-euclid-0.20'. As
a consequence it broke old revisions of `plotters' and `font-kit'
crates, which I had to remove.

Also, indentation from imported packages is a bit off. You may want to
re-indent packages.

In any case, all applied!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.