GNU bug report logs - #53169
[PATCH 1/8] gnu: Add rust-svgtypes-0.5.

Previous Next

Full log

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: phodina via Guix-patches via <guix-patches <at> gnu.org>,
 53169-done <at> debbugs.gnu.org
Subject: Re: [bug#53169] [PATCH 1/8] gnu: Add rust-svgtypes-0.5.
Date: Fri, 21 Jan 2022 05:08:21 +0000

Hi Nicolas,

> Note that some of your commit messages were misleading. E.g., when you
>
> write "gnu: rust-euclid-0.22: Update to 0.22.6.", you actually create
>
> a new variable `rust-euclid-0.22' and remove` rust-euclid-0.20'. As
>
> a consequence it broke old revisions of `plotters' and` font-kit'
>
> crates, which I had to remove.
>
> Also, indentation from imported packages is a bit off. You may want to
>
> re-indent packages.
>
> In any case, all applied!

Thanks for the note. You're right that in case "gnu: rust-euclid-0.22" it's new variable as there are dependencies on the old one.

I'll keep that in mind next time :-)


----
Petr

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.