GNU bug report logs - #53126
29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc.

Previous Next

Full log

Message #91 received at 53126 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: 53126 <at> debbugs.gnu.org
Subject: Re: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading
 query-replace string, etc.
Date: Sun, 20 Mar 2022 21:24:43 +0200

>> OTOH, your changes that add lazy-count-update-hook and remove
>> '(null isearch-message-function)' can be already pushed.
>> Could you please send a separate patch for pushing with these changes only?
>>
>> Then the patch with minibuffer-lazy-count feature will be shorter.
>
> There it is:
>
> From 3de37cfec647cedd69032df072a1176970224ecb Mon Sep 17 00:00:00 2001
> From: Augusto Stoffel <arstoffel <at> gmail.com>
> Date: Thu, 17 Mar 2022 20:02:13 +0100
> Subject: [PATCH] Allow lazy highlight and match count while reading from
>  minibuffer

Could you please split it to more logically separate patches?

1. a patch that removes checks for 'isearch-mode (null isearch-message-function)'
   and adds '(setq-local isearch-lazy-count nil)'.
   It could also contain more changes in comint.el etc
   from your earlier patch from 14 May 2021.

2. a patch that adds and runs 'lazy-count-update-hook'.

3. a patch with minibuffer-lazy-highlight feature in isearch.el.

Then what will remain to do is to decide how it would be better to activate
the minibuffer-lazy-highlight feature.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.