GNU bug report logs - #53126
29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc.

Previous Next

Full log

Message #160 received at 53126 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Augusto Stoffel <arstoffel <at> gmail.com>
Cc: 53126 <at> debbugs.gnu.org
Subject: Re: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading
 query-replace string, etc.
Date: Tue, 05 Apr 2022 20:12:16 +0300

> But that's a good point, we don't need a macro.  Among several
> variations, we could make the setup code look like this:
>
>      (minibuffer-with-setup-hook
>            (minibuffer-lazy-highlight-init :case-fold case-fold-search
>                                            :regexp regexp-flag
>                                            ...)
>        (query-replace-read-from prompt regexp-flag))
>
> where now `minibuffer-lazy-highlight-init' is not the function that
> initializes stuff, but rather a function that returns a closure that
> initializes stuff.

Looks good.

>> Please also note that condition-case can be replaced by
>> a hook in minibuffer-exit-hook that can remove highlighting
>> after exiting the minibuffer.
>
> If it was a `unwind-protect', I would agree.  But I don't know how to
> simulate a `condition-case'.  Specifically, how can we determine if some
> hook (the minibuffer-exit-hook in this case) is being run "normally" or
> as part of the recovery from a signaled error?

Shouldn't both cases clean up highlight from the buffer?
Then I see no need to distinguish each case.  Or if really needed,
you can try to bind the cleanup to command-error-function.

>> Alternatively, the same lambda above could be added to
>>
>>   (add-hook 'minibuffer-setup-hook (lambda () ...))
>
> Why was it again that we want to avoid saying something like this?
>
>     (let ((case-fold-search whatever)
>           (isearch-regexp regexp-flag))
>        (minibuffer-with-setup-hook #'minibuffer-lazy-highlight-init
>          (query-replace-read-from prompt regexp-flag)))

4 lines look nice, unlike 20 lines in one of your patches ;-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.