GNU bug report logs - #53075
[PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53092: closed ([PATCH 17/41] gnu: rust-rbw: adding rust-base64ct)
Date: Wed, 19 Jan 2022 13:30:09 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 19 Jan 2022 14:29:32 +0100
with message-id <87zgnretvn.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
has caused the debbugs.gnu.org bug report #53075,
regarding [PATCH 17/41] gnu: rust-rbw: adding rust-base64ct
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53075: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53075
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH 17/41] gnu: rust-rbw: adding rust-base64ct
Date: Fri, 07 Jan 2022 15:11:39 +0100

[0018-rust-rbw-dependencies-adding-rust-base64ct.patch (text/x-patch, inline)]

From 53384ac30f14891cdc1b1d7557e03394097c43ab Mon Sep 17 00:00:00 2001
From: Nicolas Graves <ngraves <at> ngraves.fr>
Date: Fri, 7 Jan 2022 11:43:10 +0100
Subject: [PATCH 18/42] rust-rbw dependencies : adding rust-base64ct

---
 gnu/packages/crates-io.scm | 34 +++++++++++++++++++++++++++++-----
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index e66f8e5f2c..a4860cc3c6 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -4937,18 +4937,42 @@ (define-public rust-base64-0.6
        (("rust-byteorder" ,rust-byteorder-1)
         ("rust-safemem" ,rust-safemem-0.2))))))
 
-(define-public rust-base-x-0.2
+(define-public rust-base64ct-1
   (package
-    (name "rust-base-x")
-    (version "0.2.6")
+    (name "rust-base64ct")
+    (version "1.1.1")
     (source
       (origin
         (method url-fetch)
-        (uri (crate-uri "base-x" version))
+        (uri (crate-uri "base64ct" version))
         (file-name (string-append name "-" version ".tar.gz"))
         (sha256
          (base32
-          "1hfy0wv7j5ynd73yk1vyr32pqa77rp15lkrc54f8ky9c6hcbc80v"))))
+          "0p4was874qc90q2chm2i14m9mn8zmxjis8vaxihd6a2x4aqxkd76"))))
+    (build-system cargo-build-system)
+    (arguments `(#:skip-build? #t))
+    (home-page "https://github.com/RustCrypto/formats/tree/master/base64ct")
+    (synopsis
+      "Implementation of Base64 (RFC 4648) avoiding any usages of
+data-dependent branches/LUTs")
+    (description
+      "Pure Rust implementation of Base64 (RFC 4648) which avoids any usages of
+data-dependent branches/LUTs and thereby provides portable \"best effort\"
+constant-time operation and embedded-friendly no_std support")
+    (license (list license:asl2.0 license:expat))))
+
+(define-public rust-base-x-0.2
+  (package
+    (name "rust-base-x")
+    (version "0.2.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "base-x" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1hfy0wv7j5ynd73yk1vyr32pqa77rp15lkrc54f8ky9c6hcbc80v"))))
     (build-system cargo-build-system)
     (arguments
      `(#:skip-build? #t
-- 
2.34.0

[Message part 4 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, 53075-done <at> debbugs.gnu.org
Subject: Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
Date: Wed, 19 Jan 2022 14:29:32 +0100

Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> From 117ac2e745d1e9e2122bdf5859ae2b2781ca01c4 Mon Sep 17 00:00:00 2001
> From: Nicolas Graves <ngraves <at> ngraves.fr>
> Date: Thu, 6 Jan 2022 23:16:42 +0100
> Subject: [PATCH 02/42] rust-rbw dependencies : adding rust-zeroize-1.4

Thank you. First some general notes about your patches.

The first thing is that your patch set should have gone under the same
bug number. You created more than 40 bugs for rbw. You may want to look
at "Contributing" section of the Guix manual for details.

Also, commit messages are normalized in Guix. You should look at what
I wrote instead of yours to get a feel about it.

Eventually, descriptions should consist of full sentences.

Now about this patch.

Unless under exceptional circumstances, we don't add a new package for
a change below the first non-zero digit. In this case, the common way is
to simply update rust-zeroize-1 to 1.4.3.

Therefore, I dropped this patch and did the above.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.