GNU bug report logs - #53075
[PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53083: closed ([PATCH 9/41] gnu: rust-rbw: adding rust-der)
Date: Wed, 19 Jan 2022 13:30:05 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 19 Jan 2022 14:29:32 +0100
with message-id <87zgnretvn.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
has caused the debbugs.gnu.org bug report #53075,
regarding [PATCH 9/41] gnu: rust-rbw: adding rust-der
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53075: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53075
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH 9/41] gnu: rust-rbw: adding rust-der
Date: Fri, 07 Jan 2022 15:01:02 +0100

[0010-rust-rbw-dependencies-adding-rust-der.patch (text/x-patch, inline)]

From e55403639e4c0e4f992c64ba4e3fb4cd275677e5 Mon Sep 17 00:00:00 2001
From: Nicolas Graves <ngraves <at> ngraves.fr>
Date: Fri, 7 Jan 2022 02:27:03 +0100
Subject: [PATCH 10/42] rust-rbw dependencies : adding rust-der

---
 gnu/packages/crates-io.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index ee4c29c470..e2cda73aba 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -14725,6 +14725,35 @@ (define-public rust-demo-hack-impl-0.0
     (description "Demo of proc-macro-hack.")
     (license (list license:expat license:asl2.0))))
 
+(define-public rust-der-0.4
+  (package
+    (name "rust-der")
+    (version "0.4.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (crate-uri "der" version))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32 "1x4k0jln8va1657cghl40l6p7hyvr1ixz71v9cd6imwmgp51rdvr"))))
+    (build-system cargo-build-system)
+    (arguments
+     `(#:skip-build?
+       #t                               ; FIXME
+       #:cargo-inputs
+       (("rust-const-oid" ,rust-const-oid-0.6)
+        ("rust-crypto-bigint" ,rust-crypto-bigint-0.2)
+        ("rust-der-derive" ,rust-der-derive-0.4))))
+    (home-page "https://github.com/RustCrypto/formats/tree/master/der")
+    (synopsis
+     "Implementation of the Distinguished Encoding Rules (DER)")
+    (description
+     "This package provides a pure Rust embedded-friendly implementation of
+the Distinguished Encoding Rules (DER) for Abstract Syntax Notation One
+(ASN.1) as described in ITU X.690 with full support for heapless no_std
+targets")
+    (license (list license:asl2.0 license:expat))))
+
 (define-public rust-der-derive-0.4
   (package
     (name "rust-der-derive")
-- 
2.34.0

[Message part 4 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, 53075-done <at> debbugs.gnu.org
Subject: Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
Date: Wed, 19 Jan 2022 14:29:32 +0100

Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> From 117ac2e745d1e9e2122bdf5859ae2b2781ca01c4 Mon Sep 17 00:00:00 2001
> From: Nicolas Graves <ngraves <at> ngraves.fr>
> Date: Thu, 6 Jan 2022 23:16:42 +0100
> Subject: [PATCH 02/42] rust-rbw dependencies : adding rust-zeroize-1.4

Thank you. First some general notes about your patches.

The first thing is that your patch set should have gone under the same
bug number. You created more than 40 bugs for rbw. You may want to look
at "Contributing" section of the Guix manual for details.

Also, commit messages are normalized in Guix. You should look at what
I wrote instead of yours to get a feel about it.

Eventually, descriptions should consist of full sentences.

Now about this patch.

Unless under exceptional circumstances, we don't add a new package for
a change below the first non-zero digit. In this case, the common way is
to simply update rust-zeroize-1 to 1.4.3.

Therefore, I dropped this patch and did the above.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.