GNU bug report logs - #53075
[PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53079: closed ([PATCH 5/41] gnu: rust-rbw: adding rust-rlp)
Date: Wed, 19 Jan 2022 13:30:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 19 Jan 2022 14:29:32 +0100
with message-id <87zgnretvn.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
has caused the debbugs.gnu.org bug report #53075,
regarding [PATCH 5/41] gnu: rust-rbw: adding rust-rlp
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53075: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53075
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH 5/41] gnu: rust-rbw: adding rust-rlp
Date: Fri, 07 Jan 2022 14:56:52 +0100

[0006-rust-rbw-dependencies-adding-rust-rlp.patch (text/x-patch, inline)]

From b50871c840173bf8304c252f4b3ae798525a072c Mon Sep 17 00:00:00 2001
From: Nicolas Graves <ngraves <at> ngraves.fr>
Date: Fri, 7 Jan 2022 00:13:30 +0100
Subject: [PATCH 06/42] rust-rbw dependencies : adding rust-rlp

---
 gnu/packages/crates-io.scm | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 3621243c1c..61822ae431 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -44015,6 +44015,28 @@ (define-public rust-rls-span-0.5
 Rust Language Server.")
     (license (list license:expat license:asl2.0))))
 
+(define-public rust-rlp-0.5
+  (package
+    (name "rust-rlp")
+    (version "0.5.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "rlp" version))
+        (file-name (string-append name "-" version ".tar.gz"))
+        (sha256
+          (base32 "1da7b1hc4czlmsyr7ifs9bz9fv8hi5dw8q14xnmjlydfn2mhi5cr"))))
+    (build-system cargo-build-system)
+    (arguments
+      `(#:skip-build?
+        #t
+        #:cargo-inputs
+        (("rust-bytes" ,rust-bytes-1) ("rust-rustc-hex" ,rust-rustc-hex-2))))
+    (home-page "https://github.com/paritytech/parity-common")
+    (synopsis "Recursive-length prefix encoding, decoding, and compression")
+    (description "Recursive-length prefix encoding, decoding, and compression")
+    (license (list license:expat license:asl2.0))))
+
 (define-public rust-rkv-0.10
   (package
     (name "rust-rkv")
@@ -45751,9 +45773,9 @@ (define-public rust-rustc-hex-2
     (build-system cargo-build-system)
     (arguments `(#:skip-build? #t))
     (home-page "https://github.com/debris/rustc-hex")
-    (synopsis "rustc-serialize compatible hex conversion traits")
+    (synopsis "Rustc-serialize compatible hex conversion traits")
     (description "This package provides rustc-serialize compatible hex
-conversion traits")
+conversion traits.")
     (license (list license:expat license:asl2.0))))
 
 (define-public rust-rustc-rayon-0.3
-- 
2.34.0

[Message part 4 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, 53075-done <at> debbugs.gnu.org
Subject: Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
Date: Wed, 19 Jan 2022 14:29:32 +0100

Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> From 117ac2e745d1e9e2122bdf5859ae2b2781ca01c4 Mon Sep 17 00:00:00 2001
> From: Nicolas Graves <ngraves <at> ngraves.fr>
> Date: Thu, 6 Jan 2022 23:16:42 +0100
> Subject: [PATCH 02/42] rust-rbw dependencies : adding rust-zeroize-1.4

Thank you. First some general notes about your patches.

The first thing is that your patch set should have gone under the same
bug number. You created more than 40 bugs for rbw. You may want to look
at "Contributing" section of the Guix manual for details.

Also, commit messages are normalized in Guix. You should look at what
I wrote instead of yours to get a feel about it.

Eventually, descriptions should consist of full sentences.

Now about this patch.

Unless under exceptional circumstances, we don't add a new package for
a change below the first non-zero digit. In this case, the common way is
to simply update rust-zeroize-1 to 1.4.3.

Therefore, I dropped this patch and did the above.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.