GNU bug report logs - #53075
[PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53103: closed ([PATCH 28/41] gnu: rust-rbw: adding rust-des-0.7)
Date: Wed, 19 Jan 2022 13:30:12 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 19 Jan 2022 14:29:32 +0100
with message-id <87zgnretvn.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
has caused the debbugs.gnu.org bug report #53075,
regarding [PATCH 28/41] gnu: rust-rbw: adding rust-des-0.7
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53075: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53075
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH 28/41] gnu: rust-rbw: adding rust-des-0.7
Date: Fri, 07 Jan 2022 15:20:51 +0100

[0029-rust-rbw-dependencies-adding-rust-des-0.7.patch (text/x-patch, inline)]

From 21379bc77d0aeb5451deb9da81211f41d8aacb0c Mon Sep 17 00:00:00 2001
From: Nicolas Graves <ngraves <at> ngraves.fr>
Date: Fri, 7 Jan 2022 13:04:30 +0100
Subject: [PATCH 29/42] rust-rbw dependencies : adding rust-des-0.7

---
 gnu/packages/crates-io.scm | 36 +++++++++++++++++++++++++++++-------
 1 file changed, 29 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 9d113c8fb0..480d54a9a0 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -15248,8 +15248,36 @@ (define-public rust-derive-new-0.5
 structs and enums.")
   (license license:expat)))
 
+(define-public rust-des-0.7
+  (package
+    (name "rust-des")
+    (version "0.7.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "des" version))
+        (file-name
+         (string-append name "-" version ".tar.gz"))
+        (sha256
+         (base32
+          "0pbsfkkwfqnd4nsv3ik4z09h248f57y7bj2j1l134i2mzd4xshdc"))))
+    (build-system cargo-build-system)
+    (arguments
+      `(#:skip-build?
+        #t
+        #:cargo-inputs
+        (("rust-byteorder" ,rust-byteorder-1)
+         ("rust-cipher" ,rust-cipher-0.3)
+         ("rust-opaque-debug" ,rust-opaque-debug-0.3))))
+    (home-page "https://github.com/RustCrypto/block-ciphers")
+    (synopsis "DES and Triple DES block ciphers implementation")
+    (description "This package provides DES and Triple DES (3DES, TDES) block
+ciphers implementations.")
+    (license (list license:expat license:asl2.0))))
+
 (define-public rust-des-0.6
   (package
+    (inherit rust-des-0.7)
     (name "rust-des")
     (version "0.6.0")
     (source
@@ -15260,19 +15288,13 @@ (define-public rust-des-0.6
         (string-append name "-" version ".tar.gz"))
        (sha256
         (base32 "1bigk1x1kxvnfjn1alr8cc383z1flmj8q7g2pjl2zal8i1s7qkmj"))))
-    (build-system cargo-build-system)
     (arguments
      `(#:cargo-inputs
        (("rust-byteorder" ,rust-byteorder-1)
         ("rust-cipher" ,rust-cipher-0.2)
         ("rust-opaque-debug" ,rust-opaque-debug-0.3))
        #:cargo-development-inputs
-       (("rust-cipher" ,rust-cipher-0.2))))
-    (home-page "https://github.com/RustCrypto/block-ciphers")
-    (synopsis "DES and Triple DES block ciphers implementation")
-    (description "This package provides DES and Triple DES (3DES, TDES) block
-ciphers implementations.")
-    (license (list license:expat license:asl2.0))))
+       (("rust-cipher" ,rust-cipher-0.2))))))
 
 (define-public rust-deunicode-0.4
   (package
-- 
2.34.0

[Message part 4 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, 53075-done <at> debbugs.gnu.org
Subject: Re: [bug#53075] [PATCH 1/41] gnu: rust-rbw: adding rust-zeroize-1.4
Date: Wed, 19 Jan 2022 14:29:32 +0100

Hello,

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> From 117ac2e745d1e9e2122bdf5859ae2b2781ca01c4 Mon Sep 17 00:00:00 2001
> From: Nicolas Graves <ngraves <at> ngraves.fr>
> Date: Thu, 6 Jan 2022 23:16:42 +0100
> Subject: [PATCH 02/42] rust-rbw dependencies : adding rust-zeroize-1.4

Thank you. First some general notes about your patches.

The first thing is that your patch set should have gone under the same
bug number. You created more than 40 bugs for rbw. You may want to look
at "Contributing" section of the Guix manual for details.

Also, commit messages are normalized in Guix. You should look at what
I wrote instead of yours to get a feel about it.

Eventually, descriptions should consist of full sentences.

Now about this patch.

Unless under exceptional circumstances, we don't add a new package for
a change below the first non-zero digit. In this case, the common way is
to simply update rust-zeroize-1 to 1.4.3.

Therefore, I dropped this patch and did the above.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.