GNU bug report logs - #53071
28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms?

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Fri, 7 Jan 2022 09:37:02 UTC

Severity: normal

Found in version 28.0.90

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: p.stephani2 <at> gmail.com, pogonyshev <at> gmail.com, 53071 <at> debbugs.gnu.org
Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms?
Date: Wed, 12 Jan 2022 21:33:38 +0200
> From: Mattias Engdegård <mattiase <at> acm.org>
> Date: Wed, 12 Jan 2022 20:09:26 +0100
> Cc: 53071 <at> debbugs.gnu.org, Philipp <p.stephani2 <at> gmail.com>,
>         Paul Pogonyshev <pogonyshev <at> gmail.com>
> 
> 12 jan. 2022 kl. 17.58 skrev Eli Zaretskii <eliz <at> gnu.org>:
> 
> > So I'm about to revert this backport, but I'm prepared to hear
> > arguments why shouldn't I.
> 
> I broke protocol by pushing it to the stable branch in this phase without permission. Sorry about that; the change has now been reverted. Will be more careful in the future.
> 
> > From my POV, the regression is very minor, and it doesn't justify such
> > a non-trivial change in such a central place.
> 
> I personally don't care much about it since I don't use Emacs 28 but would certainly not prefer at least two known, documented and harmful bugs reported by our users over some vague hypothetical conjectured problem that might arise.
> 
> >  If you think the
> > problem is serious, I'd rather revert the change we did which produced
> > the regression in the first place (assuming it's not too complicated).
> 
> That would be inadvisable as it would introduce yet another bug, the fix of which was the immediate cause of the regression.

Fine by me, then let's leave emacs-28 at its present state.

Thanks.




This bug report was last modified 3 years and 131 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.