From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jan 2022 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 53071@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164154817515934 (code B ref -1); Fri, 07 Jan 2022 09:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2022 09:36:15 +0000 Received: from localhost ([127.0.0.1]:43077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5lfS-00048w-Gn for submit@debbugs.gnu.org; Fri, 07 Jan 2022 04:36:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:60684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5lfP-00048k-Aw for submit@debbugs.gnu.org; Fri, 07 Jan 2022 04:36:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5lfP-0002QG-29 for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:11 -0500 Received: from [2a00:1450:4864:20::42a] (port=40528 helo=mail-wr1-x42a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5lfN-0000k6-99 for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:10 -0500 Received: by mail-wr1-x42a.google.com with SMTP id l10so9927429wrh.7 for ; Fri, 07 Jan 2022 01:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YpVhiKIE/Em5BF5F+W3Qpa2rVpQSz2cJlTgV9jpv6OE=; b=IwsPtrF0pWfKiuAAtMQjgSx0FLQqDMhBzQ3gtH+9fFC67+1j9coq0TanMwcfClYMla YAjmZmTG94McOj4oxQhWBjxv9V9yNZ1DVHKW/XZlXrJk/qX0VNI5XUZBWDL/H8Z4e4SX BfVgrVg/QCS+O/dp1oz4JwVvakvl16He4hWA6iNvprjbUxsm++BCs6BmY+gbSBOrzpG3 Xrp44XSNDnjc0eWNVA1dDGMrhoS+QZDI9Sd5NaYlCsfYCZdlwtML8y5KEZRWrnOZYwmI 0akzzKf1ZtGAhM+93y5Ko9U7A4tFmMKuzVzpWag+HaRQ2oCvUcfQs3kloX3CMSP+/Vfv o/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YpVhiKIE/Em5BF5F+W3Qpa2rVpQSz2cJlTgV9jpv6OE=; b=J+tY756m0ntowPFItu/z4xWqbXAU8/CDMxmDOx2Wrk2TNUgd0GfaTHFMa5/A8/ubz1 wxfpM0KKzDMgmniffwmJ+ZAOtvK0jGqrGyaNaCl0t72/ANfg8Zfu7pnvPiFtOU1ptRJg TPS13FybOySq/13EBhIL+VwxxQ5xDhge32XuHozCNtPz3kyJXnsG/b/rnPx6UCGW9cli iYL5XpQ+/8jGe4vjAUO3o4NCl5OR8xxtPakbKlXlmJJyGbvtdAyuy6s0382lMqctIxKi LsQywHd402EdPYjPVWAtVnjOiPJSfq4J9/QctCpLM65JFcPyLDyuh9M/s7bgzBa7GnN/ e7oA== X-Gm-Message-State: AOAM531gm8HW8PHw2eFEEr57Awf+N9J+J52DXyRRAWgJRjR9fy5lv/1j Ubm2SrMts2nVgz/PTPnlAwL3O/6CoJg= X-Google-Smtp-Source: ABdhPJw//k6eooo5l6cBd8xkfd7Qqn7jX3bwJqFNH/QfXmot/+FapECLMUi721SeMcBnyB53LRzqrQ== X-Received: by 2002:a05:6000:168a:: with SMTP id y10mr56038077wrd.572.1641548167094; Fri, 07 Jan 2022 01:36:07 -0800 (PST) Received: from phst ([2a02:2455:2a4:dc00:39ea:b2a2:f94b:4358]) by smtp.gmail.com with ESMTPSA id l2sm4404437wrz.8.2022.01.07.01.36.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 01:36:06 -0800 (PST) From: Philipp Stephani Date: Fri, 07 Jan 2022 10:36:03 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=p.stephani2@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I hit the following subtle Edebug regression in Emacs 28: Create a file /tmp/pcase-edebug.el with these contents: $ cat /tmp/pcase-edebug.el ;; -*- lexical-binding: t; -*- (require 'rx) (defun f (a) (pcase a ((rx bos (let q (opt (let r nonl)) (let a nonl))) (message "%s" a)) ((rx bos eos) (message "%s" a)))) Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (p.stephani2[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (p.stephani2[at]gmail.com) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.3 SPOOFED_FREEMAIL No description available. 1.5 SPOOF_GMAIL_MID From Gmail but it doesn't seem to be... X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) I hit the following subtle Edebug regression in Emacs 28: Create a file /tmp/pcase-edebug.el with these contents: $ cat /tmp/pcase-edebug.el=20 ;; -*- lexical-binding: t; -*- (require 'rx) (defun f (a) (pcase a ((rx bos (let q (opt (let r nonl)) (let a nonl))) (message "%s" a)) ((rx bos eos) (message "%s" a)))) Visit the file in Emacs: $ emacs -Q -l rx /tmp/pcase-edebug.el Move point into the `f' function and instrument it using C-u C-M-x. Then, byte-compile `f' using M-: (byte-compile 'f). In Emacs 28, this will generate the following warnings: Warning: Unused lexical variable `q' Warning: Unused lexical variable `r' Warning: reference to free variable =E2=80=98a=E2=80=99 The first two are expected, the third one is not. Indeed, M-: (f "ab") and stepping through the code will signal an error: Symbol's value as variable is void: a This doesn't happen in Emacs 27, so I think it should be fixed on the release branch before releasing Emacs 28. In GNU Emacs 28.0.90 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, = cairo version 1.16.0) of 2022-01-05 Repository revision: c0cfbca311e6e07e9f8b9c1c9d0e2fe9792cd08c Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=3Dall --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_TIME: en_DK.utf8 value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail phst skeleton edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap rx message rmc dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader gnutls puny elp dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv compile text-property-search comint ansi-color ring cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 69586 8115) (symbols 48 8528 3) (strings 32 24811 2252) (string-bytes 1 802373) (vectors 16 15668) (vector-slots 8 207469 17113) (floats 8 29 46) (intervals 56 228 0) (buffers 992 11)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Philipp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 02:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 53071@debbugs.gnu.org Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164195399215870 (code B ref 53071); Wed, 12 Jan 2022 02:20:01 +0000 Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 02:19:52 +0000 Received: from localhost ([127.0.0.1]:55910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7TEt-00047u-NE for submit@debbugs.gnu.org; Tue, 11 Jan 2022 21:19:51 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:46054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7TEs-00047d-3i for 53071@debbugs.gnu.org; Tue, 11 Jan 2022 21:19:50 -0500 Received: by mail-wr1-f48.google.com with SMTP id q8so1496467wra.12 for <53071@debbugs.gnu.org>; Tue, 11 Jan 2022 18:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=u+5/prJkqs7Emm5dl3YfH1LUBZTv5XSusxAqJmymthM=; b=mFIOubfdIZH9EgFmEdWupVRbZFPPWbm+YTNbt+Enx2dDZb0AL7EygPu8ZCnneHMgTL DrGc6s3+5NdREvXymolPeyUJ3zS6qzsxO3BUvmTu46X8wfRWPgvXe3I4ZA9R1/z5/Dih BfT4qUAUwIlnw8ktYuCKGxy9BJF3vHAz8ajW5BAZd3EqdT52EHx5EaiuE1iICFzOo0yC l/Si9l2clptWeOyxeLiFI7NWjSa2wg99C9toKeNJJN2/Tsd5Ui9UMcuzPcB1EIoVUFZY 4hfsogKFe4ekF2IlMnoe9/vWLOZPtCLw53rurasc2+LISYyo5dMGvJ/vYSX5g68FJibv SS/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=u+5/prJkqs7Emm5dl3YfH1LUBZTv5XSusxAqJmymthM=; b=vPWvTvep6SCj62nRJ92svhN8FPhIEp5UVdpDz9FbH3TuXl6lbTEWTG61wUYKKuy5iR 8dJA7rKcVaNfDoHDXL+bzISLzW78IeIyAwrrFVLAM21W6iEixZ8HvOqKw/XOsbOgftqI RuyL0RBWikbNEQ7pFqKtUK16hliStNwgL9BRkTVN7agBJcpgzv7ll+vgPqJgP7t8/ChZ GVTNoTDJ7sRPEON4IuDPWCxTSXu8kd7X4wx4BJPMntmHOlWGmMzgImE783VtuFBSxwdl qljDFRCjEWap4Qb+UKGsnJS/1tPLY4I9DT2XbPk3SOfcL8/Q9wkaLVQ/nvfk2dHXGd9P tlzA== X-Gm-Message-State: AOAM532zx9G9yLweKKAxN6kx6iUCO+k4kQrRXqdQvwhSJXeyOP1NNXdE wbdkKUCQn+ARzw+UxL+OmbvYe+T17JY= X-Google-Smtp-Source: ABdhPJwFOC/HoNEdFvrABpfSy0H20O6cvMitCi+jCY5sj58OZBUIHTmtRY7Dau5UHBdBTc6UV5ry5g== X-Received: by 2002:adf:ab59:: with SMTP id r25mr6302660wrc.321.1641953983821; Tue, 11 Jan 2022 18:19:43 -0800 (PST) Received: from smtpclient.apple ([2a02:2455:2a4:dc00:e1c4:132:bb2:acf9]) by smtp.gmail.com with ESMTPSA id i8sm13831000wry.108.2022.01.11.18.19.43 for <53071@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jan 2022 18:19:43 -0800 (PST) From: Philipp Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Date: Wed, 12 Jan 2022 03:19:42 +0100 References: In-Reply-To: Message-Id: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > Am 07.01.2022 um 10:36 schrieb Philipp Stephani = : >=20 >=20 > I hit the following subtle Edebug regression in Emacs 28: >=20 > Create a file /tmp/pcase-edebug.el with these contents: >=20 > $ cat /tmp/pcase-edebug.el=20 > ;; -*- lexical-binding: t; -*- > (require 'rx) > (defun f (a) > (pcase a > ((rx bos (let q (opt (let r nonl)) (let a nonl))) > (message "%s" a)) > ((rx bos eos) > (message "%s" a)))) >=20 > Visit the file in Emacs: >=20 > $ emacs -Q -l rx /tmp/pcase-edebug.el >=20 > Move point into the `f' function and instrument it using C-u C-M-x. > Then, byte-compile `f' using M-: (byte-compile 'f). > In Emacs 28, this will generate the following warnings: >=20 > Warning: Unused lexical variable `q' > Warning: Unused lexical variable `r' > Warning: reference to free variable =E2=80=98a=E2=80=99 >=20 > The first two are expected, the third one is not. > Indeed, M-: (f "ab") and stepping through the code will signal an = error: >=20 > Symbol's value as variable is void: a 'git bisect' claims that the following commit is the culprit: commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd Author: Mattias Engdeg=C3=A5rd Date: Fri Mar 5 20:21:01 2021 +0100 Make lambda-lifting work again =20 From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 53071@debbugs.gnu.org Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164199662829623 (code B ref 53071); Wed, 12 Jan 2022 14:11:02 +0000 Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 14:10:28 +0000 Received: from localhost ([127.0.0.1]:56494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7eKa-0007hj-2N for submit@debbugs.gnu.org; Wed, 12 Jan 2022 09:10:28 -0500 Received: from mout.web.de ([212.227.17.11]:38323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7eKX-0007hT-HH for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 09:10:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1641996613; bh=KZDSqs/51XwqusN4C8hzSkTN30W8p/9kb17ee19cWrY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=h4aFf+BSuz/YZGNQsCgtMbgQbvCcKXh3hfOBwlAWg5fl4IPxx+QhCgwGJu/AJnrAc Czm7eFcT0Cl1UGZukior92o84UCGEmq2tSzQpdoG1U4RHJJu77lN/i7hrog+ZDYjfV DASbn8yGVpVXImlCMUEQbUvQ/ovaIzByeqdIgw8c= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.66.201.186]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Mr7eu-1mb3PW3MQg-00o4yp; Wed, 12 Jan 2022 15:10:12 +0100 From: Michael Heerdegen References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> Date: Wed, 12 Jan 2022 15:10:12 +0100 In-Reply-To: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> (Philipp's message of "Wed, 12 Jan 2022 03:19:42 +0100") Message-ID: <87mtk1niyj.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8Qj1ThyTvW0CLuU0J7ZEFA7mUImjRjI4cuJubJZ4RccRr5FX8Fv wtzB7U641AXfhsUAvG37L7eZbtBVAUbt1QSsTY0jpTZto6CQfaojCNpNe1tozTQWGX4Jd0s s+erV81XHXYrTtitXlCXGGMVWvIi9lORyQhwHppyTVuwYr6XsBJIJX7PhMS6h96Ftp4gZQt qB92Xx5hsLlgl1MoZqAxg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:4TdWw7b+r4I=:o4PO0uAQPXRaFV4w2Oko9M 2b3xN0jB7RIlErlsvXwLtSbRgfLD6qGW6jVRbBmRYwpom6hEjPArMOz9uI9tMWBPzsjKyxFAH Wlrnz72m0Rsa1MC1zynx+INVbaFxRn4L84Amdfi4Q/Ek0N+jVrBFdxflVqXDzL54TNB/I67pH rgVOQPm5BFegrFCqJqzGXPA+Bdwgm7L/3k0QG9qfXT6EA9Q2tuZwo43oj3z+83eoMrxVr6/8E JlgE5ZADLNUveX0oJRIL7vo2DwsC2KNkL74cXcKiHVrDCornXNDwo6jwC/0nqNpAcJDxHDRc2 3Oa28E1EtZG0Wr0XWqO9DOkFommPjjJMf3yOx8K3P8dgzZhiAJH6ufAuSjLWQHAsUapxc9d+Z 6uPlFVqWkLhdq0WzPvU6L+ALHLVdVWD3dUvQIl/UiU4V4pG3pTK5RWKU3RdqU5kupL7IdmfVW VqvbVRLd07THFCf+EjsA84VJ+s7d+Nxzyf+6D+v+gD7Xb9nyqay/51zEvGBKhUqs3RsU8ucKI sqH0PQHtN0XQtJvprQWzslfKfktOVUnuf/Ruca8iGXXKkwOwr8isRO72QTMAB/Jzjf/cOTHwC DZv6AWuRYvL37REmRP51bpjXIFycBfdLfV9kAdrVMoKv9wwmyedpKGBYtHzJ8kJUVoJu4uz1Z icwiryQknkJlH/okNTAribI+bHMUqP8Fr8hsj997QoKxXY+dAniJUkPjnynhqkLTygJkycAP6 lh/cf66rpPGfQ69TCAqTuquPrv4Dd/V8MBWXZMLjBcDNv1ALybsedal5iQdIGbXFVlEgaVLy7 fcxjuuhxqFi7f6GaEvqpGTK6HSsMSik2Zap+1bZtQcAMIm6yhME1vh2rH6l+taz0u22sWeKvS ErY7LtMQLuvmKf87e1eytX4Ab03a4uaezmJT0fEJUPu7WzTu7K6HpzeUnxA5jJI41o2b67qHh pZVI+9i4vBv7PQePVi2rrXXJAOkYI0Awlouqhw22Ie4DOD8VRJrhARy7rOr6rzIuByk1fD4q0 V5/H2U5z7gohrOc52wAV//H/GGYQaFeIbrpv0S/gAuhH1d0vEbJ9P2bIdsTpPKrWV6Y7vQead 3ITgd1JR9tyWqM= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp writes: > 'git bisect' claims that the following commit is the culprit: > > commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd > Author: Mattias Engdeg=C3=A5rd > Date: Fri Mar 5 20:21:01 2021 +0100 > > Make lambda-lifting work again Not that again. Let's CC Mattias then. > > Am 07.01.2022 um 10:36 schrieb Philipp Stephani : > >=20 > > I hit the following subtle Edebug regression in Emacs 28: > >=20 > > Create a file /tmp/pcase-edebug.el with these contents: > >=20 > > $ cat /tmp/pcase-edebug.el=20 > > ;; -*- lexical-binding: t; -*- > > (require 'rx) > > (defun f (a) > > (pcase a > > ((rx bos (let q (opt (let r nonl)) (let a nonl))) > > (message "%s" a)) > > ((rx bos eos) > > (message "%s" a)))) > >=20 > > Visit the file in Emacs: > >=20 > > $ emacs -Q -l rx /tmp/pcase-edebug.el > >=20 > > Move point into the `f' function and instrument it using C-u C-M-x. > > Then, byte-compile `f' using M-: (byte-compile 'f). > > In Emacs 28, this will generate the following warnings: > >=20 > > Warning: Unused lexical variable `q' > > Warning: Unused lexical variable `r' > > Warning: reference to free variable =E2=80=98a=E2=80=99 > >=20 > > The first two are expected, the third one is not. > > Indeed, M-: (f "ab") and stepping through the code will signal an error: > >=20 > > Symbol's value as variable is void: a Michael. From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 15:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Philipp , Stefan Monnier , 53071@debbugs.gnu.org Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.16420017709930 (code B ref 53071); Wed, 12 Jan 2022 15:37:01 +0000 Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 15:36:10 +0000 Received: from localhost ([127.0.0.1]:58727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7ffV-0002a5-NJ for submit@debbugs.gnu.org; Wed, 12 Jan 2022 10:36:09 -0500 Received: from mail1448c50.megamailservers.eu ([91.136.14.48]:50856 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7ffS-0002ZV-AY for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 10:36:09 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642001759; bh=xef2cTzDLKC10uO/4+DT0ekOx64s1TdiWMLVsT+23nA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=OmFSO8Mc+7gCFsC7x4E+E0jd53OJ8ooeOt4MmOaDADTM6Z5hnv59V5cXFCg2pbR2t 9TTiHsAj+pRYSDcKKh6Pq/jntDFz6sBZkhv6k7yglFSzt1kDfBktbSOkJhqC0PmaxR IPtt8HFz9pzKvUK3zQqTNOu5Pz2BXYW7bT8tSIT8= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20CFZuuk004909; Wed, 12 Jan 2022 15:35:58 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <87mtk1niyj.fsf@web.de> Date: Wed, 12 Jan 2022 16:35:56 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F26.61DEF55F.0028, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 12 jan. 2022 kl. 15.10 skrev Michael Heerdegen : >> commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd >> Author: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= >> Date: Fri Mar 5 20:21:01 2021 +0100 >> >> Make lambda-lifting work again > > Not that again. Let' [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 12 jan. 2022 kl. 15.10 skrev Michael Heerdegen = : >> commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd >> Author: Mattias Engdeg=C3=A5rd >> Date: Fri Mar 5 20:21:01 2021 +0100 >>=20 >> Make lambda-lifting work again >=20 > Not that again. Let's CC Mattias then. Again? In any case, that change only fixed a typo in earlier code by = Stefan. More likely to be a logic error in the parent change = (a350ae058cae), or in edebug. I'll give it a quick look just the same. The bug doesn't seem to be = present on master. From unknown Sun Jun 22 08:09:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Philipp Stephani Subject: bug#53071: closed (Re: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms?) Message-ID: References: <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> X-Gnu-PR-Message: they-closed 53071 X-Gnu-PR-Package: emacs Reply-To: 53071@debbugs.gnu.org Date: Wed, 12 Jan 2022 16:05:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1642003501-13338-1" This is a multi-part message in MIME format... ------------=_1642003501-13338-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex= pcase forms? which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 53071@debbugs.gnu.org. --=20 53071: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D53071 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1642003501-13338-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 53071-done) by debbugs.gnu.org; 12 Jan 2022 16:04:06 +0000 Received: from localhost ([127.0.0.1]:58758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7g6X-0003RT-35 for submit@debbugs.gnu.org; Wed, 12 Jan 2022 11:04:06 -0500 Received: from mail1436c50.megamailservers.eu ([91.136.14.36]:48648 helo=mail263c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7g6M-0003Qb-9v for 53071-done@debbugs.gnu.org; Wed, 12 Jan 2022 11:04:04 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642003427; bh=unPThGVGOM9ZsOUGmTPOXE8BckCcDpHu9yFuKSiKzso=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gJ+/+kWe3QdXAdUtqe5NvJXEg96RoCL0y2NpiJosBuhzZghBkjUG5/EWpx+rA3z1b w9ad/AWyFw4DvW67eQIvYP0K0Z5+DzaChVmf5tMVl2SLieKaZmvzExMnOh6k5D0gGU 8aUGPir1zVIK+W/PJ2WYc5NAMQimUhxnt5tI9BmY= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20CG3iuX003253; Wed, 12 Jan 2022 16:03:46 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Wed, 12 Jan 2022 17:03:44 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> To: Michael Heerdegen X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F18.61DEFBE3.0034, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 12 jan. 2022 kl. 16.35 skrev Mattias Engdegård : > > 12 jan. 2022 kl. 15.10 skrev Michael Heerdegen : > >>> commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 T_SPF_HELO_TEMPERROR SPF: test of HELO record failed (temperror) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 53071-done Cc: 53071-done@debbugs.gnu.org, Philipp , Stefan Monnier , Paul Pogonyshev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 12 jan. 2022 kl. 16.35 skrev Mattias Engdeg=C3=A5rd : >=20 > 12 jan. 2022 kl. 15.10 skrev Michael Heerdegen = : >=20 >>> commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd >>> Author: Mattias Engdeg=C3=A5rd >>> Date: Fri Mar 5 20:21:01 2021 +0100 >>>=20 >>> Make lambda-lifting work again >>=20 >> Not that again. Let's CC Mattias then. >=20 > Again? In any case, that change only fixed a typo in earlier code by = Stefan. More likely to be a logic error in the parent change = (a350ae058cae), or in edebug. No, you're right, it's bug#51982 again. I've backported the fix from = master, which we should have done from the beginning. Paul, I'd like to = say on record that listening to you would have saved us much time. Thanks for bringing this to my attention! ------------=_1642003501-13338-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Jan 2022 09:36:15 +0000 Received: from localhost ([127.0.0.1]:43077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5lfS-00048w-Gn for submit@debbugs.gnu.org; Fri, 07 Jan 2022 04:36:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:60684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5lfP-00048k-Aw for submit@debbugs.gnu.org; Fri, 07 Jan 2022 04:36:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5lfP-0002QG-29 for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:11 -0500 Received: from [2a00:1450:4864:20::42a] (port=40528 helo=mail-wr1-x42a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5lfN-0000k6-99 for bug-gnu-emacs@gnu.org; Fri, 07 Jan 2022 04:36:10 -0500 Received: by mail-wr1-x42a.google.com with SMTP id l10so9927429wrh.7 for ; Fri, 07 Jan 2022 01:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YpVhiKIE/Em5BF5F+W3Qpa2rVpQSz2cJlTgV9jpv6OE=; b=IwsPtrF0pWfKiuAAtMQjgSx0FLQqDMhBzQ3gtH+9fFC67+1j9coq0TanMwcfClYMla YAjmZmTG94McOj4oxQhWBjxv9V9yNZ1DVHKW/XZlXrJk/qX0VNI5XUZBWDL/H8Z4e4SX BfVgrVg/QCS+O/dp1oz4JwVvakvl16He4hWA6iNvprjbUxsm++BCs6BmY+gbSBOrzpG3 Xrp44XSNDnjc0eWNVA1dDGMrhoS+QZDI9Sd5NaYlCsfYCZdlwtML8y5KEZRWrnOZYwmI 0akzzKf1ZtGAhM+93y5Ko9U7A4tFmMKuzVzpWag+HaRQ2oCvUcfQs3kloX3CMSP+/Vfv o/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YpVhiKIE/Em5BF5F+W3Qpa2rVpQSz2cJlTgV9jpv6OE=; b=J+tY756m0ntowPFItu/z4xWqbXAU8/CDMxmDOx2Wrk2TNUgd0GfaTHFMa5/A8/ubz1 wxfpM0KKzDMgmniffwmJ+ZAOtvK0jGqrGyaNaCl0t72/ANfg8Zfu7pnvPiFtOU1ptRJg TPS13FybOySq/13EBhIL+VwxxQ5xDhge32XuHozCNtPz3kyJXnsG/b/rnPx6UCGW9cli iYL5XpQ+/8jGe4vjAUO3o4NCl5OR8xxtPakbKlXlmJJyGbvtdAyuy6s0382lMqctIxKi LsQywHd402EdPYjPVWAtVnjOiPJSfq4J9/QctCpLM65JFcPyLDyuh9M/s7bgzBa7GnN/ e7oA== X-Gm-Message-State: AOAM531gm8HW8PHw2eFEEr57Awf+N9J+J52DXyRRAWgJRjR9fy5lv/1j Ubm2SrMts2nVgz/PTPnlAwL3O/6CoJg= X-Google-Smtp-Source: ABdhPJw//k6eooo5l6cBd8xkfd7Qqn7jX3bwJqFNH/QfXmot/+FapECLMUi721SeMcBnyB53LRzqrQ== X-Received: by 2002:a05:6000:168a:: with SMTP id y10mr56038077wrd.572.1641548167094; Fri, 07 Jan 2022 01:36:07 -0800 (PST) Received: from phst ([2a02:2455:2a4:dc00:39ea:b2a2:f94b:4358]) by smtp.gmail.com with ESMTPSA id l2sm4404437wrz.8.2022.01.07.01.36.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 01:36:06 -0800 (PST) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Date: Fri, 07 Jan 2022 10:36:03 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=p.stephani2@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I hit the following subtle Edebug regression in Emacs 28: Create a file /tmp/pcase-edebug.el with these contents: $ cat /tmp/pcase-edebug.el ;; -*- lexical-binding: t; -*- (require 'rx) (defun f (a) (pcase a ((rx bos (let q (opt (let r nonl)) (let a nonl))) (message "%s" a)) ((rx bos eos) (message "%s" a)))) Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (p.stephani2[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (p.stephani2[at]gmail.com) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.3 SPOOFED_FREEMAIL No description available. 1.5 SPOOF_GMAIL_MID From Gmail but it doesn't seem to be... X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) I hit the following subtle Edebug regression in Emacs 28: Create a file /tmp/pcase-edebug.el with these contents: $ cat /tmp/pcase-edebug.el=20 ;; -*- lexical-binding: t; -*- (require 'rx) (defun f (a) (pcase a ((rx bos (let q (opt (let r nonl)) (let a nonl))) (message "%s" a)) ((rx bos eos) (message "%s" a)))) Visit the file in Emacs: $ emacs -Q -l rx /tmp/pcase-edebug.el Move point into the `f' function and instrument it using C-u C-M-x. Then, byte-compile `f' using M-: (byte-compile 'f). In Emacs 28, this will generate the following warnings: Warning: Unused lexical variable `q' Warning: Unused lexical variable `r' Warning: reference to free variable =E2=80=98a=E2=80=99 The first two are expected, the third one is not. Indeed, M-: (f "ab") and stepping through the code will signal an error: Symbol's value as variable is void: a This doesn't happen in Emacs 27, so I think it should be fixed on the release branch before releasing Emacs 28. In GNU Emacs 28.0.90 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, = cairo version 1.16.0) of 2022-01-05 Repository revision: c0cfbca311e6e07e9f8b9c1c9d0e2fe9792cd08c Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=3Dall --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_TIME: en_DK.utf8 value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail phst skeleton edmacro kmacro pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap rx message rmc dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader gnutls puny elp dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv compile text-property-search comint ansi-color ring cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 69586 8115) (symbols 48 8528 3) (strings 32 24811 2252) (string-bytes 1 802373) (vectors 16 15668) (vector-slots 8 207469 17113) (floats 8 29 46) (intervals 56 228 0) (buffers 992 11)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. ------------=_1642003501-13338-1-- From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: p.stephani2@gmail.com, 53071@debbugs.gnu.org Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164200674019731 (code B ref 53071); Wed, 12 Jan 2022 16:59:02 +0000 Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 16:59:00 +0000 Received: from localhost ([127.0.0.1]:58836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7gxg-00058B-6x for submit@debbugs.gnu.org; Wed, 12 Jan 2022 11:59:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7gxc-00057r-LD for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 11:58:59 -0500 Received: from [2001:470:142:3::e] (port=51112 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7gxW-0002Uz-Ua; Wed, 12 Jan 2022 11:58:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mO4FF7Bg8CIVw/8w5dPcbKESEeikfbCgyudFqeSUB1I=; b=AZfTIhBT3if/WnuUqQY7 u4xlVlbR1O0gyMi6N6ovh1XZ4Ohun1VJx1Zh1gdGIII0eo2yz8X/rJIE6SSDj+LepIhT1Cei7AEuo Ui6BcBELKW0EqEaBoJ6ufju2cUcYP7H6mBXWif70mWgS/WPy1RI0fj69fDZ2vfFbeY6NDiNpJAwBB P1PufurGHv8r32vJA0HnZtqcv/JRBRfAf+cVPxbFaHd04j1tMXQPK2fH2HiNKyYD5/9BR2XYzXTKF EQO5jaJ34ijD2mHkMpjfN/i0rpkQBIaux04RvcVYPDdP6r3+0+uzsM+Lym5sW8YxAgxHdF5xCv3Gd /ZSQfUkI//z7eQ==; Received: from [87.69.77.57] (port=1262 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7gxW-0005cU-09; Wed, 12 Jan 2022 11:58:50 -0500 Date: Wed, 12 Jan 2022 18:58:45 +0200 Message-Id: <83czkw6gca.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 12 Jan 2022 17:03:44 +0100) References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 12 Jan 2022 17:03:44 +0100 > Cc: 53071-done@debbugs.gnu.org, Philipp , > Stefan Monnier , > Paul Pogonyshev > > >>> commit 1362a9fec4dff341a84c881ac17dbf1ee2cf82fd > >>> Author: Mattias Engdegård > >>> Date: Fri Mar 5 20:21:01 2021 +0100 > >>> > >>> Make lambda-lifting work again > >> > >> Not that again. Let's CC Mattias then. > > > > Again? In any case, that change only fixed a typo in earlier code by Stefan. More likely to be a logic error in the parent change (a350ae058cae), or in edebug. > > No, you're right, it's bug#51982 again. I've backported the fix from master, which we should have done from the beginning. Paul, I'd like to say on record that listening to you would have saved us much time. Emacs 28 is in a very good shape, and no serious problems were reported in several weeks. We could release Emacs 28.1 in a few weeks, fingers crossed. So I'm about to revert this backport, but I'm prepared to hear arguments why shouldn't I. >From my POV, the regression is very minor, and it doesn't justify such a non-trivial change in such a central place. If you think the problem is serious, I'd rather revert the change we did which produced the regression in the first place (assuming it's not too complicated). Thanks. From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 19:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Philipp , Paul Pogonyshev , 53071@debbugs.gnu.org Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.16420145804699 (code B ref 53071); Wed, 12 Jan 2022 19:10:02 +0000 Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 19:09:40 +0000 Received: from localhost ([127.0.0.1]:59118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7j08-0001Dj-AE for submit@debbugs.gnu.org; Wed, 12 Jan 2022 14:09:40 -0500 Received: from mail151c50.megamailservers.eu ([91.136.10.161]:59642 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7j05-0001DW-Gf for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 14:09:39 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1642014575; bh=xqJ08UeRrdjjPBcZdjdXEtmGHBFGNDdNP2Xkqux1EZk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=WWL9jmY9wwwxm8EPJBsmjDzad43DQo+nyewQ4z7obMNcwNWv1uyDB3+G03r/XFhO0 +01SXSasf6s8/H0lR9H+gl/Hlt48U7XXouh2t4BwJbc+3t5+SrjFkxV6QdnnzKa80U 7agR/6HIhmGqu9sRMCbrgrTufdAtdbZXBeRy8BWk= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 20CJ9QlG019809; Wed, 12 Jan 2022 19:09:32 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <83czkw6gca.fsf@gnu.org> Date: Wed, 12 Jan 2022 20:09:26 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> <83czkw6gca.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F22.61DF276E.0066, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 12 jan. 2022 kl. 17.58 skrev Eli Zaretskii : > So I'm about to revert this backport, but I'm prepared to hear > arguments why shouldn't I. I broke protocol by pushing it to the stable branch in this phase without permission. Sorry about that; the change has now been reverted. Will be more careful in the future. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 12 jan. 2022 kl. 17.58 skrev Eli Zaretskii : > So I'm about to revert this backport, but I'm prepared to hear > arguments why shouldn't I. I broke protocol by pushing it to the stable branch in this phase = without permission. Sorry about that; the change has now been reverted. = Will be more careful in the future. > =46rom my POV, the regression is very minor, and it doesn't justify = such > a non-trivial change in such a central place. I personally don't care much about it since I don't use Emacs 28 but = would certainly not prefer at least two known, documented and harmful = bugs reported by our users over some vague hypothetical conjectured = problem that might arise. > If you think the > problem is serious, I'd rather revert the change we did which produced > the regression in the first place (assuming it's not too complicated). That would be inadvisable as it would introduce yet another bug, the fix = of which was the immediate cause of the regression. From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: p.stephani2@gmail.com, pogonyshev@gmail.com, 53071@debbugs.gnu.org Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164201603115895 (code B ref 53071); Wed, 12 Jan 2022 19:34:02 +0000 Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 19:33:51 +0000 Received: from localhost ([127.0.0.1]:59175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jNX-00048I-Dy for submit@debbugs.gnu.org; Wed, 12 Jan 2022 14:33:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jNV-000487-W3 for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 14:33:50 -0500 Received: from [2001:470:142:3::e] (port=55258 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7jNQ-00038M-Mm; Wed, 12 Jan 2022 14:33:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tpdUoK2NyIKUJx1K5pWmrKCbQVpcCMmGmtad4RzVBzc=; b=i8OAOaQLQs8/5sK6I2Gz 2chIZemezypJGYV5CIDowRU4hoska/RCpXMb37h4VHbtU4qhHvWKodkvBvXkISNlica2thznJU/jM tM+eYVwdYIpXLuj0df/BmXH1Ih1K+ZArwCjcNJHWDVZQ67UL3xFJmneCcBLWVADLbcLKj9qK6D+8e 84E49EToZbqu8mqGv6DxInRev9HpkTX26edo5+eJJe1TZgEETast6ZCDrdclWJKuMfpDgERc58ke8 7vrZScFe2dfydWmdi0cjeiwEgJKjsBSQhji+SPbzY+q4aCCzk3b/CfGDPE4u3mVlPS+amnGv+a+Oc j+TMBzroB2gwRA==; Received: from [87.69.77.57] (port=2783 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7jNQ-0004gQ-Ih; Wed, 12 Jan 2022 14:33:44 -0500 Date: Wed, 12 Jan 2022 21:33:38 +0200 Message-Id: <831r1c6965.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 12 Jan 2022 20:09:26 +0100) References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> <83czkw6gca.fsf@gnu.org> <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 12 Jan 2022 20:09:26 +0100 > Cc: 53071@debbugs.gnu.org, Philipp , > Paul Pogonyshev > > 12 jan. 2022 kl. 17.58 skrev Eli Zaretskii : > > > So I'm about to revert this backport, but I'm prepared to hear > > arguments why shouldn't I. > > I broke protocol by pushing it to the stable branch in this phase without permission. Sorry about that; the change has now been reverted. Will be more careful in the future. > > > From my POV, the regression is very minor, and it doesn't justify such > > a non-trivial change in such a central place. > > I personally don't care much about it since I don't use Emacs 28 but would certainly not prefer at least two known, documented and harmful bugs reported by our users over some vague hypothetical conjectured problem that might arise. > > > If you think the > > problem is serious, I'd rather revert the change we did which produced > > the regression in the first place (assuming it's not too complicated). > > That would be inadvisable as it would introduce yet another bug, the fix of which was the immediate cause of the regression. Fine by me, then let's leave emacs-28 at its present state. Thanks. From unknown Sun Jun 22 08:09:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#53071: 28.0.90; Emacs 28 regression: incorrect code generation for complex pcase forms? Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2022 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Eli Zaretskii , Paul Pogonyshev , 53071@debbugs.gnu.org Received: via spool by 53071-submit@debbugs.gnu.org id=B53071.164201626116282 (code B ref 53071); Wed, 12 Jan 2022 19:38:01 +0000 Received: (at 53071) by debbugs.gnu.org; 12 Jan 2022 19:37:41 +0000 Received: from localhost ([127.0.0.1]:59179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jRF-0004EY-0S for submit@debbugs.gnu.org; Wed, 12 Jan 2022 14:37:41 -0500 Received: from mail-oi1-f177.google.com ([209.85.167.177]:34621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7jRC-0004EJ-4X for 53071@debbugs.gnu.org; Wed, 12 Jan 2022 14:37:39 -0500 Received: by mail-oi1-f177.google.com with SMTP id r131so4774789oig.1 for <53071@debbugs.gnu.org>; Wed, 12 Jan 2022 11:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cIHXbxVaekX2RwGVJ+nPogLr8CUXG8gVattMVCEJl+4=; b=QRf+A8b4BMwZZOp2O39cb8OTBh4yNVp9gZUZ8njGv4kTU5Bbb/omeBpMi5ueHbjuSf 1CN77GXzZuYTKAeXhNfSrEgL3I38Y/lRabZkGjDneLliRmb0HOv9DNDCZHi0uMAka4d+ mE8DIfeZiC9CoU6jjHWyoHxaWtqhcVs3RcysHqNDX6tCVoHJMurCMkwI5uz3xnTMNTen MsRiwqQRy/cRFtBdvX55DhcwtoXH5+cnTva0IK0Ntp4Ln9DXLQHlmq/CI79hgTxumC0o HDNCDBmViMTfZl/8XmWZlZVKSfJ+CgjTUzDb3gWqBLMkD6bFc6LPziZf7d6uoY1qSufP rs5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cIHXbxVaekX2RwGVJ+nPogLr8CUXG8gVattMVCEJl+4=; b=HBWI62JWboAtl/4ScQ+q8KGLp0Cogg0dmFJXKCc1RkousSIgkhthYQ7DJnCF+uoh/5 08nAIWmlfRavS+DbjZ2kNycJ57RpH2LA0m8VTQk+cC7m5fieha2kTknCHINICfZ0hQzl yi/M41zpWdTj9MI8BhVuIXSiW5tCgsEQbp8LvAtiDAsFot6X8S/WbbKBsrvzPERiBPH9 IrvrPHLufSpFVgfPH6kAt1OOo35OaxsBMu8nOajS6Skq5RLttuc/ULTOiqr4uQXPwRct n0MELc9nDDUaWxAloqe2LrnitgCdwM0TC1hC35SmEc8/EjQB3nMPLDv+C1pQ5W4f2n6B g+qQ== X-Gm-Message-State: AOAM5300/9a3rxddjpxlvKNty5hDLjYW/ptDqmd7ZOiSeCdT0b8HA84g HQPj1GItF/LnwjOMgD4KfGmLk56myFDhXqR9oYM= X-Google-Smtp-Source: ABdhPJxgB2HsM/HHQT0amvRse1DTw6z4SqkCylMMF1ib/D+ha7L30phhKSRaCOxlM4jcJacSsVosFWrxzqAnt/x+1Lk= X-Received: by 2002:a05:6808:ab2:: with SMTP id r18mr836171oij.25.1642016252533; Wed, 12 Jan 2022 11:37:32 -0800 (PST) MIME-Version: 1.0 References: <39D132B5-6B44-41F0-A618-6A68BFB5FEBF@gmail.com> <87mtk1niyj.fsf@web.de> <653D1A81-3A8F-4964-8A80-4C84F8C2A07A@acm.org> <83czkw6gca.fsf@gnu.org> <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> In-Reply-To: <5CB5FFBD-7859-416B-9E66-21A7590DB35C@acm.org> From: Philipp Stephani Date: Wed, 12 Jan 2022 20:37:21 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Mi., 12. Jan. 2022 um 20:09 Uhr schrieb Mattias Engdeg=C3=A5rd : > > 12 jan. 2022 kl. 17.58 skrev Eli Zaretskii : > > > So I'm about to revert this backport, but I'm prepared to hear > > arguments why shouldn't I. > > I broke protocol by pushing it to the stable branch in this phase without= permission. Sorry about that; the change has now been reverted. Will be mo= re careful in the future. Is there a workaround? Seems like renaming the shadowed variables would help, but I'm not 100% sure.