GNU bug report logs - #53048
28.0.90; [PATCH] GNU ELPA local build fails silently on macOS

Previous Next

Package: emacs;

Reported by: "Y. E." <yet <at> ego.team>

Date: Thu, 6 Jan 2022 10:36:01 UTC

Severity: normal

Tags: patch

Found in version 28.0.90

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 53048-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Y. E." <yet <at> ego.team>
Cc: 53048-done <at> debbugs.gnu.org
Subject: Re: bug#53048: 28.0.90; [PATCH] GNU ELPA local build fails silently
 on macOS
Date: Sun, 9 Jan 2022 07:25:22 -0600
Y. E. <yet <at> ego.team> writes:

> From b8ce44d9f3da636a9236d7fc6a29dffb73d819ec Mon Sep 17 00:00:00 2001
> From: YugaEgo <yet <at> ego.team>
> Date: Thu, 6 Jan 2022 11:55:27 +0200
> Subject: [PATCH] * admin/elpa-admin.el (elpaa--make-one-tarball-1): Assert
>  tarball exists
>
> ---
>  elpa-admin.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/elpa-admin.el b/elpa-admin.el
> index b4ad318ef6..d94cc7fd73 100644
> --- a/elpa-admin.el
> +++ b/elpa-admin.el
> @@ -612,6 +612,7 @@ auxillary files unless TARBALL-ONLY is non-nil ."
>                ,(format "s|^packages/%s|%s-%s|" pkgname pkgname vers)
>                "-chf" ,tarball
>                ,(concat "packages/" pkgname)))
> +     (cl-assert (file-readable-p tarball))
>       (unless tarball-only
>         (let* ((pkgdesc
>                 ;; FIXME: `elpaa--write-pkg-file' wrote the metadata to

Makes sense, pushed as commit 102694997e.

Thanks for the patch!




This bug report was last modified 3 years and 219 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.